protocol-http1 0.35.1 → 0.35.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2726ec9583e06af47b9b37f5cefb493843bb1a5dff749a145bd117193048aa86
-  data.tar.gz: f1c9bd6f71750cf67d038c98926048e3927b69f4efc64a49f92374f9d01b0b31
+  metadata.gz: 4bf3ffc440b97d40277fdf64e1962d31edb93d808fc6a3059234af3b8be6e9c0
+  data.tar.gz: 9495d1bf263831872363193cbe2dab89775c57d503eacbb74bd83dffe7863f8e
 SHA512:
-  metadata.gz: 1d2b40ff72b50573db8975890a1ddd2a3366725407315f16d336aa72153caddd9a7a2d547b05bd12418dafbcc7f8810dde442821e600e4ee13a36c9aae0b7858
-  data.tar.gz: ca70b6a65753b759d933495a8ca034b6fe3c431d869b6b08bd8ebb9a53488057be2c585c7c7b9d7c880a009d3edd341b973bbe8744ad05b5cd6e5df97e72035a
+  metadata.gz: 549410520376936764b4c55653bcc2bc30fd770fa63c3befeb634d6e909be02ce94dd8a11c0823a46a9de106fb6d3fce03eeacc03066e0a100aa797328641f80
+  data.tar.gz: f0d72eb0d29c2e9d97fe725e53da409c5dbd0352df6575d44a27bab6a4d55fef929eb8a72adc0d484cb471479b383f425541881996c229f31ab2703b055ebb94

data/lib/protocol/http1/connection.rb

@@ -350,17 +350,25 @@ module Protocol
 			# Read a line from the connection.
 			#
 			# @returns [String | Nil] the line read, or nil if the connection is closed.
-			# @raises [EOFError] if the connection is closed.
 			# @raises [LineLengthError] if the line is too long.
+			# @raises [ProtocolError] if the line is not terminated properly.
 			def read_line?
 				if line = @stream.gets(CRLF, @maximum_line_length)
 					unless line.chomp!(CRLF)
-						# This basically means that the request line, response line, header, or chunked length line is too long.
-						raise LineLengthError, "Line too long!"
+						if line.bytesize == @maximum_line_length
+							# This basically means that the request line, response line, header, or chunked length line is too long:
+							raise LineLengthError, "Line too long!"
+						else
+							# This means the line was not terminated properly, which is a protocol violation:
+							raise ProtocolError, "Line not terminated properly!"
+						end
 					end
 				end
 				
 				return line
+			# If a connection is shut down abruptly, we treat it as EOF, but only specifically in `read_line?`.
+			rescue Errno::ECONNRESET
+				return nil
 			end
 			
 			# Read a line from the connection.

data/lib/protocol/http1/version.rb

@@ -5,6 +5,6 @@
 
 module Protocol
 	module HTTP1
-		VERSION = "0.35.1"
+		VERSION = "0.35.2"
 	end
 end

data/readme.md

@@ -30,6 +30,11 @@ Please see the [project documentation](https://socketry.github.io/protocol-http1
 
 Please see the [project releases](https://socketry.github.io/protocol-http1/releases/index) for all releases.
 
+### v0.35.2
+
+  - Tidy up implementation of `read_line?` to handle line length errors and protocol violations more clearly.
+  - Improve error handling for unexpected connection closures (`Errno::ECONNRESET`) in `read_line?`.
+
 ### v0.35.0
 
   - Add traces provider for `Protocol::HTTP1::Connection`.
@@ -68,10 +73,6 @@ Please see the [project releases](https://socketry.github.io/protocol-http1/rele
 
   - Fix handling of `nil` lines in HTTP parsing.
 
-### v0.28.0
-
-  - Add configurable maximum line length to prevent denial of service attacks.
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,5 +1,10 @@
 # Releases
 
+## v0.35.2
+
+  - Tidy up implementation of `read_line?` to handle line length errors and protocol violations more clearly.
+  - Improve error handling for unexpected connection closures (`Errno::ECONNRESET`) in `read_line?`.
+
 ## v0.35.0
 
   - Add traces provider for `Protocol::HTTP1::Connection`.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: protocol-http1
 version: !ruby/object:Gem::Version
-  version: 0.35.1
+  version: 0.35.2
 platform: ruby
 authors:
 - Samuel Williams