protobuf 2.8.4 → 2.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce09086e344463e2c1193ad642e5ddf90186a40b
-  data.tar.gz: e215cd2b66f2a290ed0193a4dae2ec7329780de5
+  metadata.gz: a856318d0dafa9da5a88d40dcc319c500e766a13
+  data.tar.gz: 868ee8f458233c1bf2e62a9db3371a4b0f698391
 SHA512:
-  metadata.gz: 51c1d0bea9a61d7d6b921ec859419ebbdac79a75efc54987b5cbaa7a378069d75755e6d04c47ab2c2d1b5f4fd71d206b2a89d5fe069db5e6b6e607b1cfc9428f
-  data.tar.gz: 172872992b14d0b53d1375789a4c2ea76519c4bc8b560fcc9b752fbc68822ada11cea4987ff2b5319a79bd68295d8fc7b71100510f73d49383ea8d79fe7af61b
+  metadata.gz: 138f5e2b81b0c2375012bbc6ee4bae97a2af3e53cb83e5f348ee407544c29628a6b4bbc6cdef95f44467ed9180a23ad93a148f6f3b8e2f00bd2768455ea89335
+  data.tar.gz: 3775fad99cbc871003c146c8c86cc2a2e1a9ab29f439bfd5b12e0e0c115fd18ba4f70558095f1b48a3a54910361c47e6de20fcb6c514e3ae0ab470a510217aaa

data/CHANGES.md

@@ -1,3 +1,8 @@
+2.8.5
+----------
+
+- Fix issue where ServiceDirectory lookups were failing when given a class name, breaking the directory load balancing. (#119)
+
 2.8.4
 ----------
 

data/lib/protobuf/rpc/service_directory.rb

@@ -91,8 +91,8 @@ module Protobuf
 
       def lookup(service)
         if running?
-          if @listings_by_service.key?(service)
-            @listings_by_service[service].entries.sample
+          if @listings_by_service.key?(service.to_s)
+            @listings_by_service[service.to_s].entries.sample
           end
         end
       end

data/lib/protobuf/version.rb

@@ -1,4 +1,4 @@
 module Protobuf
-  VERSION = '2.8.4'
+  VERSION = '2.8.5'
   PROTOC_VERSION = '2.5.0'
 end

data/spec/lib/protobuf/rpc/service_directory_spec.rb

@@ -49,6 +49,7 @@ describe ::Protobuf::Rpc::ServiceDirectory do
     @address = "127.0.0.1"
     @port = 33333
     @socket = UDPSocket.new
+    EchoService = Class.new
 
     described_class.address = @address
     described_class.port = @port
@@ -202,6 +203,13 @@ describe ::Protobuf::Rpc::ServiceDirectory do
 
         subject.lookup("EchoService").port.should eq "7777"
       end
+
+      context 'when given service identifier is a class name' do
+        it 'returns the listing corresponding to the class name' do
+          send_beacon(:heartbeat, echo_server)
+          subject.lookup(EchoService).uuid.should eq echo_server.uuid
+        end
+      end
     end
 
     describe "#restart" do
@@ -239,7 +247,7 @@ describe ::Protobuf::Rpc::ServiceDirectory do
       let(:servers) {
         100.times.collect do |x|
           ::Protobuf::Rpc::DynamicDiscovery::Server.new(
-            :uuid => server_name = "performance_server#{x + 1}",
+            :uuid => "performance_server#{x + 1}",
             :address => '127.0.0.1',
             :port => (5555 + x).to_s,
             :ttl => rand(1..5),

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: protobuf
 version: !ruby/object:Gem::Version
-  version: 2.8.4
+  version: 2.8.5
 platform: ruby
 authors:
 - BJ Neilsen
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-06 00:00:00.000000000 Z
+date: 2013-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport