protip 0.30.5 → 0.30.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a10a4eb93f79aa7fe56de1217cd27ae431a46232
-  data.tar.gz: 5847fed82b56670f7bd9a813374d8e0c908e9915
+  metadata.gz: e8ea8a8d2f1e92c3bcebb676f2e40d591b9a2138
+  data.tar.gz: 7195b1267a211416473fc2ef3b750964c8725486
 SHA512:
-  metadata.gz: 6a15ec580d5f122a244767e9c6589bbb2f136c8687ebc34752cae8897e29ada1d147dd9c64581fb8726f84dbcb56e5462969a3de4b4692fc39992b521b9ce546
-  data.tar.gz: 1eb2142c60d6db130339aa0d22b15a6c9524074292e2a5382aef7371376b338f0db7f9578c025ce03d4e3a8c43e71d0020c1bb8fbacbb94d680107b4179d5f48
+  metadata.gz: c73b37b4f1f904d0600649f7cc2f7111b61171d725c7a9f06dc6b723b202e05b83d4f5a8bdeba9d9de78e67a547fcf6ba82c23073c12e63002dc04eb48fb06f2
+  data.tar.gz: 69129ed10031078627b54ae3a947bf5bbb6142b98af076ff20ea1c7126ebb32c4e8f806aef82604b8cacffcfdf85ffcc594215ecb387349e579cd0ad6baa447c

data/definitions/protip/messages/big_decimal_value.proto

@@ -3,5 +3,7 @@ syntax = "proto3";
 package protip.messages;
 
 message BigDecimalValue {
-  bytes serialized = 1;
+  int64  numerator   = 1;
+  uint64 denominator = 2;
+  uint32 precision   = 3;
 }

data/lib/protip/messages/big_decimal_value.rb

@@ -5,7 +5,9 @@ require 'google/protobuf'
 
 Google::Protobuf::DescriptorPool.generated_pool.build do
   add_message "protip.messages.BigDecimalValue" do
-    optional :serialized, :bytes, 1
+    optional :numerator, :int64, 1
+    optional :denominator, :uint64, 2
+    optional :precision, :uint32, 3
   end
 end
 

data/lib/protip/transformers/big_decimal_transformer.rb

@@ -1,4 +1,5 @@
 require 'bigdecimal'
+require 'bigdecimal/util' # Pulls in the rational -> bigdecimal conversion
 
 require 'protip/transformer'
 require 'protip/transformers/delegating_transformer'
@@ -11,11 +12,17 @@ module Protip
         self['protip.messages.BigDecimalValue'] = (Class.new do
             include Protip::Transformer
             def to_object(message, field)
-              BigDecimal._load(message.serialized)
+              Rational(message.numerator, message.denominator).to_d(message.precision)
             end
 
             def to_message(object, field)
-              field.subtype.msgclass.new(serialized: BigDecimal.new(object)._dump)
+              object = BigDecimal.new(object)
+              rational = object.to_r
+              field.subtype.msgclass.new(
+                numerator: rational.numerator,
+                denominator: rational.denominator,
+                precision: object.precs[0], # This is the current precision of the decimal
+              )
             end
           end).new
       end

data/test/unit/protip/transformers/big_decimal_transformer_test.rb

@@ -21,12 +21,13 @@ describe Protip::Transformers::BigDecimalTransformer do
       expected_value ||= value
       it "transforms #{name} values" do
         message = transformer.to_message(value, field)
-        assert_equal expected_value, transformer.to_object(message, field)
+        object = transformer.to_object(message, field)
+        assert_equal BigDecimal, object.class
+        assert_equal expected_value, object
       end
     end
     describe 'for BigDecimal arguments' do
       it_transforms 'integer', BigDecimal.new(104, 1)
-      it_transforms 'infinity', (BigDecimal.new(1, 1) / 0)
       it_transforms 'fractions', BigDecimal.new(100.5, 5)
       it_transforms 'rational numbers', BigDecimal.new(Rational(2, 3), 3)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.30.5
+  version: 0.30.6
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-24 00:00:00.000000000 Z
+date: 2016-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel