proscenium 0.4.2-x86_64-darwin → 0.5.0-x86_64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66baa8293b370fb8909751539c7e79327d7c63f9f254fbad2a38bcecf80afe75
-  data.tar.gz: d0666219ca0b7a9b4a12627a160df177764e3b097eb3a3e6d063da585c413b05
+  metadata.gz: 1f905fa040049f8ad4f5863b705c9f99f74cda1e38c3cbb9325e7bada262e36d
+  data.tar.gz: 73ef3f88ab3a1c6510275be8df6c0ca982d483685deff51764c9ae4ae057acef
 SHA512:
-  metadata.gz: 0cefd18721b3f644ba32274bd8a7d3eac6d38a78a203971715ae98fbef4ff2bc70fd4c3258fa049d6b75c8120c3225ebd78d5f73f0701f0dc52e7d76c3f423f5
-  data.tar.gz: 0ffad05d6db91c8aaec6949452039d92d34c78f19110e62abd1fa4e9e303072fde623ac885418fcd3c31c228652b3d8e9800462539c08659acfcfbe58108193a
+  metadata.gz: da5cb634c091dba3d8a86e571dae54a1683b45620076ebbe74ac1f2990e1a5b934310704cd16cc364f4fc3b3edd6900561f5a11d20b0065379546af349a6ec17
+  data.tar.gz: 2468099ba8d90572e876a54e7f1a66c1b1cf77c243edcbd57a9b89a25e71f06c501c9c61133b6249082efc12675a5a24fe6d43750c2ab12422bc688a6b73b2b2

data/app/channels/proscenium/connection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Proscenium
   class Connection < ActionCable::Connection::Base
     identified_by :uid

data/app/channels/proscenium/reload_channel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Proscenium
   class ReloadChannel < ActionCable::Channel::Base
     def subscribed

data/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Proscenium::Railtie.routes.draw do
   if Proscenium.config.auto_reload
     mount Proscenium::Railtie.websocket => Proscenium.config.cable_mount_path

data/lib/proscenium/compilers/esbuild/compile_error.js

@@ -28,6 +28,7 @@ export default function () {
             font-family: var(--monospace);
             line-height: 1.5;
             width: 800px;
+            height: 66vh;
             color: #d8d8d8;
             margin: 30px auto;
             padding: 25px 40px;

data/lib/proscenium/compilers/esbuild/resolve_plugin.js

@@ -1,5 +1,6 @@
 import { join, resolve } from 'std/path/mod.ts'
 import { resolve as resolveFromImportMap } from 'import-maps/resolve'
+import { cache } from 'cache'
 
 import setup from './setup_plugin.js'
 
@@ -15,6 +16,45 @@ export default setup('resolve', (build, options) => {
   const isProd = env === 'production'
 
   return [
+    {
+      // Filters for imports starting with `url:http://` or `url:https://`; returning the path
+      // without the `url:` prefix, and a namespace of 'url`
+      type: 'onResolve',
+      filter: /^url:https?:\/\//,
+      callback(args) {
+        return {
+          path: args.path.slice(4),
+          namespace: 'url'
+        }
+      }
+    },
+
+    {
+      type: 'onResolve',
+      filter: /.*/,
+      namespace: 'url',
+      callback(args) {
+        if (!isBareModule(args.path)) {
+          return {
+            path: new URL(args.path, args.importer).toString(),
+            namespace: 'url'
+          }
+        }
+      }
+    },
+
+    {
+      type: 'onLoad',
+      filter: /.*/,
+      namespace: 'url',
+      async callback(args) {
+        const file = await cache(args.path)
+        const contents = await Deno.readTextFile(file.path)
+
+        return { contents }
+      }
+    },
+
     {
       type: 'onResolve',
       filter: /.*/,
@@ -28,9 +68,13 @@ export default setup('resolve', (build, options) => {
           args.suffix = `?${options.cacheQueryString}`
         }
 
-        // Mark remote modules as external.
-        if (args.path.startsWith('http://') || args.path.startsWith('https://')) {
-          return { external: true }
+        // Mark remote modules as external. If not css, then the path is prefixed with "url:", which
+        // is then handled by the Url Middleware.
+        if (
+          !args.importer.endsWith('.css') &&
+          (args.path.startsWith('http://') || args.path.startsWith('https://'))
+        ) {
+          return { path: `/url:${encodeURIComponent(args.path)}`, external: true }
         }
 
         // Rewrite the path to the actual runtime directory.
@@ -56,14 +100,24 @@ export default setup('resolve', (build, options) => {
     const result = { path: params.path, suffix: params.suffix }
 
     if (importMap) {
-      const baseURL = new URL(params.importer.slice(cwd.length), 'file://')
+      let baseURL
+      if (params.importer.startsWith('https://') || params.importer.startsWith('http://')) {
+        baseURL = new URL(params.importer)
+      } else {
+        baseURL = new URL(params.importer.slice(cwd.length), 'file://')
+      }
+
       const { matched, resolvedImport } = resolveFromImportMap(params.path, importMap, baseURL)
 
       if (matched) {
         if (resolvedImport.protocol === 'file:') {
           params.path = resolvedImport.pathname
         } else {
-          return { path: resolvedImport.href, external: true }
+          if (params.importer.endsWith('.css')) {
+            return { path: resolvedImport.href, external: true }
+          }
+
+          return { path: `/url:${encodeURIComponent(resolvedImport.href)}`, external: true }
         }
       }
     }
@@ -73,9 +127,7 @@ export default setup('resolve', (build, options) => {
       result.path = resolve(cwd, params.path.slice(1))
     }
 
-    // Resolve the path using esbuild's internal resolution. This allows us to import node packages
-    // and extension-less paths without custom code, as esbuild with resolve them for us.
-    const resolveResult = await build.resolve(result.path, {
+    const resOptions = {
       // If path is a bare module (node_modules), and resolveDir is the Proscenium runtime dir, or
       // is the current working dir, then use `cwd` as the `resolveDir`, otherwise pass it through
       // as is. This ensures that nested node_modules are resolved correctly.
@@ -84,11 +136,16 @@ export default setup('resolve', (build, options) => {
         (!params.resolveDir.startsWith(cwd) || params.resolveDir.startsWith(runtimeDir))
           ? cwd
           : params.resolveDir,
+      kind: params.kind,
       pluginData: {
         // We use this property later on, as we should ignore this resolution call.
         isResolvingPath: true
       }
-    })
+    }
+
+    // Resolve the path using esbuild's internal resolution. This allows us to import node packages
+    // and extension-less paths without custom code, as esbuild with resolve them for us.
+    const resolveResult = await build.resolve(result.path, resOptions)
 
     // Simple return the resolved result if we have an error. Usually happens when module is not
     // found.

data/lib/proscenium/compilers/esbuild.js

@@ -92,9 +92,10 @@ async function main(paths = [], options = {}) {
       for await (const file of expandGlob(path, { root })) {
         file.isFile && entryPoints.add(file.path)
       }
-    } else if (path.startsWith('/')) {
-      // Path is absolute, so it must be outsideRoot. Don't prefix the root.
-      // See Proscenium::Middleware::OutsideRoot.
+    } else if (path.startsWith('/') || /^url:https?:\/\//.test(path)) {
+      // Path is absolute, or is prefixed with 'url:', so it must be outsideRoot, or Url. Don't
+      // prefix the root.
+      // See Proscenium::Middleware::[OutsideRoot|Url].
       entryPoints.add(path)
     } else {
       entryPoints.add(join(root, path))
@@ -128,6 +129,12 @@ async function main(paths = [], options = {}) {
     jsxDev: !isTest && !isProd,
     minify: isProd,
     bundle: true,
+
+    // The Esbuild default places browser before module, but we're building for modern browsers
+    // which support esm. So we prioritise that. Some libraries export a "browser" build that still
+    // uses CJS.
+    mainFields: ['module', 'browser', 'main'],
+
     plugins: [
       envPlugin(),
       resolvePlugin({ runtimeDir, importMap, debug, cacheQueryString: options.cacheQueryString }),

data/lib/proscenium/link_to_helper.rb

@@ -10,15 +10,6 @@ module Proscenium
     #   link_to 'Go to', MyComponent
     #
     # TODO: ummm, todo it! ;)
-    def link_to(*args, &block)
-      # name_argument_index = block ? 0 : 1
-      # if (args[name_argument_index]).respond_to?(:render_in)
-      #   return super(*LinkToComponentArguments.new(args, name_argument_index,
-      #                                              self).helper_options, &block)
-      # end
-
-      super
-    end
   end
 
   # Component handling for the `link_to` helper.

data/lib/proscenium/middleware/url.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Proscenium
+  class Middleware
+    # Handles requests prefixed with "url:https://"; downloading, caching, and compiling them.
+    class Url < Esbuild
+      private
+
+      # @override [Esbuild] It's a URL, so always assume it is renderable (we won't actually know
+      #   until it's downloaded).
+      def renderable?
+        true
+      end
+
+      # @override [Esbuild]
+      def path
+        CGI.unescape(@request.path)[1..]
+      end
+    end
+  end
+end

data/lib/proscenium/middleware.rb

@@ -10,6 +10,7 @@ module Proscenium
     autoload :Base
     autoload :Esbuild
     autoload :Runtime
+    autoload :Url
     autoload :OutsideRoot
 
     def initialize(app)
@@ -45,6 +46,7 @@ module Proscenium
         return OutsideRoot if path.fnmatch?(glob_types[:outsideRoot], File::FNM_EXTGLOB)
       end
 
+      return Url if request.path.match?(glob_types[:url])
       return Runtime if path.fnmatch?(glob_types[:runtime], File::FNM_EXTGLOB)
       return Esbuild if path.fnmatch?(glob_types[:esbuild], File::FNM_EXTGLOB)
     end

data/lib/proscenium/phlex.rb

@@ -11,9 +11,9 @@ module Proscenium
 
     module Helpers
       def side_load_javascripts(...)
-        if (output = @_view_context.side_load_javascripts(...))
-          @_target << output
-        end
+        return unless (output = @_view_context.side_load_javascripts(...))
+
+        @_target << output
       end
 
       %i[side_load_stylesheets proscenium_dev].each do |name|

data/lib/proscenium/railtie.rb

@@ -14,6 +14,7 @@ module Proscenium
   DEFAULT_GLOB_TYPES = {
     esbuild: '/{config,app,lib,node_modules}/**.{js,mjs,jsx,css}',
     runtime: '/proscenium-runtime/**.{js,jsx}',
+    url: %r{^/url:https?%3A%2F%2F},
     outsideRoot: '/**/*.{js,jsx,mjs,css}'
   }.freeze
 

data/lib/proscenium/side_load.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 module Proscenium
   module SideLoad
     DEFAULT_EXTENSIONS = %i[js css].freeze
@@ -68,3 +69,4 @@ module Proscenium
     end
   end
 end
+# rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity

data/lib/proscenium/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Proscenium
-  VERSION = '0.4.2'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proscenium
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
 platform: x86_64-darwin
 authors:
 - Joel Moss
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-29 00:00:00.000000000 Z
+date: 2022-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actioncable
@@ -132,14 +132,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.74.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.74.1
 description:
 email:
 - joel@developwithstyle.com
@@ -182,6 +182,7 @@ files:
 - lib/proscenium/middleware/outside_root.rb
 - lib/proscenium/middleware/runtime.rb
 - lib/proscenium/middleware/static.rb
+- lib/proscenium/middleware/url.rb
 - lib/proscenium/phlex.rb
 - lib/proscenium/phlex/component.rb
 - lib/proscenium/phlex/react_component.rb