propono 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1a85c42b5fc2bc691203ab82f348535476bdf35
-  data.tar.gz: af8fc9263c84a713779bee0e019258220102549f
+  metadata.gz: fd3ced592b10a7174ff8ad5d289be236e5ae911b
+  data.tar.gz: 684569cf1483fd61aa542bfd92156446ebdd10d6
 SHA512:
-  metadata.gz: b80edaee162402a479bff3a14cf05b56fd3e37bd5838faf7fbc040194028aa7451e12bf6b9bf551ca25fa1903a104a68083c5514b6afd6e9e137e955bcedeeb4
-  data.tar.gz: 994bdbb18b1cde05e45415d90ef435545a5e5647c1d8d466eee912e2b62a318677c1a0af658b1a718caee78fbcb6ffa1b46ac64707922cbc3c37f017d4ab811c
+  metadata.gz: 1b1070b99440428a2fcefe9ce90e2e7ead21058df3170ae76364e5e88f38b4102471bef86597d1996036f22d4916e0b2d7a49dc7d1039699a65ee60d62e1ba22
+  data.tar.gz: 449066005af17034bdd41b606fa8c649c2dc99e42950567fb8d91f903a34451a1b483f8f369037b3d6b1f68fe68bae98e377822865d2238581ef889ff442b4b8

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.9.1 / Unreleased
+
+* [FEATURE] Propono will raise exceptions if the message processing fails
+
 # 0.9.0 / Unreleased
 
 * [FEATURE] Add message ids that track throughout Propono

data/lib/propono/services/queue_listener.rb

@@ -46,8 +46,8 @@ module Propono
         message = context.delete(:message)
         Propono.config.logger.info "Propono [#{context[:id]}]: Received from sqs."
         @message_processor.call(message, context)
-      rescue
-        Propono.config.logger.info("Sending and recieving messags without ids is deprecated")
+      rescue JSON::ParserError, TypeError
+        Propono.config.logger.info("Sending and recieving messages without ids is deprecated")
         @message_processor.call(body)
       end
       sqs.delete_message(queue_url, sqs_message['ReceiptHandle'])

data/lib/propono/version.rb

@@ -1,3 +1,3 @@
 module Propono
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/test/services/queue_listener_test.rb

@@ -105,6 +105,13 @@ module Propono
       @listener.stubs(queue_url: queue_url)
       @listener.send(:read_messages)
     end
+
+    def test_messages_are_not_deleted_if_there_is_an_exception
+      @listener = QueueListener.new(@topic_id) { raise StandardError.new("Test Error") }
+      @listener.stubs(sqs: @sqs)
+      @sqs.expects(:delete_message).never
+      @listener.send(:read_messages)
+    end
   end
   class QueueListenerLegacySyntaxTest < Minitest::Test
 
@@ -129,7 +136,7 @@ module Propono
     end
 
     def test_old_syntax_has_deprecation_warning
-      Propono.config.logger.expects(:info).with("Sending and recieving messags without ids is deprecated")
+      Propono.config.logger.expects(:info).with("Sending and recieving messages without ids is deprecated")
       @listener.stubs(sqs: @sqs)
       @listener.send(:read_messages)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: propono
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - MalcyL
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-13 00:00:00.000000000 Z
+date: 2013-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog