propono 0.1.0 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: d088866567c48097ae184895e09ead7de705179d
+  data.tar.gz: c6f6e90ed8d3c1773e95e1c7d60c211274df48d9
+SHA512:
+  metadata.gz: b39237981ffd1d4c3515247ea61db476633f810e8de97308ec76a25efb4b5a0d6e9db71196c15b9250a88b6dee657f1ccc22940916c87619df8e14547e06f33f
+  data.tar.gz: 60bffaf2b6bd7f07189c5b3d441db887b90720ca3d1c5e5365895b407757943289b40c564b0a9244db1a805125b69e78dc534dd19382b6d302890cda3deb3cc7

data/README.md

@@ -40,6 +40,7 @@ class Toy
     Propono.config.access_key = '...'
     Propono.config.secret_key = '...'
     Propono.config.queue_region = 'eu-west-1'
+    Propono.config.application_name = '...'
   end
 end
 

data/lib/propono.rb

@@ -1,14 +1,16 @@
 require "propono/version"
 require 'propono/configuration'
-require 'propono/sns'
-require 'propono/sqs'
-require "propono/post_subscriber"
-require "propono/publisher"
-require "propono/queue"
-require "propono/queue_creator"
-require "propono/queue_subscriber"
-require "propono/subscriber"
-require "propono/topic_creator"
+require 'propono/components/sns'
+require 'propono/components/sqs'
+require "propono/components/queue"
+require "propono/components/topic"
+
+require "propono/services/post_subscriber"
+require "propono/services/publisher"
+require "propono/services/queue_creator"
+require "propono/services/queue_subscriber"
+require "propono/services/subscriber"
+require "propono/services/topic_creator"
 
 module Propono
   def self.config

data/lib/propono/components/topic.rb

@@ -0,0 +1,11 @@
+module Propono
+  class Topic
+
+    include Sqs
+
+    attr_reader :arn
+    def initialize(arn)
+      @arn = arn
+    end
+  end
+end

data/lib/propono/configuration.rb

@@ -8,7 +8,7 @@ module Propono
   class Configuration
     include Singleton
 
-    SETTINGS = [:access_key, :secret_key, :queue_region, :queue_url]
+    SETTINGS = [:access_key, :secret_key, :queue_region, :application_name]
     attr_writer *SETTINGS
 
     def initialize

data/lib/propono/{queue_subscriber.rb → services/queue_subscriber.rb}

@@ -15,15 +15,19 @@ module Propono
     end
 
     def subscribe
-      @topic_arn = TopicCreator.find_or_create(@topic_id)
+      @topic = TopicCreator.find_or_create(@topic_id)
       @queue = QueueCreator.find_or_create(queue_name)
-      sns.subscribe(@topic_arn, @queue.arn, 'sqs')
+      sns.subscribe(@topic.arn, @queue.arn, 'sqs')
     end
 
     private
 
     def queue_name
-      @topic_id
+      "#{config.application_name.gsub(" ", "_")}::#{@topic_id}"
+    end
+
+    def config
+      Configuration.instance
     end
   end
 end

data/lib/propono/{topic_creator.rb → services/topic_creator.rb}

@@ -16,7 +16,8 @@ module Propono
     def find_or_create
       result = sns.create_topic(@topic_id)
       body = result.body
-      body.fetch('TopicArn') { raise TopicCreatorError.new("No TopicArn returned from SNS") }
+      arn = body.fetch('TopicArn') { raise TopicCreatorError.new("No TopicArn returned from SNS") }
+      Topic.new(arn)
     end
   end
 end

data/lib/propono/version.rb

@@ -1,3 +1,3 @@
 module Propono
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/test/configuration_test.rb

@@ -34,10 +34,10 @@ module Propono
       assert_equal queue_region, config.queue_region
     end
 
-    def test_queue_url
-      queue_url = "test-queue-url"
-      config.queue_url = queue_url
-      assert_equal queue_url, config.queue_url
+    def test_application_name
+      application_name = "test-application-name"
+      config.application_name = application_name
+      assert_equal application_name, config.application_name
     end
 
     def test_missing_access_key_throws_exception
@@ -58,9 +58,9 @@ module Propono
       end
     end
 
-    def test_missing_queue_url_throws_exception
+    def test_missing_application_name_throws_exception
       assert_raises(ConfigurationError) do
-        config.queue_url
+        config.application_name
       end
     end
   end

data/test/queue_subscriber_test.rb

@@ -3,16 +3,17 @@ require File.expand_path('../test_helper', __FILE__)
 module Propono
   class QueueSubscriberTest < Minitest::Test
     def test_create_topic
-      topic = 'foobar'
-      TopicCreator.expects(:find_or_create).with(topic)
-      QueueSubscriber.subscribe(topic)
+      topic_id = 'foobar'
+      topic = Topic.new(topic_id)
+      TopicCreator.expects(:find_or_create).with(topic_id).returns(topic)
+      QueueSubscriber.subscribe(topic_id)
     end
 
     def test_sqs_create_is_called
-      topic = "Foobar"
-      subscriber = QueueSubscriber.new(topic)
+      topic_id = "Foobar"
+      subscriber = QueueSubscriber.new(topic_id)
 
-      TopicCreator.stubs(find_or_create: "1123")
+      TopicCreator.stubs(find_or_create: Topic.new("1123"))
 
       sqs = mock()
       sqs.expects(:create_queue).with(subscriber.send(:queue_name)).returns(mock(body: {'QueueUrl' => Fog::AWS::SQS::Mock::QueueUrl}))
@@ -22,14 +23,27 @@ module Propono
     end
 
     def test_subscriber_queue_name
-      skip
+      config.application_name = "MyApp"
+
+      topic_id = "Foobar"
+      subscriber = QueueSubscriber.new(topic_id)
+
+      assert_equal subscriber.send(:queue_name), "MyApp::Foobar"
+    end
+
+    def test_subscriber_queue_name_with_spaces
+      config.application_name = "My App"
+
+      topic_id = "Foobar"
+      subscriber = QueueSubscriber.new(topic_id)
+
+      assert_equal subscriber.send(:queue_name), "My_App::Foobar"
     end
 
     def test_subscribe_calls_subscribe
       arn = "arn123"
-      queue_url = 
 
-      TopicCreator.stubs(find_or_create: arn)
+      TopicCreator.stubs(find_or_create: Topic.new(arn))
       QueueCreator.stubs(find_or_create: Queue.new(Fog::AWS::SQS::Mock::QueueUrl))
 
       sns = mock()

data/test/test_helper.rb

@@ -19,6 +19,11 @@ class Minitest::Test
     Propono::Configuration.instance.access_key = "test-access-key"
     Propono::Configuration.instance.secret_key = "test-secret-key"
     Propono::Configuration.instance.queue_region = "us-east-1"
+    Propono::Configuration.instance.application_name = "MyApp"
+  end
+
+  def config
+    Propono::Configuration.instance
   end
 end
 

data/test/topic_creator_test.rb

@@ -21,7 +21,8 @@ module Propono
       creator = TopicCreator.new("foobar")
       creator.stubs(sns: sns)
 
-      assert_equal arn, creator.find_or_create
+      topic = creator.find_or_create
+      assert_equal arn, topic.arn
     end
 
     def test_should_raise_exception_if_no_arn_returned

data/test/topic_test.rb

@@ -0,0 +1,12 @@
+require File.expand_path('../test_helper', __FILE__)
+
+module Propono
+  class TopicTest < Minitest::Test
+    def test_intialization_sets_url
+      arn = 'foobar'
+      topic = Topic.new(arn)
+      assert arn, topic.arn
+    end
+  end
+end
+

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: propono
 version: !ruby/object:Gem::Version
-  version: 0.1.0
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - MalcyL
@@ -15,23 +14,20 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -39,7 +35,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -47,39 +42,34 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -87,7 +77,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -108,16 +97,17 @@ files:
 - README.md
 - Rakefile
 - lib/propono.rb
+- lib/propono/components/queue.rb
+- lib/propono/components/sns.rb
+- lib/propono/components/sqs.rb
+- lib/propono/components/topic.rb
 - lib/propono/configuration.rb
-- lib/propono/post_subscriber.rb
-- lib/propono/publisher.rb
-- lib/propono/queue.rb
-- lib/propono/queue_creator.rb
-- lib/propono/queue_subscriber.rb
-- lib/propono/sns.rb
-- lib/propono/sqs.rb
-- lib/propono/subscriber.rb
-- lib/propono/topic_creator.rb
+- lib/propono/services/post_subscriber.rb
+- lib/propono/services/publisher.rb
+- lib/propono/services/queue_creator.rb
+- lib/propono/services/queue_subscriber.rb
+- lib/propono/services/subscriber.rb
+- lib/propono/services/topic_creator.rb
 - lib/propono/version.rb
 - propono.gemspec
 - test/configuration_test.rb
@@ -131,36 +121,30 @@ files:
 - test/subscriber_test.rb
 - test/test_helper.rb
 - test/topic_creator_test.rb
+- test/topic_test.rb
 homepage: ''
 licenses:
 - AGPL3
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1295735887844079183
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1295735887844079183
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: General purpose pub/sub library built on top of AWS SNS and SQS
 test_files:
 - test/configuration_test.rb
@@ -174,3 +158,4 @@ test_files:
 - test/subscriber_test.rb
 - test/test_helper.rb
 - test/topic_creator_test.rb
+- test/topic_test.rb