property 0.8.1 → 0.8.2

data/History.txt

@@ -1,3 +1,10 @@
+== 0.8.2 2010-02-16
+
+* 2 minor enhancements
+  * fixed a bug where properties would be dumped even if none changed
+  * fixed a bug where properties would not be dumped soon enough to mark
+    storage object as dirty
+
 == 0.8.1 2010-02-14
 
 * 2 major enhancement

data/lib/property.rb

@@ -9,7 +9,7 @@ require 'property/serialization/json'
 require 'property/core_ext/time'
 
 module Property
-  VERSION = '0.8.1'
+  VERSION = '0.8.2'
 
   def self.included(base)
     base.class_eval do

data/lib/property/attribute.rb

@@ -23,7 +23,7 @@ module Property
 
         store_properties_in self
 
-        before_save :dump_properties
+        after_validation   :dump_properties
 
         alias_method_chain :attributes=,  :properties
       end
@@ -48,14 +48,14 @@ module Property
             end
 
             def dump_properties
-              if @properties
+              if @properties && @properties.changed?
                 if !@properties.empty?
                   #{accessor}write_attribute('properties', encode_properties(@properties))
                 else
                   #{accessor}write_attribute('properties', nil)
                 end
+                @properties.clear_changes!
               end
-              @properties.clear_changes!
               true
             end
         EOF

data/property.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{property}
-  s.version = "0.8.1"
+  s.version = "0.8.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Renaud Kern", "Gaspard Bucher"]
-  s.date = %q{2010-02-14}
+  s.date = %q{2010-02-16}
   s.description = %q{Wrap model properties into a single database column and declare properties from within the model.}
   s.email = %q{gaspard@teti.ch}
   s.extra_rdoc_files = [

data/test/unit/property/declaration_test.rb

@@ -226,6 +226,8 @@ class DeclarationTest < Test::Unit::TestCase
     end
 
     Contact = Class.new(ActiveRecord::Base) do
+      attr_accessor :assertion
+      before_save :before_save_assertion
       set_table_name :employees
       has_many :versions, :class_name => 'DeclarationTest::Version'
 
@@ -253,6 +255,13 @@ class DeclarationTest < Test::Unit::TestCase
           end
         end
       end
+
+      private
+        def before_save_assertion
+          return true unless @assertion
+          @assertion.call
+          true
+        end
     end
 
     setup do
@@ -274,6 +283,13 @@ class DeclarationTest < Test::Unit::TestCase
       assert_equal 'no', subject.famous
       assert_equal Hash["first_name"=>["Martin", "Hannah"]], subject.changes
     end
+
+    should 'dump properties before any before_save triggers' do
+      subject.assertion = Proc.new do
+        assert_match %r{Karl}, subject.version.properties
+      end
+      subject.update_attributes('first_name' => 'Karl')
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: property
 version: !ruby/object:Gem::Version 
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors: 
 - Renaud Kern
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-14 00:00:00 +01:00
+date: 2010-02-16 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency