proof-sharepoint-ruby 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02de9841d5e27fa6c194f2c556e2ada51f4fd3488174d81d3dea471f39aab4f5
-  data.tar.gz: b3e32950b55aa4408ec9fa2a9bec3d585aaf8f01ea9645f46f7b6085cc973f1a
+  metadata.gz: b37b51db53e39a4afeeb13ed5924e370f42f2e820fd3c12261ab89336fd37270
+  data.tar.gz: 2afa31bb7abab11d20599d601a32140105683d818863ec58481a62f54f88b12a
 SHA512:
-  metadata.gz: 142b225cdfbc1f844aff2670eb09f6b5ca740b0625571ca0c2461697d2f4ff86ceb142be4cf0f22ee13e1e089d4107509a7945c4a1c69fc8f4a8baf2d87ee56d
-  data.tar.gz: 46a37d9d7aadab3338668659e6f57f7c26655a7a281fab6210fc053d00fb1a4bbac5a5a53c582026fb63e8c53570f238706f330c9a892719884b3d7192761c31
+  metadata.gz: 301e8ff97f4aa043b9a9a9d1c4724b0a53605ef1e0e3cd3a4247e88d50d6ea2c103299dae7c2686bfea44065af69ecc40464adf3493b2058625424d8a9123e32
+  data.tar.gz: a6c3491873211230b6b40645bbef7ba60900ab7154dcead7dcb84fc22974111b179c3ffff516bcd3ab0fcb9dcacef8013a47742ff1ec8702d2c90c0507d0698c

data/.github/pull_request_template.md

@@ -0,0 +1,44 @@
+[EV-XXXXX](https://proof-tech.atlassian.net/browse/EV-XXXXX)
+
+### Overview
+
+Please include a summary of the changes in this pull request.
+List any dependencies that are required before this change is applied.
+
+### Solution
+
+How did you solve the problem?
+Call out any particular implementation choices or design decisions you made
+
+### Screenshots
+
+[insert screenshots here]
+
+### Testing Instructions
+
+Describe, for your colleagues, how they can test your code locally on their system
+
+### Pre-Merge Checklist
+
+- [ ] My changes generate no new warnings / errors in the console
+- [ ] I have written/updated Ruby/JS tests for the areas of the code base that I have modified
+- [ ] I have done end-to-end QA testing of sections of the application I have altered
+- [ ] I am prepared for this code to go to production today (or there is a WIP label on the pull request)
+- [ ] I have translated new / edited user facing text (or have a separate ticket for i18N)
+- [ ] [_OPTIONAL_] I have considered the effects of my code on data integrity
+- [ ] [_OPTIONAL_] I have demoed the code and gotten a review from a member of the CS team (for customer facing code)
+
+### Special Pre- or Post-Deployment Instructions
+
+List any changes (if any) that need to happen in production around the deploy of this code. e.g.
+
+1. any commands to run on the host
+2. any environment variables that need to be added (share via keeper! Not here!)
+3. any commands to be run in rails console
+
+If deploying a new version:
+1. Build your new version (in bash console).
+   `gem build proof-sharepoint-ruby.gemspec`
+2. Publish the gem (in bash)
+   `gem push proof-sharepoint-ruby-x.x.x.gem`
+   > delete the *.gem file afterwards.

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [2.0.0]
+* Fix bug around apostrophes in file names for SharePoint Online.
+
+### Changes
+- encode apostrophes in filenames as %27%27 instead of just %27.
+
 ## [1.0.0]
 * Initial Release
 

data/README.md

@@ -165,3 +165,24 @@ The SPException class contains methods to inspect the query that was made to the
     puts "The request had a body: #{e.request_body}" unless e.request_body.nil?
   end
 ```
+
+# Development
+
+1. First make a PR to fix the bug.
+2. Once the PR is merged make a special commit changing the version number and adding a new Changelog entry.
+
+   i. Update the [version number](https://github.com/proofgov/sharepoint-ruby/blob/master/lib/sharepoint-version.rb).
+    
+   ii. Update the [changelog](https://github.com/proofgov/sharepoint-ruby/blob/master/CHANGELOG.md).
+    > see https://keepachangelog.com/en/1.0.0/ for more info on changelogs.
+    
+    > Optionally add yourself to the list of authors in the [Gem Spec](https://github.com/proofgov/sharepoint-ruby/blob/master/proof-sharepoint-ruby.gemspec)
+
+*If your repo supports it you can replace steps 3 and 4 with `bundle exec rake release`.*
+
+3. Build your new version (in bash console).
+   `gem build sharepoint_api.gemspec`
+
+4. Publish the gem (in bash)
+   `gem push sharepoint_api-1.0.1.gem`
+   > delete the *.gem file afterwards.

data/lib/sharepoint-properties.rb

@@ -79,7 +79,7 @@ module Sharepoint
 
     def get_deferred_property property_name
       deferred_data = @data[property_name]['__deferred']
-      uri           = deferred_data['uri'].gsub /^http.*\/_api\/web\//i, ''
+      uri           = deferred_data['uri'].gsub(/^http.*\/_api\/web\//i, '').gsub(/%27/, '%27%27')
       @site.query :get, uri
     end
 

data/lib/sharepoint-version.rb

@@ -1,3 +1,3 @@
 module Sharepoint
-  VERSION = '1.0.0'.freeze
+  VERSION = '2.0.0'.freeze
 end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: proof-sharepoint-ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Marlen Brunner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2020-12-07 00:00:00.000000000 Z
@@ -36,6 +36,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/pull_request_template.md"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -64,7 +65,7 @@ metadata:
   homepage_uri: https://github.com/proofgov/sharepoint-ruby
   source_code_uri: https://github.com/proofgov/sharepoint-ruby
   changelog_uri: https://github.com/proofgov/sharepoint-ruby/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -79,8 +80,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.4
+signing_key:
 specification_version: 4
 summary: SharePoint client.
 test_files: []