pronto 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d790438c36a0945548e93b684a0225d4f65b639
-  data.tar.gz: ca04d65732a2caf6a2fef29ad051dfca62435e73
+  metadata.gz: d9e785fa465bad216b0f336498835b2aa1187fd0
+  data.tar.gz: 9bb5d7cda10cf493fd3ced190babc7f1cc86c42b
 SHA512:
-  metadata.gz: db97dd116571fd0e2e43060e2356805f5a2e1e06b058d23fae943d086b9aae01ff3d57cf3624134100ae55a5fb54ba2cd9159f5d40fa50b0377c8763a6b5dc31
-  data.tar.gz: 510838cc30c3d6a97340a9940d86876bdc303c391f7f784b75783a16bb410397eaa7911563be9fcbe3d79f251ab26c192379b36a98f01f39c852a46b21264a5d
+  metadata.gz: 68cf5d28920fcd9093953af0227ed63cfed52946053980b77e0b274e2a9483cd3279ed16d3ab034a019392b9ee64a325b9b5e600c9180ba3c755c3810078e460
+  data.tar.gz: fa5025e68712ae7bc31cb49b3ffe357dae0069af9f567892243fcd853cbf121ea8fb84b32b95b6bf17c19ee8e0bcfd5ab101792625a98221733734cc9cd6f35b

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.9.2
+
+### Bugs fixed
+
+* [#231](https://github.com/mmozuras/pronto/pull/231): GitHub pull request review formatter was not working in some cases without Accept header.
+
 ## 0.9.1
 
 ### Bugs fixed

data/README.md

@@ -14,7 +14,7 @@ to your [styleguide](https://github.com/mmozuras/pronto-rubocop), [are DRY](http
 
 ![Pronto demo](pronto.gif "")
 
-_This README might be ahead of the latest release. Find the README for v0.9.0 [here](https://github.com/mmozuras/pronto/blob/v0.9.0/README.md)._
+_This README might be ahead of the latest release. Find the README for v0.9.2 [here](https://github.com/mmozuras/pronto/blob/v0.9.2/README.md)._
 
 * [Installation](#installation)
 * [Usage](#usage)
@@ -105,12 +105,18 @@ Then just run it:
 $ PRONTO_GITHUB_ACCESS_TOKEN=token pronto run -f github -c origin/master
 ```
 
-or, if you want comments to appear on pull request diff, instead of commit:
+If you want comments to appear on pull request diff, instead of commit:
 
 ```sh
 $ PRONTO_GITHUB_ACCESS_TOKEN=token pronto run -f github_pr -c origin/master
 ```
 
+If you want review to appear on pull request diff, instead of comments:
+
+```sh
+$ PRONTO_GITHUB_ACCESS_TOKEN=token pronto run -f github_pr_review -c origin/master
+```
+
 Use `GithubStatusFormatter` to submit [commit status](https://github.com/blog/1227-commit-status-api):
 
 ```sh
@@ -129,7 +135,7 @@ As an alternative, you can also set up a rake task:
 ```ruby
 Pronto::GemNames.new.to_a.each { |gem_name| require "pronto/#{gem_name}" }
 
-formatter = Pronto::Formatter::GithubFormatter.new # or GithubPullRequestFormatter
+formatter = Pronto::Formatter::GithubFormatter.new # also possible: GithubPullRequestFormatter, GithubPullRequestReviewFormatter
 status_formatter = Pronto::Formatter::GithubStatusFormatter.new
 formatters = [formatter, status_formatter]
 Pronto.run('origin/master', '.', formatters)

data/lib/pronto/config_file.rb

@@ -51,7 +51,7 @@ module Pronto
         if oldval.is_a?(Hash) && newval.is_a?(Hash)
           oldval.merge(newval, &merger)
         else
-          oldval || newval
+          oldval.nil? ? newval : oldval
         end
       end
 

data/lib/pronto/github.rb

@@ -41,6 +41,7 @@ module Pronto
     def create_pull_request_review(comments)
       options = {
         event: 'COMMENT',
+        accept: 'application/vnd.github.black-cat-preview+json', # https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review
         comments: comments.map do |c|
           { path: c.path, position: c.position, body: c.body }
         end

data/lib/pronto/version.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Version
-    STRING = '0.9.1'.freeze
+    STRING = '0.9.2'.freeze
 
     MSG = '%s (running on %s %s %s)'.freeze
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-23 00:00:00.000000000 Z
+date: 2017-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged