pronto 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5a612afb137e615ee5e2ff77940bef61836f285
-  data.tar.gz: 0028f06bc680ba757b55872dadb633a38dae08e0
+  metadata.gz: aaeb87265191eb83028cbb2472b1420ee19377d9
+  data.tar.gz: 19c3d10ff59f8a50f1d179023579ccfda4a4284c
 SHA512:
-  metadata.gz: 8232ab1382ee1447884bf1061e58d28f8a62100c59743ac5a6a8264404c94b61966e8478b0b11b2da999eaab21a136233fc44cbc1354d4403dc6301094d88915
-  data.tar.gz: 8a4a1196d482efceedb8c64edced6b56fa8977fe07ce9511cd4cf6374863dd5fdfa2e4f5992d56cc93eeb6a03f669182c67de03418cffbe6774e914a773e62ad
+  metadata.gz: b10a90fd0bd0d9289bb1989b91e61eb1d0ed0026860bd4056729247fddea2bea9631ca645492e40f67434be185afff16f579888410ce00cebe14e2891cdc5f7e
+  data.tar.gz: bdfb4bc6140b8d65b7dfddbe70b663410adb9476eec31d566256811b2b128ac1f0864790298ce7ebe941f22ff34c542a6b21407c458d1b41536d489a7055c317

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 0.8.1
+
+### Changes
+
+* Add a default GitLab API endpoint: https://gitlab.com/api/v3
+
+### Bugs fixed
+
+* [#125](https://github.com/mmozuras/pronto/issues/125): check whether message has a line before posting to GitLab.
+* Post on commit comments on correct commit: use message.commit_sha to set comment.sha instead of head.
+* [#201](https://github.com/mmozuras/pronto/issues/201): allow messages without line positions or paths.
+
 ## 0.8.0
 
 ### New features

data/README.md

@@ -137,14 +137,14 @@ on GitLab commits using `GitlabFormatter`.
 
 Set the `PRONTO_GITLAB_API_ENDPOINT` environment variable or value in `.pronto.yml` to
 your API endpoint URL. If you are using Gitlab.com's hosted service your
-endpoint will be `https://gitlab.com/api/v3`.
+endpoint will be set by default.
 Set the `PRONTO_GITLAB_API_PRIVATE_TOKEN` environment variable or value in `.pronto.yml
 to your Gitlab private token which you can find in your account settings.
 
 Then just run it:
 
 ```sh
-$ PRONTO_GITLAB_API_ENDPOINT="https://gitlab.com/api/v3" PRONTO_GITLAB_API_PRIVATE_TOKEN=token pronto run -f gitlab -c origin/master
+$ PRONTO_GITLAB_API_PRIVATE_TOKEN=token pronto run -f gitlab -c origin/master
 ```
 
 ### Bitbucket Integration
@@ -214,7 +214,10 @@ Currently available:
 
 * [pronto-brakeman](https://github.com/mmozuras/pronto-brakeman)
 * [pronto-coffeelint](https://github.com/siebertm/pronto-coffeelint)
+* [pronto-clippy](https://github.com/hauleth/pronto-clippy)
 * [pronto-credo](https://github.com/carakan/pronto-credo)
+* [pronto-dialyzer](https://github.com/iurifq/pronto-dialyzer)
+* [pronto-dogma](https://github.com/iurifq/pronto-dogma)
 * [pronto-eslint](https://github.com/mmozuras/pronto-eslint) (uses [eslintrb](https://github.com/zendesk/eslintrb))
 * [pronto-eslint_npm](https://github.com/doits/pronto-eslint_npm) (uses eslint installed from npm)
 * [pronto-fasterer](https://github.com/mmozuras/pronto-fasterer)
@@ -235,10 +238,12 @@ Currently available:
 * [pronto-scss](https://github.com/mmozuras/pronto-scss)
 * [pronto-shellcheck](https://github.com/pclalv/pronto-shellcheck)
 * [pronto-slim](https://github.com/nysthee/pronto-slim)
+* [pronto-slim_lint](https://github.com/ibrahima/pronto-slim_lint)
 * [pronto-spell](https://github.com/mmozuras/pronto-spell)
 * [pronto-stylelint](https://github.com/kevinjalbert/pronto-stylelint)
 * [pronto-swiftlint](https://github.com/ajanauskas/pronto-swiftlint)
 * [pronto-tailor](https://github.com/ajanauskas/pronto-tailor)
+* [pronto-textlint](https://github.com/seikichi/pronto-textlint)
 
 ## Articles
 
@@ -261,4 +266,4 @@ Make a Pull Request to add something you wrote or found useful.
 
 ## Copyright
 
-Copyright (c) 2013-2016 Mindaugas Mozūras. See [LICENSE](LICENSE) for further details.
+Copyright (c) 2013-2017 Mindaugas Mozūras. See [LICENSE](LICENSE) for further details.

data/lib/pronto/bitbucket.rb

@@ -30,9 +30,13 @@ module Pronto
     end
 
     def create_pull_comment(comment)
-      @config.logger.log("Creating pull request comment on #{pull_id}")
-      client.create_pull_comment(slug, pull_id, comment.body,
-                                 comment.path, comment.position)
+      if comment.path && comment.position
+        @config.logger.log("Creating pull request comment on #{pull_id}")
+        client.create_pull_comment(slug, pull_id, comment.body,
+                                   comment.path, comment.position)
+      else
+        create_commit_comment(comment)
+      end
     end
 
     private

data/lib/pronto/config_file.rb

@@ -14,7 +14,7 @@ module Pronto
       'gitlab' => {
         'slug' => nil,
         'api_private_token' => nil,
-        'api_endpoint' => nil
+        'api_endpoint' => 'https://gitlab.com/api/v3'
       },
       'bitbucket' => {
         'slug' => nil,

data/lib/pronto/formatter/bitbucket_formatter.rb

@@ -10,7 +10,7 @@ module Pronto
       end
 
       def line_number(message, _)
-        message.line.new_lineno
+        message.line.new_lineno if message.line
       end
     end
   end

data/lib/pronto/formatter/bitbucket_pull_request_formatter.rb

@@ -8,6 +8,10 @@ module Pronto
       def pretty_name
         'BitBucket'
       end
+
+      def line_number(message, _)
+        message.line.line.new_lineno if message.line
+      end
     end
   end
 end

data/lib/pronto/formatter/commit_formatter.rb

@@ -1,15 +1,12 @@
 module Pronto
   module Formatter
     class CommitFormatter < GitFormatter
-      def existing_comments(client, sha)
-        comments = client.commit_comments(sha)
+      def existing_comments(messages, client, repo)
+        shas = messages.map(&:commit_sha)
+        comments = shas.flat_map { |sha| client.commit_comments(sha) }
         grouped_comments(comments)
       end
 
-      def line_number(message, _)
-        message.line.new_lineno
-      end
-
       def submit_comments(client, comments)
         comments.each { |comment| client.create_commit_comment(comment) }
       rescue Octokit::UnprocessableEntity, HTTParty::Error => e

data/lib/pronto/formatter/git_formatter.rb

@@ -3,9 +3,8 @@ module Pronto
     class GitFormatter
       def format(messages, repo, patches)
         client = client_module.new(repo)
-        head = repo.head_commit_sha
-        existing = existing_comments(client, head)
-        comments = new_comments(messages, patches, head)
+        existing = existing_comments(messages, client, repo)
+        comments = new_comments(messages, patches)
         additions = remove_duplicate_comments(existing, comments)
         submit_comments(client, additions)
 
@@ -63,18 +62,19 @@ module Pronto
         comments.map { |comment| "- #{comment.body}" }.join("\n")
       end
 
-      def new_comment(message, patches, sha)
+      def new_comment(message, patches)
+        config.logger.log("Creating a comment from message: #{message.inspect}")
+        sha = message.commit_sha
         body = message.msg
         path = message.path
-        lineno = line_number(message, patches)
-
+        lineno = line_number(message, patches) if message.line
         Comment.new(sha, body, path, lineno)
       end
 
-      def new_comments(messages, patches, sha)
+      def new_comments(messages, patches)
         comments = messages
           .uniq
-          .map { |message| new_comment(message, patches, sha) }
+          .map { |message| new_comment(message, patches) }
         grouped_comments(comments)
       end
 

data/lib/pronto/formatter/gitlab_formatter.rb

@@ -10,7 +10,7 @@ module Pronto
       end
 
       def line_number(message, _)
-        message.line.commit_line.new_lineno
+        message.line.commit_line.new_lineno if message.line
       end
     end
   end

data/lib/pronto/formatter/pull_request_formatter.rb

@@ -1,15 +1,12 @@
 module Pronto
   module Formatter
     class PullRequestFormatter < GitFormatter
-      def existing_comments(client, sha)
+      def existing_comments(messages, client, repo)
+        sha = repo.head_commit_sha
         comments = client.pull_comments(sha)
         grouped_comments(comments)
       end
 
-      def line_number(message, _)
-        message.line.line.new_lineno
-      end
-
       def submit_comments(client, comments)
         comments.each { |comment| client.create_pull_comment(comment) }
       rescue Octokit::UnprocessableEntity, HTTParty::Error => e

data/lib/pronto/github.rb

@@ -31,10 +31,14 @@ module Pronto
     end
 
     def create_pull_comment(comment)
-      @config.logger.log("Creating pull request comment on #{pull_id}")
-      client.create_pull_comment(slug, pull_id, comment.body,
-                                 pull_sha || comment.sha,
-                                 comment.path, comment.position)
+      if comment.path && comment.position
+        @config.logger.log("Creating pull request comment on #{pull_id}")
+        client.create_pull_comment(slug, pull_id, comment.body,
+                                   pull_sha || comment.sha,
+                                   comment.path, comment.position)
+      else
+        create_commit_comment(comment)
+      end
     end
 
     def create_commit_status(status)

data/lib/pronto/version.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Version
-    STRING = '0.8.0'.freeze
+    STRING = '0.8.1'.freeze
 
     MSG = '%s (running on %s %s %s)'.freeze
 

data/pronto.gemspec

@@ -52,6 +52,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rspec-expectations', '~> 3.4')
   s.add_development_dependency('bundler', '~> 1.3')
   s.add_development_dependency('simplecov', '~> 0.11')
-  s.add_development_dependency('rubocop', '~> 0.42')
-  s.add_development_dependency('pronto-rubocop', '~> 0.7.0')
+  s.add_development_dependency('rubocop', '~> 0.47')
+  s.add_development_dependency('pronto-rubocop', '~> 0.8.0')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-12 00:00:00.000000000 Z
+date: 2017-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged
@@ -208,28 +208,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.42'
+        version: '0.47'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.42'
+        version: '0.47'
 - !ruby/object:Gem::Dependency
   name: pronto-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.8.0
 description: |2
       Pronto runs analysis quickly by checking only the relevant changes. Created
       to be used on pull requests, but suited for other scenarios as well. Perfect