pronto 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed857182c87afee371e2822b26f8303a42cd848a
-  data.tar.gz: 152bd31948ddf2b999dbc7334c5292842e99ffcd
+  metadata.gz: a27da5811cbcfa71ddffc5842dc3295214206496
+  data.tar.gz: 233865c5cf619728fcd26dfbf3607feb0d5fed51
 SHA512:
-  metadata.gz: c06cb847d4a953da70c9b79944a55d7b93058c49e737cd898d7247ca803ea00960b8343395b0376cea0efc2c2d18bda55ae6cd52a65aa60d391e55aa95b16a86
-  data.tar.gz: 181ab9b31d663a84e3a49c38d4e59826cda02f7cf047813dc92c8d4350ea81c6940da803b5109c7c031f918edd5c2cb79f31992179c922b76a1dcbe34a95a020
+  metadata.gz: b9fb4cb872bca3c99d59ffe3a931dfac4911c617363a72f3307353792e514390fe5995382f11897da40694653e8029a8d181ed7a453aef27b0a79ba318a6423b
+  data.tar.gz: fa1ff35ec5743311ff86453f2487a14903e40c9ea00b6df04a507dc2949d696957c6067d7d4dfee9e0e6412d0fc3331394f1db247e399157d62d75fd2723c45a

data/CHANGELOG.md

@@ -1,7 +1,14 @@
 # Changelog
 
-## Unreleased
+## 0.7.1
 
+### Changes
+
+* Remove support for Ruby 1.9.3.
+
+## Bugs fixed
+
+* [#149](https://github.com/mmozuras/pronto/issues/149): Use patches to correctly find line position for GitHub pull request formatter.
 
 ## 0.7.0
 

data/README.md

@@ -211,7 +211,8 @@ Currently available:
 * [pronto-brakeman](https://github.com/mmozuras/pronto-brakeman)
 * [pronto-coffeelint](https://github.com/siebertm/pronto-coffeelint)
 * [pronto-credo](https://github.com/carakan/pronto-credo)
-* [pronto-eslint](https://github.com/mmozuras/pronto-eslint)
+* [pronto-eslint](https://github.com/mmozuras/pronto-eslint) (uses [eslintrb](https://github.com/zendesk/eslintrb))
+* [pronto-eslint_npm](https://github.com/doits/pronto-eslint_npm) (uses eslint installed from npm)
 * [pronto-fasterer](https://github.com/mmozuras/pronto-fasterer)
 * [pronto-flay](https://github.com/mmozuras/pronto-flay)
 * [pronto-foodcritic](https://github.com/mmozuras/pronto-foodcritic)
@@ -226,6 +227,7 @@ Currently available:
 * [pronto-reek](https://github.com/mmozuras/pronto-reek)
 * [pronto-rubocop](https://github.com/mmozuras/pronto-rubocop)
 * [pronto-scss](https://github.com/mmozuras/pronto-scss)
+* [pronto-slim](https://github.com/nysthee/pronto-slim)
 * [pronto-spell](https://github.com/mmozuras/pronto-spell)
 * [pronto-swiftlint](https://github.com/ajanauskas/pronto-swiftlint)
 * [pronto-tailor](https://github.com/ajanauskas/pronto-tailor)

data/lib/pronto/formatter/bitbucket_formatter.rb

@@ -9,7 +9,7 @@ module Pronto
         'BitBucket'
       end
 
-      def line_number(message)
+      def line_number(message, _)
         message.line.new_lineno
       end
     end

data/lib/pronto/formatter/commit_formatter.rb

@@ -6,7 +6,7 @@ module Pronto
         grouped_comments(comments)
       end
 
-      def line_number(message)
+      def line_number(message, _)
         message.line.new_lineno
       end
 

data/lib/pronto/formatter/git_formatter.rb

@@ -63,10 +63,10 @@ module Pronto
         comments.map { |comment| "- #{comment.body}" }.join("\n")
       end
 
-      def new_comment(message, _patches, sha)
+      def new_comment(message, patches, sha)
         body = message.msg
         path = message.path
-        lineno = line_number(message)
+        lineno = line_number(message, patches)
 
         Comment.new(sha, body, path, lineno)
       end

data/lib/pronto/formatter/github_formatter.rb

@@ -9,8 +9,8 @@ module Pronto
         'GitHub'
       end
 
-      def line_number(message)
-        message.line.commit_line.position
+      def line_number(message, _)
+        message.line.commit_line.position if message.line
       end
     end
   end

data/lib/pronto/formatter/github_pull_request_formatter.rb

@@ -8,6 +8,11 @@ module Pronto
       def pretty_name
         'GitHub'
       end
+
+      def line_number(message, patches)
+        line = patches.find_line(message.full_path, message.line.new_lineno)
+        line.position
+      end
     end
   end
 end

data/lib/pronto/formatter/gitlab_formatter.rb

@@ -9,7 +9,7 @@ module Pronto
         'GitLab'
       end
 
-      def line_number(message)
+      def line_number(message, _)
         message.line.commit_line.new_lineno
       end
     end

data/lib/pronto/formatter/pull_request_formatter.rb

@@ -6,7 +6,7 @@ module Pronto
         grouped_comments(comments)
       end
 
-      def line_number(message)
+      def line_number(message, _)
         message.line.line.new_lineno
       end
 

data/lib/pronto/version.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Version
-    STRING = '0.7.0'.freeze
+    STRING = '0.7.1'.freeze
 
     MSG = '%s (running on %s %s %s)'.freeze
 

data/pronto.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   EOF
 
   s.licenses = ['MIT']
-  s.required_ruby_version = '>= 1.9.3'
+  s.required_ruby_version = '>= 2.0.0'
   s.rubygems_version = '1.8.23'
 
   s.files = `git ls-files`.split($RS).reject do |file|
@@ -52,6 +52,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rspec-expectations', '~> 3.4')
   s.add_development_dependency('bundler', '~> 1.3')
   s.add_development_dependency('simplecov', '~> 0.11')
-  s.add_development_dependency('rubocop', '~> 0.39.0')
-  s.add_development_dependency('pronto-rubocop', '~> 0.6.2')
+  s.add_development_dependency('rubocop', '~> 0.42')
+  s.add_development_dependency('pronto-rubocop', '~> 0.7.0')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-07 00:00:00.000000000 Z
+date: 2016-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged
@@ -202,28 +202,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: '0.42'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: '0.42'
 - !ruby/object:Gem::Dependency
   name: pronto-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.0
 description: |2
       Pronto runs analysis quickly by checking only the relevant changes. Created
       to be used on pull requests, but suited for other scenarios as well. Perfect
@@ -295,7 +295,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="