pronto 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff7961eb19513e5f97591c8c3fe3630e3236728a
-  data.tar.gz: 967a58d14779d25bce8f2532795ce8002984512f
+  metadata.gz: ed857182c87afee371e2822b26f8303a42cd848a
+  data.tar.gz: 152bd31948ddf2b999dbc7334c5292842e99ffcd
 SHA512:
-  metadata.gz: 6d5dd6119ee5480bcd3d2df9eab8a7a260d7ba22fde8d4eeb5bdcecc25b67564eab12507507e9a315d5673a8f11753eede5480723238895c2129b1e62adc5fd6
-  data.tar.gz: 1dd77adf6e74f41db0241da701de825084da6dff03370ab9e2faf37681b019bb6b2a66685dee304c545c3edc1d13dfd1c421756e69a481a1cdddba40ff4ec9fa
+  metadata.gz: c06cb847d4a953da70c9b79944a55d7b93058c49e737cd898d7247ca803ea00960b8343395b0376cea0efc2c2d18bda55ae6cd52a65aa60d391e55aa95b16a86
+  data.tar.gz: 181ab9b31d663a84e3a49c38d4e59826cda02f7cf047813dc92c8d4350ea81c6940da803b5109c7c031f918edd5c2cb79f31992179c922b76a1dcbe34a95a020

data/CHANGELOG.md

@@ -2,11 +2,31 @@
 
 ## Unreleased
 
+
+## 0.7.0
+
+### New features
+
+* [#135](https://github.com/mmozuras/pronto/pull/135): add Bitbucket formatter.
+* [#135](https://github.com/mmozuras/pronto/pull/135): add Bitbucket pull request formatter.
+* [#134](https://github.com/mmozuras/pronto/pull/134): colorize text formatter.
+* [#144](https://github.com/mmozuras/pronto/pull/144): add GitHub status formatter.
+* [#157](https://github.com/mmozuras/pronto/pull/157): ability to run pronto CLI from within subdirectories of a git repository.
+* [#154](https://github.com/mmozuras/pronto/pull/154): add an option to consolidate pull request comments.
+
+### Changes
+
+* [#162](https://github.com/mmozuras/pronto/pull/162): don't count info messages for error exit code.
+
+### Bugs fixed
+
+* [#153](https://github.com/mmozuras/pronto/pull/153): correctly get repo_path.
+
 ## 0.6.0
 
 ### New features
 
-* Added `-V/--verbose-version` option that displays Ruby version.
+* Add `-V/--verbose-version` option that displays Ruby version.
 * [#127](https://github.com/mmozuras/pronto/pull/127): ability to specify `max_warnings` via configuration or environment variable.
 * [#18](https://github.com/mmozuras/pronto/issues/18): ability to specify `verbose` via configuration, which can provide more output for debugging purposes.
 * [#83](https://github.com/mmozuras/pronto/issues/83): support multiple formatters as an option to `pronto run`.
@@ -14,9 +34,9 @@
 ### Changes
 
 * `--version` only displays the version itself without any additional text.
-* Replaced `Pronto.gem_names` with `Pronto::GemNames.new.to_a`.
-* [#116](https://github.com/mmozuras/pronto/pull/116): improved GitHub formatter error output.
-* [#123](https://github.com/mmozuras/pronto/pull/126): added runner attribute to message initialization.
+* Replace `Pronto.gem_names` with `Pronto::GemNames.new.to_a`.
+* [#116](https://github.com/mmozuras/pronto/pull/116): improve GitHub formatter error output.
+* [#123](https://github.com/mmozuras/pronto/pull/126): add runner attribute to message initialization.
 * Runner expects to receive patches/commit via `initialize(patches, commit)`, instead of `run(patches, commit)`.
 
 ### Bugs fixed

data/README.md

@@ -1,13 +1,13 @@
 # Pronto
 
-[![Code Climate](https://codeclimate.com/github/mmozuras/pronto.png)](https://codeclimate.com/github/mmozuras/pronto)
-[![Build Status](https://secure.travis-ci.org/mmozuras/pronto.png)](http://travis-ci.org/mmozuras/pronto)
-[![Gem Version](https://badge.fury.io/rb/pronto.png)](http://badge.fury.io/rb/pronto)
-[![Dependency Status](https://gemnasium.com/mmozuras/pronto.png)](https://gemnasium.com/mmozuras/pronto)
-[![Inline docs](http://inch-ci.org/github/mmozuras/pronto.png)](http://inch-ci.org/github/mmozuras/pronto)
+[![Code Climate](https://codeclimate.com/github/mmozuras/pronto.svg)](https://codeclimate.com/github/mmozuras/pronto)
+[![Build Status](https://secure.travis-ci.org/mmozuras/pronto.svg)](http://travis-ci.org/mmozuras/pronto)
+[![Gem Version](https://badge.fury.io/rb/pronto.svg)](http://badge.fury.io/rb/pronto)
+[![Dependency Status](https://gemnasium.com/mmozuras/pronto.svg)](https://gemnasium.com/mmozuras/pronto)
+[![Inline docs](http://inch-ci.org/github/mmozuras/pronto.svg)](http://inch-ci.org/github/mmozuras/pronto)
 
 **Pronto** runs analysis quickly by checking only the relevant changes. Created to
-be used on [pull requests](#github-integration), but also works [locally](#local-changes) and integrates with [GitLab](#gitlab-integration).
+be used on [pull requests](#github-integration), but also works [locally](#local-changes) and integrates with [GitLab](#gitlab-integration) and [Bitbucket](#bitbucket-integration).
 Perfect if want to find out quickly if branch introduces changes that conform
 to your [styleguide](https://github.com/mmozuras/pronto-rubocop), [are DRY](https://github.com/mmozuras/pronto-flay), [don't introduce security holes](https://github.com/mmozuras/pronto-brakeman) and [more](#runners).
 
@@ -18,6 +18,7 @@ to your [styleguide](https://github.com/mmozuras/pronto-rubocop), [are DRY](http
     * [Local Changes](#local-changes)
     * [GitHub Integration](#github-integration)
     * [GitLab Integration](#gitlab-integration)
+    * [Bitbucket Integration](#bitbucket-integration)
 * [Configuration](#configuration)
 * [Runners](#runners)
 * [Articles](#articles)
@@ -100,7 +101,20 @@ $ GITHUB_ACCESS_TOKEN=token pronto run -f github -c origin/master
 or, if you want comments to appear on pull request diff, instead of commit:
 
 ```sh
-$ GITHUB_ACCESS_TOKEN=token PULL_REQUEST_ID=id pronto run -f github_pr -c origin/master
+$ GITHUB_ACCESS_TOKEN=token pronto run -f github_pr -c origin/master
+```
+
+Use `GithubStatusFormatter` to submit [commit status](https://github.com/blog/1227-commit-status-api):
+
+```sh
+$ GITHUB_ACCESS_TOKEN=token pronto run -f github_status -c origin/master
+```
+
+It's possible to combine multiple formatters.
+To get both pull request comments and commit status summary use:
+
+```sh
+$ GITHUB_ACCESS_TOKEN=token PULL_REQUEST_ID=id pronto run -f github_status github_pr -c origin/master
 ```
 
 As an alternative, you can also set up a rake task:
@@ -109,7 +123,9 @@ As an alternative, you can also set up a rake task:
 Pronto::GemNames.new.to_a.each { |gem_name| require "pronto/#{gem_name}" }
 
 formatter = Pronto::Formatter::GithubFormatter.new # or GithubPullRequestFormatter
-Pronto.run('origin/master', '.', formatter)
+status_formatter = Pronto::Formatter::GithubStatusFormatter.new
+formatters = [formatter, status_formatter]
+Pronto.run('origin/master', '.', formatters)
 ```
 
 ### GitLab Integration
@@ -131,13 +147,26 @@ Then just run it:
 $ GITLAB_API_ENDPOINT="https://gitlab.com/api/v3" GITLAB_API_PRIVATE_TOKEN=token pronto run -f gitlab -c origin/master
 ```
 
-As an alternative, you can also set up a rake task:
+### Bitbucket Integration
 
-```ruby
-Pronto::GemNames.new.to_a.each { |gem_name| require "pronto/#{gem_name}" }
+You can run Pronto as a step of your CI builds and get the results as comments
+on Bitbucket commits using `BitbucketFormatter` or `BitbucketPullRequestFormatter`.
+
+Add Pronto runners you want to use to your Gemfile:
+
+Set the BITBUCKET_USERNAME and BITBUCKET_PASSWORD environment variables or values in `.pronto.yml`.
+.
+
+Then just run it:
 
-formatter = Pronto::Formatter::GitlabFormatter.new
-Pronto.run('origin/master', '.', formatter)
+```sh
+$ BITBUCKET_USERNAME=user BITBUCKET_PASSWORD=pass pronto run -f bitbucket -c origin/master
+```
+
+or, if you want comments to appear on pull request diff, instead of commit:
+
+```sh
+$ BITBUCKET_USERNAME=user BITBUCKET_PASSWORD=pass pronto run -f bitbucket_pr -c origin/master
 ```
 
 ## Configuration
@@ -157,9 +186,14 @@ github:
   api_endpoint: https://api.github.com/
   web_endpoint: https://github.com/
 gitlab:
-  slug: mmozuras/pronto,
-  api_private_token: 46751,
+  slug: mmozuras/42
+  api_private_token: 46751
   api_endpoint: https://api.vinted.com/gitlab
+bitbucket:
+  slug: mmozuras/pronto
+  username: user
+  password: pass
+  web_endpoint: https://bitbucket.org/
 max_warnings: 150
 verbose: false
 ```
@@ -176,13 +210,16 @@ Currently available:
 
 * [pronto-brakeman](https://github.com/mmozuras/pronto-brakeman)
 * [pronto-coffeelint](https://github.com/siebertm/pronto-coffeelint)
+* [pronto-credo](https://github.com/carakan/pronto-credo)
 * [pronto-eslint](https://github.com/mmozuras/pronto-eslint)
 * [pronto-fasterer](https://github.com/mmozuras/pronto-fasterer)
 * [pronto-flay](https://github.com/mmozuras/pronto-flay)
 * [pronto-foodcritic](https://github.com/mmozuras/pronto-foodcritic)
+* [pronto-haml](https://github.com/mmozuras/pronto-haml)
 * [pronto-jscs](https://github.com/spajus/pronto-jscs)
 * [pronto-jshint](https://github.com/mmozuras/pronto-jshint)
-* [pronto-haml](https://github.com/mmozuras/pronto-haml)
+* [pronto-json](https://github.com/deees/pronto-json)
+* [pronto-luacheck](https://github.com/seikichi/pronto-luacheck)
 * [pronto-poper](https://github.com/mmozuras/pronto-poper)
 * [pronto-rails_best_practices](https://github.com/mmozuras/pronto-rails_best_practices)
 * [pronto-rails_schema](https://github.com/raimondasv/pronto-rails_schema)
@@ -202,6 +239,7 @@ Articles to help you to get started:
 * [Continuous Static Analysis using Pronto](http://codingfearlessly.com/2014/11/06/continuous-static-analysis/)
 * [Pronto and git hooks](http://elliotthilaire.net/gem-pronto-and-git-hooks/)
 * [How to end fruitless dev discussions about your project’s code style?](https://medium.com/appaloosa-store-engineering/how-to-end-fruitless-dev-discussions-about-your-project-s-code-style-245070bff6d4)
+* [Free automated code reviews using Pronto](https://hovancik.net/blog/2016/04/11/free-automated-code-reviews-using-pronto.html)
 
 Make a Pull Request to add something you wrote or found useful.
 

data/lib/pronto/bitbucket.rb

@@ -0,0 +1,76 @@
+module Pronto
+  class Bitbucket
+    def initialize(repo)
+      @repo = repo
+      @config = Config.new
+      @comment_cache = {}
+      @pull_id_cache = {}
+    end
+
+    def pull_comments(sha)
+      @comment_cache["#{pull_id}/#{sha}"] ||= begin
+        client.pull_comments(slug, pull_id).map do |comment|
+          Comment.new(sha, comment.content, comment.filename, comment.line_to)
+        end
+      end
+    end
+
+    def commit_comments(sha)
+      @comment_cache[sha.to_s] ||= begin
+        client.commit_comments(slug, sha).map do |comment|
+          Comment.new(sha, comment.content, comment.filename, comment.line_to)
+        end
+      end
+    end
+
+    def create_commit_comment(comment)
+      @config.logger.log("Creating commit comment on #{comment.sha}")
+      client.create_commit_comment(slug, comment.sha, comment.body,
+                                   comment.path, comment.position)
+    end
+
+    def create_pull_comment(comment)
+      @config.logger.log("Creating pull request comment on #{pull_id}")
+      client.create_pull_comment(slug, pull_id, comment.body,
+                                 comment.path, comment.position)
+    end
+
+    private
+
+    def slug
+      return @config.bitbucket_slug if @config.bitbucket_slug
+      @slug ||= begin
+        @repo.remote_urls.map do |url|
+          hostname = Regexp.escape(@config.bitbucket_hostname)
+          match = %r{.*#{hostname}(:|\/)(?<slug>.*?)(?:\.git)?\z}.match(url)
+          match[:slug] if match
+        end.compact.first
+      end
+    end
+
+    def client
+      @client ||= BitbucketClient.new(@config.bitbucket_username,
+                                      @config.bitbucket_password)
+    end
+
+    def pull_id
+      pull ? pull.id.to_i : env_pull_id.to_i
+    end
+
+    def env_pull_id
+      ENV['PULL_REQUEST_ID']
+    end
+
+    def pull
+      @pull ||= if env_pull_id
+                  pull_requests.find { |pr| pr.id.to_i == env_pull_id.to_i }
+                elsif @repo.branch
+                  pull_requests.find { |pr| pr.branch['name'] == @repo.branch }
+                end
+    end
+
+    def pull_requests
+      @pull_requests ||= client.pull_requests(slug)
+    end
+  end
+end

data/lib/pronto/cli.rb

@@ -49,8 +49,14 @@ module Pronto
 
       formatters = ::Pronto::Formatter.get(options[:formatters])
       commit = options[:index] ? :index : options[:commit]
-      messages = ::Pronto.run(commit, '.', formatters, path)
-      exit(messages.count) if options[:'exit-code']
+      repo_workdir = ::Rugged::Repository.discover('.').workdir
+      messages = Dir.chdir(repo_workdir) do
+        ::Pronto.run(commit, '.', formatters, path)
+      end
+      if options[:'exit-code']
+        error_messages_count = messages.count { |m| m.level != :info }
+        exit(error_messages_count)
+      end
     rescue Rugged::RepositoryError
       puts '"pronto" should be run from a git repository'
     end

data/lib/pronto/clients/bitbucket_client.rb

@@ -0,0 +1,55 @@
+class BitbucketClient
+  include HTTParty
+  base_uri 'https://api.bitbucket.org/1.0/repositories'
+
+  def initialize(username, password)
+    credentials = { username: username, password: password }
+    @headers = { basic_auth: credentials }
+  end
+
+  def commit_comments(slug, sha)
+    response = self.class.get("/#{slug}/changesets/#{sha}/comments", @headers)
+    openstruct(response.parsed_response)
+  end
+
+  def create_commit_comment(slug, sha, body, path, position)
+    options = {
+      body: {
+        content: body,
+        line_to: position,
+        filename: path
+      }
+    }
+    options.merge!(@headers)
+    self.class.post("/#{slug}/changesets/#{sha}/comments", options)
+  end
+
+  def pull_comments(slug, pr_id)
+    url = "/#{slug}/pullrequests/#{pr_id}/comments"
+    response = self.class.get(url, @headers)
+    openstruct(response.parsed_response)
+  end
+
+  def pull_requests(slug)
+    base = 'https://api.bitbucket.org/2.0/repositories'
+    url = "#{base}/#{slug}/pullrequests?state=OPEN"
+    response = self.class.get(url, @headers)
+    openstruct(response.parsed_response['values'])
+  end
+
+  def create_pull_comment(slug, pull_id, body, path, position)
+    options = {
+      body: {
+        content: body,
+        line_to: position,
+        filename: path
+      }
+    }
+    options.merge!(@headers)
+    self.class.post("/#{slug}/pullrequests/#{pull_id}/comments", options)
+  end
+
+  def openstruct(response)
+    response.map { |r| OpenStruct.new(r) }
+  end
+end

data/lib/pronto/comment.rb

@@ -0,0 +1,13 @@
+module Pronto
+  Comment = Struct.new(:sha, :body, :path, :position) do
+    def ==(other)
+      position == other.position &&
+        path == other.path &&
+        body == other.body
+    end
+
+    def to_s
+      "[#{sha}] #{path}:#{position} - #{body}"
+    end
+  end
+end

data/lib/pronto/config.rb

@@ -4,13 +4,17 @@ module Pronto
       @config_hash = config_hash
     end
 
-    %w(github gitlab).each do |service|
+    %w(github gitlab bitbucket).each do |service|
       ConfigFile::EMPTY[service].each do |key, _|
         name = "#{service}_#{key}"
         define_method(name) { ENV[name.upcase] || @config_hash[service][key] }
       end
     end
 
+    def consolidate_comments?
+      !@config_hash['consolidate_comments'].nil?
+    end
+
     def excluded_files
       @excluded_files ||= Array(exclude)
         .flat_map { |path| Dir[path.to_s] }
@@ -21,6 +25,10 @@ module Pronto
       URI.parse(github_web_endpoint).host
     end
 
+    def bitbucket_hostname
+      URI.parse(bitbucket_web_endpoint).host
+    end
+
     def max_warnings
       @config_hash['max_warnings']
     end

data/lib/pronto/config_file.rb

@@ -16,6 +16,12 @@ module Pronto
         'api_private_token' => nil,
         'api_endpoint' => nil
       },
+      'bitbucket' => {
+        'slug' => nil,
+        'username' => nil,
+        'password' => nil,
+        'web_endpoint' => 'https://bitbucket.org/'
+      },
       'runners' => [],
       'formatters' => [],
       'max_warnings' => nil,

data/lib/pronto/formatter/bitbucket_formatter.rb

@@ -0,0 +1,17 @@
+module Pronto
+  module Formatter
+    class BitbucketFormatter < CommitFormatter
+      def client_module
+        Bitbucket
+      end
+
+      def pretty_name
+        'BitBucket'
+      end
+
+      def line_number(message)
+        message.line.new_lineno
+      end
+    end
+  end
+end

data/lib/pronto/formatter/bitbucket_pull_request_formatter.rb

@@ -0,0 +1,13 @@
+module Pronto
+  module Formatter
+    class BitbucketPullRequestFormatter < PullRequestFormatter
+      def client_module
+        Bitbucket
+      end
+
+      def pretty_name
+        'BitBucket'
+      end
+    end
+  end
+end

data/lib/pronto/formatter/colorizable.rb

@@ -0,0 +1,17 @@
+module Pronto
+  module Formatter
+    module Colorizable
+      def colorize(string, color)
+        rainbow.wrap(string).color(color)
+      end
+
+      private
+
+      def rainbow
+        @rainbow ||= Rainbow.new.tap do |rainbow|
+          rainbow.enabled = $stdout.tty?
+        end
+      end
+    end
+  end
+end

data/lib/pronto/formatter/commit_formatter.rb

@@ -0,0 +1,21 @@
+module Pronto
+  module Formatter
+    class CommitFormatter < GitFormatter
+      def existing_comments(client, sha)
+        comments = client.commit_comments(sha)
+        grouped_comments(comments)
+      end
+
+      def line_number(message)
+        message.line.new_lineno
+      end
+
+      def submit_comments(client, comments)
+        comments.each { |comment| client.create_commit_comment(comment) }
+      rescue Octokit::UnprocessableEntity, HTTParty::Error => e
+        $stderr.puts "Failed to post: #{e.message}"
+        $stderr.puts e.inspect
+      end
+    end
+  end
+end

data/lib/pronto/formatter/formatter.rb

@@ -12,8 +12,11 @@ module Pronto
 
     FORMATTERS = {
       'github' => GithubFormatter,
+      'github_status' => GithubStatusFormatter,
       'github_pr' => GithubPullRequestFormatter,
       'gitlab' => GitlabFormatter,
+      'bitbucket' => BitbucketFormatter,
+      'bitbucket_pr' => BitbucketPullRequestFormatter,
       'json' => JsonFormatter,
       'checkstyle' => CheckstyleFormatter,
       'text' => TextFormatter,

data/lib/pronto/formatter/git_formatter.rb

@@ -0,0 +1,96 @@
+module Pronto
+  module Formatter
+    class GitFormatter
+      def format(messages, repo, patches)
+        client = client_module.new(repo)
+        head = repo.head_commit_sha
+        existing = existing_comments(client, head)
+        comments = new_comments(messages, patches, head)
+        additions = remove_duplicate_comments(existing, comments)
+        submit_comments(client, additions)
+
+        "#{additions.count} Pronto messages posted to #{pretty_name}"
+      end
+
+      def client_module
+        raise NotImplementedError
+      end
+
+      def pretty_name
+        raise NotImplementedError
+      end
+
+      protected
+
+      def existing_comments(*)
+        raise NotImplementedError
+      end
+
+      def line_number(*)
+        raise NotImplementedError
+      end
+
+      def submit_comments(*)
+        raise NotImplementedError
+      end
+
+      private
+
+      def grouped_comments(comments)
+        comments.group_by { |comment| [comment.path, comment.position] }
+      end
+
+      def config
+        @config ||= Config.new
+      end
+
+      def consolidate_comments(comments)
+        comment = comments.first
+        if comments.length > 1
+          joined_body = join_comments(comments)
+          Comment.new(comment.sha, joined_body, comment.path, comment.position)
+        else
+          comment
+        end
+      end
+
+      def dedupe_comments(existing, comments)
+        body = existing.map(&:body).join(' ')
+        comments.select { |comment| !body.include?(comment.body) }
+      end
+
+      def join_comments(comments)
+        comments.map { |comment| "- #{comment.body}" }.join("\n")
+      end
+
+      def new_comment(message, _patches, sha)
+        body = message.msg
+        path = message.path
+        lineno = line_number(message)
+
+        Comment.new(sha, body, path, lineno)
+      end
+
+      def new_comments(messages, patches, sha)
+        comments = messages
+          .uniq
+          .map { |message| new_comment(message, patches, sha) }
+        grouped_comments(comments)
+      end
+
+      def remove_duplicate_comments(old_comments, new_comments)
+        new_comments.each_with_object([]) do |(key, comments), memo|
+          existing = old_comments[key]
+          comments = dedupe_comments(existing, comments) if existing
+
+          if config.consolidate_comments?
+            comment = consolidate_comments(comments)
+            memo.push(comment)
+          else
+            memo.concat(comments)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pronto/formatter/github_formatter.rb

@@ -1,28 +1,16 @@
 module Pronto
   module Formatter
-    class GithubFormatter
-      def format(messages, repo, _)
-        client = Github.new(repo)
-
-        commit_messages = messages.uniq.map do |message|
-          sha = message.commit_sha
-          body = message.msg
-          path = message.path
-          position = message.line.commit_line.position if message.line
-
-          create_comment(client, sha, body, path, position)
-        end
-
-        "#{commit_messages.compact.count} Pronto messages posted to GitHub"
+    class GithubFormatter < CommitFormatter
+      def client_module
+        Github
       end
 
-      private
+      def pretty_name
+        'GitHub'
+      end
 
-      def create_comment(client, sha, body, path, position)
-        comment = Github::Comment.new(sha, body, path, position)
-        comments = client.commit_comments(sha)
-        existing = comments.any? { |c| comment == c }
-        client.create_commit_comment(comment) unless existing
+      def line_number(message)
+        message.line.commit_line.position
       end
     end
   end

data/lib/pronto/formatter/github_pull_request_formatter.rb

@@ -1,35 +1,12 @@
 module Pronto
   module Formatter
-    class GithubPullRequestFormatter
-      def format(messages, repo, patches)
-        client = Github.new(repo)
-        head = repo.head_commit_sha
-
-        commit_messages = messages.uniq.map do |message|
-          body = message.msg
-          path = message.path
-          line = patches.find_line(message.full_path, message.line.new_lineno)
-
-          create_comment(client, head, body, path, line.position)
-        end
-
-        "#{commit_messages.compact.count} Pronto messages posted to GitHub"
+    class GithubPullRequestFormatter < PullRequestFormatter
+      def client_module
+        Github
       end
 
-      private
-
-      def create_comment(client, sha, body, path, position)
-        comment = Github::Comment.new(sha, body, path, position)
-        comments = client.pull_comments(sha)
-        existing = comments.any? { |c| comment == c }
-        client.create_pull_comment(comment) unless existing
-      rescue Octokit::UnprocessableEntity => e
-        # The diff output of the local git version and Github is not always
-        # consistent, especially in areas where file renames happened, Github
-        # tends to recognize these better, leading to messages we can't post
-        # because their diff position is non-existent on Github.
-        # Ignore such occasions and continue posting other messages.
-        $stderr.puts "Failed to post: #{comment} with #{e.message}"
+      def pretty_name
+        'GitHub'
       end
     end
   end

data/lib/pronto/formatter/github_status_formatter/inflector.rb

@@ -0,0 +1,17 @@
+module Pronto
+  module Formatter
+    class GithubStatusFormatter
+      class Inflector
+        def self.underscore(camel_cased_word)
+          return camel_cased_word unless camel_cased_word =~ /[A-Z-]|::/
+          word = camel_cased_word.to_s.gsub(/::/, '/')
+          word.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+          word.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
+          word.tr!('-', '_')
+          word.downcase!
+          word
+        end
+      end
+    end
+  end
+end

data/lib/pronto/formatter/github_status_formatter/sentence.rb

@@ -0,0 +1,42 @@
+module Pronto
+  module Formatter
+    class GithubStatusFormatter
+      class Sentence
+        def initialize(words)
+          @words = words
+        end
+
+        def to_s
+          case words.size
+          when 0
+            ''
+          when 1
+            words[0].to_s.dup
+          when 2
+            "#{words[0]}#{WORD_CONNECTORS[:two_words_connector]}#{words[1]}"
+          else
+            to_oxford_comma_sentence
+          end
+        end
+
+        private
+
+        attr_reader :words
+
+        WORD_CONNECTORS = {
+          words_connector: ', ',
+          two_words_connector: ' and ',
+          last_word_connector: ', and '
+        }.freeze
+
+        private_constant :WORD_CONNECTORS
+
+        def to_oxford_comma_sentence
+          "#{words[0...-1].join(WORD_CONNECTORS[:words_connector])}"\
+            "#{WORD_CONNECTORS[:last_word_connector]}"\
+            "#{words[-1]}"
+        end
+      end
+    end
+  end
+end

data/lib/pronto/formatter/github_status_formatter/status_builder.rb

@@ -0,0 +1,76 @@
+require_relative 'sentence'
+require_relative 'inflector'
+
+module Pronto
+  module Formatter
+    class GithubStatusFormatter
+      class StatusBuilder
+        def initialize(runner, messages)
+          @runner = runner
+          @messages = messages
+        end
+
+        def description
+          desc = map_description
+          desc.empty? ? NO_ISSUES_DESCRIPTION : "Found #{desc}."
+        end
+
+        def state
+          failure? ? :failure : :success
+        end
+
+        def context
+          Inflector.underscore(@runner.name)
+        end
+
+        private
+
+        def failure?
+          @messages.any? { |message| failure_message?(message) }
+        end
+
+        def failure_message?(message)
+          message_state(message) == :failure
+        end
+
+        def message_state(message)
+          DEFAULT_LEVEL_TO_STATE_MAPPING[message.level]
+        end
+
+        def map_description
+          words = count_issue_types.map do |issue_type, issue_count|
+            pluralize(issue_count, issue_type)
+          end
+
+          Sentence.new(words).to_s
+        end
+
+        def count_issue_types
+          counts = @messages.each_with_object(Hash.new(0)) do |message, r|
+            r[message.level] += 1
+          end
+          order_by_severity(counts)
+        end
+
+        def order_by_severity(counts)
+          Hash[counts.sort_by { |k, _v| Pronto::Message::LEVELS.index(k) }]
+        end
+
+        def pluralize(count, word)
+          "#{count} #{word}#{count > 1 ? 's' : ''}"
+        end
+
+        DEFAULT_LEVEL_TO_STATE_MAPPING = {
+          info: :success,
+          warning: :failure,
+          error: :failure,
+          fatal: :failure
+        }.freeze
+
+        NO_ISSUES_DESCRIPTION = 'Coast is clear!'.freeze
+
+        private_constant :DEFAULT_LEVEL_TO_STATE_MAPPING, :NO_ISSUES_DESCRIPTION
+      end
+    end
+  end
+end

data/lib/pronto/formatter/github_status_formatter.rb

@@ -0,0 +1,28 @@
+require_relative 'github_status_formatter/status_builder'
+
+module Pronto
+  module Formatter
+    class GithubStatusFormatter
+      def format(messages, repo, _)
+        client = Github.new(repo)
+        head = repo.head_commit_sha
+
+        messages_by_runner = messages.uniq.group_by(&:runner)
+
+        Runner.runners.each do |runner|
+          create_status(client, head, runner, messages_by_runner[runner] || [])
+        end
+      end
+
+      private
+
+      def create_status(client, sha, runner, messages)
+        builder = StatusBuilder.new(runner, messages)
+        status = Status.new(sha, builder.state,
+                            builder.context, builder.description)
+
+        client.create_commit_status(status)
+      end
+    end
+  end
+end

data/lib/pronto/formatter/gitlab_formatter.rb

@@ -1,27 +1,16 @@
 module Pronto
   module Formatter
-    class GitlabFormatter
-      def format(messages, repo, _)
-        client = Gitlab.new repo
-
-        commit_messages = messages.uniq.map do |message|
-          create_comment(client,
-                         message.commit_sha,
-                         message.msg,
-                         message.path,
-                         message.line.commit_line.new_lineno)
-        end
-
-        "#{commit_messages.compact.count} Pronto messages posted to GitLab"
+    class GitlabFormatter < CommitFormatter
+      def client_module
+        Gitlab
       end
 
-      private
+      def pretty_name
+        'GitLab'
+      end
 
-      def create_comment(client, sha, note, path, line)
-        comment = Gitlab::Comment.new(sha, note, path, line)
-        comments = client.commit_comments(sha)
-        existing = comments.any? { |c| comment == c }
-        client.create_commit_comment(comment) unless existing
+      def line_number(message)
+        message.line.commit_line.new_lineno
       end
     end
   end

data/lib/pronto/formatter/json_formatter.rb

@@ -11,6 +11,7 @@ module Pronto
           result[:path] = message.path if message.path
           result[:line] = lineno if lineno
           result[:commit_sha] = message.commit_sha if message.commit_sha
+          result[:runner] = message.runner if message.runner
           result
         end.to_json
       end

data/lib/pronto/formatter/pull_request_formatter.rb

@@ -0,0 +1,20 @@
+module Pronto
+  module Formatter
+    class PullRequestFormatter < GitFormatter
+      def existing_comments(client, sha)
+        comments = client.pull_comments(sha)
+        grouped_comments(comments)
+      end
+
+      def line_number(message)
+        message.line.line.new_lineno
+      end
+
+      def submit_comments(client, comments)
+        comments.each { |comment| client.create_pull_comment(comment) }
+      rescue Octokit::UnprocessableEntity, HTTParty::Error => e
+        $stderr.puts "Failed to post: #{e.message}"
+      end
+    end
+  end
+end

data/lib/pronto/formatter/text_formatter.rb

@@ -1,22 +1,44 @@
 module Pronto
   module Formatter
     class TextFormatter
+      include Colorizable
+
+      LOCATION_COLOR = :cyan
+
+      LEVEL_COLORS = {
+        info: :yellow,
+        warning: :magenta,
+        error: :red,
+        fatal: :red
+      }.freeze
+
       def format(messages, _, _)
         messages.map do |message|
-          level = message.level[0].upcase
-          "#{location(message)} #{level}: #{message.msg}"
+          "#{format_location(message)} #{format_level(message)}: #{message.msg}".strip
         end
       end
 
       private
 
-      def location(message)
+      def format_location(message)
         line = message.line
         lineno = line.new_lineno if line
         path = message.path
-        commit_sha = message.commit_sha[0..6] if message.commit_sha
+        commit_sha = message.commit_sha
+
+        if path || lineno
+          path = colorize(path, LOCATION_COLOR) if path
+          "#{path}:#{lineno}"
+        elsif commit_sha
+          colorize(commit_sha[0..6], LOCATION_COLOR)
+        end
+      end
+
+      def format_level(message)
+        level = message.level
+        color = LEVEL_COLORS.fetch(level)
 
-        (path.nil? && lineno.nil?) ? commit_sha : "#{path}:#{lineno}"
+        colorize(level[0].upcase, color)
       end
     end
   end

data/lib/pronto/gem_names.rb

@@ -1,16 +1,21 @@
 module Pronto
   class GemNames
     def to_a
-      gems = Gem::Specification.find_all.select do |gem|
+      gems.map { |gem| gem.name.sub(/^pronto-/, '') }.uniq.sort
+    end
+
+    private
+
+    def gems
+      Gem::Specification.find_all.select do |gem|
         if gem.name =~ /^pronto-/
           true
         elsif gem.name != 'pronto'
-          runner_path = File.join(gem.full_gem_path, "lib/pronto/#{gem.name}.rb")
+          runner_path = File.join(gem.full_gem_path,
+                                  "lib/pronto/#{gem.name}.rb")
           File.exist?(runner_path)
         end
       end
-
-      gems.map { |gem| gem.name.sub(/^pronto-/, '') }.uniq.sort
     end
   end
 end

data/lib/pronto/github.rb

@@ -37,6 +37,14 @@ module Pronto
                                  comment.path, comment.position)
     end
 
+    def create_commit_status(status)
+      sha = pull_sha || status.sha
+      @config.logger.log("Creating comment status on #{sha}")
+      client.create_status(slug,
+                           sha,
+                           status.state, context: status.context, description: status.description)
+    end
+
     private
 
     def slug
@@ -44,7 +52,7 @@ module Pronto
       @slug ||= begin
         @repo.remote_urls.map do |url|
           hostname = Regexp.escape(@config.github_hostname)
-          match = /.*#{hostname}(:|\/)(?<slug>.*?)(?:\.git)?\z/.match(url)
+          match = %r{.*#{hostname}(:|\/)(?<slug>.*?)(?:\.git)?\z}.match(url)
           match[:slug] if match
         end.compact.first
       end
@@ -80,17 +88,5 @@ module Pronto
     def pull_requests
       @pull_requests ||= client.pull_requests(slug)
     end
-
-    Comment = Struct.new(:sha, :body, :path, :position) do
-      def ==(other)
-        position == other.position &&
-          path == other.path &&
-          body == other.body
-      end
-
-      def to_s
-        "[#{sha}] #{path}:#{position} - #{body}"
-      end
-    end
   end
 end

data/lib/pronto/gitlab.rb

@@ -16,8 +16,8 @@ module Pronto
 
     def create_commit_comment(comment)
       @config.logger.log("Creating commit comment on #{comment.sha}")
-      client.create_commit_comment(slug, comment.sha, comment.note,
-                                   path: comment.path, line: comment.line,
+      client.create_commit_comment(slug, comment.sha, comment.body,
+                                   path: comment.path, line: comment.position,
                                    line_type: 'new')
     end
 
@@ -27,17 +27,21 @@ module Pronto
       return @config.gitlab_slug if @config.gitlab_slug
       @slug ||= begin
         slug = @repo.remote_urls.map do |url|
-          match = if url =~ /^ssh:\/\//
-                    /.*#{host}(:[0-9]+)?(:|\/)(?<slug>.*).git/.match(url)
-                  else
-                    /.*#{host}(:|\/)(?<slug>.*).git/.match(url)
-                  end
+          match = slug_regex(url).match(url)
           match[:slug] if match
         end.compact.first
         URI.escape(slug, '/') if slug
       end
     end
 
+    def slug_regex(url)
+      if url =~ %r{^ssh:\/\/}
+        %r{.*#{host}(:[0-9]+)?(:|\/)(?<slug>.*).git}
+      else
+        %r{.*#{host}(:|\/)(?<slug>.*).git}
+      end
+    end
+
     def host
       @host ||= URI.split(gitlab_api_endpoint)[2, 2].compact.join(':')
     end
@@ -54,13 +58,5 @@ module Pronto
     def gitlab_api_endpoint
       @config.gitlab_api_endpoint
     end
-
-    Comment = Struct.new(:sha, :note, :path, :line) do
-      def ==(other)
-        line == other.line &&
-          path == other.path &&
-          note == other.note
-      end
-    end
   end
 end

data/lib/pronto/runner.rb

@@ -23,7 +23,7 @@ module Pronto
     end
 
     def repo_path
-      ruby_patches.first.repo.path
+      @patches.first.repo.path
     end
 
     private

data/lib/pronto/status.rb

@@ -0,0 +1,14 @@
+module Pronto
+  Status = Struct.new(:sha, :state, :context, :description) do
+    def ==(other)
+      sha == other.sha &&
+        state == other.state &&
+        context == other.context &&
+        description == other.description
+    end
+
+    def to_s
+      "[#{sha}] #{context} #{state} - #{description}"
+    end
+  end
+end

data/lib/pronto/version.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Version
-    STRING = '0.6.0'.freeze
+    STRING = '0.7.0'.freeze
 
     MSG = '%s (running on %s %s %s)'.freeze
 

data/lib/pronto.rb

@@ -2,6 +2,8 @@ require 'rugged'
 require 'octokit'
 require 'gitlab'
 require 'forwardable'
+require 'httparty'
+require 'rainbow'
 
 require 'pronto/gem_names'
 
@@ -9,6 +11,8 @@ require 'pronto/logger'
 require 'pronto/config_file'
 require 'pronto/config'
 
+require 'pronto/clients/bitbucket_client'
+
 require 'pronto/git/repository'
 require 'pronto/git/patches'
 require 'pronto/git/patch'
@@ -16,16 +20,26 @@ require 'pronto/git/line'
 
 require 'pronto/plugin'
 require 'pronto/message'
+require 'pronto/comment'
+require 'pronto/status'
 require 'pronto/runner'
 require 'pronto/runners'
 require 'pronto/github'
 require 'pronto/gitlab'
+require 'pronto/bitbucket'
 
+require 'pronto/formatter/colorizable'
 require 'pronto/formatter/text_formatter'
 require 'pronto/formatter/json_formatter'
+require 'pronto/formatter/git_formatter'
+require 'pronto/formatter/commit_formatter'
+require 'pronto/formatter/pull_request_formatter'
 require 'pronto/formatter/github_formatter'
+require 'pronto/formatter/github_status_formatter'
 require 'pronto/formatter/github_pull_request_formatter'
 require 'pronto/formatter/gitlab_formatter'
+require 'pronto/formatter/bitbucket_formatter'
+require 'pronto/formatter/bitbucket_pull_request_formatter'
 require 'pronto/formatter/checkstyle_formatter'
 require 'pronto/formatter/null_formatter'
 require 'pronto/formatter/formatter'

data/pronto.gemspec

@@ -44,10 +44,14 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('thor', '~> 0.19.0')
   s.add_runtime_dependency('octokit', '~> 4.3', '>= 4.1.0')
   s.add_runtime_dependency('gitlab', '~> 3.6', '>= 3.4.0')
+  s.add_runtime_dependency('httparty', '~> 0.13.7')
+  s.add_runtime_dependency('rainbow', '~> 2.1')
   s.add_development_dependency('rake', '~> 11.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')
   s.add_development_dependency('rspec-expectations', '~> 3.4')
   s.add_development_dependency('bundler', '~> 1.3')
   s.add_development_dependency('simplecov', '~> 0.11')
+  s.add_development_dependency('rubocop', '~> 0.39.0')
+  s.add_development_dependency('pronto-rubocop', '~> 0.6.2')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-13 00:00:00.000000000 Z
+date: 2016-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged
@@ -84,6 +84,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.4.0
+- !ruby/object:Gem::Dependency
+  name: httparty
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.7
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.7
+- !ruby/object:Gem::Dependency
+  name: rainbow
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -168,6 +196,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.39.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.39.0
+- !ruby/object:Gem::Dependency
+  name: pronto-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.2
 description: |2
       Pronto runs analysis quickly by checking only the relevant changes. Created
       to be used on pull requests, but suited for other scenarios as well. Perfect
@@ -187,16 +243,29 @@ files:
 - README.md
 - bin/pronto
 - lib/pronto.rb
+- lib/pronto/bitbucket.rb
 - lib/pronto/cli.rb
+- lib/pronto/clients/bitbucket_client.rb
+- lib/pronto/comment.rb
 - lib/pronto/config.rb
 - lib/pronto/config_file.rb
+- lib/pronto/formatter/bitbucket_formatter.rb
+- lib/pronto/formatter/bitbucket_pull_request_formatter.rb
 - lib/pronto/formatter/checkstyle_formatter.rb
+- lib/pronto/formatter/colorizable.rb
+- lib/pronto/formatter/commit_formatter.rb
 - lib/pronto/formatter/formatter.rb
+- lib/pronto/formatter/git_formatter.rb
 - lib/pronto/formatter/github_formatter.rb
 - lib/pronto/formatter/github_pull_request_formatter.rb
+- lib/pronto/formatter/github_status_formatter.rb
+- lib/pronto/formatter/github_status_formatter/inflector.rb
+- lib/pronto/formatter/github_status_formatter/sentence.rb
+- lib/pronto/formatter/github_status_formatter/status_builder.rb
 - lib/pronto/formatter/gitlab_formatter.rb
 - lib/pronto/formatter/json_formatter.rb
 - lib/pronto/formatter/null_formatter.rb
+- lib/pronto/formatter/pull_request_formatter.rb
 - lib/pronto/formatter/text_formatter.rb
 - lib/pronto/gem_names.rb
 - lib/pronto/git/line.rb
@@ -211,6 +280,7 @@ files:
 - lib/pronto/rake_task/travis_pull_request.rb
 - lib/pronto/runner.rb
 - lib/pronto/runners.rb
+- lib/pronto/status.rb
 - lib/pronto/version.rb
 - pronto.gemspec
 homepage: http://github.com/mmozuras/pronto