pronto 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c969116e9f09a05199f174e918f6d1d2f585ee9
-  data.tar.gz: ceade9cb751655a96c08a7ace4c333612bf12632
+  metadata.gz: c6eced888221992765e7822d10cc30c5bb425807
+  data.tar.gz: 3691ca0e624f99993eff02d044fc76dc8f13b633
 SHA512:
-  metadata.gz: 8a49323ec0df4da0d1aa3a5b0698ec9396d1aa1281043420914ce7637158d1b6b0d645747508f93dd95a9142923aff2b6fadcdef04b503e2b3f62fa120a4b711
-  data.tar.gz: 0580f948b0456f33ff48319b09fd1e572bc19beea2f255b94a62a39d9041d3fa7906cd804a364c4ee3876493f8cf9553883d6f00a3705051454d6041e8b8b65e
+  metadata.gz: 502260ec324f87bda046de5c75313abc8a48a2dc29c9c9f5339820ad40c683e1150e80013f9c5864b9f003a601759fcadfc99458fcb9424bf095aea02a0d4882
+  data.tar.gz: 640af0dbfe133fa024ccd924ccd9496011a32d5001bb076a692ac9e833a36b3bbeeb5caa857ef33600f9e1c0929e221899827a1f42d5c4ecd608446651cd84c9

data/CHANGELOG.md

@@ -0,0 +1,93 @@
+# Changelog
+
+## Unreleased
+
+### New features
+### Changes
+### Bugs fixed
+
+## 0.5.0
+
+### New features
+
+* [#104](https://github.com/mmozuras/pronto/pull/104): configure via .pronto.yml file.
+* [#86](https://github.com/mmozuras/pronto/pull/86): ability to specify GitHub slug via configuration or environment variable.
+* [#77](https://github.com/mmozuras/pronto/pull/77): ability to specify GitHub endpoints via configuration or environment variable.
+* [#108](https://github.com/mmozuras/pronto/pull/108): ability to specify excluded files via configuration.
+
+### Changes
+
+* [#82](https://github.com/mmozuras/pronto/pull/82): treat Rake files as Ruby files.
+* [#107](https://github.com/mmozuras/pronto/pull/107): use desc: instead of banner: for CLI options descriptions.
+
+### Bugs fixed
+
+* [#87](https://github.com/mmozuras/pronto/pull/87): handle github remote urls without .git suffix.
+* [#91](https://github.com/mmozuras/pronto/pull/91): find position in full diff and fix how commit id is used in GithubPullRequestFormatter.
+* [#92](https://github.com/mmozuras/pronto/pull/92): ignore failed pull request comments.
+* [#93](https://github.com/mmozuras/pronto/pull/93): comments didn't have position when outdated.
+* [#94](https://github.com/mmozuras/pronto/pull/94): duplicate comment detection was failing for large GitHub pull requests.
+* [poper#4](https://github.com/mmozuras/pronto-poper/issues/4): handle message uniqueness when they're without line numbers.
+* [#101](https://github.com/mmozuras/pronto/pull/101): make GitLab work with ssh port urls.
+
+## 0.4.3
+
+### Changes
+
+* Depend on `rugged ~> 0.23.0` and `octokit ~> 4.1.0`.
+
+## 0.4.2
+
+### New features
+
+* New formatter: NullFormatter. Discards data without writing it anywhere.
+
+## 0.4.1
+
+### Bugs fixed
+
+* [#58](https://github.com/mmozuras/pronto/pull/58): GitlabFormatter uses a high +per_page+ value to avoid pagination (and thus duplicate comments).
+
+## 0.4.0
+
+### New features
+
+* Try to detect pull request id automatically, if `PULL_REQUEST_ID` is not specified. Inspired by @willnet/prid.
+* [#40](https://github.com/mmozuras/pronto/issues/40): add '--index' option for 'pronto run'. Pronto analyzes changes before committing.
+* [#50](https://github.com/mmozuras/pronto/pull/50): add GitLab formatter
+* [#52](https://github.com/mmozuras/pronto/pull/52): allow specifying a path for 'pronto run'.
+
+### Changes
+
+* GitHub and GitHub pull request formatters now filter out duplicate offenses on the same line to avoid spamming with redundant comments.
+
+## 0.3.3
+
+### Bugs fixed
+
+* GithubPullRequestFormatter was working incorrectly with merge commits.
+
+## 0.3.2
+
+### Bugs fixed
+
+* GithubPullRequestFormatter had an off-by-one positioning error.
+
+## 0.3.1
+
+### Bugs fixed
+
+* Git::Patches#repo was always returning nil.
+
+## 0.3.0
+
+### New features
+
+* [#27](https://github.com/mmozuras/pronto/issues/27): '--exit-code' option for 'pronto run'. Pronto exits with non-zero code if there were any warnings/errors.
+* [#16](https://github.com/mmozuras/pronto/issues/16): new formatter: GithubPullRequestFormatter. Writes review comments on GitHub pull requests.
+
+### Changes
+
+* [#29](https://github.com/mmozuras/pronto/issues/29): be compatible and depend on rugged '0.21.0'.
+* Performance improvement: use Rugged::Blame instead of one provided by Grit.
+* Performance improvement: cache comments retrieved from GitHub.

data/CONTRIBUTING.md

@@ -0,0 +1,32 @@
+# Contributing
+
+If you discover issues, have ideas for improvements or new features,
+please report them to the [issue tracker][1] of the repository or
+submit a pull request. Please, try to follow these guidelines when you
+do so.
+
+## Issue reporting
+
+* Check that the issue has not already been reported.
+* Check that the issue has not already been fixed in the latest code
+  (a.k.a. `master`).
+* Be clear, concise and precise in your description of the problem.
+* Open an issue with a descriptive title and a summary in grammatically correct,
+  complete sentences.
+* Include any relevant code or traces in the issue summary.
+
+## Pull requests
+
+* Read [how to properly contribute to open source projects on Github][2].
+* Fork the project.
+* Use a topic/feature branch to easily amend a pull request later, if necessary.
+* Write [good commit messages][3].
+* Use the same coding conventions as the rest of the project.
+* Commit and push until you are happy with your contribution.
+* Open a [pull request][4] that relates to *only* one subject with a clear title
+  and description in grammatically correct, complete sentences.
+
+[1]: https://github.com/mmozuras/pronto/issues
+[2]: http://gun.io/blog/how-to-github-fork-branch-and-pull-request
+[3]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[4]: https://help.github.com/articles/using-pull-requests

data/README.md

@@ -13,6 +13,13 @@ to your [styleguide](https://github.com/mmozuras/pronto-rubocop), [are DRY](http
 
 ![Pronto demo](pronto.gif "")
 
+* [Usage](#usage)
+    * [Local Changes](#local-changes)
+    * [GitHub Integration](#github-integration)
+    * [GitLab Integration](#gitlab-integration)
+* [Configuration](#configuration)
+* [Runners](#runners)
+
 ## Usage
 
 Pronto runs the checks on a diff between the current HEAD and the provided commit-ish (default is master).
@@ -40,6 +47,16 @@ pronto run --commit=$(git log --pretty=format:%H | tail -1)
 
 Just run `pronto` without any arguments to see what Pronto is capable of.
 
+Available Options
+
+Command flag     | Description
+-----------------|------------------------------------------------------------
+`--exit-code`    | Exits with non-zero code if there were any warnings/errors.
+`-c/--commit`    | Commit for the diff.
+`-i/--index`     | Analyze changes in git index (staging area).
+`-r/--runner`    | Run only the passed runners.
+`-f/--formatter` | Pick output formatter.
+
 ### GitHub Integration
 
 You can run Pronto as a step of your CI builds and get the results as comments
@@ -57,8 +74,8 @@ s.add_development_dependency 'pronto'
 s.add_development_dependency 'pronto-rubocop'
 s.add_development_dependency 'pronto-scss'
 ```
-Set the GITHUB_ACCESS_TOKEN environment variable to [OAuth token](https://help.github.com/articles/creating-an-access-token-for-command-line-use)
-that has access to the repository.
+Set the GITHUB_ACCESS_TOKEN environment variable or value in `.pronto.yml` to
+[OAuth token](https://help.github.com/articles/creating-an-access-token-for-command-line-use) that has access to the repository.
 
 Then just run it:
 ```bash
@@ -97,10 +114,11 @@ s.add_development_dependency 'pronto-rubocop'
 s.add_development_dependency 'pronto-scss'
 ```
 
-Set the `GITLAB_API_ENDPOINT` environment variable to your API endpoint URL.
-If you are using Gitlab.com's hosted service your endpoint will be `https://gitlab.com/api/v3`.
-Set the `GITLAB_API_PRIVATE_TOKEN` environment variable to your Gitlab private token
-which you can find in your account settings.
+Set the `GITLAB_API_ENDPOINT` environment variable or value in `.pronto.yml` to
+your API endpoint URL. If you are using Gitlab.com's hosted service your
+endpoint will be `https://gitlab.com/api/v3`.
+Set the `GITLAB_API_PRIVATE_TOKEN` environment variable or value in `.pronto.yml
+to your Gitlab private token which you can find in your account settings.
 
 Then just run it:
 ```bash
@@ -115,6 +133,32 @@ formatter = Pronto::Formatter::GitlabFormatter.new
 Pronto.run('origin/master', '.', formatter)
 ```
 
+## Configuration
+
+The behavior of Pronto can be controlled via the `.pronto.yml` configuration
+file. It must be placed in your project directory.
+
+The file has the following format:
+
+```yaml
+all:
+  exclude: rspec/*
+github:
+  slug: mmozuras/pronto
+  access_token: B26354
+  api_endpoint: https://api.github.com/
+  web_endpoint: https://github.com/
+gitlab:
+  slug: mmozuras/pronto,
+  api_private_token: 46751,
+  api_endpoint: https://api.vinted.com/gitlab
+```
+
+All properties that can be specified via `.pronto.yml`, can also be specified
+via environment variables. Their names will be the upcased path to the property.
+For example: `GITHUB_SLUG` or `GITLAB_API_PRIVATE_TOKEN`. Environment variables
+will always take precedence over values in configuration file.
+
 ## Runners
 
 Pronto can run various tools and libraries, as long as there's a runner for it.
@@ -122,12 +166,14 @@ Currently available:
 
 * [pronto-brakeman](https://github.com/mmozuras/pronto-brakeman)
 * [pronto-coffeelint](https://github.com/siebertm/pronto-coffeelint)
+* [pronto-fasterer](https://github.com/mmozuras/pronto-fasterer)
 * [pronto-flay](https://github.com/mmozuras/pronto-flay)
 * [pronto-foodcritic](https://github.com/mmozuras/pronto-foodcritic)
 * [pronto-jshint](https://github.com/mmozuras/pronto-jshint)
 * [pronto-haml](https://github.com/mmozuras/pronto-haml)
 * [pronto-poper](https://github.com/mmozuras/pronto-poper)
 * [pronto-rails_best_practices](https://github.com/mmozuras/pronto-rails_best_practices)
+* [pronto-rails_schema](https://github.com/raimondasv/pronto-rails_schema)
 * [pronto-reek](https://github.com/mmozuras/pronto-reek)
 * [pronto-rubocop](https://github.com/mmozuras/pronto-rubocop)
 * [pronto-scss](https://github.com/mmozuras/pronto-scss)

data/lib/pronto.rb

@@ -3,6 +3,9 @@ require 'octokit'
 require 'gitlab'
 require 'forwardable'
 
+require 'pronto/config_file'
+require 'pronto/config'
+
 require 'pronto/git/repository'
 require 'pronto/git/patches'
 require 'pronto/git/patch'
@@ -11,6 +14,7 @@ require 'pronto/git/line'
 require 'pronto/plugin'
 require 'pronto/message'
 require 'pronto/runner'
+require 'pronto/runners'
 require 'pronto/github'
 require 'pronto/gitlab'
 
@@ -32,9 +36,9 @@ module Pronto
     options = { paths: [file] } if file
     patches = repo.diff(commit, options)
 
-    result = run_all_runners(patches)
+    result = Runners.new.run(patches)
 
-    formatted = formatter.format(result, repo)
+    formatted = formatter.format(result, repo, patches)
     puts formatted if formatted
 
     result
@@ -50,16 +54,6 @@ module Pronto
       end
     end
 
-    gems.map { |gem| gem.name.sub(/^pronto-/, '') }
-      .uniq
-      .sort
-  end
-
-  private
-
-  def self.run_all_runners(patches)
-    Runner.runners.map do |runner|
-      runner.new.run(patches, patches.commit)
-    end.flatten.compact
+    gems.map { |gem| gem.name.sub(/^pronto-/, '') }.uniq.sort
   end
 end

data/lib/pronto/cli.rb

@@ -16,30 +16,30 @@ module Pronto
 
     method_option :'exit-code',
                   type: :boolean,
-                  banner: 'Exits with non-zero code if there were any warnings/errors.'
+                  desc: 'Exits with non-zero code if there were any warnings/errors.'
 
     method_option :commit,
                   type: :string,
                   default: 'master',
                   aliases: '-c',
-                  banner: 'Commit for the diff'
+                  desc: 'Commit for the diff'
 
     method_option :index,
                   type: :boolean,
                   aliases: '-i',
-                  banner: 'Analyze changes in git index (staging area)'
+                  desc: 'Analyze changes in git index (staging area)'
 
     method_option :runner,
                   type: :array,
                   default: [],
                   aliases: '-r',
-                  banner: 'Run only the passed runners'
+                  desc: 'Run only the passed runners'
 
     method_option :formatter,
                   type: :string,
                   default: 'text',
                   aliases: '-f',
-                  banner: "Pick output formatter. Available: #{::Pronto::Formatter.names.join(', ')}"
+                  desc: "Pick output formatter. Available: #{::Pronto::Formatter.names.join(', ')}"
 
     def run(path = nil)
       gem_names = options[:runner].any? ? options[:runner] : ::Pronto.gem_names

data/lib/pronto/config.rb

@@ -0,0 +1,30 @@
+module Pronto
+  class Config
+    def initialize(config_hash = ConfigFile.new.to_h)
+      @config_hash = config_hash
+    end
+
+    %w(github gitlab).each do |service|
+      ConfigFile::EMPTY[service].each do |key, _|
+        name = "#{service}_#{key}"
+        define_method(name) { ENV[name.upcase] || @config_hash[service][key] }
+      end
+    end
+
+    def excluded_files
+      @excluded_files ||= Array(exclude)
+        .flat_map { |path| Dir[path.to_s] }
+        .map { |path| File.expand_path(path) }
+    end
+
+    def github_hostname
+      URI.parse(github_web_endpoint).host
+    end
+
+    private
+
+    def exclude
+      @config_hash['all']['exclude']
+    end
+  end
+end

data/lib/pronto/config_file.rb

@@ -0,0 +1,46 @@
+module Pronto
+  class ConfigFile
+    EMPTY = {
+      'all' => {
+        'exclude' => [],
+        'include' => []
+      },
+      'github' => {
+        'slug' => nil,
+        'access_token' => nil,
+        'api_endpoint' => 'https://api.github.com/',
+        'web_endpoint' => 'https://github.com/'
+      },
+      'gitlab' => {
+        'slug' => nil,
+        'api_private_token' => nil,
+        'api_endpoint' => nil
+      },
+      'runners' => [],
+      'formatters' => []
+    }
+
+    def initialize(path = '.pronto.yml')
+      @path = path
+    end
+
+    def to_h
+      hash = File.exist?(@path) ? YAML.load_file(@path) : {}
+      deep_merge(hash)
+    end
+
+    private
+
+    def deep_merge(hash)
+      merger = proc do |_, oldval, newval|
+        if oldval.is_a?(Hash) && newval.is_a?(Hash)
+          oldval.merge(newval, &merger)
+        else
+          oldval || newval
+        end
+      end
+
+      hash.merge(EMPTY, &merger)
+    end
+  end
+end

data/lib/pronto/formatter/checkstyle_formatter.rb

@@ -7,7 +7,7 @@ module Pronto
         @output = ''
       end
 
-      def format(messages, _)
+      def format(messages, _, _)
         open_xml
         process_messages(messages)
         close_xml

data/lib/pronto/formatter/github_formatter.rb

@@ -1,11 +1,10 @@
 module Pronto
   module Formatter
     class GithubFormatter
-      def format(messages, repo)
-        messages = messages.uniq { |message| [message.msg, message.line.new_lineno] }
+      def format(messages, repo, _)
         client = Github.new(repo)
 
-        commit_messages = messages.map do |message|
+        commit_messages = messages.uniq.map do |message|
           sha = message.commit_sha
           body = message.msg
           path = message.path

data/lib/pronto/formatter/github_pull_request_formatter.rb

@@ -1,24 +1,16 @@
 module Pronto
   module Formatter
     class GithubPullRequestFormatter
-      def format(messages, repo)
-        messages = messages.uniq { |message| [message.msg, message.line.new_lineno] }
+      def format(messages, repo, patches)
         client = Github.new(repo)
+        head = repo.head_commit_sha
 
-        commit_messages = messages.map do |message|
+        commit_messages = messages.uniq.map do |message|
           body = message.msg
           path = message.path
+          line = patches.find_line(message.full_path, message.line.new_lineno)
 
-          commits = repo.commits_until(message.commit_sha)
-
-          line = nil
-          sha = commits.find do |commit|
-            patches = repo.show_commit(commit)
-            line = patches.find_line(message.full_path, message.line.new_lineno)
-            line
-          end
-
-          create_comment(client, sha, body, path, line.position)
+          create_comment(client, head, body, path, line.position)
         end
 
         "#{commit_messages.compact.count} Pronto messages posted to GitHub"
@@ -31,6 +23,13 @@ module Pronto
         comments = client.pull_comments(sha)
         existing = comments.any? { |c| comment == c }
         client.create_pull_comment(comment) unless existing
+      rescue Octokit::UnprocessableEntity => e
+        # The diff output of the local git version and Github is not always
+        # consistent, especially in areas where file renames happened, Github
+        # tends to recognize these better, leading to messages we can't post
+        # because their diff position is non-existent on Github.
+        # Ignore such occasions and continue posting other messages.
+        STDERR.puts "Failed to post: #{comment.inspect} with #{e.message}"
       end
     end
   end

data/lib/pronto/formatter/gitlab_formatter.rb

@@ -1,11 +1,10 @@
 module Pronto
   module Formatter
     class GitlabFormatter
-      def format(messages, repo)
-        messages = messages.uniq { |message| [message.msg, message.line.new_lineno] }
+      def format(messages, repo, _)
         client = Gitlab.new repo
 
-        commit_messages = messages.map do |message|
+        commit_messages = messages.uniq.map do |message|
           create_comment(client,
                          message.commit_sha,
                          message.msg,

data/lib/pronto/formatter/json_formatter.rb

@@ -3,7 +3,7 @@ require 'json'
 module Pronto
   module Formatter
     class JsonFormatter
-      def format(messages, _)
+      def format(messages, _, _)
         messages.map do |message|
           lineno = message.line.new_lineno if message.line
 

data/lib/pronto/formatter/null_formatter.rb

@@ -1,7 +1,7 @@
 module Pronto
   module Formatter
     class NullFormatter
-      def format(_, _)
+      def format(_, _, _)
       end
     end
   end

data/lib/pronto/formatter/text_formatter.rb

@@ -1,18 +1,23 @@
 module Pronto
   module Formatter
     class TextFormatter
-      def format(messages, _)
+      def format(messages, _, _)
         messages.map do |message|
           level = message.level[0].upcase
-          line = message.line
-          lineno = line.new_lineno if line
-          path = message.path
-          commit_sha = message.commit_sha[0..6] if message.commit_sha
-
-          location = (path.nil? && lineno.nil?) ? commit_sha : "#{path}:#{lineno}"
-          "#{location} #{level}: #{message.msg}"
+          "#{location(message)} #{level}: #{message.msg}"
         end
       end
+
+      private
+
+      def location(message)
+        line = message.line
+        lineno = line.new_lineno if line
+        path = message.path
+        commit_sha = message.commit_sha[0..6] if message.commit_sha
+
+        (path.nil? && lineno.nil?) ? commit_sha : "#{path}:#{lineno}"
+      end
     end
   end
 end

data/lib/pronto/git/line.rb

@@ -28,6 +28,9 @@ module Pronto
       end
 
       def ==(other)
+        return false if other.nil?
+        return true if line.nil? && other.line.nil?
+
         content == other.content &&
           line_origin == other.line_origin &&
           old_lineno == other.old_lineno &&

data/lib/pronto/git/patches.rb

@@ -15,6 +15,10 @@ module Pronto
         @patches.each(&block)
       end
 
+      def reject!(&block)
+        @patches.reject!(&block)
+      end
+
       def find_line(path, line)
         patch = find { |p| p.new_file_full_path == path }
         lines = patch ? patch.lines : []

data/lib/pronto/git/repository.rb

@@ -58,6 +58,10 @@ module Pronto
         @repo.remotes.map(&:url)
       end
 
+      def head_commit_sha
+        head.oid
+      end
+
       private
 
       def empty_patches(sha)

data/lib/pronto/github.rb

@@ -2,6 +2,7 @@ module Pronto
   class Github
     def initialize(repo)
       @repo = repo
+      @config = Config.new
       @comment_cache = {}
       @pull_id_cache = {}
     end
@@ -9,7 +10,8 @@ module Pronto
     def pull_comments(sha)
       @comment_cache["#{pull_id}/#{sha}"] ||= begin
         client.pull_comments(slug, pull_id).map do |comment|
-          Comment.new(sha, comment.body, comment.path, comment.position)
+          Comment.new(sha, comment.body, comment.path,
+                      comment.position || comment.original_position)
         end
       end
     end
@@ -35,16 +37,21 @@ module Pronto
     private
 
     def slug
+      return @config.github_slug if @config.github_slug
       @slug ||= begin
         @repo.remote_urls.map do |url|
-          match = /.*github.com(:|\/)(?<slug>.*).git/.match(url)
+          hostname = Regexp.escape(@config.github_hostname)
+          match = /.*#{hostname}(:|\/)(?<slug>.*?)(?:\.git)?\z/.match(url)
           match[:slug] if match
         end.compact.first
       end
     end
 
     def client
-      @client ||= Octokit::Client.new(access_token: access_token)
+      @client ||= Octokit::Client.new(api_endpoint: @config.github_api_endpoint,
+                                      web_endpoint: @config.github_web_endpoint,
+                                      access_token: @config.github_access_token,
+                                      auto_paginate: true)
     end
 
     def pull_requests
@@ -63,10 +70,6 @@ module Pronto
       end
     end
 
-    def access_token
-      ENV['GITHUB_ACCESS_TOKEN']
-    end
-
     Comment = Struct.new(:sha, :body, :path, :position) do
       def ==(other)
         position == other.position &&

data/lib/pronto/gitlab.rb

@@ -2,6 +2,7 @@ module Pronto
   class Gitlab
     def initialize(repo)
       @repo = repo
+      @config = Config.new
       @comment_cache = {}
     end
 
@@ -22,26 +23,35 @@ module Pronto
     private
 
     def slug
+      return @config.gitlab_slug if @config.gitlab_slug
       @slug ||= begin
-        host = URI.split(endpoint)[2, 2].compact.join(':')
         slug = @repo.remote_urls.map do |url|
-          match = /.*#{host}(:|\/)(?<slug>.*).git/.match(url)
+          match = if url.match(/^ssh:\/\//)
+                    /.*#{host}(:[0-9]+)?(:|\/)(?<slug>.*).git/.match(url)
+                  else
+                    /.*#{host}(:|\/)(?<slug>.*).git/.match(url)
+                  end
           match[:slug] if match
         end.compact.first
         URI.escape(slug, '/') if slug
       end
     end
 
+    def host
+      @host ||= URI.split(gitlab_api_endpoint)[2, 2].compact.join(':')
+    end
+
     def client
-      @client ||= ::Gitlab.client(endpoint: endpoint, private_token: private_token)
+      @client ||= ::Gitlab.client(endpoint: gitlab_api_endpoint,
+                                  private_token: gitlab_api_private_token)
     end
 
-    def private_token
-      ENV['GITLAB_API_PRIVATE_TOKEN']
+    def gitlab_api_private_token
+      @config.gitlab_api_private_token
     end
 
-    def endpoint
-      ENV['GITLAB_API_ENDPOINT']
+    def gitlab_api_endpoint
+      @config.gitlab_api_endpoint
     end
 
     Comment = Struct.new(:sha, :note, :path, :line) do

data/lib/pronto/message.rb

@@ -24,5 +24,25 @@ module Pronto
     def repo
       line.patch.repo if line
     end
+
+    def ==(other)
+      comparison_attributes.all? do |attribute|
+        send(attribute) == other.send(attribute)
+      end
+    end
+
+    alias_method :eql?, :==
+
+    def hash
+      comparison_attributes.reduce(0) do |hash, attribute|
+        hash ^ send(attribute).hash
+      end
+    end
+
+    private
+
+    def comparison_attributes
+      line ? [:path, :msg, :level, :line] : [:path, :msg, :level, :commit_sha]
+    end
   end
 end

data/lib/pronto/runner.rb

@@ -7,11 +7,19 @@ module Pronto
     end
 
     def ruby_file?(path)
-      File.extname(path) == '.rb' || ruby_executable?(path)
+      rb_file?(path) || rake_file?(path) || ruby_executable?(path)
     end
 
     private
 
+    def rb_file?(path)
+      File.extname(path) == '.rb'
+    end
+
+    def rake_file?(path)
+      File.extname(path) == '.rake'
+    end
+
     def ruby_executable?(path)
       line = File.open(path, &:readline)
       line =~ /#!.*ruby/

data/lib/pronto/runners.rb

@@ -0,0 +1,28 @@
+module Pronto
+  class Runners
+    def initialize(runners = Runner.runners, config = Config.new)
+      @runners = runners
+      @config = config
+    end
+
+    def run(patches)
+      patches = reject_excluded(patches)
+      return [] unless patches.any?
+
+      @runners.map { |runner| runner.new.run(patches, patches.commit) }
+        .flatten.compact
+    end
+
+    private
+
+    def reject_excluded(patches)
+      return patches unless @config.excluded_files.any?
+      patches.reject! { |patch| excluded?(patch) }
+      patches
+    end
+
+    def excluded?(patch)
+      @config.excluded_files.include?(patch.new_file_full_path.to_s)
+    end
+  end
+end

data/lib/pronto/version.rb

@@ -1,3 +1,3 @@
 module Pronto
-  VERSION = '0.4.3'
+  VERSION = '0.5.0'
 end

data/pronto.gemspec

@@ -0,0 +1,52 @@
+# -*- encoding: utf-8 -*-
+
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+require 'pronto/version'
+require 'English'
+
+Gem::Specification.new do |s|
+  s.name = 'pronto'
+  s.version = Pronto::VERSION
+  s.platform = Gem::Platform::RUBY
+  s.author = 'Mindaugas Mozūras'
+  s.email = 'mindaugas.mozuras@gmail.com'
+  s.homepage = 'http://github.com/mmozuras/pronto'
+  s.summary = 'Pronto runs analysis by checking only the introduced changes'
+  s.description = <<-EOF
+    Pronto runs analysis quickly by checking only the relevant changes. Created
+    to be used on pull requests, but suited for other scenarios as well. Perfect
+    if you want to find out quickly if branch introduces changes that conform to
+    your styleguide, are DRY, don't introduce security holes and more.
+  EOF
+
+  s.licenses = ['MIT']
+  s.required_ruby_version = '>= 1.9.3'
+  s.rubygems_version = '1.8.23'
+
+  s.files = `git ls-files`.split($RS).reject do |file|
+    file =~ %r{^(?:
+    spec/.*
+    |Gemfile
+    |Rakefile
+    |\.rspec
+    |\.gitignore
+    |\.rubocop.yml
+    |\.travis.yml
+    )$}x
+  end
+  s.test_files = []
+  s.extra_rdoc_files = ['LICENSE', 'README.md']
+  s.require_paths = ['lib']
+  s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
+
+  s.add_runtime_dependency('rugged', '~> 0.23.0')
+  s.add_runtime_dependency('thor', '~> 0.19.0')
+  s.add_runtime_dependency('octokit', '~> 4.1.0')
+  s.add_runtime_dependency('gitlab', '~> 3.4.0')
+  s.add_development_dependency('rake', '~> 10.4')
+  s.add_development_dependency('rspec', '~> 3.3')
+  s.add_development_dependency('rspec-its', '~> 1.2')
+  s.add_development_dependency('rspec-expectations', '~> 3.3')
+  s.add_development_dependency('bundler', '~> 1.3')
+  s.add_development_dependency('simplecov', '~> 0.10')
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-05 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged
@@ -72,56 +72,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.4.0
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.4.0
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
 description: |2
       Pronto runs analysis quickly by checking only the relevant changes. Created
       to be used on pull requests, but suited for other scenarios as well. Perfect
@@ -131,13 +159,19 @@ email: mindaugas.mozuras@gmail.com
 executables:
 - pronto
 extensions: []
-extra_rdoc_files: []
+extra_rdoc_files:
+- LICENSE
+- README.md
 files:
+- CHANGELOG.md
+- CONTRIBUTING.md
 - LICENSE
 - README.md
 - bin/pronto
 - lib/pronto.rb
 - lib/pronto/cli.rb
+- lib/pronto/config.rb
+- lib/pronto/config_file.rb
 - lib/pronto/formatter/checkstyle_formatter.rb
 - lib/pronto/formatter/formatter.rb
 - lib/pronto/formatter/github_formatter.rb
@@ -156,7 +190,10 @@ files:
 - lib/pronto/plugin.rb
 - lib/pronto/rake_task/travis_pull_request.rb
 - lib/pronto/runner.rb
+- lib/pronto/runners.rb
 - lib/pronto/version.rb
+- pronto.gemspec
+- pronto.gif
 homepage: http://github.com/mmozuras/pronto
 licenses:
 - MIT
@@ -169,12 +206,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.6
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5
@@ -182,4 +219,3 @@ signing_key:
 specification_version: 4
 summary: Pronto runs analysis by checking only the introduced changes
 test_files: []
-has_rdoc: