pronto 0.11.1 → 0.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 544591a739632f48bdbe56cc7a006b02a8ce13a22c9fbc679d35a4d5e67a0b00
-  data.tar.gz: 1fee173f0ab873998cc2920a576687a842485509bbef0bd4fc23c03703372d20
+  metadata.gz: cc92d09f9dae20d0ddfb42faca81ab52258623f2014a5c0a736466f443996b00
+  data.tar.gz: 1d1c524e047a717e33d11f993d3e6fa6fc5b4103e9b75b1ae8c1275d7404394b
 SHA512:
-  metadata.gz: b172a79ba57c6319761945212c7d8991adfafb4fdb6a3a91d9dea587a2099859bc5b052e0c54f694a5760b5f98d1a32e146d5811cbaf45d85afbf3c1204526a3
-  data.tar.gz: ea63d5bb296cebc7628af1d1d20a93877cd40ac297954bbe898b7e7b8137482e2c516755c4ea63ef8ca2ee8c60331a39d3c9be6edc4aeab609a816c8ff9bc720
+  metadata.gz: 73d534c7929826919482802d0630f73a566e4525a2ffef4fe3a8f9ff1acce051b7dfbe77a01835ba483e6a5d977ddb39b18f455b832773e6e3e32ac9358b9f5a
+  data.tar.gz: 7c9f9c8ecaa21d3d1860c9da8ddebcfcf61d88deff3717b599c3fd65a0623c33ec76f99f34bd773f0f5d3832129295531c8d7e10ccb205b4714f809a6fc906d8

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.11.2
+
+### Changes
+
+* [#449](https://github.com/prontolabs/pronto/pull/449) relax octokit version dependency to allow releases up to 8.0
+* [#450](https://github.com/prontolabs/pronto/pull/450) introduce Pronto::Formatter.register for adding custom formatters
+
 ## 0.11.1
 
 ### New features

data/lib/pronto/formatter/base.rb

@@ -2,7 +2,7 @@ module Pronto
   module Formatter
     class Base
       def self.name
-        Formatter::FORMATTERS.invert[self]
+        raise NoMethodError, 'Must be implemented in subclasses.'
       end
 
       def config

data/lib/pronto/formatter/bitbucket_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class BitbucketFormatter < CommitFormatter
+      def self.name
+        'bitbucket'
+      end
+
       def client_module
         Bitbucket
       end
@@ -15,3 +19,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::BitbucketFormatter)

data/lib/pronto/formatter/bitbucket_pull_request_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class BitbucketPullRequestFormatter < PullRequestFormatter
+      def self.name
+        'bitbucket_pr'
+      end
+
       def client_module
         Bitbucket
       end
@@ -17,7 +21,7 @@ module Pronto
         return if config.bitbucket_auto_approve == false
 
         if comments_count > 0 && additions_count > 0
-          client.unapprove_pull_request  
+          client.unapprove_pull_request
         elsif comments_count == 0
           client.approve_pull_request
         end
@@ -25,3 +29,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::BitbucketPullRequestFormatter)

data/lib/pronto/formatter/bitbucket_server_pull_request_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class BitbucketServerPullRequestFormatter < PullRequestFormatter
+      def self.name
+        'bitbucket_server_pr'
+      end
+
       def client_module
         BitbucketServer
       end
@@ -15,3 +19,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::BitbucketServerPullRequestFormatter)

data/lib/pronto/formatter/checkstyle_formatter.rb

@@ -3,6 +3,10 @@ require 'rexml/document'
 module Pronto
   module Formatter
     class CheckstyleFormatter < Base
+      def self.name
+        'checkstyle'
+      end
+
       def initialize
         @output = ''
       end
@@ -57,3 +61,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::CheckstyleFormatter)

data/lib/pronto/formatter/formatter.rb

@@ -1,30 +1,27 @@
 module Pronto
   module Formatter
-    def self.get(names)
-      names ||= 'text'
-      Array(names).map { |name| FORMATTERS[name.to_s] || TextFormatter }
-        .uniq.map(&:new)
-    end
+    class << self
+      def register(formatter_klass)
+        unless formatter_klass.method_defined?(:format)
+          raise NoMethodError, "format method is not declared in the #{formatter_klass.name} class."
+        end
 
-    def self.names
-      FORMATTERS.keys
-    end
+        base = Pronto::Formatter::Base
+        raise "#{formatter_klass.name} is not a #{base}" unless formatter_klass.ancestors.include?(base)
+
+        @formatters ||= {}
+        @formatters[formatter_klass.name] = formatter_klass
+      end
 
-    FORMATTERS = {
-      'github' => GithubFormatter,
-      'github_status' => GithubStatusFormatter,
-      'github_combined_status' => GithubCombinedStatusFormatter,
-      'github_pr' => GithubPullRequestFormatter,
-      'github_pr_review' => GithubPullRequestReviewFormatter,
-      'gitlab' => GitlabFormatter,
-      'gitlab_mr' => GitlabMergeRequestReviewFormatter,
-      'bitbucket' => BitbucketFormatter,
-      'bitbucket_pr' => BitbucketPullRequestFormatter,
-      'bitbucket_server_pr' => BitbucketServerPullRequestFormatter,
-      'json' => JsonFormatter,
-      'checkstyle' => CheckstyleFormatter,
-      'text' => TextFormatter,
-      'null' => NullFormatter
-    }.freeze
+      def get(names)
+        names ||= 'text'
+        Array(names).map { |name| @formatters[name.to_s] || TextFormatter }
+          .uniq.map(&:new)
+      end
+
+      def names
+        @formatters.keys
+      end
+    end
   end
 end

data/lib/pronto/formatter/github_combined_status_formatter.rb

@@ -2,7 +2,11 @@ require_relative 'github_status_formatter/status_builder'
 
 module Pronto
   module Formatter
-    class GithubCombinedStatusFormatter
+    class GithubCombinedStatusFormatter < Base
+      def self.name
+        'github_combined_status'
+      end
+
       def format(messages, repo, _)
         client = Github.new(repo)
         head = repo.head_commit_sha
@@ -22,3 +26,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GithubCombinedStatusFormatter)

data/lib/pronto/formatter/github_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class GithubFormatter < CommitFormatter
+      def self.name
+        'github'
+      end
+
       def client_module
         Github
       end
@@ -15,3 +19,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GithubFormatter)

data/lib/pronto/formatter/github_pull_request_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class GithubPullRequestFormatter < PullRequestFormatter
+      def self.name
+        'github_pr'
+      end
+
       def client_module
         Github
       end
@@ -16,3 +20,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GithubPullRequestFormatter)

data/lib/pronto/formatter/github_pull_request_review_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class GithubPullRequestReviewFormatter < PullRequestFormatter
+      def self.name
+        'github_pr_review'
+      end
+
       def client_module
         Github
       end
@@ -22,3 +26,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GithubPullRequestReviewFormatter)

data/lib/pronto/formatter/github_status_formatter/sentence.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Formatter
-    class GithubStatusFormatter
+    class GithubStatusFormatter < Base
       class Sentence
         def initialize(words)
           @words = words

data/lib/pronto/formatter/github_status_formatter/status_builder.rb

@@ -2,7 +2,7 @@ require_relative 'sentence'
 
 module Pronto
   module Formatter
-    class GithubStatusFormatter
+    class GithubStatusFormatter < Base
       class StatusBuilder
         def initialize(runner, messages)
           @runner = runner

data/lib/pronto/formatter/github_status_formatter.rb

@@ -2,7 +2,11 @@ require_relative 'github_status_formatter/status_builder'
 
 module Pronto
   module Formatter
-    class GithubStatusFormatter
+    class GithubStatusFormatter < Base
+      def self.name
+        'github_status'
+      end
+
       def format(messages, repo, _)
         client = Github.new(repo)
         head = repo.head_commit_sha
@@ -26,3 +30,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GithubStatusFormatter)

data/lib/pronto/formatter/gitlab_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class GitlabFormatter < CommitFormatter
+      def self.name
+        'gitlab'
+      end
+
       def client_module
         Gitlab
       end
@@ -15,3 +19,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GitlabFormatter)

data/lib/pronto/formatter/gitlab_merge_request_review_formatter.rb

@@ -1,6 +1,10 @@
 module Pronto
   module Formatter
     class GitlabMergeRequestReviewFormatter < PullRequestFormatter
+      def self.name
+        'gitlab_mr'
+      end
+
       def client_module
         Gitlab
       end
@@ -27,3 +31,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::GitlabMergeRequestReviewFormatter)

data/lib/pronto/formatter/json_formatter.rb

@@ -3,6 +3,10 @@ require 'json'
 module Pronto
   module Formatter
     class JsonFormatter < Base
+      def self.name
+        'json'
+      end
+
       def format(messages, _repo, _patches)
         messages.map do |message|
           lineno = message.line.new_lineno if message.line
@@ -18,3 +22,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::JsonFormatter)

data/lib/pronto/formatter/null_formatter.rb

@@ -1,7 +1,13 @@
 module Pronto
   module Formatter
     class NullFormatter < Base
+      def self.name
+        'null'
+      end
+
       def format(_messages, _repo, _patches); end
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::NullFormatter)

data/lib/pronto/formatter/text_formatter.rb

@@ -3,6 +3,10 @@ require 'pronto/formatter/text_message_decorator'
 module Pronto
   module Formatter
     class TextFormatter < Base
+      def self.name
+        'text'
+      end
+
       def format(messages, _repo, _patches)
         messages.map do |message|
           message_format = config.message_format(self.class.name)
@@ -13,3 +17,5 @@ module Pronto
     end
   end
 end
+
+Pronto::Formatter.register(Pronto::Formatter::TextFormatter)

data/lib/pronto/version.rb

@@ -1,6 +1,6 @@
 module Pronto
   module Version
-    STRING = '0.11.1'.freeze
+    STRING = '0.11.2'.freeze
 
     MSG = '%s (running on %s %s %s)'.freeze
 

data/lib/pronto.rb

@@ -35,6 +35,7 @@ require 'pronto/bitbucket_server'
 
 require 'pronto/formatter/colorizable'
 require 'pronto/formatter/base'
+require 'pronto/formatter/formatter'
 require 'pronto/formatter/text_formatter'
 require 'pronto/formatter/json_formatter'
 require 'pronto/formatter/git_formatter'
@@ -52,7 +53,6 @@ require 'pronto/formatter/bitbucket_pull_request_formatter'
 require 'pronto/formatter/bitbucket_server_pull_request_formatter'
 require 'pronto/formatter/checkstyle_formatter'
 require 'pronto/formatter/null_formatter'
-require 'pronto/formatter/formatter'
 
 module Pronto
   def self.run(commit = nil, repo_path = '.',

data/pronto.gemspec

@@ -42,7 +42,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency('gitlab', '>= 4.4.0', '< 5.0')
   s.add_runtime_dependency('httparty', '>= 0.13.7', '< 1.0')
-  s.add_runtime_dependency('octokit', '>= 4.7.0', '< 7.0')
+  s.add_runtime_dependency('octokit', '>= 4.7.0', '< 8.0')
   s.add_runtime_dependency('rainbow', '>= 2.2', '< 4.0')
   s.add_runtime_dependency('rexml', '>= 3.2.5', '< 4.0')
   s.add_runtime_dependency('rugged', '>= 0.23.0', '< 2.0')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.11.2
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-31 00:00:00.000000000 Z
+date: 2023-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gitlab
@@ -59,7 +59,7 @@ dependencies:
         version: 4.7.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -69,7 +69,7 @@ dependencies:
         version: 4.7.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -401,7 +401,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.3.15
 signing_key:
 specification_version: 4
 summary: Pronto runs analysis by checking only the introduced changes