pronto-golang 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 44322a5abe5e297a8aca4dcbcaf6cadcc281aece
-  data.tar.gz: 5e3a4285833911a46405d0ca87b52f4328917374
+SHA256:
+  metadata.gz: 76519296caac98ba7adaba5317b737704d2e92c895a56629098b209f554f32ee
+  data.tar.gz: d9501233693ea8ef3f734e937ecd79b6f2f723a9524b0bc0aa0ef645e3d59fce
 SHA512:
-  metadata.gz: cc3dc687d363a3a91ca82ab729aa548f8dcae82ab2999e7c239355674eaaf3661bf40ac67979e0dd099a59d25be3cd6d1e78a7106bb154ffda91cefa9c79b23c
-  data.tar.gz: 2338419e929ff992ce3751d8fb546704d219e23b2e00dc8a5034de2200591d9bded52c60fe28b56d91345149ad64bbe11f4582580b9e7cad5856b82eb0eba1e2
+  metadata.gz: a22a2998ee44aa6fc3232c0d516b880ce61fce4cbc0eac7dc51f2a89fe402d46897c527ab3bf8ceec0d92b1cdc9db72d700cc7cce79df4dd0e7a6c77888b1473
+  data.tar.gz: 78261ce6a7bb74f0547dcaf1b77c56798b4b9517f5ce21eebcdcafe1ec76620050e81871525f83c7ee28111e05310a53b8eb74ea37c7a0f35d9b062dd68e165f

data/README.md

@@ -8,9 +8,9 @@ Pronto runner for [Golang](https://golang.org) tools
 
 |  Tool    | Install  |
 |----------|----------|
-| errcheck | go get -u github.com/kisielk/errcheck |
 | go vet   | - |
 | golint   | go get -u golang.org/x/lint/golint |
+| gosec    | See [Install instructions](https://github.com/securego/gosec#install) |
 | staticcheck | go get -u honnef.co/go/tools/cmd/staticcheck |
 
 ## Configuring tools

data/lib/pronto/golang.rb

@@ -3,6 +3,7 @@ require 'pronto'
 require 'yaml'
 require 'shellwords'
 
+require_relative './golang/errors'
 require_relative './golang/file_finder'
 require_relative './golang/tools'
 
@@ -56,18 +57,22 @@ module Pronto
     def process_line(patch, tool, output_line)
       return nil if output_line =~ /^#/
 
-      file_path, line_number, level, message = tool.parse_line(output_line)
+      begin
+        file_path, line_number, level, message = tool.parse_line(output_line)
 
-      patch.added_lines.each do |line|
-        if line_number.to_s == line.new_lineno.to_s &&
-           patch.new_file_full_path.to_s == File.expand_path(file_path)
+        patch.added_lines.each do |line|
+          if line_number.to_s == line.new_lineno.to_s &&
+             patch.new_file_full_path.to_s == File.expand_path(file_path)
 
-          prefix_message = "#{tool.base_command}: #{message}"
+            prefix_message = "#{tool.base_command}: #{message}"
 
-          return Message.new(
-            file_path, line, level, prefix_message, line.commit_sha, self.class
-          )
+            return Message.new(
+              file_path, line, level, prefix_message, line.commit_sha, self.class
+            )
+          end
         end
+      rescue ::Pronto::GolangSupport::UnprocessableLine
+        # Do nothing if the line is not processable
       end
 
       return nil

data/lib/pronto/golang/errors.rb

@@ -0,0 +1,5 @@
+module Pronto
+  module GolangSupport
+    class UnprocessableLine < RuntimeError; end
+  end
+end

data/lib/pronto/golang/tools.rb

@@ -5,7 +5,7 @@ end
 
 require_relative './tools/base'
 
-require_relative './tools/errcheck'
 require_relative './tools/golint'
+require_relative './tools/gosec'
 require_relative './tools/govet'
 require_relative './tools/staticcheck'

data/lib/pronto/golang/tools/gosec.rb

@@ -0,0 +1,32 @@
+require 'pathname'
+
+require_relative '../errors'
+
+module Pronto
+  module GolangTools
+    class Gosec < Base
+      def self.base_command
+        'gosec'
+      end
+
+      def parse_line(line)
+        # Accepts lines of the following format:
+        #   [path_to_file:<line_number>] -
+        if line !~ /^\[(\S+):(\d+)\] - (.+)/
+          raise ::Pronto::GolangSupport::UnprocessableLine.new(line)
+        end
+
+        path        = $1.strip
+        line_number = $2.strip
+        message     = $3.strip
+
+        absolute_path = Pathname.new(path)
+        working_directory = Pathname.new(Dir.pwd)
+
+        file_path = absolute_path.relative_path_from(working_directory)
+
+        return file_path.to_s, line_number, :warning, message
+      end
+    end
+  end
+end

data/lib/pronto/golang/tools/govet.rb

@@ -10,7 +10,13 @@ module Pronto
       end
 
       def parse_line(line)
-        file_path, line_number, message = line.split(':')
+        # Support handling messages like
+        # - spec/fixtures/test.git/main.go:18:2: unreachable code
+        # - spec/fixtures/test.git/main.go:18: something else
+        elements = line.split(':')
+        file_path   = elements[0]
+        line_number = elements[1]
+        message     = elements[-1]
 
         return file_path, line_number, :warning, message.to_s.strip
       end

data/lib/pronto/golang/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module GolangVersion
-    VERSION = '0.0.7'.freeze
+    VERSION = '0.0.8'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-golang
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Tobias Schoknecht
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-14 00:00:00.000000000 Z
+date: 2019-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
@@ -63,11 +63,12 @@ files:
 - LICENSE
 - README.md
 - lib/pronto/golang.rb
+- lib/pronto/golang/errors.rb
 - lib/pronto/golang/file_finder.rb
 - lib/pronto/golang/tools.rb
 - lib/pronto/golang/tools/base.rb
-- lib/pronto/golang/tools/errcheck.rb
 - lib/pronto/golang/tools/golint.rb
+- lib/pronto/golang/tools/gosec.rb
 - lib/pronto/golang/tools/govet.rb
 - lib/pronto/golang/tools/staticcheck.rb
 - lib/pronto/golang/version.rb
@@ -91,7 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Pronto runner for golang tools

data/lib/pronto/golang/tools/errcheck.rb

@@ -1,19 +0,0 @@
-module Pronto
-  module GolangTools
-    class Errcheck < Base
-      def self.base_command
-        'errcheck'
-      end
-
-      def parse_line(line)
-        file_path, line_number, _, _ = line.split(':')
-
-        return file_path, line_number, :warning, message
-      end
-
-      def message
-        'Error response given but not checked'
-      end
-    end
-  end
-end