pronto-github_resolver 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6724a96a446afe92679d71a695c66caef7ee8bfb0fc67569aa7d11541a3d2682
-  data.tar.gz: c9d3681104e1990b423d73e4d3989853f718ae584ce733840665672ee29266b6
+  metadata.gz: 23f7bc5d4cc79dd38274876a42bde7415e46d74709de16d0679b4e1c6075db55
+  data.tar.gz: 78bf5cb42c9ea45a020ec6a853959e0445058c0e587fad684a2d3e9790841258
 SHA512:
-  metadata.gz: ef745534dd513e7d1ac9161740f805b7589e8918477e7f01623932717bd0519e7440454920fef6ecca5133244a4bae4dbc9236f801a65928a3b68ab7bb5da717
-  data.tar.gz: ad719deed8a69fb7ee362162715b5fee13703d8a9aaa5708379e0828a37d0d08d66049609956e8c4caaff38b5a4dc98cddbae55965e1bea29dcfdad63ac88621
+  metadata.gz: c1ed837a3fb1a1e8cf16d613d68be09df09fa6cbd87d82d634ccff9ac20635296c5e14326169394fcbe8eee621ab6302b3b51bf25e099abe46a42b1911fa927e
+  data.tar.gz: 95bc80951dca62a513ac75728f7bdfc75cdad52e40f8836175eeff7d217b4282aaba51927c6409d31b8e1138967aff59d5efa1bc328ad2a44402b5bc7f3d9c6f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pronto-github_resolver (0.0.3)
+    pronto-github_resolver (0.0.4)
       pronto (~> 0.11)
 
 GEM

data/lib/pronto/github_resolver/version.rb

@@ -2,6 +2,6 @@
 
 module Pronto
   module GithubResolver
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/lib/pronto/github_resolver.rb

@@ -6,20 +6,6 @@ require 'pronto'
 module Pronto
 
   class Github < Client
-    # pronto messes up relative paths and does not have tests for this, patch to add repo.path.join
-    def pull_comments(sha)
-      @comment_cache["#{pull_id}/#{sha}"] ||= begin
-        client.pull_comments(slug, pull_id).map do |comment|
-          Comment.new(sha, comment.body, @repo.path.join(comment.path),
-                      comment.position || comment.original_position)
-        end
-      end
-    rescue Octokit::NotFound => e
-      @config.logger.log("Error raised and rescued: #{e}")
-      msg = "Pull request for sha #{sha} with id #{pull_id} was not found."
-      raise Pronto::Error, msg
-    end
-
     def publish_pull_request_comments(comments, event: nil)
       comments_left = comments.clone
       while comments_left.any?
@@ -166,7 +152,7 @@ module Pronto
         client.get_review_threads.each_pair do |thread_id, thread_comments|
           next unless thread_comments.all? do |comment|
             comment[:authored] &&
-              (actual_comments[[repo.path.join(comment[:path]), comment[:position]]] || []).none? { |actual_comment|
+              (actual_comments[[comment[:path], comment[:position]]] || []).none? { |actual_comment|
                 comment[:body].include?(actual_comment.body)
               }
           end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pronto-github_resolver
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Vasily Fedoseyev