pronto-clang_tidy 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d20206bbc89510ef27a4e7f97573fe05e905c136a04676a2c946a2c2d3d48fe
-  data.tar.gz: 52c7dd9ec890b0b2e29c81a53c833640b93b354ecc8f1279101ecace60f383bd
+  metadata.gz: aa8b2568123ef68b9a13cb451f547eabf93a7deada6854e31fb4d715faf7d84e
+  data.tar.gz: 27f8ca1e59d14a209a2651c47868a58a7ad825ce2badde47199835908762c1b7
 SHA512:
-  metadata.gz: '0845109034135d43dd8f810333e87c857fb1e83858695b12a8d02abddcadf5790ccd20ef4e44a72b8b40a5d065ce77fd79230004bebb2e00f107ca977bf3181c'
-  data.tar.gz: b7f0bd0c318e3957ab823e23026adc12264adb2ac48b6a9b8314d1b3d3c7bdc72489bc793b46956c778c28e99e570f24120573fd65b092ec2deb76255095d897
+  metadata.gz: 5fb3f5aaa237f15b8ff4558cb641eec7ea664d0dc029ee0fa4edd1d1776c250d42c4ce088001d1a6f0c64af35a22c289326c87e0abc41354c14b3749a82ba884
+  data.tar.gz: 41d2a054d544738db1de3f50a4b205dbfa92061f2dec3ba7ac8d590cf97fe5731cb9ce80eb6391befc92bd437a37372a33fe1252ef786cc8792a9233f0767141

data/README.md

@@ -3,7 +3,6 @@
 [![Code Climate](https://codeclimate.com/github/micjabbour/pronto-clang_tidy.png)](https://codeclimate.com/github/micjabbour/pronto-clang_tidy)
 [![Build Status](https://travis-ci.org/micjabbour/pronto-clang_tidy.png)](https://travis-ci.org/micjabbour/pronto-clang_tidy)
 [![Gem Version](https://badge.fury.io/rb/pronto-clang_tidy.png)](http://badge.fury.io/rb/pronto-clang_tidy)
-[![Dependency Status](https://gemnasium.com/micjabbour/pronto-clang_tidy.png)](https://gemnasium.com/micjabbour/pronto-clang_tidy)
 
 Pronto runner for [clang-tidy](http://clang.llvm.org/extra/clang-tidy), a clang-based C++ "linter" tool. [What is Pronto?](https://github.com/prontolabs/pronto)
 
@@ -29,4 +28,10 @@ Pronto will look for clang-tidy output file and submit its contents as soon as t
 
 After configuring and running `clang-tidy` on your codebase, redirect and save its standard output to a file (e.g. `clang-tidy.out`).
 
+To do that, you can use my [modified version of `run-clang-tidy.py`](https://gist.github.com/micjabbour/948578e0e24ce99aaaf6b32d848c9c18#file-run-clang-tidy-py) to automatically save clang-tidy output into `clang-tidy.out`:
+```
+python run-clang-tidy.py -checks=* -p build
+```
+where `build` is your build directory (that is, the directory that contains the generated file [`compile_commands.json`](https://clang.llvm.org/docs/JSONCompilationDatabase.html)).
+
 The name of the clang-tidy output file can be configured by setting the environment variable `PRONTO_CLANG_TIDY_OUTFILE` prior to running pronto. If it is not set, the runner will assume the file name is `clang-tidy.out`.

data/lib/pronto/clang_tidy/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module ClangTidy
-    VERSION = '0.9.0'.freeze
+    VERSION = '0.9.1'.freeze
   end
 end

data/lib/pronto/clang_tidy.rb

@@ -13,7 +13,9 @@ module Pronto
         next if patch.nil?
         # generate a message for the corresponding added_line in the patch
         message_for(patch, offence)
-      end.flatten.compact
+        # Header warnings are repeated for every compilation unit that includes
+        # them. Use uniq to ignore repeated messages
+      end.flatten.compact.uniq
     end
 
     private
@@ -37,23 +39,42 @@ module Pronto
 
     def new_message(offence, line)
       path = line.patch.delta.new_file[:path]
-      Message.new(path, line, :warning, offence.msg, nil, self.class)
+      Message.new(path, line, pronto_level(offence.level), offence.msg, nil,
+                  self.class)
+    end
+
+    def pronto_level(clang_level)
+      case clang_level
+      when :warning
+        :warning
+      when :error
+        :error
+      when :fatal
+        :fatal
+      else
+        :info
+      end
     end
 
     # reads clang-tidy output file and returns an array of offences
     def read_clang_tidy_output
       unless FileTest.file? clang_tidy_output_file
         puts 'WARN: pronto-clang_tidy: clang-tidy output file not found'
-        return ''
+        return []
       end
       clang_tidy_output = File.read clang_tidy_output_file
-      clang_tidy_output.split("\n").each_slice(3).map do |offence|
-        properties = offence[0].split(':').map(&:strip)
+      clang_tidy_output.each_line.select { |line| line_is_offence? line }
+                       .map do |offence|
+        properties = offence.split(':').map(&:strip)
         OpenStruct.new(file: properties[0], lineno: properties[1].to_i,
-                       level: properties[3], msg: properties[4])
+                       level: properties[3].to_sym, msg: properties[4])
       end
     end
 
+    def line_is_offence?(line)
+      line.start_with?('/') && /:\d+:\d+:/.match(line) && /\[\S+\]/.match(line)
+    end
+
     def clang_tidy_output_file
       ENV['PRONTO_CLANG_TIDY_OUTFILE'] || 'clang-tidy.out'
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-clang_tidy
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Michael Jabbour
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-14 00:00:00.000000000 Z
+date: 2018-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto