promoter 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b7e2c0354a1131bd25443d9e99ad8d87ddfee677b058def12bf8c7c105b296b
-  data.tar.gz: dce5471e6325bad206a0db864f84172f7d20392b8af25b6fe3ee8c0780ced310
+  metadata.gz: 43969ad482fc7bc346366f0b32d80581829550e18a53af2ced62488429dbcf9d
+  data.tar.gz: 5369949d18a1cbc07378e563211931a9752a6ab89dd098f630542c5e4d0f7306
 SHA512:
-  metadata.gz: 7dac49fe1a74a633fb39d91083cbd6d9ad08e171e05ae3c3133a6057de76a6b7e04a42c57ae6c8818a83b048e7f81f8ad62f48137a00647a30e834ac8fca71f8
-  data.tar.gz: 6a5b6716ca5b558f4ef524a4c69cba077c6563ecd60843d39fc3454858825e70a733fd3f6e5fc42ad4ef3ab37ad957bd3f33dff775782bc4681774a4269b1184
+  metadata.gz: 46f679a4587e1441f5e8d46d0a7ba1873086b2b23346406bbdf6329b1f2b63ef92070961801d031cccca514b10d12fea1b13004a2d52daa18406a2425b976e0d
+  data.tar.gz: cd5409b18f5b2d3167448427698983e4b152454a859e25f8bbd63c622d6e5cdf0925275c9e1ced76e1f20d95ed819744eca62d6c3010663f9e29b52b6546dd91

data/lib/promoter/contact.rb

@@ -89,13 +89,13 @@ module Promoter
       contact_attributes = if Promoter.api_version == 2
         api_url = "https://app.promoter.io/api/v2"
         contact_params = {
-          attributes: params[:attributes],
+          attributes: params[:attributes] || {},
           email: params[:email],
           first_name: params[:first_name],
           last_name: params[:last_name]
         }
         survey_params = {
-          attributes: params[:survey_attributes],
+          attributes: params[:survey_attributes] || {},
           campaign_id: params[:campaign_id],
           contact: contact_params,
         }

data/lib/promoter/errors.rb

@@ -24,10 +24,10 @@ module Promoter
     # 429	Too Many Requests – You’re requesting too much! Slown down!
     # 500	Internal Server Error – We had a problem with our server. Try again later.
     # 503	Service Unavailable – We’re temporarially offline for maintanance. Please try again later.
-    def check_for_error(status_code)
+    def check_for_error(status_code, response_body)
       case status_code.to_i
       when 400
-        raise BadRequest.new("Something is wrong with your request")
+        raise BadRequest.new(response_body)
       when 401
         raise Unauthorized.new("Your API key is incorrect or invalid")
       when 403
@@ -49,4 +49,4 @@ module Promoter
       end
     end
   end
-end
+end

data/lib/promoter/request.rb

@@ -28,12 +28,13 @@ module Promoter
 
     def self.parse_response(response, response_format=:json)
       display_debug(response.body)
-      check_for_error(response.response.code)
-      if response_format == :json
-        JSON.parse(response.body.to_s)
-      else
-        response.body.to_s
-      end
+      response_body = begin
+                        JSON.parse(response.body.to_s)
+                      rescue
+                        response.body.to_s
+                      end
+      check_for_error(response.response.code, response_body)
+      response_body
     end
 
     def self.display_debug(response)
@@ -54,4 +55,4 @@ module Promoter
 
   end
 
-end
+end

data/lib/promoter/version.rb

@@ -1,3 +1,3 @@
 module Promoter
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: promoter
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Chris O'Sullivan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-03 00:00:00.000000000 Z
+date: 2019-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler