promoted-ruby-client 0.1.23 → 0.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 280c1b17bece86732743246173338746e1ab9d414b9515bc9fc77c8c598ae319
-  data.tar.gz: 1fed11fd16de69732e6f61d1d1e33b31c812151413a34d881b8dd7aace712daa
+  metadata.gz: 99f637dce3d3f85f13e8937bf586e6e9f5a11891b262e84a6e66d57a44bc6b09
+  data.tar.gz: 0c517b9e7b0049c6ae873c90db9536eae6b153367114cc50af887f36efcf79f2
 SHA512:
-  metadata.gz: 997ca8c047a62a08b2f5e008184719c3e3f1f1dac45cfbccf41c4f451b8fad3f9a8aab7737e148a6281b4a9600e8c2ff6b8bfe9a269aba417ab7bf21f735fcd3
-  data.tar.gz: 274d3ce469128a6fa7da5fc127b65e9a3e1cc2327b322af5719182f06a37ada713806458c754d2efed6d6a21ad7ab945890541d5e3d1247844b66fa6b3a77a16
+  metadata.gz: 640878d97d82424619a60ebf451db0f1501d15e625adfc2c53f3a47511e2661cb4d61bc8788d5b42f93c11f778411bc3bad59d5bab3fd787270a9b015f9968c3
+  data.tar.gz: e4a99864846f7d542e773d84897f9ce3ff9db842115d0ebd835f604a7763bebfa7c875656377e22f57442637f71a7d0663b098379e2603c5b6852f9696e626ce

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    promoted-ruby-client (0.1.23)
+    promoted-ruby-client (0.1.24)
       concurrent-ruby (~> 1)
       faraday (>= 0.9.0)
       faraday_middleware (>= 0.9.0)

data/dev.md

@@ -4,5 +4,5 @@
 2. Get credentials for deployment from 1password.
 3. Modify `promoted-ruby-client.gemspec`'s push block.
 4. Run `gem build promoted-ruby-client.gemspec` to generate `gem`.
-5. Run (using new output) `gem push promoted-ruby-client-0.1.23.gem`
+5. Run (using new output) `gem push promoted-ruby-client-0.1.24.gem`
 6. Update README with new version.

data/lib/promoted/ruby/client/request_builder.rb

@@ -100,17 +100,12 @@ module Promoted
           filled_in_copy
         end
 
-        def log_request_params(include_insertions: true, include_request: true)
+        def log_request_params(include_delivery_log:, exec_server:)
           params = {
             user_info: user_info,
             timing: timing,
             client_info: merge_client_info_defaults,
             device: @device,
-            delivery_log: [{
-              execution: {
-                execution_server: Promoted::Ruby::Client::EXECUTION_SERVER['SDK']
-              }
-            }]
           }
 
           if @experiment
@@ -118,17 +113,19 @@ module Promoted
           end
 
           # Log request allows for multiple requests but here we only send one.
-          if include_request
+          if include_delivery_log
             request[:request_id] = request[:request_id] || @id_generator.newID
-            # Set request on delivery log.
-            params[:delivery_log][0][:request] = request
-          end
 
-          if include_insertions
-            # Add a response containing compacted insertions to delivery log.
-            params[:delivery_log][0][:response] = {
-              insertion: compact_metrics_properties
-            }
+            params[:delivery_log] = [{
+              execution: {
+                execution_server: exec_server
+              },
+              request: request,
+              response: {
+                insertion: insertions_with_compact_metrics_properties
+              }
+            }]
+
             add_missing_ids_on_insertions! request, params[:delivery_log][0][:response][:insertion]
           end
           
@@ -170,7 +167,7 @@ module Promoted
         end
 
         # TODO: This looks overly complicated.
-        def compact_metrics_properties
+        def insertions_with_compact_metrics_properties
           @insertion            = [] # insertion should be set according to the compact insertion
           paging                = request[:paging] || {}
           size                  = paging[:size] ? paging[:size].to_i : 0

data/lib/promoted/ruby/client/version.rb

@@ -1,7 +1,7 @@
 module Promoted
   module Ruby
     module Client
-      VERSION = "0.1.23"
+      VERSION = "0.1.24"
     end
   end
 end

data/lib/promoted/ruby/client.rb

@@ -194,6 +194,8 @@ module Promoted
           end
 
           log_req = nil
+          exec_server = (insertions_from_delivery ? Promoted::Ruby::Client::EXECUTION_SERVER['API'] : Promoted::Ruby::Client::EXECUTION_SERVER['SDK'])
+          
           # We only return a log request if there's a request or cohort to log.
           if request_to_log || cohort_membership_to_log
             log_request_builder = RequestBuilder.new
@@ -212,14 +214,14 @@ module Promoted
             # On a successful delivery request, we don't log the insertions
             # or the request since they are logged on the server-side.
             log_req = log_request_builder.log_request_params(
-              include_insertions: !insertions_from_delivery, 
-              include_request: !insertions_from_delivery)
+              include_delivery_log: !insertions_from_delivery, 
+              exec_server: exec_server)
           end
 
           client_response = {
             insertion: response_insertions,
             log_request: log_req,
-            execution_server: insertions_from_delivery ? Promoted::Ruby::Client::EXECUTION_SERVER['API'] : Promoted::Ruby::Client::EXECUTION_SERVER['SDK'],
+            execution_server: exec_server,
             client_request_id: delivery_request_builder.client_request_id
           }
           return client_response
@@ -258,7 +260,9 @@ module Promoted
             deliver_shadow_traffic args, headers
           end
 
-          log_request_builder.log_request_params
+          log_request_builder.log_request_params(
+            include_delivery_log: true, 
+            exec_server: Promoted::Ruby::Client::EXECUTION_SERVER['SDK'])
         end
 
         ##

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: promoted-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.24
 platform: ruby
 authors:
 - scottmcmaster
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-10-15 00:00:00.000000000 Z
+date: 2021-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday