promise.rb 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1c5730ef1d6a9d4aca9152d2d0b0978d3599bf9
-  data.tar.gz: 7bf7f65107907530efb5befd130d8257c95b1ebd
+  metadata.gz: 1e3533c32b2d839c7fe076eb9ef7e02e38d594cf
+  data.tar.gz: 8041c55194508d424bf52709b0d55f97c75900a5
 SHA512:
-  metadata.gz: b91773b745efae988afbcdd56080fac09398f72e781266e92b755128a3f606fc09f63299849a729c2b6e1ced9cc1cdc46581beb6880949c7ea2748516994cff3
-  data.tar.gz: 7ca9447a4c2766299ccc9d941dd2a25d68a65a1626ff3407726966ed85157bc0c25873bf53c5eecd2a6e683c093a6217f354be5712c38602d5d02f7e7f8bb3c5
+  metadata.gz: b7d7ea80750476d1334d79b24c87d6b2c50a3165f336e978064eab63398722bdb5d652aac575ca9826d28305099780e40812ae9def94a23f729a657f345b09d9
+  data.tar.gz: c079077407ed72f4d8b0e0ba688ec623f59a23e2e3ae4240209def4c9d54bfccc19a7105e21e484dc46a6db6fa79e7be7441f45e9ba9877f74a6d8ed68c58806

data/.gitignore

@@ -4,6 +4,7 @@
 Gemfile.lock
 pkg/
 *.rbc
+*.gem
 .yardoc/
 doc/
 coverage/

data/CHANGELOG.md

@@ -1,11 +1,18 @@
 # promise.rb changelog
 
+## 0.7.3 (April 28, 2017)
+
+### Features
+
+* Allow to call Promise.resolve without argument (pull #21)
+* Return self from fulfill and reject (pull #22)
+
 ## 0.7.2 (November 15, 2016)
 
 ### Features
 
 * Add support for calling sync on the result of Promise.all (pull #24)
-* Add Promise.sync to unwrap an object that may be a promise. (#25)
+* Add Promise.sync to unwrap an object that may be a promise. (pull #25)
 
 ## 0.7.1 (June 15, 2016)
 

data/Gemfile

@@ -7,21 +7,21 @@ gemspec
 if Gem.ruby_version < Gem::Version.new('2.0')
   # gems that no longer support ruby 1.9.3
   gem 'json', '~> 1.8.3'
-  gem 'tins', '~> 1.6.0'
   gem 'term-ansicolor', '~> 1.3.2'
+  gem 'tins', '~> 1.6.0'
 end
 if Gem.ruby_version >= Gem::Version.new('2.1')
-  gem 'devtools', '~> 0.1.4'
+  gem 'devtools', '~> 0.1.16'
 end
-gem 'fuubar', '~> 2.0.0'
-gem 'awesome_print'
 
+gem 'awesome_print'
+gem 'coveralls', '~> 0.8.9'
+gem 'fuubar', '~> 2.0.0'
 gem 'rake'
 gem 'rspec', '~> 3.5'
 gem 'rspec-its'
-gem 'coveralls', '~> 0.8.9'
 
 platform :rbx do
-  gem 'rubysl', '~> 2.0'
   gem 'rubinius', '~> 2.0'
+  gem 'rubysl', '~> 2.0'
 end

data/README.md

@@ -158,6 +158,15 @@ Promise.new
   .then(nil, proc { |reason| p reason })
 ```
 
+In order to use the result of multiple promises, they can be grouped using
+`Promise.all` for chaining.
+
+```ruby
+sum_promise = Promise.all([promise1, promise2]).then do |value1, value2|
+  value1 + value2
+end
+```
+
 ### Progress callbacks
 
 Very simple progress callbacks, as per Promises/A, are supported as well. They have been dropped in A+, but I found them to be a useful mechanism - if kept simple. Callback dispatch happens immediately in the call to `#progress`, in the order of definition via `#on_progress`. Also note that `#on_progress` does not return a new promise for chaining - the progress mechanism is meant to be very lightweight, and ignores many of the constraints and guarantees of `then`.

data/config/reek.yml

@@ -64,7 +64,7 @@ TooManyStatements:
   exclude:
   - initialize
   - each
-  max_statements: 6
+  max_statements: 7
 UncommunicativeMethodName:
   enabled: true
   exclude: []

data/config/rubocop.yml

@@ -14,7 +14,7 @@ ParameterLists:
 
 MethodLength:
   CountComments: false
-  Max: 10
+  Max: 11
 
 # Avoid more than `Max` levels of nesting.
 BlockNesting:
@@ -69,6 +69,9 @@ SignalException:
 BlockDelimiters:
   Enabled: false
 
+Metrics/BlockLength:
+  Enabled: false
+
 # Allow empty lines around body
 EmptyLinesAroundBlockBody:
   Enabled: false

data/lib/promise.rb

@@ -15,7 +15,7 @@ class Promise
   attr_accessor :source
   attr_reader :state, :value, :reason
 
-  def self.resolve(obj)
+  def self.resolve(obj = nil)
     return obj if obj.is_a?(self)
     new.tap { |promise| promise.fulfill(obj) }
   end
@@ -85,7 +85,7 @@ class Promise
         @value = value
       end
     end
-    nil
+    self
   end
 
   def reject(reason = nil)
@@ -94,6 +94,7 @@ class Promise
       @source = nil
       @reason = reason_coercion(reason || Error)
     end
+    self
   end
 
   # Override to support sync on a promise without a source or to wait

data/lib/promise/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 class Promise
-  VERSION = '0.7.2'.freeze
+  VERSION = '0.7.3'.freeze
 end

data/spec/unit/promise_spec.rb

@@ -398,12 +398,8 @@ describe Promise do
     end
 
     describe '#fulfill' do
-      it 'does not return anything' do
-        expect(subject.fulfill(nil)).to eq(nil)
-      end
-
-      it 'does not return anything when given a promise' do
-        expect(subject.fulfill(Promise.new)).to eq(nil)
+      it 'returns itself to allow chaining' do
+        expect(subject.fulfill(nil)).to be(subject)
       end
 
       it 'does not require a value' do
@@ -424,8 +420,8 @@ describe Promise do
     end
 
     describe '#reject' do
-      it 'does not return anything' do
-        expect(subject.reject(nil)).to eq(nil)
+      it 'returns itself for easy chaning' do
+        expect(subject.reject(nil)).to be(subject)
       end
 
       it 'does not require a reason' do
@@ -558,6 +554,12 @@ describe Promise do
         expect(new_promise).to be_fulfilled
         expect(new_promise.value).to eq(42)
       end
+
+      it 'can be passed no argument' do
+        promise = Promise.resolve
+        expect(promise.fulfilled?).to eq(true)
+        expect(promise.value).to eq(nil)
+      end
     end
 
     describe '.all' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: promise.rb
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Lars Gierth
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-16 00:00:00.000000000 Z
+date: 2017-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -76,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Ruby implementation of the Promises/A+ spec