prolog_minitest_matchers 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fab4720efbabb4f86251454fb1107c3b12b133e2
-  data.tar.gz: 10d7bb2ce0ce02a2308193a66d1853b89ba45d57
+  metadata.gz: 3432250c36aada7c4efaf78622e1c6f538ce804d
+  data.tar.gz: d312f4b46721223e8796c7b8a08b714335719fd3
 SHA512:
-  metadata.gz: e44d46dde47f14931e9056e898e6b10a9361d48f314b3ad1b810dbe8681e4d246689a6b30a9a722307601c72d8d09bee0d34a1db7d7fa9deadd67f6c9f3e9853
-  data.tar.gz: 488130da26e438b86938551ced8286f7fbb2252e28923fe0e27d9f03961d40e062d3a78b5371e1ff0e6024db7ffc7861448d5a0aa1e769466defb39d7bcedf91
+  metadata.gz: 9c5dcf648b266d338d43023504adcf61004828cca72b101deef1a373570cf010f7ebcf8a640c59fa7e3068713a06f5cdc9f86329648a23950df792bc7ff0e2b6
+  data.tar.gz: 09a985e617ed970d21f272838491612672ab8f6c59e7b2f700d8f4866ddd1ddb48b02deb54e5ce0bcce34522084ca4981b91d68d9f9e24cb98edb058fd3118e3

data/.rubocop.yml

@@ -0,0 +1,4 @@
+
+AllCops:
+  TargetRubyVersion: 2.3
+

data/Rakefile

@@ -1,10 +1,47 @@
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 
+require 'rake/tasklib'
+require 'flay'
+require 'flay_task'
+require 'tasks/prolog_flog_task'
+require 'reek/rake/task'
+require 'rubocop/rake_task'
+
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList['test/**/*_test.rb']
 end
 
-task :default => :test
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.patterns = [
+    'lib/**/*.rb',
+    'test/**/*.rb'
+  ]
+  task.formatters = ['simple', 'd']
+  task.fail_on_error = true
+  task.options << '--display-cop-names'
+  end
+
+Reek::Rake::Task.new do |t|
+  t.config_file = 'config.reek'
+  t.source_files = 'lib/**/*.rb'
+  t.reek_opts = '--sort-by smelliness -s'
+end
+
+FlayTask.new do |t|
+  t.verbose = true
+  t.dirs = %w(lib)
+end
+
+FlogTask.new do |t|
+  t.verbose = true
+  t.threshold = 200 # default is 200
+  t.methods_only = true
+  t.dirs = %w(lib)
+end
+
+task(:default).clear
+task default: [:test, :rubocop, :flay, :flog, :reek]

data/config.reek

@@ -0,0 +1,8 @@
+
+LongParameterList:
+  max_params: 4  # If it's good enough for Sandi, it's good enough for us.
+
+# NestedIterators:
+#   max_allowed_nesting: 2
+#   ignore_iterators:
+#     - lambda

data/lib/prolog_minitest_matchers/matchers/asserters/assert_requires_initialize_parameter.rb

@@ -25,34 +25,44 @@ module MiniTest
         errors[:expected]&.message == message
       end
 
+      def filtered_params
+        full_params.dup.reject { |source_key, _| source_key == param_key }
+      end
+
+      # Running Reek will complain about a :reek:ControlParameter. Protocol is.
       def initial_message_from(message, param_key)
         message || "missing keyword: #{param_key}"
       end
 
       def save_and_try_to_init
         verify_param_in_list
-        saved_item = full_params[param_key]
-        full_params.delete param_key
-        errors = try_to_init
-        full_params[param_key] = saved_item
-        errors
+        save_and_delete_param_before { |params| try_to_init params }
+      end
+
+      def save_and_delete_param_before
+        yield filtered_params
       end
 
-      def try_to_init
+      def try_to_init(params)
         expected_error = nil
         begin
-          _ = klass.new full_params
+          klass.new params
         rescue ArgumentError => error
           expected_error = error
-        rescue StandardError => error
-          ap [:matcher_48, 'Unexpected error', error]
         end
         { expected: expected_error }
       end
 
       def verify_param_in_list
-        no_param_message = "No key :#{param_key} in #{full_params}!"
-        fail KeyError, no_param_message unless full_params.key?(param_key)
+        raise KeyError, no_param_message unless param_in_full_list?
+      end
+
+      def no_param_message
+        "No key :#{param_key} in #{full_params}!"
+      end
+
+      def param_in_full_list?
+        full_params.key? param_key
       end
     end # class MiniTest::Assertions::AssertRequiresInitializeParameter
   end

data/lib/prolog_minitest_matchers/matchers/asserters/assert_requires_static_call_param.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module MiniTest
+  # Adding custom assertions to make specs easier to read
+  module Assertions
+    # Actual test logic for `#assert_requires_static_call_paramr`.
+    class AssertRequiresStaticCallParam
+      def initialize(klass, full_params, param_key, message)
+        @klass = klass
+        @full_params = full_params
+        @param_key = param_key
+        @message = initial_message_from(message, param_key)
+        self
+      end
+
+      def call(assert)
+        verify_param_in_list(assert)
+        assert.call(errors_as_expected(save_and_try_to_call), message)
+      end
+
+      private
+
+      attr_reader :full_params, :klass, :message, :param_key
+
+      def errors_as_expected(errors)
+        errors[:expected]&.message == message
+      end
+
+      def filtered_params
+        full_params.dup.reject { |source_key, _| source_key == param_key }
+      end
+
+      # Running Reek will complain about a :reek:ControlParameter. Protocol is.
+      def initial_message_from(message, param_key)
+        message || "missing keyword: #{param_key}"
+      end
+
+      def key_not_found_message
+        "Key :#{param_key} not found in #{full_params}!"
+      end
+
+      def save_and_try_to_call
+        save_and_delete_param_before { |params| try_to_call params }
+        # saved_item = full_params[param_key]
+        # full_params.delete param_key
+        # errors = try_to_call
+        # full_params[param_key] = saved_item
+        # errors
+      end
+
+      def try_to_call(params)
+        expected_error = nil
+        begin
+          klass.call params
+        rescue ArgumentError => error
+          expected_error = error
+        end
+        { expected: expected_error }
+      end
+
+      def save_and_delete_param_before
+        yield filtered_params
+      end
+
+      def verify_param_in_list(assert)
+        assert.call(param_in_list?, key_not_found_message)
+      end
+
+      def param_in_list?
+        full_params.key?(param_key)
+      end
+    end # class MiniTest::Assertions::AssertRequiresStaticCallParam
+  end
+end

data/lib/prolog_minitest_matchers/matchers/requires_static_call_param.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'minitest/spec'
+
+require_relative './asserters/assert_requires_static_call_param.rb'
+
+module MiniTest
+  # Adding custom assertions to make specs easier to read
+  module Assertions
+    def assert_requires_static_call_param(klass, full_params, param_key,
+                                          message = nil)
+      AssertRequiresStaticCallParam.new(klass, full_params, param_key, message)
+                                   .call(method(:assert))
+    end
+  end
+
+  # Make it available to MiniTest::Spec
+  module Expectations
+    infect_an_assertion :assert_requires_static_call_param,
+                        :must_require_static_call_param, :reverse
+  end
+end # module MiniTest

data/lib/prolog_minitest_matchers/version.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Module to satisfy Gem requirements; nothing inside but version-spec constant.
 module PrologMinitestMatchers
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/prolog_minitest_matchers.rb

@@ -3,6 +3,7 @@
 require 'prolog_minitest_matchers/version'
 require 'prolog_minitest_matchers/matchers/requires_initialize_parameter'
 
+# Module to satisfy Gem requirements; nothing inside but version-spec constant.
 module PrologMinitestMatchers
-  # Your code goes here...
+  # Your code would go here if it wasn't required to go elsewhere...
 end

data/lib/tasks/prolog_flog_task.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'rake/tasklib'
+require 'flog'
+require 'flog_task'
+
+# Redefinition of standard task's Rake invocation. Because we don't like
+# inconsistency in option settings.
+class FlogTask < Rake::TaskLib
+  # Reek bitches that this is a :reek:Attribute (writable). That's the *point*.
+  attr_accessor :methods_only
+end

data/prolog_minitest_matchers.gemspec

@@ -30,4 +30,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.12", ">= 1.12.5"
   spec.add_development_dependency "rake", "~> 11.2", ">= 11.2.2"
   spec.add_development_dependency "minitest", "~> 5.9", ">= 5.9.0"
+
+  spec.add_development_dependency "flay", "~> 2.8", ">= 2.8.0"
+  spec.add_development_dependency "flog", "~> 4.4", ">= 4.4.0"
+  spec.add_development_dependency "reek", "~> 4.2", ">= 4.2.1"
+  spec.add_development_dependency "rubocop", "~> 0.42", ">= 0.42.0"
+  spec.add_development_dependency "pry-byebug", "~> 3.4", ">= 3.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prolog_minitest_matchers
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jeff Dickey
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-20 00:00:00.000000000 Z
+date: 2016-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -70,6 +70,106 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.9.0
+- !ruby/object:Gem::Dependency
+  name: flay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+- !ruby/object:Gem::Dependency
+  name: flog
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.4.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.4.0
+- !ruby/object:Gem::Dependency
+  name: reek
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.42'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.42.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.42'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.42.0
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.4.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.4.0
 description: 
 email:
 - jdickey@seven-sigma.com
@@ -78,16 +178,21 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- config.reek
 - lib/prolog_minitest_matchers.rb
 - lib/prolog_minitest_matchers/matchers/asserters/assert_requires_initialize_parameter.rb
+- lib/prolog_minitest_matchers/matchers/asserters/assert_requires_static_call_param.rb
 - lib/prolog_minitest_matchers/matchers/requires_initialize_parameter.rb
+- lib/prolog_minitest_matchers/matchers/requires_static_call_param.rb
 - lib/prolog_minitest_matchers/version.rb
+- lib/tasks/prolog_flog_task.rb
 - prolog_minitest_matchers.gemspec
 homepage: https://github.com/TheProlog/prolog_minitest_matchers
 licenses: