production_log_analyzer 1.5.0 → 1.5.1

data/History.txt

@@ -1,10 +1,14 @@
-= 1.5.0
+=== 1.5.1
+
+* 1.9 and 1.8.7 compatibility.
+
+=== 1.5.0
 
 * Fixed empty log bug.  Patch by Tim Lucas.
 * Fixed bug where sometimes lines would be logged before the
   Processing line.  Patch by Geoff Grosenbach.
 
-= 1.4.0
+=== 1.4.0
 
 * Switched to Hoe
 * Allowed action_errors to suppress routing errors with > 3 occurances
@@ -13,22 +17,22 @@
 * Added action_errors to extract error counts from logs
 * Retabbed to match the rest of the world
 
-= 1.3.0
+=== 1.3.0
 
 * Added action_grep
 * Added support for newer log format
 
-= 1.2.0
+=== 1.2.0
 
 * pl_analyze calculates per-action statistics
 * pl_analyze can send an email with its output
 
-= 1.1.0
+=== 1.1.0
 
 * RDoc
 * Other various fixes lost to time.
 
-= 1.0.0
+=== 1.0.0
 
 * Birthday!
 

data/README.txt

@@ -1,11 +1,12 @@
 = production_log_analyzer
 
-production_log_analyzer lets you find out which actions on a Rails
-site are slowing you down.
+* http://seattlerb.rubyforge.org/production_log_analyzer
+* http://rubyforge.org/projects/seattlerb
 
-http://seattlerb.rubyforge.org/production_log_analyzer
+== DESCRIPTION
 
-http://rubyforge.org/projects/seattlerb
+production_log_analyzer lets you find out which actions on a Rails
+site are slowing you down.
 
 Bug reports:
 

data/Rakefile

@@ -1,17 +1,15 @@
+ENV.delete 'GEM_PATH'
+
+require 'rubygems'
 require 'hoe'
 
-$:.unshift './lib'
-require 'production_log/analyzer'
+Hoe.plugin :seattlerb
 
-Hoe.new 'production_log_analyzer', '1.5.0' do |p|
-  p.summary = p.paragraphs_of('README.txt', 1).join ' '
-  p.description = p.paragraphs_of('README.txt', 7).join ' '
-  p.author = 'Eric Hodel'
-  p.email = 'drbrain@segment7.net'
-  p.url = p.paragraphs_of('README.txt', 2).join ' '
+Hoe.spec 'production_log_analyzer' do
+  developer 'Eric Hodel', 'drbrain@segment7.net'
 
-  p.rubyforge_name = 'seattlerb'
+  self.rubyforge_name = 'seattlerb'
 
-  p.extra_deps << ['rails_analyzer_tools', '>= 1.4.0']
+  extra_deps << ['rails_analyzer_tools', '>= 1.4.0']
 end
 

data/lib/production_log/analyzer.rb

@@ -95,7 +95,7 @@ class SlowestTimes < SizedList
 
   def initialize(limit)
     super limit do |arr, new_item|
-      fastest_time = arr.sort_by { |time, name| time }.first
+      fastest_time = arr.sort_by { |time, name| [time, name] }.first
       if fastest_time.first < new_item.first then
         arr.delete_at index(fastest_time)
         true
@@ -115,7 +115,7 @@ class Analyzer
   ##
   # The version of the production log analyzer you are using.
 
-  VERSION = '1.5.0'
+  VERSION = '1.5.1'
 
   ##
   # The logfile being read by the Analyzer.
@@ -161,11 +161,13 @@ class Analyzer
 
   def self.envelope(recipient, subject = nil) # :nodoc:
     envelope = {}
-    envelope['To'] = recipient
+
+    # HACK: this is a hack and the tests should be made order independent
     envelope['Subject'] = subject || "pl_analyze"
+    envelope['To'] = recipient
     envelope['Content-Type'] = "text/html"
 
-    return envelope.map { |(k,v)| "#{k}: #{v}" }
+    envelope.sort.map { |(k,v)| "#{k}: #{v}" }
   end
 
   ##
@@ -328,16 +330,19 @@ class Analyzer
     list << record.join("\t")
 
     # all requests
-    times = records.values.flatten
-    record = [times.average, times.standard_deviation, times.min, times.max]
+    all_times = records.values.flatten
+    record = [
+      all_times.average, all_times.standard_deviation, all_times.min,
+      all_times.max
+    ]
     record.map! { |v| "%0.3f" % v }
-    record.unshift [pad_request_name('ALL REQUESTS'), times.size]
+    record.unshift [pad_request_name('ALL REQUESTS'), all_times.size]
     list << record.join("\t")
 
     # spacer
     list << nil
 
-    records.sort_by { |k,v| v.size}.reverse_each do |req, times|
+    records.sort_by { |k,v| [-v.size, k] }.each do |req, times|
       record = [times.average, times.standard_deviation, times.min, times.max]
       record.map! { |v| "%0.3f" % v }
       record.unshift ["#{pad_request_name req}", times.size]
@@ -356,7 +361,7 @@ class Analyzer
       end
     end
 
-    return slowest_times.sort_by { |time, name| time }.reverse
+    return slowest_times.sort_by { |time, name| [-time, name] }
   end
 
   def time_average(records) # :nodoc:

data/lib/production_log/parser.rb

@@ -71,6 +71,7 @@ module LogParser
     # same request.
 
     def parse(entry)
+      entry = entry.split(/\n/) if String === entry
       entry.each do |line|
         case line
         when /^Parameters/, /^Cookie set/, /^Rendering/,
@@ -149,7 +150,7 @@ module LogParser
       end
     end
 
-    buckets.each do |bucket, data|
+    buckets.sort.each do |bucket, data|
       yield LogEntry.new(data)
     end
   end

data/test/test.syslog.log

@@ -1,4 +1,3 @@
-//src/production_log_analyzer/dev/test/test.syslog.log#1 - add change 3135 (text)
 Mar  7 00:00:00 online1 newsyslog[61307]: logfile turned over
 Mar  7 00:00:20 online1 rails[59600]: Goal Load (0.002112)   SELECT g.*, gs.score as score FROM goals g, goal_similarities gs WHERE g.id = gs.similar_goal_id AND g.num_active_people > 0 AND gs.goal_similarity_type_id = 1 AND gs.goal_id = 59133 ORDER BY score DESC LIMIT 3
 Mar  7 00:00:20 online1 rails[59600]: Tag Load (0.001527)   SELECT tags.*, count(*) as num_goals FROM tags_teams, tags, teams WHERE tags_teams.tag_id = tags.id AND tags_teams.team_id = teams.id AND teams.num_members > 0 AND teams.goal_id = 59133 GROUP BY tags.id ORDER BY num_goals DESC LIMIT 5
@@ -255,4 +254,3 @@ Mar  7 00:00:32 online1 rails[59635]: Processing PeopleController#progress (for
 Mar  7 00:00:32 online1 rails[59635]: Parameters: {:id=>"swirlygirl", :on=>"35926", :action=>"progress", :"people/progress/swirlygirl/35926.html/progress/swirlygirl/35926"=>nil, :controller=>"people"}
 Mar  7 00:00:32 online1 rails[59635]: Browser Load (0.000698)   SELECT * FROM browsers WHERE ubid = 'STUFF' LIMIT 1
 Mar  7 00:00:32 online1 rails[59635]: Person Load (0.001319)   SELECT * FROM people WHERE username = 'swirlygirl' LIMIT 1
-

data/test/test_analyzer.rb

@@ -91,18 +91,18 @@ class TestAnalyzer < Test::Unit::TestCase
     email = Analyzer.email('test/test.syslog.log', 'devnull@robotcoop.com',
                            nil, 1)
     expected = <<-EOF
+Content-Type: text/html
 Subject: pl_analyze
 To: devnull@robotcoop.com
-Content-Type: text/html
 
 <pre>Request Times Summary:    	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
 
 ThingsController#view:    	3	0.716	0.387	0.396	1.260
-TeamsController#progress: 	2	0.841	0.629	0.212	1.470
-RssController#uber:       	2	0.035	0.000	0.035	0.035
 PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
 
 Slowest Request Times:
 \tTeamsController#progress took 1.470s
@@ -113,10 +113,10 @@ DB Times Summary:         	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
 
 ThingsController#view:    	3	0.403	0.362	0.122	0.914
-TeamsController#progress: 	2	0.646	0.497	0.149	1.144
-RssController#uber:       	2	0.008	0.000	0.008	0.008
 PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
 
 Slowest Total DB Times:
 \tTeamsController#progress took 1.144s
@@ -127,10 +127,10 @@ Render Times Summary:     	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
 
 ThingsController#view:    	3	0.270	0.171	0.108	0.506
-TeamsController#progress: 	2	0.000	0.000	0.000	0.000
-RssController#uber:       	2	0.012	0.000	0.012	0.012
 PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
 
 Slowest Total Render Times:
 \tPeopleController#view took 0.695s
@@ -142,9 +142,9 @@ Slowest Total Render Times:
 
   def test_self_envelope
     expected = [
+      "Content-Type: text/html",
       "Subject: pl_analyze",
       "To: devnull@example.com",
-      "Content-Type: text/html"
     ]
 
     assert_equal expected, Analyzer.envelope('devnull@example.com')
@@ -152,9 +152,9 @@ Slowest Total Render Times:
 
   def test_self_envelope_subject
     expected = [
+      "Content-Type: text/html",
       "Subject: happy fancy boom",
       "To: devnull@example.com",
-      "Content-Type: text/html"
     ]
 
     assert_equal(expected,
@@ -183,10 +183,10 @@ DB Times Summary:         	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
 
 ThingsController#view:    	3	0.403	0.362	0.122	0.914
-TeamsController#progress: 	2	0.646	0.497	0.149	1.144
-RssController#uber:       	2	0.008	0.000	0.008	0.008
 PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
 EOF
 
     assert_equal expected, @analyzer.db_times_summary
@@ -282,10 +282,10 @@ Render Times Summary:     	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
 
 ThingsController#view:    	3	0.270	0.171	0.108	0.506
-TeamsController#progress: 	2	0.000	0.000	0.000	0.000
-RssController#uber:       	2	0.012	0.000	0.012	0.012
 PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
 EOF
 
     assert_equal expected, @analyzer.render_times_summary
@@ -297,10 +297,10 @@ Request Times Summary:    	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
 
 ThingsController#view:    	3	0.716	0.387	0.396	1.260
-TeamsController#progress: 	2	0.841	0.629	0.212	1.470
-RssController#uber:       	2	0.035	0.000	0.035	0.035
 PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
 
 Slowest Request Times:
 \tTeamsController#progress took 1.470s
@@ -320,10 +320,10 @@ DB Times Summary:         	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
 
 ThingsController#view:    	3	0.403	0.362	0.122	0.914
-TeamsController#progress: 	2	0.646	0.497	0.149	1.144
-RssController#uber:       	2	0.008	0.000	0.008	0.008
 PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
 
 Slowest Total DB Times:
 \tTeamsController#progress took 1.144s
@@ -343,10 +343,10 @@ Render Times Summary:     	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
 
 ThingsController#view:    	3	0.270	0.171	0.108	0.506
-TeamsController#progress: 	2	0.000	0.000	0.000	0.000
-RssController#uber:       	2	0.012	0.000	0.012	0.012
 PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
 
 Slowest Total Render Times:
 \tPeopleController#view took 0.695s
@@ -374,10 +374,10 @@ Request Times Summary:    	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
 
 ThingsController#view:    	3	0.716	0.387	0.396	1.260
-TeamsController#progress: 	2	0.841	0.629	0.212	1.470
-RssController#uber:       	2	0.035	0.000	0.035	0.035
 PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
 EOF
 
     assert_equal expected, @analyzer.request_times_summary

data/test/test_parser.rb

@@ -222,8 +222,8 @@ Jan 03 12:24:24 duo2 rails[4277]: Completed in 0.00112 (896 reqs/sec) | DB: 0.00
 
   def test_class_parse_multi
     entries = []
-    File.open 'test/test.syslog.log' do |fp|
-      LogParser.parse fp do |entry|
+    open 'test/test.syslog.log' do |io|
+      LogParser.parse io do |entry|
         entries << entry
       end
     end
@@ -235,15 +235,18 @@ Jan 03 12:24:24 duo2 rails[4277]: Completed in 0.00112 (896 reqs/sec) | DB: 0.00
     assert_equal 'TeamsController#progress', redirect.page
     assert_equal 0, redirect.render_time
 
+    second_last = entries[-2]
+    assert_equal 'PeopleController#progress', second_last.page
+    assert_equal 0, second_last.request_time
+
     last = entries.last
-    assert_equal 'PeopleController#progress', last.page
-    assert_equal 0, last.request_time
+    assert_equal nil, last.page
   end
 
   def test_class_parse_0_14_x
     entries = []
-    File.open 'test/test.syslog.0.14.x.log' do |fp|
-      LogParser.parse fp do |entry|
+    open 'test/test.syslog.0.14.x.log' do |io|
+      LogParser.parse io do |entry|
         entries << entry
       end
     end

metadata

@@ -1,33 +1,78 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.2
-specification_version: 1
 name: production_log_analyzer
 version: !ruby/object:Gem::Version 
-  version: 1.5.0
-date: 2007-05-16 00:00:00 -07:00
-summary: production_log_analyzer lets you find out which actions on a Rails site are slowing you down.
-require_paths: 
-- lib
-email: drbrain@segment7.net
-homepage: http://seattlerb.rubyforge.org/production_log_analyzer
-rubyforge_project: seattlerb
-description: production_log_analyzer provides three tools to analyze log files created by SyslogLogger.  pl_analyze for getting daily reports, action_grep for pulling log lines for a single action and action_errors to summarize errors with counts.
-autorequire: 
-default_executable: 
-bindir: bin
-has_rdoc: true
-required_ruby_version: !ruby/object:Gem::Version::Requirement 
-  requirements: 
-  - - ">"
-    - !ruby/object:Gem::Version 
-      version: 0.0.0
-  version: 
+  version: 1.5.1
 platform: ruby
-signing_key: 
-cert_chain: 
-post_install_message: 
 authors: 
 - Eric Hodel
+autorequire: 
+bindir: bin
+cert_chain: 
+- |
+  -----BEGIN CERTIFICATE-----
+  MIIDNjCCAh6gAwIBAgIBADANBgkqhkiG9w0BAQUFADBBMRAwDgYDVQQDDAdkcmJy
+  YWluMRgwFgYKCZImiZPyLGQBGRYIc2VnbWVudDcxEzARBgoJkiaJk/IsZAEZFgNu
+  ZXQwHhcNMDcxMjIxMDIwNDE0WhcNMDgxMjIwMDIwNDE0WjBBMRAwDgYDVQQDDAdk
+  cmJyYWluMRgwFgYKCZImiZPyLGQBGRYIc2VnbWVudDcxEzARBgoJkiaJk/IsZAEZ
+  FgNuZXQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCbbgLrGLGIDE76
+  LV/cvxdEzCuYuS3oG9PrSZnuDweySUfdp/so0cDq+j8bqy6OzZSw07gdjwFMSd6J
+  U5ddZCVywn5nnAQ+Ui7jMW54CYt5/H6f2US6U0hQOjJR6cpfiymgxGdfyTiVcvTm
+  Gj/okWrQl0NjYOYBpDi+9PPmaH2RmLJu0dB/NylsDnW5j6yN1BEI8MfJRR+HRKZY
+  mUtgzBwF1V4KIZQ8EuL6I/nHVu07i6IkrpAgxpXUfdJQJi0oZAqXurAV3yTxkFwd
+  g62YrrW26mDe+pZBzR6bpLE+PmXCzz7UxUq3AE0gPHbiMXie3EFE0oxnsU3lIduh
+  sCANiQ8BAgMBAAGjOTA3MAkGA1UdEwQCMAAwCwYDVR0PBAQDAgSwMB0GA1UdDgQW
+  BBS5k4Z75VSpdM0AclG2UvzFA/VW5DANBgkqhkiG9w0BAQUFAAOCAQEAHagT4lfX
+  kP/hDaiwGct7XPuVGbrOsKRVD59FF5kETBxEc9UQ1clKWngf8JoVuEoKD774dW19
+  bU0GOVWO+J6FMmT/Cp7nuFJ79egMf/gy4gfUfQMuvfcr6DvZUPIs9P/TlK59iMYF
+  DIOQ3DxdF3rMzztNUCizN4taVscEsjCcgW6WkUJnGdqlu3OHWpQxZBJkBTjPCoc6
+  UW6on70SFPmAy/5Cq0OJNGEWBfgD9q7rrs/X8GGwUWqXb85RXnUVi/P8Up75E0ag
+  14jEc90kN+C7oI/AGCBN0j6JnEtYIEJZibjjDJTSMWlUKKkj30kq7hlUC2CepJ4v
+  x52qPcexcYZR7w==
+  -----END CERTIFICATE-----
+
+date: 2009-06-23 00:00:00 -07:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: rails_analyzer_tools
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.4.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: hoe
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 2.2.0
+    version: 
+description: |-
+  production_log_analyzer lets you find out which actions on a Rails
+  site are slowing you down.
+  
+  Bug reports:
+  
+  http://rubyforge.org/tracker/?func=add&group_id=1513&atid=5921
+email: 
+- drbrain@segment7.net
+executables: 
+- action_errors
+- action_grep
+- pl_analyze
+extensions: []
+
+extra_rdoc_files: 
+- History.txt
+- LICENSE.txt
+- Manifest.txt
+- README.txt
 files: 
 - History.txt
 - LICENSE.txt
@@ -47,38 +92,36 @@ files:
 - test/test_action_grep.rb
 - test/test_analyzer.rb
 - test/test_parser.rb
+has_rdoc: true
+homepage: http://seattlerb.rubyforge.org/production_log_analyzer
+licenses: []
+
+post_install_message: 
+rdoc_options: 
+- --main
+- README.txt
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+requirements: []
+
+rubyforge_project: seattlerb
+rubygems_version: 1.3.4
+signing_key: 
+specification_version: 3
+summary: production_log_analyzer lets you find out which actions on a Rails site are slowing you down
 test_files: 
 - test/test_action_grep.rb
 - test/test_analyzer.rb
 - test/test_parser.rb
-rdoc_options: []
-
-extra_rdoc_files: []
-
-executables: 
-- action_errors
-- action_grep
-- pl_analyze
-extensions: []
-
-requirements: []
-
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: rails_analyzer_tools
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 1.4.0
-    version: 
-- !ruby/object:Gem::Dependency 
-  name: hoe
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 1.2.0
-    version: