production_log_analyzer 1.1.0 → 1.2.0

data/README

@@ -26,7 +26,7 @@ http://rubyforge.org/frs/?group_id=586
 
 Either:
 
-A syslogd that doesn't suck.  This means that +man syslog.conf+ shows a
+A syslogd that doesn't suck.  This means that syslog.conf(5) shows a
 !prog specification.  (FreeBSD's syslogd doesn't suck, but OS X's syslogd
 does.)
 
@@ -62,60 +62,96 @@ If you want, you can run it from a cron something like this:
 
   /usr/bin/gzip -dc /var/log/production.log.0.gz | /usr/local/bin/pl_analyze /dev/stdin
 
+Or, have pl_analyze email you (which is preferred, because tabs get preserved):
+
+  /usr/bin/gzip -dc /var/log/production.log.0.gz | /usr/local/bin/pl_analyze /dev/stdin -e devnull@robotcoop.com -s "pl_analyze for `date -v-1d "+%D"`"
+
 In the future, pl_analyze will be able to read from STDIN.
 
 = Sample output
 
-  Average Request Time: 0.279874593327209
-  Request Time Std Dev: 0.351590385021209
-
-  Slowest Request Times:
-          ZeitgeistController#goals took 30.889858s
-          ZeitgeistController#goals took 29.657513s
-          EntriesController#save_comment took 20.499292s
-          AccountController#create took 19.539545s
-          EntriesController#save_comment took 15.46844s
-          ZeitgeistController#goals took 14.814086s
-          ZeitgeistController#goals took 13.943129s
-          ZeitgeistController#goals took 13.113908s
-          ZeitgeistController#completed_goals took 12.776777s
-          ZeitgeistController#goals took 12.32529s
-
-  Average DB Time: 0.0649204642242509
-  DB Time Std Dev: 0.214050667483775
-
-  Slowest Total DB Times:
-          ZeitgeistController#goals took 30.797014s
-          ZeitgeistController#goals took 29.567076s
-          ZeitgeistController#goals took 14.709733s
-          ZeitgeistController#goals took 13.84484s
-          ZeitgeistController#goals took 12.968071s
-          ZeitgeistController#completed_goals took 12.400506s
-          ZeitgeistController#goals took 12.241167s
-          ZeitgeistController#goals took 11.561719s
-          ZeitgeistController#goals took 11.445382s
-          ZeitgeistController#goals took 11.085795s
-
-  Average Render Time: 0.128757978789508
-  Render Time Std Dev: 0.131171213785894
-
-  Slowest Total Render Times:
-          TeamsController#progress took 4.698406s
-          TeamsController#progress took 4.679505s
-          PeopleController#doing_same_things took 3.628557s
-          ThingsController#view took 3.34039s
-          ThingsController#view took 2.096405s
-          RssController#goals took 1.759452s
-          EntriesController#view took 1.423261s
-          ThingsController#view took 1.422453s
-          ThingsController#people took 1.377157s
-          PeopleController#view took 1.195831s
+Request Times Summary:          Count   Avg     Std Dev Min     Max
+ALL REQUESTS:                   11      0.576   0.508   0.000   1.470
+
+ThingsController#view:          3       0.716   0.387   0.396   1.260
+TeamsController#progress:       2       0.841   0.629   0.212   1.470
+RssController#uber:             2       0.035   0.000   0.035   0.035
+PeopleController#progress:      2       0.489   0.489   0.000   0.977
+PeopleController#view:          2       0.731   0.371   0.360   1.102
+
+Average Request Time: 0.634
+Request Time Std Dev: 0.498
+
+Slowest Request Times:
+        TeamsController#progress took 1.470s
+        ThingsController#view took 1.260s
+        PeopleController#view took 1.102s
+        PeopleController#progress took 0.977s
+        ThingsController#view took 0.492s
+        ThingsController#view took 0.396s
+        PeopleController#view took 0.360s
+        TeamsController#progress took 0.212s
+        RssController#uber took 0.035s
+        RssController#uber took 0.035s
+
+------------------------------------------------------------------------
+
+DB Times Summary:               Count   Avg     Std Dev Min     Max
+ALL REQUESTS:                   11      0.366   0.393   0.000   1.144
+
+ThingsController#view:          3       0.403   0.362   0.122   0.914
+TeamsController#progress:       2       0.646   0.497   0.149   1.144
+RssController#uber:             2       0.008   0.000   0.008   0.008
+PeopleController#progress:      2       0.415   0.415   0.000   0.830
+PeopleController#view:          2       0.338   0.149   0.189   0.486
+
+Average DB Time: 0.402
+DB Time Std Dev: 0.394
+
+Slowest Total DB Times:
+        TeamsController#progress took 1.144s
+        ThingsController#view took 0.914s
+        PeopleController#progress took 0.830s
+        PeopleController#view took 0.486s
+        PeopleController#view took 0.189s
+        ThingsController#view took 0.173s
+        TeamsController#progress took 0.149s
+        ThingsController#view took 0.122s
+        RssController#uber took 0.008s
+        RssController#uber took 0.008s
+
+------------------------------------------------------------------------
+
+Render Times Summary:           Count   Avg     Std Dev Min     Max
+ALL REQUESTS:                   11      0.219   0.253   0.000   0.695
+
+ThingsController#view:          3       0.270   0.171   0.108   0.506
+TeamsController#progress:       2       0.000   0.000   0.000   0.000
+RssController#uber:             2       0.012   0.000   0.012   0.012
+PeopleController#progress:      2       0.302   0.302   0.000   0.604
+PeopleController#view:          2       0.487   0.209   0.278   0.695
+
+Average Render Time: 0.302
+Render Time Std Dev: 0.251
+
+Slowest Total Render Times:
+        PeopleController#view took 0.695s
+        PeopleController#progress took 0.604s
+        ThingsController#view took 0.506s
+        PeopleController#view took 0.278s
+        ThingsController#view took 0.197s
+        ThingsController#view took 0.108s
+        RssController#uber took 0.012s
+        RssController#uber took 0.012s
+        TeamsController#progress took 0.000s
+        TeamsController#progress took 0.000s
 
 = What's missing
 
 * More reports
 * Command line arguments including:
-  * Number of lines to report
+  * Help
   * What type of log file you've got (if somebody sends patches with tests)
+* Read from STDIN
 * Lots more
 

data/Rakefile

@@ -9,7 +9,7 @@ $VERBOSE = nil
 
 spec = Gem::Specification.new do |s|
     s.name = "production_log_analyzer"
-    s.version = "1.1.0"
+    s.version = "1.2.0"
     s.summary = "Extracts statistics from Rails production logs"
     s.author = "Eric Hodel"
     s.email = "hodel@robotcoop.com"

data/bin/pl_analyze

@@ -5,46 +5,31 @@ require 'production_log/analyzer'
 file_name = ARGV.shift
 
 if file_name.nil? then
-  puts "Usage: #{$0} file_name"
+  puts "Usage: #{$0} file_name [-e email_recipient [-s subject]] [count]"
   exit 1
 end
 
-analyzer = Analyzer.new file_name
-analyzer.process
+email_recipient = nil
+subject = nil
 
-count = ARGV.shift
-count = count.nil? ? 10 : count.to_i
-
-request_times = analyzer.slowest_request_times(count).map do |time, name|
-  "\t#{name} took #{time}s"
+if ARGV.first == '-e' then
+  ARGV.shift # -e
+  email_recipient = ARGV.shift
 end
 
-puts "Average Request Time: #{analyzer.average_request_time}"
-puts "Request Time Std Dev: #{analyzer.request_time_std_dev}"
-puts
-puts "Slowest Request Times:"
-puts request_times.join($/)
-puts
-
-db_times = analyzer.slowest_db_times(count).map do |time, name|
-  "\t#{name} took #{time}s"
+if email_recipient and ARGV.first == '-s' then
+  ARGV.shift # -s
+  subject = ARGV.shift
 end
 
-puts "Average DB Time: #{analyzer.average_db_time}"
-puts "DB Time Std Dev: #{analyzer.db_time_std_dev}"
-puts
-puts "Slowest Total DB Times:"
-puts db_times.join($/)
-puts
-
-render_times = analyzer.slowest_render_times(count).map do |time, name|
-  "\t#{name} took #{time}s"
+count = ARGV.shift
+count = count.nil? ? 10 : Integer(count)
+
+if email_recipient.nil? then
+  analyzer = Analyzer.new file_name
+  analyzer.process
+  puts analyzer.report(count)
+else
+  Analyzer.email file_name, email_recipient, subject, count
 end
 
-puts "Average Render Time: #{analyzer.average_render_time}"
-puts "Render Time Std Dev: #{analyzer.render_time_std_dev}"
-puts
-puts "Slowest Total Render Times:"
-puts render_times.join($/)
-puts
-

data/lib/production_log/analyzer.rb

@@ -1,4 +1,4 @@
-#!/usr/local/bin/ruby -w
+$TESTING = false unless defined? $TESTING
 
 require 'production_log/parser'
 
@@ -131,7 +131,36 @@ class Analyzer
 
     attr_reader :render_times
 
-#    attr_reader :query_times
+    ##
+    # Generates and sends an email report with lots of fun stuff in it.  This
+    # way, Mail.app will behave when given tabs (I hope).
+
+    def self.email(file_name, recipient, subject, count = 10)
+        analyzer = self.new file_name
+        analyzer.process
+        body = analyzer.report(count)
+
+        email = self.envelope(recipient, subject)
+        email << nil
+        email << "<pre>#{body}</pre>"
+        email = email.join($/) << $/
+
+        return email if $TESTING
+
+        IO.popen("/usr/sbin/sendmail -i -t", "w+") do |sm|
+            sm.print email
+            sm.flush
+        end
+    end
+
+    def self.envelope(recipient, subject = nil) # :nodoc:
+        envelope = {}
+        envelope['To'] = recipient
+        envelope['Subject'] = subject || "pl_analyze"
+        envelope['Content-Type'] = "text/html"
+
+        return envelope.map { |(k,v)| "#{k}: #{v}" }
+    end
 
     ##
     # Creates a new Analyzer that will read data from +logfile_name+.
@@ -154,9 +183,6 @@ class Analyzer
                 @request_times[entry_page] << entry.request_time
                 @db_times[entry_page] << entry.db_time
                 @render_times[entry_page] << entry.render_time
-#                entry.queries.each do |name, time, sql|
-#                    @query_times[entry_page] << time 
-#                end
             end
         end
     end
@@ -165,93 +191,166 @@ class Analyzer
     # The average total request time for all requests.
 
     def average_request_time
-        times = @request_times.values.flatten
-        times.delete 0
-        return times.average
+        return time_average(@request_times)
     end
 
     ##
     # The standard deviation of the total request time for all requests.
 
     def request_time_std_dev
-        times = @request_times.values.flatten
-        times.delete 0
-        return times.standard_deviation
+        return time_std_dev(@request_times)
     end
 
     ##
     # The +limit+ slowest total request times.
 
     def slowest_request_times(limit = 10)
-        slowest_times = SlowestTimes.new limit
-
-        @request_times.each do |name, times|
-            times.each do |time|
-                slowest_times << [time, name]
-            end
-        end
-
-        return slowest_times.sort_by { |time, name| time }.reverse
+        return slowest_times(@request_times, limit)
     end
 
     ##
     # The average total database time for all requests.
 
     def average_db_time
-        times = @db_times.values.flatten
-        times.delete 0
-        return times.average
+        return time_average(@db_times)
     end
 
     ##
     # The standard deviation of the total database time for all requests.
 
     def db_time_std_dev
-        times = @db_times.values.flatten
-        times.delete 0
-        return times.standard_deviation
+        return time_std_dev(@db_times)
     end
 
     ##
     # The +limit+ slowest total database times.
 
     def slowest_db_times(limit = 10)
-        slowest_times = SlowestTimes.new limit
-
-        @db_times.each do |name, times|
-            times.each do |time|
-                slowest_times << [time, name]
-            end
-        end
-
-        return slowest_times.sort_by { |time, name| time }.reverse
+        return slowest_times(@db_times, limit)
     end
 
     ##
     # The average total render time for all requests.
 
     def average_render_time
-        times = @render_times.values.flatten
-        times.delete 0
-        return times.average
+        return time_average(@render_times)
     end
 
     ##
     # The standard deviation of the total render time for all requests.
 
     def render_time_std_dev
-        times = @render_times.values.flatten
-        times.delete 0
-        return times.standard_deviation
+        return time_std_dev(@render_times)
     end
 
     ##
     # The +limit+ slowest total render times for all requests.
 
     def slowest_render_times(limit = 10)
+        return slowest_times(@render_times, limit)
+    end
+
+    ##
+    # A list of count/min/max/avg/std dev for request times.
+
+    def request_times_summary
+        return summarize("Request Times", @request_times)
+    end
+
+    ##
+    # A list of count/min/max/avg/std dev for database times.
+
+    def db_times_summary
+        return summarize("DB Times", @db_times)
+    end
+
+    ##
+    # A list of count/min/max/avg/std dev for request times.
+
+    def render_times_summary
+        return summarize("Render Times", @render_times)
+    end
+
+    ##
+    # Builds a report containing +count+ slow items.
+
+    def report(count)
+        text = []
+
+        text << request_times_summary
+        text << nil
+        text << "Average Request Time: #{'%0.3f' % average_request_time}"
+        text << "Request Time Std Dev: #{'%0.3f' % request_time_std_dev}"
+        text << nil
+        text << "Slowest Request Times:"
+        slowest_request_times(count).each do |time, name|
+            text << "\t#{name} took #{'%0.3f' % time}s"
+        end
+        text << nil
+        text << "-" * 72
+        text << nil
+
+        text << db_times_summary
+        text << nil
+        text << "Average DB Time: #{'%0.3f' % average_db_time}"
+        text << "DB Time Std Dev: #{'%0.3f' % db_time_std_dev}"
+        text << nil
+        text << "Slowest Total DB Times:"
+        slowest_db_times(count).each do |time, name|
+            text << "\t#{name} took #{'%0.3f' % time}s"
+        end
+        text << nil
+        text << "-" * 72
+        text << nil
+
+
+        text << render_times_summary
+        text << nil
+        text << "Average Render Time: #{'%0.3f' % average_render_time}"
+        text << "Render Time Std Dev: #{'%0.3f' % render_time_std_dev}"
+        text << nil
+        text << "Slowest Total Render Times:"
+        slowest_render_times(count).each do |time, name|
+            text << "\t#{name} took #{'%0.3f' % time}s"
+        end
+        text << nil
+
+        return text.join($/)
+    end
+
+    private unless $TESTING
+
+    def summarize(title, records) # :nodoc:
+        record = nil
+        list = []
+
+        records.sort_by { |k,v| v.size}.reverse_each do |req, times|
+            record = [times.average, times.standard_deviation,
+                      times.min, times.max]
+            record.map! { |v| "%0.3f" % v }
+            record.unshift ["#{pad_request_name req}", times.size]
+            list << record.join("\t")
+        end
+
+        list.unshift nil
+
+        times = records.values.flatten
+        record = [times.average, times.standard_deviation, times.min, times.max]
+        record.map! { |v| "%0.3f" % v }
+        record.unshift [pad_request_name('ALL REQUESTS'), times.size]
+        list.unshift record.join("\t")
+
+        record = [pad_request_name("#{title} Summary"), 'Count', 'Avg',
+                  'Std Dev', 'Min', 'Max']
+        list.unshift record.join("\t")
+
+        return list.join("\n")
+    end
+
+    def slowest_times(records, limit) # :nodoc:
         slowest_times = SlowestTimes.new limit
 
-        @render_times.each do |name, times|
+        records.each do |name, times|
             times.each do |time|
                 slowest_times << [time, name]
             end
@@ -260,6 +359,27 @@ class Analyzer
         return slowest_times.sort_by { |time, name| time }.reverse
     end
 
+    def time_average(records) # :nodoc:
+        times = records.values.flatten
+        times.delete 0
+        return times.average
+    end
+
+    def time_std_dev(records) # :nodoc:
+        times = records.values.flatten
+        times.delete 0
+        return times.standard_deviation
+    end
+
+    def longest_request_name # :nodoc:
+        @longest_req ||= @request_times.keys.map { |name| name.length + 1 }.max
+    end
+
+    def pad_request_name(name) # :nodoc:
+        name = name.dup << ':'
+        name += (' ' * (longest_request_name - name.length))
+    end
+
 end
 
 # vim: ts=4 sts=4 sw=4

data/test/test_analyzer.rb

@@ -1,5 +1,7 @@
 #!/usr/local/bin/ruby -w
 
+$TESTING = true
+
 require 'test/unit'
 
 require 'production_log/analyzer'
@@ -85,6 +87,120 @@ class TestAnalyzer < Test::Unit::TestCase
         @analyzer.process
     end
 
+    def test_self_email
+      email = Analyzer.email('test/test.syslog.log', 'devnull@robotcoop.com',
+                             nil, 1)
+      expected = <<-EOF
+Subject: pl_analyze
+To: devnull@robotcoop.com
+Content-Type: text/html
+
+<pre>Request Times Summary:    	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
+
+ThingsController#view:    	3	0.716	0.387	0.396	1.260
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+PeopleController#progress:	2	0.489	0.489	0.000	0.977
+PeopleController#view:    	2	0.731	0.371	0.360	1.102
+
+Average Request Time: 0.634
+Request Time Std Dev: 0.498
+
+Slowest Request Times:
+	TeamsController#progress took 1.470s
+
+------------------------------------------------------------------------
+
+DB Times Summary:         	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
+
+ThingsController#view:    	3	0.403	0.362	0.122	0.914
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+PeopleController#progress:	2	0.415	0.415	0.000	0.830
+PeopleController#view:    	2	0.338	0.149	0.189	0.486
+
+Average DB Time: 0.402
+DB Time Std Dev: 0.394
+
+Slowest Total DB Times:
+	TeamsController#progress took 1.144s
+
+------------------------------------------------------------------------
+
+Render Times Summary:     	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
+
+ThingsController#view:    	3	0.270	0.171	0.108	0.506
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+PeopleController#progress:	2	0.302	0.302	0.000	0.604
+PeopleController#view:    	2	0.487	0.209	0.278	0.695
+
+Average Render Time: 0.302
+Render Time Std Dev: 0.251
+
+Slowest Total Render Times:
+	PeopleController#view took 0.695s
+</pre>
+      EOF
+
+      assert_equal expected, email
+    end
+
+    def test_self_envelope
+      expected = [
+        "Subject: pl_analyze",
+        "To: devnull@example.com",
+        "Content-Type: text/html"
+      ]
+
+      assert_equal expected, Analyzer.envelope('devnull@example.com')
+    end
+
+    def test_self_envelope_subject
+      expected = [
+        "Subject: happy fancy boom",
+        "To: devnull@example.com",
+        "Content-Type: text/html"
+      ]
+
+      assert_equal(expected,
+                   Analyzer.envelope('devnull@example.com', 'happy fancy boom'))
+    end
+
+    def test_average_db_time
+        assert_in_delta 0.4023761, @analyzer.average_db_time, 0.0000001
+    end
+
+    def test_average_render_time
+        assert_in_delta 0.3015584, @analyzer.average_render_time, 0.0000001
+    end
+
+    def test_average_request_time
+        assert_in_delta 0.6338176, @analyzer.average_request_time, 0.0000001
+    end
+
+    def test_db_time_std_dev
+        assert_in_delta 0.3941380, @analyzer.db_time_std_dev, 0.0000001
+    end
+
+    def test_db_times_summary
+      expected = <<EOF.strip
+DB Times Summary:         	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
+
+ThingsController#view:    	3	0.403	0.362	0.122	0.914
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+PeopleController#progress:	2	0.415	0.415	0.000	0.830
+PeopleController#view:    	2	0.338	0.149	0.189	0.486
+EOF
+
+      assert_equal expected, @analyzer.db_times_summary
+    end
+
     def test_logfile_name
         assert_equal 'test/test.syslog.log', @analyzer.logfile_name
     end
@@ -122,25 +238,126 @@ class TestAnalyzer < Test::Unit::TestCase
 #        assert_equal expected_query_times, @analyzer.query_times
     end
 
-    def test_slowest_request_times
-        times = @analyzer.slowest_request_times 3
-        assert_equal 3, times.length
-        expected = [
-            [1.469788, "TeamsController#progress"],
-            [1.259728, "ThingsController#view"],
-            [1.102098, "PeopleController#view"]
-        ]
-        assert_equal expected, times
+    def test_render_time_std_dev
+        assert_in_delta 0.2513925, @analyzer.render_time_std_dev, 0.0000001
     end
 
-    def test_average_request_time
-        assert_in_delta 0.6338176, @analyzer.average_request_time, 0.0000001
+    def test_render_times_summary
+      expected = <<EOF.strip
+Render Times Summary:     	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
+
+ThingsController#view:    	3	0.270	0.171	0.108	0.506
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+PeopleController#progress:	2	0.302	0.302	0.000	0.604
+PeopleController#view:    	2	0.487	0.209	0.278	0.695
+EOF
+
+      assert_equal expected, @analyzer.render_times_summary
+    end
+
+    def test_report
+      expected = <<-EOF
+Request Times Summary:    	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
+
+ThingsController#view:    	3	0.716	0.387	0.396	1.260
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+PeopleController#progress:	2	0.489	0.489	0.000	0.977
+PeopleController#view:    	2	0.731	0.371	0.360	1.102
+
+Average Request Time: 0.634
+Request Time Std Dev: 0.498
+
+Slowest Request Times:
+	TeamsController#progress took 1.470s
+	ThingsController#view took 1.260s
+	PeopleController#view took 1.102s
+	PeopleController#progress took 0.977s
+	ThingsController#view took 0.492s
+	ThingsController#view took 0.396s
+	PeopleController#view took 0.360s
+	TeamsController#progress took 0.212s
+	RssController#uber took 0.035s
+	RssController#uber took 0.035s
+
+------------------------------------------------------------------------
+
+DB Times Summary:         	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
+
+ThingsController#view:    	3	0.403	0.362	0.122	0.914
+TeamsController#progress: 	2	0.646	0.497	0.149	1.144
+RssController#uber:       	2	0.008	0.000	0.008	0.008
+PeopleController#progress:	2	0.415	0.415	0.000	0.830
+PeopleController#view:    	2	0.338	0.149	0.189	0.486
+
+Average DB Time: 0.402
+DB Time Std Dev: 0.394
+
+Slowest Total DB Times:
+	TeamsController#progress took 1.144s
+	ThingsController#view took 0.914s
+	PeopleController#progress took 0.830s
+	PeopleController#view took 0.486s
+	PeopleController#view took 0.189s
+	ThingsController#view took 0.173s
+	TeamsController#progress took 0.149s
+	ThingsController#view took 0.122s
+	RssController#uber took 0.008s
+	RssController#uber took 0.008s
+
+------------------------------------------------------------------------
+
+Render Times Summary:     	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
+
+ThingsController#view:    	3	0.270	0.171	0.108	0.506
+TeamsController#progress: 	2	0.000	0.000	0.000	0.000
+RssController#uber:       	2	0.012	0.000	0.012	0.012
+PeopleController#progress:	2	0.302	0.302	0.000	0.604
+PeopleController#view:    	2	0.487	0.209	0.278	0.695
+
+Average Render Time: 0.302
+Render Time Std Dev: 0.251
+
+Slowest Total Render Times:
+	PeopleController#view took 0.695s
+	PeopleController#progress took 0.604s
+	ThingsController#view took 0.506s
+	PeopleController#view took 0.278s
+	ThingsController#view took 0.197s
+	ThingsController#view took 0.108s
+	RssController#uber took 0.012s
+	RssController#uber took 0.012s
+	TeamsController#progress took 0.000s
+	TeamsController#progress took 0.000s
+      EOF
+
+      assert_equal expected, @analyzer.report(10)
     end
 
     def test_request_time_std_dev
         assert_in_delta 0.4975667, @analyzer.request_time_std_dev, 0.0000001
     end
 
+    def test_request_times_summary
+      expected = <<EOF.strip
+Request Times Summary:    	Count	Avg	Std Dev	Min	Max
+ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
+
+ThingsController#view:    	3	0.716	0.387	0.396	1.260
+TeamsController#progress: 	2	0.841	0.629	0.212	1.470
+RssController#uber:       	2	0.035	0.000	0.035	0.035
+PeopleController#progress:	2	0.489	0.489	0.000	0.977
+PeopleController#view:    	2	0.731	0.371	0.360	1.102
+EOF
+
+      assert_equal expected, @analyzer.request_times_summary
+    end
+
     def test_slowest_db_times
         times = @analyzer.slowest_db_times 3
         assert_equal 3, times.length
@@ -152,12 +369,15 @@ class TestAnalyzer < Test::Unit::TestCase
         assert_equal expected, times
     end
 
-    def test_average_db_time
-        assert_in_delta 0.4023761, @analyzer.average_db_time, 0.0000001
-    end
-
-    def test_db_time_std_dev
-        assert_in_delta 0.3941380, @analyzer.db_time_std_dev, 0.0000001
+    def test_slowest_request_times
+        times = @analyzer.slowest_request_times 3
+        assert_equal 3, times.length
+        expected = [
+            [1.469788, "TeamsController#progress"],
+            [1.259728, "ThingsController#view"],
+            [1.102098, "PeopleController#view"]
+        ]
+        assert_equal expected, times
     end
 
     def test_slowest_render_times
@@ -171,13 +391,5 @@ class TestAnalyzer < Test::Unit::TestCase
         assert_equal expected, times
     end
 
-    def test_average_render_time
-        assert_in_delta 0.3015584, @analyzer.average_render_time, 0.0000001
-    end
-
-    def test_render_time_std_dev
-        assert_in_delta 0.2513925, @analyzer.render_time_std_dev, 0.0000001
-    end
-
 end
 

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.8.6
+rubygems_version: 0.8.10
 specification_version: 1
 name: production_log_analyzer
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
-date: 2005-03-30
+  version: 1.2.0
+date: 2005-05-10
 summary: Extracts statistics from Rails production logs
 require_paths: 
   - lib