producer-core 0.3.6 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7eb43f3bef9d4d62b0d7b1b74a2c8e71f58410e2
-  data.tar.gz: ec652f99e4273ba9f603bcbc8e602abbbf583437
+  metadata.gz: b765ca3e62a5f6d52c70023568a7ff479eb90fb4
+  data.tar.gz: c742add987d14bc54d14933bf560d236e89f3be0
 SHA512:
-  metadata.gz: 8e6d71a688e80c7a9e806c67de3f917dd51fb322af9dfb8f45379980579894423c149812e2f653dba3d11f460dce998ed9422c035c069d535d3857f133be081c
-  data.tar.gz: 3ea4adbcebff73ab03680bee2f3c579df399738c6a5c638fdbd08755262bb219efd6fcdfc2be81d5f2f577b044bd9fdbf5ac0c3035db02de1e75959497537588
+  metadata.gz: a59aea6fc1ea7fc7ce56b0ce33adbd53095d895945f2a036a2057b2b9f9b5460047d92b94a5f20866b20756d39511ab38e032dca792f85e5b786d73995028792
+  data.tar.gz: dd3ef0d2f879a4d9e1dd4b1bd3cb2747c390070f9d7544db077d044aa76dda67e11883ff08b45e79042fba471a6ca2bf351e625f7ee67457b4d9272f74f0b959

data/features/action_mkdir.feature

@@ -19,3 +19,13 @@ Feature: `mkdir' task action
     When I successfully execute the recipe on remote target
     Then the remote directory "some_directory_0700" must have 0700 mode
     And  the remote directory "some_directory_0500" must have 0500 mode
+
+  Scenario: creates directories recursively
+    Given a recipe with:
+      """
+      task :mkdir_action do
+        mkdir 'some/directory'
+      end
+      """
+    When I successfully execute the recipe on remote target
+    Then the remote directory "some/directory" must exists

data/features/recipe_target.feature

@@ -10,4 +10,14 @@ Feature: `target' recipe keyword
       end
       """
     When I successfully execute the recipe
-    Then the output must contain exactly "some_host.example\n"
+    Then the output must contain "some_host.example"
+
+  Scenario: returns current target when no arguments are provided
+    Given a recipe with:
+      """
+      target 'some_host.example'
+
+      env.output.puts target
+      """
+    When I successfully execute the recipe
+    Then the output must contain "some_host.example"

data/lib/producer/core/actions/mkdir.rb

@@ -7,14 +7,16 @@ module Producer
         end
 
         def apply
-          case arguments.size
-          when 1
-            fs.mkdir path
-          when 2
-            fs.mkdir path, mode
+          Pathname.new(path).descend do |p|
+            next if fs.dir? p
+            fs.mkdir p.to_s
+            fs.chmod p.to_s, mode if mode
           end
         end
 
+
+        private
+
         def path
           arguments.first
         end

data/lib/producer/core/recipe.rb

@@ -26,8 +26,8 @@ module Producer
         instance_eval File.read("./#{filepath}.rb"), "#{filepath}.rb"
       end
 
-      def target(hostname)
-        env.target ||= hostname
+      def target(hostname = nil)
+        if hostname then env.target ||= hostname else env.target end
       end
 
       def task(name, *args, &block)

data/lib/producer/core/remote/fs.rb

@@ -20,6 +20,10 @@ module Producer
           false
         end
 
+        def chmod(path, mode)
+          sftp.setstat! path, permissions: mode
+        end
+
         def mkdir(path, mode = nil)
           options = mode ? { permissions: mode } : {}
           sftp.mkdir! path, options

data/lib/producer/core/version.rb

@@ -1,5 +1,5 @@
 module Producer
   module Core
-    VERSION = '0.3.6'.freeze
+    VERSION = '0.3.7'.freeze
   end
 end

data/lib/producer/core.rb

@@ -1,6 +1,7 @@
+require 'etc'
 require 'forwardable'
+require 'pathname'
 
-require 'etc'
 require 'net/ssh'
 require 'net/sftp'
 

data/spec/producer/core/actions/mkdir_spec.rb

@@ -9,6 +9,8 @@ module Producer::Core
       it_behaves_like 'action'
 
       describe '#apply' do
+        before { allow(remote_fs).to receive(:dir?) { false } }
+
         it 'creates directory on remote filesystem' do
           expect(remote_fs).to receive(:mkdir).with(path)
           mkdir.apply
@@ -17,29 +19,28 @@ module Producer::Core
         context 'when a mode was given' do
           subject(:mkdir) { Mkdir.new(env, path, 0700) }
 
-          it 'creates the directory with given mode' do
-            expect(remote_fs).to receive(:mkdir).with(anything, 0700)
+          it 'changes the directory with given mode' do
+            expect(remote_fs).to receive(:chmod).with(path, 0700)
             mkdir.apply
           end
         end
-      end
 
-      describe '#path' do
-        it 'returns the path' do
-          expect(mkdir.path).to eq path
-        end
-      end
+        context 'when parent directories does not exists' do
+          let(:path) { 'some/path' }
 
-      describe '#mode' do
-        it 'returns nil' do
-          expect(mkdir.mode).to be nil
+          it 'creates parent directories' do
+            expect(remote_fs).to receive(:mkdir).with('some').ordered
+            expect(remote_fs).to receive(:mkdir).with('some/path').ordered
+            mkdir.apply
+          end
         end
 
-        context 'when a mode was given' do
-          subject(:mkdir) { Mkdir.new(env, path, 0700) }
+        context 'when directory already exists' do
+          before { allow(remote_fs).to receive(:dir?) { true } }
 
-          it 'returns the mode' do
-            expect(mkdir.mode).to be 0700
+          it 'creates directory on remote filesystem' do
+            expect(remote_fs).not_to receive(:mkdir)
+            mkdir.apply
           end
         end
       end

data/spec/producer/core/recipe_spec.rb

@@ -38,6 +38,13 @@ module Producer::Core
           expect { recipe.target host }.not_to change { env.target }
         end
       end
+
+      context 'when no arguments are provided' do
+        it 'returns current target' do
+          recipe.target host
+          expect(recipe.target).to eq host
+        end
+      end
     end
 
     describe '#task' do

data/spec/support/test_env_helpers.rb

@@ -36,7 +36,7 @@ module TestEnvHelpers
   end
 
   def build_remote
-    fs = RSpec::Mocks::Double.new('remote fs')
+    fs = instance_spy Producer::Core::Remote::FS
     remote = Producer::Core::Testing::MockRemote.new('some_host.test')
     remote.define_singleton_method(:fs) { fs }
     remote

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: producer-core
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.3.7
 platform: ruby
 authors:
 - Thibault Jouan