producer-core 0.2.8 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4762ed57bd74293a1017f2ca3410b27642eae90
-  data.tar.gz: ad1cd8fa2f52b877951503497c5207eb8a39c92e
+  metadata.gz: 0288c1cd99933e1e53201413bc0d8c90a6229204
+  data.tar.gz: 5d7aaef70745ce1b3396d775adfa94328a092151
 SHA512:
-  metadata.gz: f3b81d877cf394644a533673c78f11078446c0f2392178e258e3496eb9a9d29420b017c26efde01250f4f924ecff163a75e9bf92b92f04828c2dba70f3705e6a
-  data.tar.gz: 02368fc9778bded5100a90a28e1e6ec3bebc1941db706581151d829d6042e9e7ff3a1cd1fea343b0aaed73237d7e58f6e173cbff8a4b25a24a418186fd1a14c8
+  metadata.gz: 2ca8cfca02bec39f6732bf697a2d9111119864c4e7a96176fb87669f0fc5215bb8ffd319cf5e39b90fdf984fb7edb3cfe22f75200f9e464ea89a73585cb60dac
+  data.tar.gz: 4786539f7a836eee916c4e278ba8b4206d32b5a6349c5c98e85609c638ce86b99300aa3295fab4d80e5c77cd8f8926a2fa32618beaa638b2fde8bed8c4a5011d

data/features/cli_dry_run.feature

@@ -1,11 +1,17 @@
 Feature: CLI dry run option
 
-  Scenario: perfoms a trial run without applying actions
+  Background:
     Given a recipe with:
       """
       task :say_hello do
         echo 'hello'
       end
       """
+
+  Scenario: perfoms a trial run without applying actions
     When I successfully execute the recipe with option -n
     Then the output must not contain "hello"
+
+  Scenario: prints a warning before any output
+    When I successfully execute the recipe with option -n
+    Then the output must match /\AWarning: running in dry run mode, actions will NOT be applied/

data/lib/producer/core/env.rb

@@ -27,14 +27,14 @@ module Producer
       def logger
         @logger ||= begin
           logger = Logger.new(output)
-          logger.level = verbose? ? Logger::INFO : Logger::ERROR
+          logger.level = verbose? ? Logger::INFO : Logger::WARN
           logger.formatter = LoggerFormatter.new
           logger
         end
       end
 
-      def log(message)
-        logger.info message
+      def log(message, severity = :info)
+        logger.send severity, message
       end
 
       def verbose?

data/lib/producer/core/logger_formatter.rb

@@ -2,7 +2,14 @@ module Producer
   module Core
     class LoggerFormatter < Logger::Formatter
       def call(severity, datetime, progname, message)
-        message + "\n"
+        prefix(severity) + message + "\n"
+      end
+
+
+      private
+
+      def prefix(severity)
+        severity == 'WARN' ? 'Warning: ' : ''
       end
     end
   end

data/lib/producer/core/version.rb

@@ -1,5 +1,5 @@
 module Producer
   module Core
-    VERSION = '0.2.8'.freeze
+    VERSION = '0.2.9'.freeze
   end
 end

data/lib/producer/core/worker.rb

@@ -1,6 +1,9 @@
 module Producer
   module Core
     class Worker
+      DRY_RUN_WARNING =
+        'running in dry run mode, actions will NOT be applied'.freeze
+
       attr_accessor :env
 
       def initialize(env)
@@ -8,6 +11,8 @@ module Producer
       end
 
       def process(tasks)
+        env.log DRY_RUN_WARNING, :warn if env.dry_run?
+
         tasks.each { |t| process_task t }
       end
 

data/spec/producer/core/env_spec.rb

@@ -113,8 +113,8 @@ module Producer::Core
         expect(output.string).to include 'some message'
       end
 
-      it 'has a log level of ERROR' do
-        expect(env.logger.level).to eq Logger::ERROR
+      it 'has a log level of WARN' do
+        expect(env.logger.level).to eq Logger::WARN
       end
 
       it 'uses our formatter' do
@@ -135,6 +135,13 @@ module Producer::Core
         expect(env.logger).to receive(:info).with 'message'
         env.log 'message'
       end
+
+      context 'when second argument is :warn' do
+        it 'logs a warning message through the assigned logger' do
+          expect(env.logger).to receive(:warn).with 'message'
+          env.log 'message', :warn
+        end
+      end
     end
 
     describe '#verbose?' do

data/spec/producer/core/logger_formatter_spec.rb

@@ -13,6 +13,14 @@ module Producer::Core
       it 'returns the given message with a line separator' do
         expect(subject).to eq "#{message}\n"
       end
+
+      context 'when severity is WARN' do
+        let(:severity) { 'WARN' }
+
+        it 'prefix the message with `Warning:\'' do
+          expect(subject).to match /\AWarning: #{message}/
+        end
+      end
     end
   end
 end

data/spec/producer/core/worker_spec.rb

@@ -10,6 +10,18 @@ module Producer::Core
         expect(worker).to receive(:process_task).with(:some_task)
         worker.process [:some_task]
       end
+
+      context 'when dry run is enabled' do
+        before { allow(env).to receive(:dry_run?) { true } }
+
+        it 'warns dry run is enabled' do
+          expect(env).to receive(:log).with(
+            /\Arunning in dry run mode, actions will NOT be applied\z/,
+            :warn
+          )
+          worker.process []
+        end
+      end
     end
 
     describe '#process_task' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: producer-core
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors:
 - Thibault Jouan