producer-core 0.2.11 → 0.2.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8faaa83c5e385860c285a917432f88805b1445d
-  data.tar.gz: b52d94053b00d17230c749c322951a9bb827cf62
+  metadata.gz: 993830c5ed30225fe7333275a8eb33f39b000448
+  data.tar.gz: 74554e80ba1c4bfd0d1b7f23421e8fec68197693
 SHA512:
-  metadata.gz: f6b3876fbe282f363d89b8fde05c0c39d9631e13cb64fa42b7bc5fae4773b76ceba55895906afa1a51b34429de16b5ca24cb75ba3f68d78222cd9148fe0e26ad
-  data.tar.gz: 4ad7ba7ef20948f5ad4ddc795fb7a6a075f5de6fd06591e86edd8b8114e20e5aa22c405652c074b5624915f44223de00dd250071997146d4baaa7b942173adb2
+  metadata.gz: 133378dc481c5f5bbdd899d37aa4519a2e5f4dfcb3b771b44254bed19bbb8275940d192bef19705e2187b30d9dfe9a5ee9fabd1d0ce91c516c3fd27dd1346c1d
+  data.tar.gz: 41ee1449668ed09cad36e08274ee81ddd318f29d2b3e0dfc884ce5b7f7cf54c955525200afdc09a4945fcf812ba1fc3ed5c62c3dc108bec09f8f8f34c4715111

data/features/cli_verbose.feature

@@ -16,8 +16,8 @@ Feature: CLI verbose option
 
   Scenario: prints tasks name
     When I successfully execute the recipe with option -v
-    Then the output must match /^Task:.+`task_ok'/
-    And  the output must match /^Task:.+`task_ko'/
+    Then the output must match /Task:.+`task_ok'/
+    And  the output must match /Task:.+`task_ko'/
 
   Scenario: appends `applying' or `skipped' after tasks name
     When I successfully execute the recipe with option -v
@@ -28,6 +28,16 @@ Feature: CLI verbose option
     When I successfully execute the recipe with option -v
     Then the output must match /^ action: echo/
 
-  Scenario: formats message with our simple logger
+  Scenario: prints actions arguments
     When I successfully execute the recipe with option -v
-    Then the output must match /\ATask:/
+    Then the output must match /echo \["some message"\]/
+
+  Scenario: summarizes printed actions arguments
+    Given a recipe with:
+      """
+      task :some_task do
+        echo 'long message ' * 32
+      end
+      """
+    When I successfully execute the recipe with option -v
+    Then the output must match /action: .{,70}$/

data/lib/producer/core/action.rb

@@ -1,6 +1,8 @@
 module Producer
   module Core
     class Action
+      INSPECT_ARGUMENTS_SUM_LEN = 68.freeze
+
       extend Forwardable
       def_delegators :@env, :input, :output, :error_output, :remote
       def_delegators :remote, :fs
@@ -17,7 +19,14 @@ module Producer
       end
 
       def to_s
-        name
+        [name, inspect_arguments].join ' '
+      end
+
+
+      private
+
+      def inspect_arguments
+        @arguments.inspect[0, INSPECT_ARGUMENTS_SUM_LEN - name.length]
       end
     end
   end

data/lib/producer/core/version.rb

@@ -1,5 +1,5 @@
 module Producer
   module Core
-    VERSION = '0.2.11'.freeze
+    VERSION = '0.2.12'.freeze
   end
 end

data/lib/producer/core/worker.rb

@@ -20,7 +20,7 @@ module Producer
         if task.condition_met?
           env.log "Task: `#{task}' applying..."
           task.actions.each do |e|
-            env.log " action: #{e} applying"
+            env.log " action: #{e}"
             e.apply unless env.dry_run?
           end
         else

data/producer-core.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'net-ssh',   '~> 2.7'
   s.add_dependency 'net-sftp',  '~> 2.1'
 
-  s.add_development_dependency 'rspec',         '~> 2.14'
+  s.add_development_dependency 'rspec',         '~> 3.1'
   s.add_development_dependency 'cucumber',      '~> 1.3'
   s.add_development_dependency 'aruba',         '~> 0.5'
   s.add_development_dependency 'cucumber-sshd', '~> 0.1'

data/spec/producer/core/remote_spec.rb

@@ -71,7 +71,8 @@ module Producer::Core
       let(:sftp_session) { double 'sftp session' }
 
       it 'returns an FS instance built with a new sftp session' do
-        remote.stub_chain(:session, :sftp, :connect) { sftp_session }
+        allow(remote)
+          .to receive_message_chain(:session, :sftp, :connect) { sftp_session }
         expect(remote.fs.sftp).to be sftp_session
       end
     end

data/spec/spec_helper.rb

@@ -4,8 +4,6 @@ Dir['spec/support/**/*.rb'].map { |e| require e.gsub 'spec/', '' }
 
 
 RSpec.configure do |c|
-  c.treat_symbols_as_metadata_keys_with_true_values = true
-
   c.include TestEnvHelpers, :env
 
   c.include NetSSHStoryHelpers, :ssh

data/spec/support/shared_action.rb

@@ -54,8 +54,20 @@ module Producer::Core
     end
 
     describe '#to_s' do
-      it 'returns a word' do
-        expect(action.to_s).to eq action.name
+      it 'includes action name' do
+        expect(action.to_s).to match /\A#{action.name}/
+      end
+
+      it 'includes arguments inspection' do
+        expect(action.to_s).to match /#{Regexp.quote(arguments.inspect)}\z/
+      end
+
+      context 'when arguments inspection is very long' do
+        let(:arguments)   { [:some, :arguments] * 32 }
+
+        it 'summarizes arguments inspection' do
+          expect(action.to_s.length).to be < 70
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: producer-core
 version: !ruby/object:Gem::Version
-  version: 0.2.11
+  version: 0.2.12
 platform: ruby
 authors:
 - Thibault Jouan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-24 00:00:00.000000000 Z
+date: 2014-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ssh
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement