producer-core 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9dca497744fe5fa26c09753548310eb42414a25
-  data.tar.gz: 212301a43272758c9624d5e0d2556ced790c17b3
+  metadata.gz: 2806c20d86e7d0aa08f72a3005b5ee5456cad346
+  data.tar.gz: 4c75c67cd9815e30849302aeb9021dcbaf4721a7
 SHA512:
-  metadata.gz: 7f456c2225b377db0d58df63d3207fce98a103d18501a0d30969fc75c243c094888ba667dfa109cfb1aef878243fa161a5e800dfe0941bfda7c98dd760bce8ee
-  data.tar.gz: e4eb9ce9cc707064a9318b0971971231ef9a42279b5f17d9038bb99d2e1d6ae9ec84eccd1b1e4d67486163eb86e817a24bddeeb756bf51376d30b9badf662585
+  metadata.gz: 4cddfc09e41207a5d9f01a9e04bac5c7ec7f841e89ce1e225d073923e5555460461b92f93b2978508c1003d8bdd24c92f9f106e947226190ca165ef78ae10b75
+  data.tar.gz: 3bace5c3bbba48e3727e380f96d5f4a31f11fd29e9a319a7c09b2e284c400c2b105352bca4b3ae4ebfcabb5159faba99b9d88fa4e47153dfd4ff747b92b70d92

data/features/tests/negated_test.feature

@@ -0,0 +1,44 @@
+@sshd
+Feature: negated test prefix (no_)
+
+  Scenario: prefixed test fails when non-prefixed test is successful
+    Given a recipe with:
+      """
+      target 'some_host.test'
+
+      task :successful_test do
+        condition { has_env :shell }
+
+        echo 'successful_test'
+      end
+
+      task :negated_test do
+        condition { no_has_env :shell }
+
+        echo 'negated_test'
+      end
+      """
+    When I successfully execute the recipe
+    Then the output must contain "successful_test"
+    And the output must not contain "negated_test"
+
+  Scenario: prefixed test fails when non-prefixed test is failing
+    Given a recipe with:
+      """
+      target 'some_host.test'
+
+      task :failing_test do
+        condition { has_env :inexistent_var }
+
+        echo 'failing_test'
+      end
+
+      task :negated_test do
+        condition { no_has_env :inexistent_var }
+
+        echo 'negated_test'
+      end
+      """
+    When I successfully execute the recipe
+    Then the output must not contain "failing_test"
+    And the output must contain "negated_test"

data/lib/producer/core/condition.rb

@@ -14,7 +14,7 @@ module Producer
 
       def met?
         return !!@return_value if @tests.empty?
-        @tests.each { |t| return false unless t.success? }
+        @tests.each { |t| return false unless t.pass? }
         true
       end
 

data/lib/producer/core/condition/dsl.rb

@@ -13,6 +13,9 @@ module Producer
             define_method(keyword) do |*args|
               @tests << klass.new(@env, *args)
             end
+            define_method("no_#{keyword}") do |*args|
+              @tests << klass.new(@env, *args, negated: true)
+            end
           end
         end
 

data/lib/producer/core/test.rb

@@ -3,9 +3,18 @@ module Producer
     class Test
       attr_reader :env, :arguments
 
-      def initialize(env, *arguments)
+      def initialize(env, *arguments, negated: false)
         @env        = env
         @arguments  = arguments
+        @negated    = negated
+      end
+
+      def negated?
+        @negated
+      end
+
+      def pass?
+        verify ^ negated?
       end
     end
   end

data/lib/producer/core/tests/has_env.rb

@@ -2,7 +2,7 @@ module Producer
   module Core
     module Tests
       class HasEnv < Test
-        def success?
+        def verify
           env.remote.environment.has_key? arguments.first.to_s.upcase
         end
       end

data/lib/producer/core/tests/has_file.rb

@@ -2,7 +2,7 @@ module Producer
   module Core
     module Tests
       class HasFile < Test
-        def success?
+        def verify
           env.remote.fs.has_file? arguments.first
         end
       end

data/lib/producer/core/version.rb

@@ -1,5 +1,5 @@
 module Producer
   module Core
-    VERSION = '0.1.4'
+    VERSION = '0.1.5'
   end
 end

data/spec/producer/core/actions/echo_spec.rb

@@ -2,15 +2,11 @@ require 'spec_helper'
 
 module Producer::Core
   describe Actions::Echo do
-    let(:env)       { Env.new }
+    let(:env)       { double 'env' }
     let(:text)      { 'hello' }
     subject(:echo)  { Actions::Echo.new(env, text) }
 
     describe '#apply' do
-      before do
-        env.output = StringIO.new
-      end
-
       it 'outputs the string given as argument through env.output' do
         expect(env).to receive(:output).with(text)
         echo.apply

data/spec/producer/core/actions/shell_command_spec.rb

@@ -8,9 +8,7 @@ module Producer::Core
     subject(:sh)        { Actions::ShellCommand.new(env, command) }
 
     describe '#apply' do
-      before do
-        env.output = StringIO.new
-      end
+      before { env.output = StringIO.new }
 
       it 'delegates the call to env.remote.execute method' do
         expect(env.remote).to receive(:execute).with(command)

data/spec/producer/core/cli_spec.rb

@@ -5,7 +5,7 @@ module Producer::Core
     include ExitHelpers
     include FixturesHelpers
 
-    let(:recipe_file) { fixture_path_for('recipes/empty.rb') }
+    let(:recipe_file) { fixture_path_for 'recipes/empty.rb' }
     let(:arguments)   { [recipe_file] }
     subject(:cli)     { CLI.new(arguments) }
 
@@ -23,13 +23,13 @@ module Producer::Core
 
     describe '#run!' do
       it 'checks the arguments' do
-        expect(cli).to receive(:check_arguments!)
+        expect(cli).to receive :check_arguments!
         cli.run!
       end
 
       it 'processes the tasks with the interpreter' do
         allow(cli.recipe).to receive(:tasks) { [:some_task] }
-        expect(cli.interpreter).to receive(:process).with([:some_task])
+        expect(cli.interpreter).to receive(:process).with [:some_task]
         cli.run!
       end
     end
@@ -61,12 +61,12 @@ module Producer::Core
 
     describe '#env' do
       it 'builds an environment with the current recipe' do
-        expect(Env).to receive(:new)
+        expect(Env).to receive :new
         cli.env
       end
 
       it 'returns the env' do
-        env = double('env')
+        env = double 'env'
         allow(Env).to receive(:new) { env }
         expect(cli.env).to be env
       end
@@ -88,12 +88,12 @@ module Producer::Core
 
     describe '#interpreter' do
       it 'builds a interpreter' do
-        expect(Interpreter).to receive(:new)
+        expect(Interpreter).to receive :new
         cli.interpreter
       end
 
       it 'returns the interpreter' do
-        interpreter = double('interpreter')
+        interpreter = double 'interpreter'
         allow(Interpreter).to receive(:new) { interpreter }
         expect(cli.interpreter).to be interpreter
       end

data/spec/producer/core/condition/dsl_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module Producer::Core
   describe Condition::DSL do
     let(:block)   { proc { :some_condition_code } }
-    let(:env)     { double('env') }
+    let(:env)     { double 'env' }
     subject(:dsl) { Condition::DSL.new(env, &block) }
 
     %w[has_env has_file].each do |test|
@@ -22,7 +22,7 @@ module Producer::Core
       it 'evaluates the DSL sandbox code' do
         dsl = double('dsl').as_null_object
         allow(Condition::DSL).to receive(:new) { dsl }
-        expect(dsl).to receive(:evaluate)
+        expect(dsl).to receive :evaluate
         Condition::DSL.evaluate(env, &block)
       end
 
@@ -33,22 +33,24 @@ module Producer::Core
       end
 
       it 'returns the condition' do
-        condition = double('task')
+        condition = double 'task'
         allow(Condition).to receive(:new) { condition }
         expect(Condition::DSL.evaluate(env, &block)).to be condition
       end
     end
 
     describe '.define_test' do
-      let(:some_test_class) { double('SomeTest class') }
+      let(:some_test_class) { double 'SomeTest class' }
 
-      before do
-        Condition::DSL.define_test(:some_test, some_test_class)
-      end
+      before { Condition::DSL.define_test(:some_test, some_test_class) }
 
       it 'defines a new test keyword' do
         expect(dsl).to respond_to :some_test
       end
+
+      it 'defines the negated test' do
+        expect(dsl).to respond_to :no_some_test
+      end
     end
 
     describe '#initialize' do
@@ -78,12 +80,10 @@ module Producer::Core
       end
 
       context 'when a defined test keyword is called' do
-        let(:some_test_class) { double('SomeTest class') }
+        let(:some_test_class) { double 'SomeTest class' }
         let(:block)           { proc { some_test :some, :args } }
 
-        before do
-          Condition::DSL.define_test(:some_test, some_test_class)
-        end
+        before { Condition::DSL.define_test(:some_test, some_test_class) }
 
         it 'builds a new test with the env and given arguments' do
           expect(some_test_class).to receive(:new).with(env, :some, :args)
@@ -91,11 +91,21 @@ module Producer::Core
         end
 
         it 'registers the new test' do
-          some_test = double('SomeTest instance')
+          some_test = double 'SomeTest instance'
           allow(some_test_class).to receive(:new) { some_test }
           dsl.evaluate
           expect(dsl.tests).to include(some_test)
         end
+
+        context 'when keyword is prefixed with "no_"' do
+          let(:block) { proc { no_some_test :some, :args } }
+
+          it 'builds a negated test' do
+            expect(some_test_class)
+              .to receive(:new).with(env, :some, :args, negated: true)
+            dsl.evaluate
+          end
+        end
       end
     end
   end

data/spec/producer/core/condition_spec.rb

@@ -8,19 +8,19 @@ module Producer::Core
     subject(:condition) { Condition.new(tests) }
 
     describe '.evaluate' do
-      let(:env)   { double('env') }
+      let(:env)   { double 'env' }
       let(:block) { proc { :some_condition_code } }
 
       it 'delegates to DSL.evaluate' do
         expect(Condition::DSL)
           .to receive(:evaluate).with(env) do |&b|
-            expect(b.call).to eq :some_condition_code
+            expect(b).to be block
           end
         Condition.evaluate(env, &block)
       end
 
       it 'returns the evaluated condition' do
-        condition = double('condition')
+        condition = double 'condition'
         allow(Condition::DSL).to receive(:evaluate) { condition }
         expect(Condition.evaluate(env, &block)).to be condition
       end
@@ -84,8 +84,10 @@ module Producer::Core
     end
 
     describe '#!' do
-      %w[true false].each do |b|
+      [true, false].each do |b|
         context "when #met? return #{b}" do
+          before { allow(condition).to receive(:met?) { b } }
+
           it 'returns the negated #met?' do
             expect(condition.!).to be !condition.met?
           end

data/spec/producer/core/env_spec.rb

@@ -9,7 +9,7 @@ module Producer::Core
         expect(env.instance_eval { @output }).to eq $stdout
       end
 
-      it 'assigns nil as a default target' do
+      it 'assigns no default target' do
         expect(env.target).not_to be
       end
     end
@@ -25,11 +25,11 @@ module Producer::Core
     end
 
     describe '#target' do
-      let(:target) { Object.new }
+      let(:target) { double 'target' }
 
       it 'returns the defined target' do
         env.target = target
-        expect(env.target).to eq target
+        expect(env.target).to be target
       end
     end
 
@@ -41,7 +41,7 @@ module Producer::Core
       end
 
       it 'returns the remote' do
-        remote = double('remote')
+        remote = double 'remote'
         allow(Remote).to receive(:new) { remote }
         expect(env.remote).to eq remote
       end

data/spec/producer/core/interpreter_spec.rb

@@ -12,24 +12,22 @@ module Producer::Core
     end
 
     describe '#process_task' do
-      let(:action)  { double('action') }
+      let(:action)  { double 'action' }
       let(:task)    { double('task', actions: [action]).as_null_object }
 
       context 'when task condition is met' do
         it 'applies the actions' do
-          expect(action).to receive(:apply)
-          interpreter.process_task(task)
+          expect(action).to receive :apply
+          interpreter.process_task task
         end
       end
 
       context 'when task condition is not met' do
-        before do
-          allow(task).to receive(:condition_met?) { false }
-        end
+        before { allow(task).to receive(:condition_met?) { false } }
 
         it 'does not apply the actions' do
-          expect(action).not_to receive(:apply)
-          interpreter.process_task(task)
+          expect(action).not_to receive :apply
+          interpreter.process_task task
         end
       end
     end

data/spec/producer/core/recipe/dsl_spec.rb

@@ -4,14 +4,14 @@ module Producer::Core
   describe Recipe::DSL do
     include FixturesHelpers
 
-    let(:code)    { proc { } }
+    let(:code)    { proc { :some_recipe_code } }
     let(:env)     { double('env').as_null_object }
     subject(:dsl) { Recipe::DSL.new(&code) }
 
     describe '.evaluate' do
       let(:code) { 'nil' }
 
-      it 'builds a new DSL sandbox with given code' do
+      it 'builds a new DSL sandbox with given code as string' do
         expect(Recipe::DSL).to receive(:new).with(code).and_call_original
         Recipe::DSL.evaluate(code, env)
       end
@@ -24,7 +24,7 @@ module Producer::Core
       end
 
       it 'builds a recipe with evaluated tasks' do
-        dsl = Recipe::DSL.new('task(:some_task) { }')
+        dsl = Recipe::DSL.new { task(:some_task) { } }
         allow(Recipe::DSL).to receive(:new) { dsl }
         expect(Recipe).to receive(:new).with(dsl.tasks)
         Recipe::DSL.evaluate(code, env)
@@ -62,7 +62,7 @@ module Producer::Core
       let(:code) { proc { task(:some_task) { } } }
 
       it 'returns registered tasks' do
-        dsl.evaluate(env)
+        dsl.evaluate env
         expect(dsl.tasks[0].name).to eq :some_task
       end
     end
@@ -70,11 +70,11 @@ module Producer::Core
     describe '#evaluate' do
       it 'evaluates its code' do
         dsl = Recipe::DSL.new { throw :recipe_code }
-        expect { dsl.evaluate(env) }.to throw_symbol :recipe_code
+        expect { dsl.evaluate env }.to throw_symbol :recipe_code
       end
 
       it 'returns itself' do
-        expect(dsl.evaluate(env)).to eq dsl
+        expect(dsl.evaluate env).to eq dsl
       end
     end
 
@@ -85,8 +85,8 @@ module Producer::Core
         let(:code) { proc { env.some_message } }
 
         it 'returns the current environment' do
-          expect(env).to receive(:some_message)
-          dsl.evaluate(env)
+          expect(env).to receive :some_message
+          dsl.evaluate env
         end
       end
 
@@ -96,7 +96,7 @@ module Producer::Core
         subject(:dsl)   { Recipe::DSL.new(code) }
 
         it 'sources the recipe given as argument' do
-          expect { dsl.evaluate(env) }.to throw_symbol :recipe_code
+          expect { dsl.evaluate env }.to throw_symbol :recipe_code
         end
       end
 
@@ -114,8 +114,8 @@ module Producer::Core
 
         it 'builds a new evaluated task' do
           expect(Task)
-            .to receive(:evaluate).with(:some_task, env) do |&block|
-              expect(block.call).to eq :some_value
+            .to receive(:evaluate).with(:some_task, env) do |&b|
+              expect(b.call).to eq :some_value
             end
           dsl
         end

data/spec/producer/core/recipe_spec.rb

@@ -7,7 +7,7 @@ module Producer::Core
     subject(:recipe) { Recipe.new }
 
     describe '.evaluate_from_file' do
-      let(:env)       { double('env') }
+      let(:env)       { double 'env' }
       let(:filepath)  { fixture_path_for 'recipes/empty.rb' }
 
       it 'delegates to DSL.evaluate with the recipe file content' do
@@ -17,7 +17,7 @@ module Producer::Core
       end
 
       it 'returns the evaluated recipe' do
-        recipe = double('recipe')
+        recipe = double 'recipe'
         allow(Recipe::DSL).to receive(:evaluate) { recipe }
         expect(Recipe.evaluate_from_file(filepath, env)).to be recipe
       end

data/spec/producer/core/remote/environment_spec.rb

@@ -3,7 +3,9 @@ require 'spec_helper'
 module Producer::Core
   describe Remote::Environment do
     let(:variables)       { { 'FOO' => 'bar', 'BAZ' => 'qux' } }
-    subject(:environment) { Remote::Environment.new(variables) }
+    let(:string)          { "FOO=bar\nBAZ=qux" }
+    let(:argument)        { variables }
+    subject(:environment) { Remote::Environment.new(argument) }
 
     describe '#initialize' do
       context 'when a hash is given' do
@@ -13,7 +15,7 @@ module Producer::Core
       end
 
       context 'when a string is given' do
-        subject(:environment) { Remote::Environment.new("FOO=bar\nBAZ=qux") }
+        let(:argument) { string }
 
         it 'assigns the key/value pairs' do
           expect(environment.instance_eval { @variables }).to eq variables

data/spec/producer/core/remote/fs_spec.rb

@@ -15,12 +15,12 @@ module Producer::Core
       before { sftp_story }
 
       it 'builds a new SFTP session' do
-        expect(remote.session.sftp).to receive(:connect)
+        expect(remote.session.sftp).to receive :connect
         fs.sftp
       end
 
       it 'returns the new SFTP session' do
-        session = double('session')
+        session = double 'session'
         allow(remote.session.sftp).to receive(:connect) { session }
         expect(fs.sftp).to be session
       end
@@ -35,7 +35,7 @@ module Producer::Core
     # part of net-ssh story helpers, which are more close to integration tests.
     describe '#has_file?', :ssh do
       let(:file_path) { "some_file_path" }
-      let(:stat)      { double('stat') }
+      let(:stat)      { double 'stat' }
 
       before do
         sftp_story
@@ -44,35 +44,31 @@ module Producer::Core
 
       context 'when path given as argument exists' do
         context 'when path is a file' do
-          before do
-            allow(stat).to receive(:file?) { true }
-          end
+          before { allow(stat).to receive(:file?) { true } }
 
           it 'returns true' do
-            expect(fs.has_file?(file_path)).to be true
+            expect(fs.has_file? file_path).to be true
           end
         end
 
         context 'when path is not a file' do
-          before do
-            allow(stat).to receive(:file?) { false }
-          end
+          before { allow(stat).to receive(:file?) { false } }
 
           it 'returns false' do
-            expect(fs.has_file?(file_path)).to be false
+            expect(fs.has_file? file_path).to be false
           end
         end
       end
 
       context 'when querying the path raises a Net::SFTP::StatusException' do
         before do
-          response = double('response', code: '42', message: 'some message')
+          response = double 'response', code: '42', message: 'some message'
           ex = Net::SFTP::StatusException.new(response)
           allow(stat).to receive(:file?).and_raise(ex)
         end
 
         it 'returns false' do
-          expect(fs.has_file?(file_path)).to be false
+          expect(fs.has_file? file_path).to be false
         end
       end
     end

data/spec/producer/core/remote_spec.rb

@@ -7,7 +7,7 @@ module Producer::Core
 
     describe '#hostname' do
       it 'returns the assignated hostname' do
-        expect(remote.hostname).to be hostname
+        expect(remote.hostname).to eq hostname
       end
     end
 
@@ -69,12 +69,12 @@ module Producer::Core
 
     describe '#fs' do
       it 'builds a new FS' do
-        expect(Remote::FS).to receive(:new)
+        expect(Remote::FS).to receive :new
         remote.fs
       end
 
       it 'returns the new FS instance' do
-        fs = double('fs')
+        fs = double 'fs'
         allow(Remote::FS).to receive(:new) { fs }
         expect(remote.fs).to be fs
       end
@@ -103,7 +103,7 @@ module Producer::Core
           ch.sends_exec command
           ch.gets_data arguments
         end
-        expect(remote.execute(command)).to eq arguments
+        expect(remote.execute command).to eq arguments
       end
 
       it 'raises an exception when the exit status code is not 0' do
@@ -112,7 +112,7 @@ module Producer::Core
           ch.gets_data arguments
           ch.gets_exit_status 1
         end
-        expect { remote.execute(command) }
+        expect { remote.execute command }
           .to raise_error(RemoteCommandExecutionError)
       end
     end
@@ -134,7 +134,7 @@ module Producer::Core
       end
 
       it 'returns the environment' do
-        environment = double('environment')
+        environment = double 'environment'
         allow(Remote::Environment).to receive(:new) { environment }
         expect(remote.environment).to be environment
       end

data/spec/producer/core/task/dsl_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module Producer::Core
   describe Task::DSL do
     let(:block)   { proc { } }
-    let(:env)     { double('env') }
+    let(:env)     { double 'env' }
     subject(:dsl) { Task::DSL.new(&block) }
 
     %w[echo sh].each do |action|
@@ -16,7 +16,11 @@ module Producer::Core
       let(:name) { :some_task }
 
       it 'builds a new DSL sandbox with given code' do
-        expect(Task::DSL).to receive(:new).with(&block).and_call_original
+        dsl = double('dsl').as_null_object
+        expect(Task::DSL).to receive(:new).with(no_args) do |&b|
+          expect(b).to be block
+          dsl
+        end
         Task::DSL.evaluate(name, env, &block)
       end
 
@@ -38,7 +42,7 @@ module Producer::Core
       end
 
       it 'returns the task' do
-        task = double('task')
+        task = double 'task'
         allow(Task).to receive(:new) { task }
         expect(Task::DSL.evaluate(name, env, &block)).to be task
       end
@@ -57,7 +61,7 @@ module Producer::Core
       end
 
       it 'assigns true as the condition' do
-        expect(dsl.instance_eval { @condition }).to be_true
+        expect(dsl.instance_eval { @condition }).to be true
       end
     end
 
@@ -68,11 +72,20 @@ module Producer::Core
       end
     end
 
+    describe '#condition' do
+      context 'without block' do
+        it 'returns the assigned condition' do
+          dsl.instance_eval { @condition = :some_condition }
+          expect(dsl.condition).to be :some_condition
+        end
+      end
+    end
+
     describe '#evaluate' do
       let(:block) { proc { throw :task_code } }
 
       it 'evaluates its code' do
-        expect { dsl.evaluate(env) }
+        expect { dsl.evaluate env }
           .to throw_symbol :task_code
       end
 
@@ -82,7 +95,7 @@ module Producer::Core
 
         before do
           Task::DSL.define_action(:some_action, some_action_class)
-          dsl.evaluate(env)
+          dsl.evaluate env
         end
 
         it 'registers the action' do
@@ -118,14 +131,5 @@ module Producer::Core
         end
       end
     end
-
-    describe '#condition' do
-      context 'without block' do
-        it 'returns the assigned condition' do
-          dsl.instance_eval { @condition = :some_condition }
-          expect(dsl.condition).to be :some_condition
-        end
-      end
-    end
   end
 end

data/spec/producer/core/task_spec.rb

@@ -3,24 +3,24 @@ require 'spec_helper'
 module Producer::Core
   describe Task do
     let(:name)      { :some_task }
-    let(:action)    { double('action') }
-    let(:condition) { double('condition') }
+    let(:action)    { double 'action' }
+    let(:condition) { double 'condition' }
     subject(:task)  { Task.new(name, [action], condition) }
 
     describe '.evaluate' do
-      let(:env)   { double('env') }
-      let(:block) { proc { :some_value } }
+      let(:env)   { double 'env' }
+      let(:block) { proc { :some_task_code } }
 
       it 'delegates to DSL.evaluate' do
         expect(Task::DSL)
           .to receive(:evaluate).with(name, env) do |&b|
-            expect(b.call).to eq :some_value
+            expect(b).to be block
           end
         Task.evaluate(name, env, &block)
       end
 
       it 'returns the evaluated task' do
-        task = double('task')
+        task = double 'task'
         allow(Task::DSL).to receive(:evaluate) { task }
         expect(Task.evaluate(name, env, &block)).to be task
       end
@@ -40,14 +40,14 @@ module Producer::Core
       end
 
       context 'when only the name is given as argument' do
-        subject(:task)  { Task.new(name) }
+        subject(:task) { Task.new(name) }
 
         it 'assigns no action' do
           expect(task.actions).to be_empty
         end
 
-        it 'assigns a truthy condition' do
-          expect(task.condition).to be_true
+        it 'assigns a true condition' do
+          expect(task.condition).to be true
         end
       end
     end

data/spec/producer/core/test_spec.rb

@@ -4,26 +4,79 @@ module Producer::Core
   describe Test do
     let(:env)         { double 'env' }
     let(:arguments)   { [:some, :arguments] }
-    subject(:action)  { Test.new(env, *arguments) }
+    subject(:test)    { Test.new(env, *arguments) }
 
     describe '#initialize' do
       it 'assigns the env' do
-        expect(action.instance_eval { @env }).to be env
+        expect(test.instance_eval { @env }).to be env
       end
+
       it 'assigns the arguments' do
-        expect(action.instance_eval { @arguments }).to eq arguments
+        expect(test.instance_eval { @arguments }).to eq arguments
+      end
+
+      it 'assigns negated as false by default' do
+        expect(test.instance_eval { @negated }).to be false
+      end
+
+      context 'when negated option is true' do
+        subject(:test) { Test.new(env, *arguments, negated: true) }
+
+        it 'assigns negated as true' do
+          expect(test.instance_eval { @negated }).to be true
+        end
       end
     end
 
     describe '#env' do
       it 'returns the assigned env' do
-        expect(action.env).to be env
+        expect(test.env).to be env
       end
     end
 
     describe '#arguments' do
       it 'returns the assigned arguments' do
-        expect(action.arguments).to eq arguments
+        expect(test.arguments).to eq arguments
+      end
+    end
+
+    describe '#negated?' do
+      it 'returns false' do
+        expect(test.negated?).to be false
+      end
+
+      context 'when test is negated' do
+        subject(:test) { Test.new(env, *arguments, negated: true) }
+
+        it 'returns true' do
+          expect(test.negated?).to be true
+        end
+      end
+    end
+
+    describe '#pass?' do
+      it 'returns true when #verify is true' do
+        allow(test).to receive(:verify) { true }
+        expect(test.pass?).to be true
+      end
+
+      it 'returns false when #verify is false' do
+        allow(test).to receive(:verify) { false }
+        expect(test.pass?).to be false
+      end
+
+      context 'when test is negated' do
+        subject(:test) { Test.new(env, *arguments, negated: true) }
+
+        it 'returns false when #verify is true' do
+          allow(test).to receive(:verify) { true }
+          expect(test.pass?).to be false
+        end
+
+        it 'returns true when #verify is false' do
+          allow(test).to receive(:verify) { false }
+          expect(test.pass?).to be true
+        end
       end
     end
   end

data/spec/producer/core/tests/has_env_spec.rb

@@ -10,8 +10,8 @@ module Producer::Core
       expect(has_env).to be_a Test
     end
 
-    describe '#success?' do
-      let(:environment) { double('environment') }
+    describe '#verify' do
+      let(:environment) { double 'environment' }
 
       before do
         allow(env.remote).to receive(:environment) { environment }
@@ -19,22 +19,22 @@ module Producer::Core
 
       it 'stringifies the queried variable name' do
         expect(environment).to receive(:has_key?).with(kind_of(String))
-        has_env.success?
+        has_env.verify
       end
 
       it 'upcases the queried variable name' do
         expect(environment).to receive(:has_key?).with('SOME_VARIABLE_NAME')
-        has_env.success?
+        has_env.verify
       end
 
       it 'returns true when remote environment var is defined' do
         allow(environment).to receive(:has_key?) { true }
-        expect(has_env.success?).to be true
+        expect(has_env.verify).to be true
       end
 
       it 'returns false when remote environment var is not defined' do
         allow(environment).to receive(:has_key?) { false }
-        expect(has_env.success?).to be false
+        expect(has_env.verify).to be false
       end
     end
   end

data/spec/producer/core/tests/has_file_spec.rb

@@ -10,18 +10,18 @@ module Producer::Core
       expect(has_file).to be_a Test
     end
 
-    describe '#success?', :ssh do
+    describe '#verify', :ssh do
       before { sftp_story }
 
       it 'delegates the call on remote FS' do
         expect(env.remote.fs).to receive(:has_file?).with(filepath)
-        has_file.success?
+        has_file.verify
       end
 
       it 'returns the file existence' do
-        existence = double('existence')
+        existence = double 'existence'
         allow(env.remote.fs).to receive(:has_file?) { existence }
-        expect(has_file.success?).to be existence
+        expect(has_file.verify).to be existence
       end
     end
   end

data/spec/support/net_ssh_story_helpers.rb

@@ -36,7 +36,7 @@ module NetSSHStoryHelpers
   def sftp_story
     story do |session|
       ch = session.opens_channel
-      ch.sends_subsystem('sftp')
+      ch.sends_subsystem 'sftp'
       ch.sends_packet(
         Net::SFTP::Constants::PacketTypes::FXP_INIT, :long,
         Net::SFTP::Session::HIGHEST_PROTOCOL_VERSION_SUPPORTED

data/spec/support/tests_helpers.rb

@@ -1,9 +1,9 @@
 module TestsHelpers
   def test_ok
-    double('test', success?: true)
+    double 'test', pass?: true
   end
 
   def test_ko
-    double('test', success?: false)
+    double 'test', pass?: false
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: producer-core
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Thibault Jouan
@@ -127,6 +127,7 @@ files:
 - features/tasks/evaluation.feature
 - features/tests/has_env.feature
 - features/tests/has_file.feature
+- features/tests/negated_test.feature
 - lib/producer/core.rb
 - lib/producer/core/action.rb
 - lib/producer/core/actions/echo.rb
@@ -196,7 +197,7 @@ rubyforge_project:
 rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: producer-core-0.1.4
+summary: producer-core-0.1.5
 test_files:
 - features/actions/echo.feature
 - features/actions/sh.feature
@@ -217,6 +218,7 @@ test_files:
 - features/tasks/evaluation.feature
 - features/tests/has_env.feature
 - features/tests/has_file.feature
+- features/tests/negated_test.feature
 - spec/fixtures/recipes/empty.rb
 - spec/fixtures/recipes/throw.rb
 - spec/producer/core/action_spec.rb