producer-core 0.1.1 → 0.1.2

data/features/actions/echo.feature

@@ -7,6 +7,5 @@ Feature: `echo' task action
         echo 'hello'
       end
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain exactly "hello\n"
+    When I successfully execute the recipe
+    Then the output must contain exactly "hello\n"

data/features/actions/sh.feature

@@ -1,5 +1,5 @@
 @sshd
-Feature: sh task action
+Feature: `sh' task action
 
   Scenario: executes command
     Given a recipe with:
@@ -22,7 +22,7 @@ Feature: sh task action
         sh '\echo from remote'
       end
       """
-    When I execute the recipe
+    When I successfully execute the recipe
     Then the output must contain "from remote"
 
   Scenario: aborts on failed command execution

data/features/recipes/evaluation.feature

@@ -5,6 +5,5 @@ Feature: recipe evaluation
       """
       puts 'hello from recipe'
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain exactly "hello from recipe\n"
+    When I successfully execute the recipe
+    Then the output must contain exactly "hello from recipe\n"

data/features/recipes/source.feature

@@ -11,6 +11,5 @@ Feature: `source' recipe keyword
       """
       puts 'sourced recipe'
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain "sourced recipe"
+    When I successfully execute the recipe
+    Then the output must contain "sourced recipe"

data/features/recipes/target.feature

@@ -7,6 +7,5 @@ Feature: `target' recipe keyword
 
       puts env.target
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain exactly "some_host.example\n"
+    When I successfully execute the recipe
+    Then the output must contain exactly "some_host.example\n"

data/features/steps/recipe_steps.rb

@@ -5,3 +5,8 @@ end
 When(/^I execute the recipe$/) do
   run_simple('producer recipe.rb', false)
 end
+
+When(/^I successfully execute the recipe$/) do
+  step 'I execute the recipe'
+  assert_exit_status(0)
+end

data/features/tasks/condition.feature

@@ -9,6 +9,5 @@ Feature: `condition' task keyword
         echo 'evaluated'
       end
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must not contain "evaluated"
+    When I successfully execute the recipe
+    Then the output must not contain "evaluated"

data/features/tasks/evaluation.feature

@@ -7,6 +7,5 @@ Feature: task evaluation
         puts 'hello from recipe'
       end
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain exactly "hello from recipe\n"
+    When I successfully execute the recipe
+    Then the output must contain exactly "hello from recipe\n"

data/features/tests/has_env.feature

@@ -12,9 +12,8 @@ Feature: `has_env' condition keyword
         echo 'evaluated'
       end
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must contain "evaluated"
+    When I successfully execute the recipe
+    Then the output must contain "evaluated"
 
   Scenario: fails when remote environment variable is not defined
     Given a recipe with:
@@ -27,6 +26,5 @@ Feature: `has_env' condition keyword
         echo 'evaluated'
       end
       """
-    When I execute the recipe
-    Then the exit status must be 0
-    And the output must not contain "evaluated"
+    When I successfully execute the recipe
+    Then the output must not contain "evaluated"

data/lib/producer/core/tests/has_env.rb

@@ -1,6 +1,6 @@
 module Producer
   module Core
-    class Tests
+    module Tests
       class HasEnv < Test
         def success?
           env.remote.environment.has_key? arguments.first.to_s.upcase

data/lib/producer/core/version.rb

@@ -1,5 +1,5 @@
 module Producer
   module Core
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

data/spec/producer/core/actions/echo_spec.rb

@@ -18,4 +18,3 @@ module Producer::Core
     end
   end
 end
-

data/spec/producer/core/interpreter_spec.rb

@@ -13,11 +13,7 @@ module Producer::Core
 
     describe '#process_task' do
       let(:action)  { double('action') }
-      let(:task)    { double('task').as_null_object }
-
-      before do
-        allow(task).to receive(:actions) { [action] }
-      end
+      let(:task)    { double('task', actions: [action]).as_null_object }
 
       context 'when task condition is met' do
         it 'applies the actions' do

data/spec/producer/core/recipe/dsl_spec.rb

@@ -6,13 +6,13 @@ module Producer::Core
 
     let(:code)    { proc { } }
     let(:env)     { double('env').as_null_object }
-    subject(:dsl) { Recipe::DSL.new &code }
+    subject(:dsl) { Recipe::DSL.new(&code) }
 
     describe '.evaluate' do
       let(:code) { 'nil' }
 
       it 'builds a new DSL sandbox with given code' do
-        expect(Recipe::DSL).to receive(:new).once.with(code).and_call_original
+        expect(Recipe::DSL).to receive(:new).with(code).and_call_original
         Recipe::DSL.evaluate(code, env)
       end
 
@@ -93,7 +93,7 @@ module Producer::Core
       describe '#source' do
         let(:filepath)  { fixture_path_for 'recipes/throw' }
         let(:code)      { "source '#{filepath}'" }
-        subject(:dsl)   { Recipe::DSL.new code }
+        subject(:dsl)   { Recipe::DSL.new(code) }
 
         it 'sources the recipe given as argument' do
           expect { dsl.evaluate(env) }.to throw_symbol :recipe_code

data/spec/producer/core/task/dsl_spec.rb

@@ -4,7 +4,7 @@ module Producer::Core
   describe Task::DSL do
     let(:block)   { proc { } }
     let(:env)     { double('env') }
-    subject(:dsl) { Task::DSL.new &block }
+    subject(:dsl) { Task::DSL.new(&block) }
 
     %w[echo sh].each do |action|
       it "has `#{action}' action defined" do
@@ -16,7 +16,7 @@ module Producer::Core
       let(:name) { :some_task }
 
       it 'builds a new DSL sandbox with given code' do
-        expect(Task::DSL).to receive(:new).once.with(&block).and_call_original
+        expect(Task::DSL).to receive(:new).with(&block).and_call_original
         Task::DSL.evaluate(name, env, &block)
       end
 
@@ -28,10 +28,10 @@ module Producer::Core
       end
 
       it 'builds a task with its name, actions and condition' do
-        dsl = double('dsl').as_null_object
+        dsl = double(
+          'dsl', actions: [:some_action], condition: :some_condition
+        ).as_null_object
         allow(Task::DSL).to receive(:new) { dsl }
-        allow(dsl).to receive(:actions) { [:some_action] }
-        allow(dsl).to receive(:condition) { :some_condition }
         expect(Task)
           .to receive(:new).with(:some_task, [:some_action], :some_condition)
         Task::DSL.evaluate(name, env, &block)

data/spec/spec_helper.rb

@@ -11,6 +11,6 @@ RSpec.configure do |c|
 
   c.include NetSSHStoryHelpers, :ssh
   c.before(:each, :ssh) do
-    allow(remote).to receive(:session) { connection }
+    allow(Net::SSH).to receive(:start) { connection }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: producer-core
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-20 00:00:00.000000000 Z
+date: 2013-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ssh
@@ -114,7 +114,6 @@ files:
 - features/recipes/source.feature
 - features/recipes/target.feature
 - features/steps/recipe_steps.rb
-- features/support/env.rb
 - features/support/env_aruba.rb
 - features/support/env_cucumber-doc_string.rb
 - features/support/ssh.rb
@@ -187,7 +186,7 @@ rubyforge_project:
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: producer-core-0.1.1
+summary: producer-core-0.1.2
 test_files:
 - features/actions/echo.feature
 - features/actions/sh.feature
@@ -197,7 +196,6 @@ test_files:
 - features/recipes/source.feature
 - features/recipes/target.feature
 - features/steps/recipe_steps.rb
-- features/support/env.rb
 - features/support/env_aruba.rb
 - features/support/env_cucumber-doc_string.rb
 - features/support/ssh.rb