produce 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4997a5baf0ad1a5fb8451ae3e42820f70a02d70
-  data.tar.gz: 8dc54278a0710a7b82715f3d7c2e5114685ecd1d
+  metadata.gz: ca2fa0c79d6eed1ca6e279042fce117a366aaa6c
+  data.tar.gz: 104523717bb390a6b1bd7142310305a760b4c639
 SHA512:
-  metadata.gz: 5d029c2b116a572e3b2e825a50b0c8db293b8ed2b3390aea9e7135057779e19280a9482d70b9e4414ef08b4b4049806d561c4c3b050c841f9c8388d652cd14d7
-  data.tar.gz: b451080be65fee905e59074f6c17453e34b981a2007edafb8f3348e2853527c1f9ad558540c31f8d8388786fff563198cd0dd73696d0228f66ef25a410182d46
+  metadata.gz: 7367d265ee0619ec0cda56b27f34eebca37c4d6736593b20a29b000ed13d3276c3e2581643a291b9081adc5fb3abf6721472f8e27dd0f9e60c836a149c8c06e3
+  data.tar.gz: 6e8570aba6f5902e7ea79cd506297989ceb1d936ccddd72b3e708117a9d273cbc3f77ebcd2546b92efb7685099e5c7aa148314b04746911a6dcf27e62497c9f3

data/bin/produce

@@ -52,7 +52,7 @@ class ProduceApplication
 
       c.action do |args, options|
         # Filter the options so that we can still build the configuration
-        allowed_keys = Produce::Options.available_options.collect { |config| config.key }
+        allowed_keys = Produce::Options.available_options.collect(&:key)
         Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, options.__hash__.select { |key, value| allowed_keys.include? key })
 
         require 'produce/service'
@@ -79,7 +79,7 @@ class ProduceApplication
 
       c.action do |args, options|
         # Filter the options so that we can still build the configuration
-        allowed_keys = Produce::Options.available_options.collect { |config| config.key }
+        allowed_keys = Produce::Options.available_options.collect(&:key)
         Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, options.__hash__.select { |key, value| allowed_keys.include? key })
 
         require 'produce/service'
@@ -96,7 +96,7 @@ class ProduceApplication
       c.option '-g', '--group_identifier STRING', String, 'Group identifier for the group (PRODUCE_GROUP_IDENTIFIER)'
 
       c.action do |args, options|
-        allowed_keys = Produce::Options.available_options.collect { |config| config.key }
+        allowed_keys = Produce::Options.available_options.collect(&:key)
         Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, options.__hash__.select { |key, value| allowed_keys.include? key })
 
         require 'produce/group'

data/lib/produce/dependency_checker.rb

@@ -5,7 +5,7 @@ module Produce
     end
 
     def self.check_xcode_select
-      unless `xcode-select -v`.include?"xcode-select version "
+      unless `xcode-select -v`.include? "xcode-select version "
         Helper.log.fatal '#############################################################'
         Helper.log.fatal "# You have to install the Xcode commdand line tools to use produce"
         Helper.log.fatal "# Install the latest version of Xcode from the AppStore"
@@ -15,4 +15,4 @@ module Produce
       end
     end
   end
-end
+end

data/lib/produce/developer_center.rb

@@ -3,7 +3,6 @@ require 'babosa'
 
 module Produce
   class DeveloperCenter
-
     def run
       login
       create_new_app
@@ -19,12 +18,12 @@ module Produce
       else
         app_name = valid_name_for(Produce.config[:app_name])
         Helper.log.info "Creating new app '#{app_name}' on the Apple Dev Center".green
-        
+
         app = Spaceship.app.create!(bundle_id: app_identifier,
                                          name: app_name)
 
         Helper.log.info "Created app #{app.app_id}"
-        
+
         raise "Something went wrong when creating the new app - it's not listed in the apps list" unless app_exists?
 
         ENV["CREATED_NEW_APP_ID"] = Time.now.to_i.to_s
@@ -45,13 +44,14 @@ module Produce
     end
 
     private
-      def app_exists?
-        Spaceship.app.find(app_identifier) != nil
-      end
 
-      def login
-        Spaceship.login(Produce.config[:username], nil)
-        Spaceship.select_team
-      end
+    def app_exists?
+      Spaceship.app.find(app_identifier) != nil
+    end
+
+    def login
+      Spaceship.login(Produce.config[:username], nil)
+      Spaceship.select_team
+    end
   end
 end

data/lib/produce/group.rb

@@ -3,7 +3,7 @@ require 'babosa'
 
 module Produce
   class Group
-    def create(options, args)
+    def create(options, _args)
       login
 
       ENV["CREATED_NEW_GROUP_ID"] = Time.now.to_i.to_s
@@ -39,16 +39,16 @@ module Produce
       return true
     end
 
-    def associate(options, args)
+    def associate(_options, args)
       login
 
       if !app_exists?
         Helper.log.info "[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist, nothing to associate with the groups".red
       else
         app = Spaceship.app.find(app_identifier)
-        raise "Something went wrong when fetching the app - it's not listed in the apps list" unless app != nil
+        raise "Something went wrong when fetching the app - it's not listed in the apps list" if app.nil?
 
-        new_groups = Array.new
+        new_groups = []
 
         Helper.log.info "Validating groups before association"
 
@@ -79,7 +79,7 @@ module Produce
       Produce.config[:app_identifier].to_s
     end
 
-    def app_group_exists? (identifier)
+    def app_group_exists?(identifier)
       Spaceship.app_group.find(identifier) != nil
     end
 

data/lib/produce/itunes_connect.rb

@@ -2,7 +2,6 @@ require 'spaceship'
 
 module Produce
   class ItunesConnect
-    
     def run
       @full_bundle_identifier = app_identifier
       @full_bundle_identifier.gsub!('*', Produce.config[:bundle_identifier_suffix].to_s) if wildcard_bundle?
@@ -22,11 +21,11 @@ module Produce
 
         Produce.config[:bundle_identifier_suffix] = '' unless wildcard_bundle?
 
-        Spaceship::Tunes::Application.create!(name: Produce.config[:app_name], 
+        Spaceship::Tunes::Application.create!(name: Produce.config[:app_name],
                                               primary_language: language,
-                                              version: Produce.config[:app_version], 
+                                              version: Produce.config[:app_version],
                                               sku: Produce.config[:sku].to_s, # might be an int
-                                              bundle_id: app_identifier, 
+                                              bundle_id: app_identifier,
                                               bundle_id_suffix: Produce.config[:bundle_identifier_suffix],
                                               company_name: Produce.config[:company_name])
         application = fetch_application
@@ -39,32 +38,33 @@ module Produce
     end
 
     private
-      def fetch_application
-        Spaceship::Application.find(@full_bundle_identifier)
-      end
 
-      def wildcard_bundle?
-        return app_identifier.end_with?("*")
-      end
+    def fetch_application
+      Spaceship::Application.find(@full_bundle_identifier)
+    end
 
-      def app_identifier
-        Produce.config[:app_identifier].to_s
-      end
+    def wildcard_bundle?
+      return app_identifier.end_with?("*")
+    end
 
-      # Makes sure to get the value for the language
-      # Instead of using the user's value `UK English` spaceship should send
-      # `English_UK` to the server
-      def language
-        @language = Produce.config[:language]
+    def app_identifier
+      Produce.config[:app_identifier].to_s
+    end
 
-        converted = Spaceship::Tunes::LanguageConverter.from_itc_readable_to_itc(@language)
-        @language = converted if converted # overwrite it with the actual value
+    # Makes sure to get the value for the language
+    # Instead of using the user's value `UK English` spaceship should send
+    # `English_UK` to the server
+    def language
+      @language = Produce.config[:language]
 
-        unless AvailableDefaultLanguages.all_languages.include?(@language)
-          raise "Please enter one of available languages: #{AvailableDefaultLanguages.all_languages}".red
-        end
+      converted = Spaceship::Tunes::LanguageConverter.from_itc_readable_to_itc(@language)
+      @language = converted if converted # overwrite it with the actual value
 
-        return @language
+      unless AvailableDefaultLanguages.all_languages.include?(@language)
+        raise "Please enter one of available languages: #{AvailableDefaultLanguages.all_languages}".red
       end
+
+      return @language
+    end
   end
 end

data/lib/produce/options.rb

@@ -12,6 +12,7 @@ module Produce
                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)),
         FastlaneCore::ConfigItem.new(key: :app_identifier,
                                      env_name: "PRODUCE_APP_IDENTIFIER",
+                                     short_option: "-a",
                                      description: "App Identifier (Bundle ID, e.g. com.krausefx.app)",
                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)),
         FastlaneCore::ConfigItem.new(key: :bundle_identifier_suffix,
@@ -36,16 +37,14 @@ module Produce
                                      env_name: "PRODUCE_LANGUAGE",
                                      description: "Primary Language (e.g. 'English', 'German')",
                                      default_value: "English",
-                                     verify_block: Proc.new do |language|
-
+                                     verify_block: proc do |language|
                                      end),
         FastlaneCore::ConfigItem.new(key: :company_name,
                                      short_option: "-c",
                                      env_name: "PRODUCE_COMPANY_NAME",
                                      description: "The name of your comapny. Only required if it's the first app you create",
                                      optional: true,
-                                     verify_block: Proc.new do |language|
-
+                                     verify_block: proc do |language|
                                      end),
         FastlaneCore::ConfigItem.new(key: :skip_itc,
                                      short_option: "-i",
@@ -65,8 +64,8 @@ module Produce
                                      description: "The ID of your team if you're in multiple teams",
                                      optional: true,
                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:team_id),
-                                     verify_block: Proc.new do |value|
-                                        ENV["FASTLANE_TEAM_ID"] = value
+                                     verify_block: proc do |value|
+                                       ENV["FASTLANE_TEAM_ID"] = value
                                      end),
         FastlaneCore::ConfigItem.new(key: :team_name,
                                      short_option: "-l",
@@ -74,8 +73,8 @@ module Produce
                                      description: "The name of your team if you're in multiple teams",
                                      optional: true,
                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:team_name),
-                                     verify_block: Proc.new do |value|
-                                        ENV["FASTLANE_TEAM_NAME"] = value
+                                     verify_block: proc do |value|
+                                       ENV["FASTLANE_TEAM_NAME"] = value
                                      end)
       ]
     end

data/lib/produce/service.rb

@@ -8,7 +8,7 @@ module Produce
       self.new.disable(options, args)
     end
 
-    def enable(options, args)
+    def enable(options, _args)
       unless app
         Helper.log.info "[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist".red
         return
@@ -20,7 +20,7 @@ module Produce
       Helper.log.info "Done! Enabled #{enabled} services.".green
     end
 
-    def disable(options, args)
+    def disable(options, _args)
       unless app
         Helper.log.info "[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist".red
         return
@@ -34,8 +34,8 @@ module Produce
 
     def valid_services_for(options)
       allowed_keys = [:app_group, :associated_domains, :data_protection, :healthkit, :homekit,
-        :wireless_conf, :icloud, :inter_app_audio, :passbook, :push_notification, :vpn_conf]
-        options.__hash__.select { |key, value| allowed_keys.include? key }
+                      :wireless_conf, :icloud, :inter_app_audio, :passbook, :push_notification, :vpn_conf]
+      options.__hash__.select { |key, value| allowed_keys.include? key }
     end
 
     def update(on, app, options)

data/lib/produce/version.rb

@@ -1,3 +1,3 @@
 module Produce
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: produce
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-07 00:00:00.000000000 Z
+date: 2015-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -184,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Create new iOS apps on iTunes Connect and Dev Portal using the command line