process_settings 0.5.4.pre.1 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c51c6fd16737845ed2ff8ab28b127d7e0a58b2a99926f47990adda952ca84db8
-  data.tar.gz: a4a2f86fd244320929523e849c15c3737d344aa34cb8288c81806f93b3844da1
+  metadata.gz: 0d3f11e7b35109103df7bcd4cc593f2589948df29edfe1eb8fabf332b6676717
+  data.tar.gz: f71a2c9d8c8b3c70e89b0ab1497d6331aaa75961f8283cb01779f2939b7cf4e9
 SHA512:
-  metadata.gz: d454ebe1d871c50d8d8d545a12ee958f2102d91c837738cda2ad9156450842a77ac86eca7c0a9b0bec5bf248081c488440f4dc082d651d438da696c7ec30d32f
-  data.tar.gz: 0e6bc0976b16124da1361900354fe27ad7e54564a8419050f92670cc4df16f0e98f8bb0b8fbddaa43d3687818fa306ba8c31146de3c690f08663e58deab01d20
+  metadata.gz: 745b8414363c0f9464b1e8a5a1025fa4808b26abcc143f28d269ae45edecb2e1671ea468d8cb64d3a696644292da8d9d720b5eda8700479a74bdff04805f28fa
+  data.tar.gz: d154960aa9a1f3a5197b5cca0bb7becb59669cd1b1e1cd6419395bed83a885b7f984e5f842cf502a60454f5a93cb630ba28e652b4d1d5ce98c533202d223f3dc

data/lib/process_settings/monitor.rb

@@ -20,23 +20,16 @@ module ProcessSettings
       @logger = logger
       @on_change_callbacks = []
       @static_context = {}
-
-      start
-    end
-
-    # starts listening for changes
-    # Note: This method creates a new thread that will be monitoring for changes
-    #       do to the nature of how the Listen gem works, there is no record of
-    #       existing threads, calling this mutliple times will result in spinning off
-    #       multiple listen threads and will have unknow effects
-    def start
-      path = File.dirname(@file_path)
+      @last_statically_targetted_settings = nil
+      @last_untargetted_settings = nil
 
       # to eliminate any race condition:
       # 1. set up file watcher
       # 2. start it (this should trigger if any changes have been made since (1))
       # 3. load the file
 
+      path = File.dirname(@file_path)
+
       @listener = file_change_notifier.to(path) do |modified, added, _removed|
         if modified.include?(@file_path) || added.include?(@file_path)
           @logger.info("ProcessSettings::Monitor file #{@file_path} changed. Reloading.")
@@ -51,14 +44,19 @@ module ProcessSettings
       end
 
       load_untargeted_settings
+
       load_statically_targeted_settings
     end
 
     # stops listening for changes
     def stop
-      @listener&.stop
+      @listener.stop
     end
 
+    # TODO:
+    # 1. rename this to `when_updated` and clone that interface from InvocaCluster
+    # 2. since the callback yields self, support Instance#[]; have ProcessSettings.[] delegate there.
+
     # Registers the given callback block to be called when settings change.
     # These are run using the shared thread that monitors for changes so be courteous and don't monopolize it!
     def on_change(&callback)
@@ -109,10 +107,6 @@ module ProcessSettings
 
     private
 
-    def listener
-
-    end
-
     # Loads the most recent settings from disk
     def load_untargeted_settings
       new_untargeted_settings = load_file(file_path)

data/lib/process_settings/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ProcessSettings
-  VERSION = '0.5.4.pre.1'
+  VERSION = '0.5.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: process_settings
 version: !ruby/object:Gem::Version
-  version: 0.5.4.pre.1
+  version: 0.5.4
 platform: ruby
 authors:
 - Invoca
@@ -98,11 +98,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Dynamic process settings