prioritized_callbacks 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 67fa423205b68cba0faae8dbe2c7ae6e2d27d4e935fa8b9240368f1db1364833
-  data.tar.gz: 684ebfffafab4bc89ff968983970c98ca5a996174f3d50307bd7b1fab56e83fb
+  metadata.gz: 920ddd09c3a79727ca904220114d5ed4df1f2246422bf708b8ccdce47534dab1
+  data.tar.gz: 5d1eccf1d4632e79130cd9e388bde7f69b32e88dae781a79161b721e05adb938
 SHA512:
-  metadata.gz: 6150409a8dcf199c6aca6685d01b3fd8ef33b62a562ee95fcd92e578fdc05279a38f6f54b91b6ebb85b3e4e2230407acb46d2380c559120d4246668cf5f732f9
-  data.tar.gz: 8b39d7091e40da431c89f40389ebc8d5b703b454b3219de41d64094866a54149439e6971696368f76b02a591098ae276671887838df2dce3ad9147752cac166f
+  metadata.gz: 0d341ef80863b66a8c31cce8ce407f25475d88426b25c5aa0e4118742173db5939f6e12b5e82844d8242989d79d1ccab5244ce199ce99eb3af8f0577c693a6b8
+  data.tar.gz: 6909e13c7d26c8f4edcce63ed9a6a72530513e0ab3e8a8a9de3c32e15601fef64763aa512a0257db0401b906fe1b60f20ace242b43066bed4adade2f2262354e

data/README.md

@@ -102,4 +102,12 @@ set_callbacks_order :save, [..., :default, ...]
 The latter can be used outside of ActiveRecord, in ActionController or ActiveModel, where ActiveSupport::Callbacks
 are included.
 
+To append the order in any inherited class:
+
+```ruby
+append_save_order :my_order, before: :default
+```
+
+You can specify `:before` or `:after` to specify a place where new order item should be inserted.
+
 2) To set priority for specific callback, you should add `:priority` option to `before_save` or `after_save`.

data/lib/prioritized_callbacks/active_model/callbacks_patch.rb

@@ -10,7 +10,10 @@ module PrioritizedCallbacks
 
         callbacks.each do |callback|
           define_singleton_method "set_#{callback}_order" do |*args|
-            set_callbacks_order(:"#{callback}", args)
+            set_callbacks_order(callback, args)
+          end
+          define_singleton_method "append_#{callback}_order" do |*args, **options|
+            append_callbacks_order(callback, args, options)
           end
         end
       end

data/lib/prioritized_callbacks/active_support/callbacks_class_methods_patch.rb

@@ -1,10 +1,27 @@
 module PrioritizedCallbacks
   module ActiveSupport
     module CallbacksClassMethodsPatch
-      def set_callbacks_order(name, order)
+      def set_callbacks_order(name, order_items)
         chain = get_callbacks(name)
         raise ArgumentError, "Callbacks for #{name} are not defined" unless chain
-        set_callbacks name, chain.copy_with_new_order(order)
+        set_callbacks name, chain.copy_with_new_order(order_items)
+      end
+
+      def append_callbacks_order(name, order_items, options = {})
+        chain = get_callbacks(name)
+        raise ArgumentError, "Callbacks for #{name} are not defined" unless chain
+        order = chain.config[:order]
+        insert_pos = order.size
+        if (before = options[:before])
+          insert_pos = order.index(before)
+          raise ArgumentError, "Order '#{before}' is not defined in #{name} callbacks" unless insert_pos
+        elsif (after = options[:after])
+          insert_pos = order.index(after)
+          raise ArgumentError, "Order '#{after}' is not defined in #{name} callbacks" unless insert_pos
+          insert_pos += 1
+        end
+        order.insert insert_pos, *order_items
+        set_callbacks_order name, order
       end
     end
   end

data/lib/prioritized_callbacks/version.rb

@@ -1,3 +1,3 @@
 module PrioritizedCallbacks
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/lib/activerecord_callbacks_spec.rb

@@ -87,10 +87,28 @@ RSpec.describe ActiveRecord::Callbacks do
     end
   end
 
+  class Record5 < Record2
+    append_save_order :final
+
+    before_save priority: :final do
+      self.text += 'X'
+    end
+  end
+
+  class Record6 < Record5
+    append_save_order :initial, before: :first
+
+    before_save priority: :initial do
+      self.text += 'Y'
+    end
+  end
+
   let(:record1) { Record1.new.tap(&:save) }
   let(:record2) { Record2.new.tap(&:save) }
   let(:record3) { Record3.new.tap(&:save) }
   let(:record4) { Record4.new.tap(&:save) }
+  let(:record5) { Record5.new.tap(&:save) }
+  let(:record6) { Record6.new.tap(&:save) }
 
   it 'has default order if order is not specified' do
     expect(record1.text).to eq('012934')
@@ -111,4 +129,12 @@ RSpec.describe ActiveRecord::Callbacks do
   it "has proper order when around is used" do
     expect(record4.text).to eq('1342')
   end
+
+  it "has proper order when new order item is appended" do
+    expect(record5.text).to eq('1023X4956')
+  end
+
+  it "has proper order when new order item is appended to the beginning" do
+    expect(record6.text).to eq('Y1023X4956')
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prioritized_callbacks
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Anton Argirov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-02 00:00:00.000000000 Z
+date: 2021-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport