primer_view_components 0.36.0 → 0.36.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0b0b4fd77e2d1af1c16252a9d51e6119854feca261d5273ecaafdf92163e977
-  data.tar.gz: f6778ad278e638c50b2aea8f86fcd73617d9822ca167da12a54d7de3710a1c75
+  metadata.gz: c94fae989b4359c72f7dfeeb678b4fafc93240645a4ff14d55ed16fdf0998cd8
+  data.tar.gz: 4ea33c5d1b3f88eb6033b99f368cdccf19ce9ff986c79b29b02bdb3c447e5bb2
 SHA512:
-  metadata.gz: 041a15920d44bfe62d5de05834b6a1bc2c4a27435b38dc52e6abb3bbb9a47efa13749b751a9c4401f42c8cf37f401743e064433df73a3d779e63ffbbde3117fb
-  data.tar.gz: badf04216b82031fb70f0902803ef0dd965f57d18ec0af8b48aad9d59390d91a6b5af1079ac29198f9b0cf2c5cba7429bf300a023d46fc8414885878907e9b61
+  metadata.gz: 48b79cf2df6eeef3791186744be2844a51979daff0f7f922af1b05fc6b2577ef293dd203b6f2bc451d959f2e2a3ba19111a79edf7a4d92fe2585ad26d153b5fe
+  data.tar.gz: cb5df33ba3522d34402d18e2fae5859f6544a1fb471ffd55e3a31af014efb6fb89f4485fcf6088344d410362cefc2cc28bc69a3898ec2b82fa3dd71dda8aa242

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.36.1
+
+### Patch Changes
+
+- [#3220](https://github.com/primer/view_components/pull/3220) [`688a4a2`](https://github.com/primer/view_components/commit/688a4a263deb4be70763b9ba39cae854896b44ce) Thanks [@jonrohan](https://github.com/jonrohan)! - Remove SystemArgumentInsteadOfClass linter and fix bug with whitespace in rendered class
+
 ## 0.36.0
 
 ### Minor Changes

data/lib/primer/classify.rb

@@ -49,7 +49,7 @@ module Primer
             case key
             when :classes
               # insert :classes first to avoid huge doc diffs
-              result.unshift(val)
+              result.unshift(val) unless val.blank?
               next
             when :style
               style = val

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 36
-      PATCH = 0
+      PATCH = 1
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/config/default.yml

@@ -1,9 +1,6 @@
 require:
   - rubocop/cop/primer
 
-Primer/SystemArgumentInsteadOfClass:
-  Enabled: true
-
 Primer/NoTagMemoize:
   Enabled: false
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.36.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -726,7 +726,6 @@ files:
 - lib/rubocop/cop/primer/deprecated_layout_component.rb
 - lib/rubocop/cop/primer/no_tag_memoize.rb
 - lib/rubocop/cop/primer/primer_octicon.rb
-- lib/rubocop/cop/primer/system_argument_instead_of_class.rb
 - lib/rubocop/cop/primer/test_selector.rb
 - lib/tasks/custom_utilities.yml
 - previews/pages/forms/01_introduction.md.erb

data/lib/rubocop/cop/primer/system_argument_instead_of_class.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-require "primer/classify/utilities"
-
-# :nocov:
-module RuboCop
-  module Cop
-    module Primer
-      # This cop ensures that components use System Arguments instead of CSS classes.
-      #
-      # bad
-      # Component.new(classes: "mr-1")
-      #
-      # good
-      # Component.new(mr: 1)
-      class SystemArgumentInsteadOfClass < BaseCop
-        INVALID_MESSAGE = <<~STR
-          Avoid using CSS classes when you can use System Arguments: https://primer.style/view-components/system-arguments.
-        STR
-
-        def on_send(node)
-          return unless valid_node?(node)
-          return unless node.arguments?
-
-          # we are looking for hash arguments and they are always last
-          kwargs = node.arguments.last
-
-          return unless kwargs.type == :hash
-
-          # find classes pair
-          classes_arg = kwargs.pairs.find { |kwarg| kwarg.key.value == :classes }
-
-          return if classes_arg.nil?
-          return unless classes_arg.value.type == :str
-
-          # get actual classes
-          classes = classes_arg.value.value
-
-          system_arguments = ::Primer::Classify::Utilities.classes_to_hash(classes)
-
-          # no classes are fixable
-          return if system_arguments[:classes] == classes
-
-          add_offense(classes_arg, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            args = ::Primer::Classify::Utilities.classes_to_args(node.value.value)
-            corrector.replace(node.loc.expression, args)
-          end
-        end
-      end
-    end
-  end
-end