primer_view_components 0.0.88 → 0.0.89

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b26233820f7e3fd5f92dbfe2b73b8ee9d4a59804bd93902bd98ab0cb2896d828
-  data.tar.gz: 114d47251ebb0c4633a0d2b1e59bdddcd85a0c8aba2d2942d52598ef5e62f732
+  metadata.gz: 549fdec61b2c1c8c5ae3632f2cc567939f00e7679c7b350e86198e6c50db00fe
+  data.tar.gz: e2ea2f9570dbb93b53c5cddc6d4e98f1ed7b6918b4c7f1a879179b48ccfda0b3
 SHA512:
-  metadata.gz: b6c4cff16a390f08f54d246a6e195862fa3572091f955ce74c85e47df31516deec98beb93ad8c4a526d51eb41b8ec1f5ef3c2e934d497fb81e6974e5df781aca
-  data.tar.gz: 1943282801abaaa921514cf116286ad274b7f71ad8e41c8cda9456a9d57364a67039dd9ad53ca2f0108bdefc6e23bbdf56c749e911829a6a4981d1619e9b4167
+  metadata.gz: cd33068d7ba46698d4e31afff8bf2edbb51472d04fdddd3a776835721ee80bf56e2fe2c398fd8545a66cdf1250b65b55f567ce488e14791737a6ccc955e54e90
+  data.tar.gz: 7bc316d92551cd6cfd15108fd864ad39a9322f3988936dc8d6aab73583d1ece0f8be035cadd637d2a352ea96ac2722b752926ee6e6136f6c61bdb70b4388f9e5

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 0.0.89
+
+### Patch Changes
+
+- [#1284](https://github.com/primer/view_components/pull/1284) [`401dac2a`](https://github.com/primer/view_components/commit/401dac2a1ab2e026b231399ddb03cfb51bc7742f) Thanks [@jonrohan](https://github.com/jonrohan)! - Don't render tooltip on IconButton when tag is a summary element
+
+* [#1283](https://github.com/primer/view_components/pull/1283) [`ea1c29d7`](https://github.com/primer/view_components/commit/ea1c29d7fa0d917a729cba684bf5f8ae039bb228) Thanks [@jonrohan](https://github.com/jonrohan)! - Updating label component to not always have large
+
 ## 0.0.88
 
 ### Patch Changes

data/app/components/primer/icon_button.html.erb

@@ -1,6 +1,12 @@
-<%= render Primer::BaseComponent.new(tag: :div, position: :relative, display: :inline_block) do %>
+<% if render_tooltip? %>
+  <%= render Primer::BaseComponent.new(tag: :div, position: :relative, display: :inline_block) do %>
+    <%= render Primer::Beta::BaseButton.new(**@system_arguments) do -%>
+      <%= render Primer::OcticonComponent.new(icon: @icon) %>
+    <% end -%>
+    <%= render Primer::Alpha::Tooltip.new(**@tooltip_arguments) %>
+  <% end %>
+<% else %>
   <%= render Primer::Beta::BaseButton.new(**@system_arguments) do -%>
     <%= render Primer::OcticonComponent.new(icon: @icon) %>
   <% end -%>
-  <%= render Primer::Alpha::Tooltip.new(**@tooltip_arguments) %>
 <% end %>

data/app/components/primer/icon_button.rb

@@ -97,5 +97,11 @@ module Primer
         @tooltip_arguments[:type] = :label
       end
     end
+
+    private
+
+    def render_tooltip?
+      @system_arguments[:tag] != :summary
+    end
   end
 end

data/app/components/primer/label_component.rb

@@ -77,7 +77,8 @@ module Primer
 
       @variant = fetch_or_fallback(VARIANT_OPTIONS, variant, nil, deprecated_values: DEPRECATED_VARIANT_OPTIONS)
       @scheme = fetch_or_fallback(SCHEME_OPTIONS, scheme, DEFAULT_SCHEME, deprecated_values: DEPRECATED_SCHEME_OPTIONS)
-      @size = fetch_or_fallback(SIZE_OPTIONS, size) || @variant == :large ? :large : nil || DEFAULT_SIZE
+      @size = fetch_or_fallback(SIZE_OPTIONS, size, DEFAULT_SIZE)
+      @size = :large if @variant == :large
       @inline = inline || @variant == :inline
 
       @system_arguments[:tag] = fetch_or_fallback(TAG_OPTIONS, tag, DEFAULT_TAG)

data/app/components/primer/primer.d.ts

@@ -6,4 +6,3 @@ import './local_time';
 import './image_crop';
 import './dropdown';
 import './alpha/tool-tip-element';
-import './alpha/segmented-control-element';

data/app/components/primer/primer.js

@@ -6,4 +6,3 @@ import './local_time';
 import './image_crop';
 import './dropdown';
 import './alpha/tool-tip-element';
-import './alpha/segmented-control-element';

data/lib/primer/view_components/linters/flash_migration_counter.rb

@@ -12,7 +12,7 @@ module ERBLint
 
       TAGS = %w[div].freeze
       CLASSES = %w[flash].freeze
-      MESSAGE = "We are migrating flashes to use [Primer::Beta::Flash](https://primer.style/view-components/components/flash), please try to use that instead of raw HTML."
+      MESSAGE = "We are migrating flashes to use [Primer::Beta::Flash](https://primer.style/view-components/components/beta/flash), please try to use that instead of raw HTML."
       ARGUMENT_MAPPER = ArgumentMappers::Flash
       COMPONENT = "Primer::Beta::Flash"
 

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 88
+      PATCH = 89
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.88
+  version: 0.0.89
 platform: ruby
 authors:
 - GitHub Open Source
@@ -412,8 +412,6 @@ files:
 - app/components/primer/alpha/button_marketing.rb
 - app/components/primer/alpha/layout.html.erb
 - app/components/primer/alpha/layout.rb
-- app/components/primer/alpha/segmented-control-element.d.ts
-- app/components/primer/alpha/segmented-control-element.js
 - app/components/primer/alpha/tab_nav.html.erb
 - app/components/primer/alpha/tab_nav.rb
 - app/components/primer/alpha/tab_panels.html.erb

data/app/components/primer/alpha/segmented-control-element.d.ts

@@ -1,8 +0,0 @@
-export default class SegmentedControlElement extends HTMLElement {
-    constructor();
-}
-declare global {
-    interface Window {
-        SegmentedControlElement: typeof SegmentedControlElement;
-    }
-}

data/app/components/primer/alpha/segmented-control-element.js

@@ -1,27 +0,0 @@
-/* eslint-disable custom-elements/no-constructor */
-export default class SegmentedControlElement extends HTMLElement {
-    constructor() {
-        super();
-        this.addEventListener('click', (event) => {
-            const controls = Array.from(this.querySelectorAll('[role="toolbar"] button')).filter(tab => tab instanceof HTMLElement && tab.closest(this.tagName) === this);
-            if (!(event.target instanceof Element))
-                return;
-            if (event.target.closest(this.tagName) !== this)
-                return;
-            const selectedControl = event.target.closest('button');
-            if (!(selectedControl instanceof HTMLElement) || !selectedControl.closest('[role="toolbar"]'))
-                return;
-            for (const control of controls) {
-                control.classList.remove('SegmentedControl-button--selected');
-                control.setAttribute('aria-current', 'false');
-            }
-            selectedControl.classList.add('SegmentedControl-button--selected');
-            selectedControl.setAttribute('aria-current', 'true');
-            selectedControl.focus();
-        });
-    }
-}
-if (!window.customElements.get('segmented-control')) {
-    window.SegmentedControlElement = SegmentedControlElement;
-    window.customElements.define('segmented-control', SegmentedControlElement);
-}