primer_view_components 0.0.80 → 0.0.81

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02db6633db0431026dcc622e6935e0f27bc627408f106bd8b35ab1ab2af9f092
-  data.tar.gz: 8fa5bcc873e721e5b988567239fa0898d02db9e5a14300afcdece1566674259f
+  metadata.gz: 5e807ec7189fc1b68388e5d3eabefa155c77cbf89d5d6572ac93eed37d9132e5
+  data.tar.gz: 4f32138832c7a375e185661f7d17e8c65f65b04364834f8a1866c4efca397232
 SHA512:
-  metadata.gz: ddcea4c9e66c560c6b1765da45df204c82d5d0a650d37338ebdf65fda33dcffa1b4d0c3142d456be462f6340c79b22bde1e01ce1435887e50380df550aa793ed
-  data.tar.gz: fb1112c5408048471a8ee0ca76c05dcd6d04d206e2372e331ee9edaec03cf5186bfade184f722abb064a5055f93877f78ea300cfb3f2a5ae59d8aad2279f71e3
+  metadata.gz: e7ee4567ce2f7a73a692a0f975a3a134b25ac5ae2183a70a295fbb4c3742d54b71944900445ed37c9257784049ffd45cb4d5c98105d7109dcf808926d1b53b7a
+  data.tar.gz: 415e4727e4cc542647ac1e69a407fbe7d329bdb068b724963359fc871e68699a35ba93a7e4423b69ad0f8cc2f80e70218ba6d7c1aa9ec3721569ed154ee1f0c4

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 0.0.81
+
+### Patch Changes
+
+- [#1200](https://github.com/primer/view_components/pull/1200) [`a6505054`](https://github.com/primer/view_components/commit/a6505054a07ae006c9d48e19a2b4be6c2e2663b3) Thanks [@camertron](https://github.com/camertron)! - Use Rubocop cops to lint .erb files
+
+* [#1201](https://github.com/primer/view_components/pull/1201) [`de2c7d68`](https://github.com/primer/view_components/commit/de2c7d68ff7d13135c04f5dd40a1e547e41923ba) Thanks [@camertron](https://github.com/camertron)! - Add xsmall size for octicons
+
 ## 0.0.80
 
 ### Patch Changes

data/app/components/primer/blankslate_component.html.erb

@@ -5,7 +5,7 @@
   <% elsif @icon.present? %>
     <%= primer_octicon @icon, size: @icon_size, classes: "blankslate-icon" %>
   <% elsif @image_src.present? && @image_alt.present? %>
-    <%= image_tag "#{@image_src}", class: "mb-3", size: "56x56", alt: "#{@image_alt}" %>
+    <%= image_tag @image_src.to_s, class: "mb-3", size: "56x56", alt: @image_alt.to_s %>
   <% end %>
 
   <% if @title.present? %>
@@ -24,7 +24,7 @@
 
   <% if @link_text.present? && @link_url.present? %>
     <p>
-      <%= link_to "#{@link_url}" do %><%= @link_text %><% end %>
+      <%= link_to @link_url.to_s do %><%= @link_text %><% end %>
     </p>
   <% end %>
 <% end %>

data/app/components/primer/octicon_component.rb

@@ -8,10 +8,12 @@ module Primer
   class OcticonComponent < Primer::Component
     status :beta
 
+    SIZE_XSMALL = :xsmall
     SIZE_DEFAULT = :small
     SIZE_MEDIUM = :medium
 
     SIZE_MAPPINGS = {
+      SIZE_XSMALL => 12,
       SIZE_DEFAULT => 16,
       SIZE_MEDIUM => 24
     }.freeze

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 80
+      PATCH = 81
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/config/default.yml

@@ -1,9 +1,33 @@
 require:
   - rubocop/cop/primer
+  - rubocop-rails
 
-AllCops:
-  DisabledByDefault: true
+####### RUBOCOP'S DEFAULTS #######
+# we don't want these in .erb files
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# lots of false-positives in .erb files
+Layout/InitialIndentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# lots of false-positives - this cop is meant for Ruby code, not .erb
+Layout/TrailingEmptyLines:
+  Enabled: false
+
+# it's often not desirable to add unnecessary newlines into .erb files, as
+# they will appear in the rendered HTML
+Layout/LineLength:
+  Enabled: false
+
+# calling .html_safe in templates is ok
+Rails/OutputSafety:
+  Enabled: false
 
+####### PRIMER COPS #######
 Primer/SystemArgumentInsteadOfClass:
   Enabled: true
 

data/static/arguments.yml

@@ -885,7 +885,7 @@
   - name: size
     type: Symbol
     default: "`:small`"
-    description: One of `:small` (`16`) and `:medium` (`24`).
+    description: One of `:xsmall` (`12`), `:small` (`16`), or `:medium` (`24`).
   - name: use_symbol
     type: Boolean
     default: "`false`"

data/static/constants.json

@@ -644,14 +644,17 @@
   "Primer::OcticonComponent": {
     "SIZE_DEFAULT": "small",
     "SIZE_MAPPINGS": {
+      "xsmall": 12,
       "small": 16,
       "medium": 24
     },
     "SIZE_MEDIUM": "medium",
     "SIZE_OPTIONS": [
+      "xsmall",
       "small",
       "medium"
-    ]
+    ],
+    "SIZE_XSMALL": "xsmall"
   },
   "Primer::OcticonSymbolsComponent": {
   },

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.80
+  version: 0.0.81
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-27 00:00:00.000000000 Z
+date: 2022-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview