primer_view_components 0.0.73 → 0.0.74

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 360520e82ed3b675176993d07d7cd293fc7ac094580c8409391aa640a3dc2659
-  data.tar.gz: 5443e46dc1ee9e900ec891b202a65e9fd6542e9eb3e190fb5b71ac29359f650b
+  metadata.gz: 99efb2e6dc8f3d4a87a4b2f2ef15f3c03297fc5e055fd9c2f4633990206dd788
+  data.tar.gz: 6d3ee3c23ccc62b9185c4723846a14351a6ed2739da99b6063b471e38041342c
 SHA512:
-  metadata.gz: 34fe9c8220f17ae7f8e9f5816c3ac0f88d7edcf255d08fc838ebd206cba9f1986c2da8a6d6ab1b251ae47edd1477b308ed4d0595ea3e397edc4042a5d50fd7f7
-  data.tar.gz: 6897b304a345d5e4c05b321a786f251ffabba4dd6d5578f3e8604a72d0b3ab81817de5d8bf77416853cd1b718833024e53da5c4d4b53fa178fb30d1b061c3d55
+  metadata.gz: 6831cfbc1bc45bfc116d08e9062a571333c6fe0a762ba6d69314fef1e3307036c70bcae48d7586b48adb4d25c5ac60a748c2b205f326181f8506d612aa851f8f
+  data.tar.gz: a5a530e666be4b7f88bf07227e1f2354e1f14c4f12c8ce29d59f01b9b5c9920bfdeb8887815aa8cad1db22d4aa1d7a6a3d3c13e50a8ce8ac64969eb79915be64

data/CHANGELOG.md

@@ -1,34 +1,14 @@
 # CHANGELOG
 
-<!--
-Authoring changelog entries
+## 0.0.74
 
-This file holds all the changes made in previous versions of Primer View Components and the ones coming to the next version.
-To add yours, you need to find in which category to write it under the `main` section. `Main` is the first section on top of the document.
-There are six categories currently in use, `New`, `Updates`, `Bug fixes`, `Breaking changes`, `Deprecations` and `Misc`.
+### Patch Changes
 
-- New
-Category for new components, system behaviours, options and arguments changes
+- [#1150](https://github.com/primer/view_components/pull/1150) [`36702a8e`](https://github.com/primer/view_components/commit/36702a8e621766772fe09d80de74c4debe8950fd) Thanks [@jonrohan](https://github.com/jonrohan)! - Adding changesets workflow to the repository for managing releases.
 
-- Updates
-Every non-breaking change to the source code go there.
+* [#1153](https://github.com/primer/view_components/pull/1153) [`8b21a680`](https://github.com/primer/view_components/commit/8b21a6808f5a9b18bd8b436b07b5b8b84b5a7397) Thanks [@camertron](https://github.com/camertron)! - Add a linter for calls to super in templates
 
-- Bug Fixes
-Non-breaking bug fixes to existing code.
-
-- Breaking Changes
-The category for changes creating incompatibilities to code written with previous versions.
-It includes any changes to components name, signature and behaviour. Also, include removing tags options or changing file location.
-If you are not sure you made breaking changes, ask us in your pull request.
-
-- Deprecations
-For changes that explicitly deprecate part of the code base.
-
-- Misc
-The category for changes related to documentation, testing and tooling. Also, for pull requests that can't fit in other sections.
--->
-
-## main
+- [#1141](https://github.com/primer/view_components/pull/1141) [`300f79a7`](https://github.com/primer/view_components/commit/300f79a762c71397de90f8d1cada529b9e9d63b6) Thanks [@maxbeizer](https://github.com/maxbeizer)! - AutoComplete component does not apply stacked label class if the label is not visible
 
 ## 0.0.73
 
@@ -36,7 +16,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Add conditional check for shadow root to avoid errors.
 
-    _Kate Higa_
+  _Kate Higa_
 
 ## 0.0.72
 
@@ -45,25 +25,25 @@ The category for changes related to documentation, testing and tooling. Also, fo
 - Fix tooltip arrow being off-centered for `s` and `n`.
 - Revert tooltip arrow offset for `sw`, `se`, `nw`, and `ne`.
 
-    _Kate Higa_
+  _Kate Higa_
 
 ### Misc
 
 - Adding [lookbook](https://github.com/allmarkedup/lookbook) dev server to the project.
 
-    _Jon Rohan_
+  _Jon Rohan_
 
 - Bump @primer/behaviors and remove dead code.
 
-    _Kate Higa_
+  _Kate Higa_
 
 - Enable `eslint-plugin-custom-elements` linting rulesets.
 
-    _Kate Higa_, _Kristján Oddsson_
+  _Kate Higa_, _Kristján Oddsson_
 
 - Introduce `DeprecatedComponents` rubocop rule.
 
-    _Kate Higa_
+  _Kate Higa_
 
 - Fix alphabetization of components in docs.
 
@@ -96,7 +76,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Add responsive values for `text_align` system argument
 
-    _Lukas Spieß_
+  _Lukas Spieß_
 
 ## 0.0.70
 
@@ -104,25 +84,25 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Add `Tooltip` support to `Button`.
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 - Add `Tooltip` support to `Link`.
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 ### Updates
 
 - Bumps @primer/css to 19.7.1
-    _Kate Higa_
+  _Kate Higa_
 
 - Bumps auto-complete package to 3.1.0
 - Updates AutoComplete API with optional clear button, restricted icon, and other argument restrictions
 
-    _Lindsey Wild_, _Kate Higa_, _Owen Niblock_
+  _Lindsey Wild_, _Kate Higa_, _Owen Niblock_
 
 - Check for the `gh` CLI tool in release scripts.
 
-    _Cameron Dutro_
+  _Cameron Dutro_
 
 ### Bug Fixes
 
@@ -140,27 +120,27 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Add ability to attach custom CSS classes to items added to `Truncate` components.
 
-    _Cameron Dutro_
+  _Cameron Dutro_
 
 - Add `Primer::Alpha::Tooltip` component
 
-    _Kate Higa_, _Kristján Oddsson_
+  _Kate Higa_, _Kristján Oddsson_
 
 ### Breaking Changes
 
 - Module for [script/update-statuses-project.rb](script/update-statuses-project.rb) changed to `GitHub`
 
-    _Josh Soref_
+  _Josh Soref_
 
 ### Misc
 
 - Spelling fixes
 
-    _Josh Soref_
+  _Josh Soref_
 
 - Bump view_component in Gemfile.lock files
 
-    _Cameron Dutro_
+  _Cameron Dutro_
 
 - Remove markdown file mistakenly checked in.
 
@@ -174,7 +154,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Fix missing @primer/components dependency.
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 ## 0.0.68
 
@@ -182,34 +162,34 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Add accessible labels to Search AutoComplete when provided with an icon.
 
-    _Andri Alexandrou_
+  _Andri Alexandrou_
 
 - Restricts children for AutoComplete API to prevent accessibility violations and misuse
 
-    _Lindsey Wild_
+  _Lindsey Wild_
 
 - Migrate from Heroku to Azure for the Rails storybook server.
 - Build storybook static assets into Docker image.
 
-    _Cameron Dutro_
+  _Cameron Dutro_
 
 - Remove CSS utilities from Blankslate
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 - Improve last example on the PopoverComponent docs
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 ### Bug Fixes
 
 - Fix live reloading during local docs development.
 
-    _Cameron Dutro_
+  _Cameron Dutro_
 
 - Fix sequence of content in Subhead.
 
-    _Hector Garcia_
+  _Hector Garcia_
 
 ### Deprecations
 
@@ -235,7 +215,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Updating octicons to `> 16`
 
-    _Jon Rohan_
+  _Jon Rohan_
 
 ## 0.0.66
 
@@ -255,7 +235,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 - Optimize logic for converting class names into args
 
-    *Josh Klina*
+  _Josh Klina_
 
 ### Deprecations
 

data/app/components/primer/alpha/tool-tip-element.js

@@ -56,7 +56,7 @@ class ToolTipElement extends HTMLElement {
         white-space: normal;
         width: max-content;
       }
-      
+
       :host:before{
         position: absolute;
         z-index: 1000001;
@@ -65,7 +65,7 @@ class ToolTipElement extends HTMLElement {
         border: 6px solid transparent;
         opacity: 0
       }
-      
+
       @keyframes tooltip-appear {
         from {
           opacity: 0
@@ -74,7 +74,7 @@ class ToolTipElement extends HTMLElement {
           opacity: 1
         }
       }
-      
+
       :host:after{
         position: absolute;
         display: block;
@@ -83,7 +83,7 @@ class ToolTipElement extends HTMLElement {
         height: 12px;
         content: ""
       }
-      
+
       :host(.${TOOLTIP_OPEN_CLASS}),
       :host(.${TOOLTIP_OPEN_CLASS}):before {
         animation-name: tooltip-appear;
@@ -92,7 +92,7 @@ class ToolTipElement extends HTMLElement {
         animation-timing-function: ease-in;
         animation-delay: .4s
       }
-      
+
       :host(.tooltip-s):before,
       :host(.tooltip-n):before {
         right: 50%;
@@ -105,38 +105,38 @@ class ToolTipElement extends HTMLElement {
         bottom: 100%;
         border-bottom-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-s):after,
       :host(.tooltip-se):after,
       :host(.tooltip-sw):after {
         bottom: 100%
       }
-      
+
       :host(.tooltip-n):before,
       :host(.tooltip-ne):before,
       :host(.tooltip-nw):before {
         top: 100%;
         border-top-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-n):after,
       :host(.tooltip-ne):after,
       :host(.tooltip-nw):after {
         top: 100%
       }
-      
+
       :host(.tooltip-se):before,
       :host(.tooltip-ne):before {
         left: 0;
         margin-left: ${TOOLTIP_ARROW_EDGE_OFFSET}px;
       }
-      
+
       :host(.tooltip-sw):before,
       :host(.tooltip-nw):before {
         right: 0;
         margin-right: ${TOOLTIP_ARROW_EDGE_OFFSET}px;
       }
-      
+
       :host(.tooltip-w):before {
         top: 50%;
         bottom: 50%;
@@ -144,7 +144,7 @@ class ToolTipElement extends HTMLElement {
         margin-top: -6px;
         border-left-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-e):before {
         top: 50%;
         right: 100%;

data/app/components/primer/alpha/tool-tip-element.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line prettier/prettier
 import type {AnchorAlignment, AnchorSide} from '@primer/behaviors'
 import {getAnchoredPosition} from '@primer/behaviors'
 
@@ -42,7 +43,7 @@ class ToolTipElement extends HTMLElement {
         white-space: normal;
         width: max-content;
       }
-      
+
       :host:before{
         position: absolute;
         z-index: 1000001;
@@ -51,7 +52,7 @@ class ToolTipElement extends HTMLElement {
         border: 6px solid transparent;
         opacity: 0
       }
-      
+
       @keyframes tooltip-appear {
         from {
           opacity: 0
@@ -60,7 +61,7 @@ class ToolTipElement extends HTMLElement {
           opacity: 1
         }
       }
-      
+
       :host:after{
         position: absolute;
         display: block;
@@ -69,7 +70,7 @@ class ToolTipElement extends HTMLElement {
         height: 12px;
         content: ""
       }
-      
+
       :host(.${TOOLTIP_OPEN_CLASS}),
       :host(.${TOOLTIP_OPEN_CLASS}):before {
         animation-name: tooltip-appear;
@@ -78,7 +79,7 @@ class ToolTipElement extends HTMLElement {
         animation-timing-function: ease-in;
         animation-delay: .4s
       }
-      
+
       :host(.tooltip-s):before,
       :host(.tooltip-n):before {
         right: 50%;
@@ -91,38 +92,38 @@ class ToolTipElement extends HTMLElement {
         bottom: 100%;
         border-bottom-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-s):after,
       :host(.tooltip-se):after,
       :host(.tooltip-sw):after {
         bottom: 100%
       }
-      
+
       :host(.tooltip-n):before,
       :host(.tooltip-ne):before,
       :host(.tooltip-nw):before {
         top: 100%;
         border-top-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-n):after,
       :host(.tooltip-ne):after,
       :host(.tooltip-nw):after {
         top: 100%
       }
-      
+
       :host(.tooltip-se):before,
       :host(.tooltip-ne):before {
         left: 0;
         margin-left: ${TOOLTIP_ARROW_EDGE_OFFSET}px;
       }
-      
+
       :host(.tooltip-sw):before,
       :host(.tooltip-nw):before {
         right: 0;
         margin-right: ${TOOLTIP_ARROW_EDGE_OFFSET}px;
       }
-      
+
       :host(.tooltip-w):before {
         top: 50%;
         bottom: 50%;
@@ -130,7 +131,7 @@ class ToolTipElement extends HTMLElement {
         margin-top: -6px;
         border-left-color: var(--color-neutral-emphasis-plus)
       }
-      
+
       :host(.tooltip-e):before {
         top: 50%;
         right: 100%;

data/app/components/primer/beta/auto_complete.rb

@@ -131,7 +131,7 @@ module Primer
         @with_icon = with_icon
         @is_clearable = is_clearable
 
-        @label_classes = is_label_inline ? "autocomplete-label-inline" : "autocomplete-label-stacked"
+        @label_classes = label_classes(is_label_visible: is_label_visible, is_label_inline: is_label_inline)
         @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = "auto-complete"
         @system_arguments[:src] = src
@@ -143,6 +143,20 @@ module Primer
         results(classes: "") unless results
         input(classes: "") unless input
       end
+
+      private
+
+      # Private: determines the label classes based on component configration.
+      #
+      # If the label is not visible, return an empty string.
+      #
+      # @param args [Hash] The component configuration.
+      # @return [String] The label classes.
+      def label_classes(**args)
+        return "" if args[:is_label_visible] == false
+
+        args[:is_label_inline] ? "autocomplete-label-inline" : "autocomplete-label-stacked"
+      end
     end
   end
 end

data/app/components/primer/clipboard_copy_component.ts

@@ -32,7 +32,7 @@ function showCheck(button: HTMLElement) {
 
 const clipboardCopyElementTimers = new WeakMap<HTMLElement, number>()
 
-document.addEventListener('clipboard-copy', function ({target}) {
+document.addEventListener('clipboard-copy', function({target}) {
   if (!(target instanceof HTMLElement)) return
   if (!target.hasAttribute('data-view-component')) return
 

data/lib/primer/view_components/linters/super_in_component_templates.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require_relative "helpers/rubocop_helpers"
+
+module ERBLint
+  module Linters
+    # Replaces calls to `super` with calls to `render_parent`.
+    class SuperInComponentTemplates < Linter
+      include ERBLint::LinterRegistry
+      include Helpers::RubocopHelpers
+
+      def run(processed_source)
+        processed_source.ast.descendants(:erb).each do |erb_node|
+          indicator_node, _, code_node = *erb_node
+          code = code_node.children.first
+          ast = erb_ast(code)
+          next unless ast
+
+          super_call_nodes = find_super_call_nodes(ast)
+          next if super_call_nodes.empty?
+
+          indicator, = *indicator_node
+          indicator ||= ""
+
+          # +2 to account for the leading "<%" characters
+          code_start_pos = erb_node.location.begin_pos + indicator.size + 2
+
+          super_call_nodes.each do |super_call_node|
+            orig_loc = code_node.location
+            super_call_loc = super_call_node.location.expression
+
+            new_loc = orig_loc.with(
+              begin_pos: super_call_loc.begin_pos + code_start_pos,
+              end_pos: super_call_loc.end_pos + code_start_pos
+            )
+
+            add_offense(
+              new_loc,
+              "Avoid calling `super` in component templates. Call `render_parent` instead",
+              "render_parent"
+            )
+          end
+        end
+      end
+
+      def autocorrect(_, offense)
+        return unless offense.context
+
+        lambda do |corrector|
+          corrector.replace(offense.source_range, offense.context)
+        end
+      end
+
+      private
+
+      def find_super_call_nodes(ast)
+        return [ast] if ast.type == :zsuper
+
+        ast.each_child_node.flat_map do |child_ast|
+          find_super_call_nodes(child_ast)
+        end
+      end
+    end
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 73
+      PATCH = 74
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.73
+  version: 0.0.74
 platform: ruby
 authors:
 - GitHub Open Source
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-10 00:00:00.000000000 Z
+date: 2022-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -366,7 +366,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.25
-description: 
+description:
 email:
 - opensource+primer_view_components@github.com
 executables: []
@@ -541,6 +541,7 @@ files:
 - lib/primer/view_components/linters/helpers/rubocop_helpers.rb
 - lib/primer/view_components/linters/label_component_migration_counter.rb
 - lib/primer/view_components/linters/subhead_component_migration_counter.rb
+- lib/primer/view_components/linters/super_in_component_templates.rb
 - lib/primer/view_components/linters/tag_tree_helpers.rb
 - lib/primer/view_components/linters/two_column_layout_migration_counter.rb
 - lib/primer/view_components/statuses.rb
@@ -579,7 +580,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -594,8 +595,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: ViewComponents for the Primer Design System
 test_files: []