primer_view_components 0.0.63 → 0.0.64

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3512259d91cf17fa6a17c0cb75037b3bc438d14ea16da0d8190d6fa7988d4c6e
-  data.tar.gz: d0a59b08f193f263b5261c94923d48f613090128e898588b3f1a8132ae7cff63
+  metadata.gz: 293526832927614dca06b1e03788d2db4f94fef8a5572a20304bd85e5498bd53
+  data.tar.gz: 419cd1ea3365120b4a3bb4429a1b9da105b2dc3c8474015a661b6e44d319f359
 SHA512:
-  metadata.gz: 20ff155c9aad794c3712b478cedfba3abf2d83888a5b4c20af97600cfc4a2000173582585d1c9656806636f499b2c57505ab609352bc00cfa678bb980030fef7
-  data.tar.gz: 0da39969c71bcf2c102606f633d31ff213ade782744df47022c7a09d1178d0c4dc161d4b9c5f03848f5f8ec3c6cac63acc43b3e8d3563b106429800a02147667
+  metadata.gz: 2da4816e43ed7a7b7a13436d83d767bb5d6ee100748c7058f8a2f201e41132f34a17df862bf0f798b216f4b2b2cb6249b2bd61a3d620fbc401ce6fa06a16ce43
+  data.tar.gz: ca7bbc94ecdc2a39b57892f881b9be545b4af17456ac14094880a5154ebd6a2d6e69fe1e1b219f9ec1bbddac607a4c25b6f12c7117a32dd06366c3125f521f1b

data/CHANGELOG.md

@@ -30,6 +30,20 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 ## main
 
+## 0.0.64
+
+### New
+
+* Add `raise_on_invalid_aria` config option to silence `aria-label` errors.
+
+    *Manuel Puyol*
+
+### Bug Fixes
+
+* Add missing `border: 0`, `font_size: 0` and responsive `flex` system arguments.
+
+    *Manuel Puyol*
+
 ## 0.0.63
 
 ### Breaking Changes

data/app/components/primer/component.rb

@@ -23,6 +23,10 @@ module Primer
       Rails.application.config.primer_view_components.raise_on_invalid_options
     end
 
+    def raise_on_invalid_aria?
+      Rails.application.config.primer_view_components.raise_on_invalid_aria
+    end
+
     def deprecated_component_warning(new_class: nil, version: nil)
       return if Rails.env.production? || silence_deprecations?
 
@@ -101,10 +105,7 @@ module Primer
       return unless aria(:label, arguments)
       return unless INVALID_ARIA_LABEL_TAGS.include?(tag)
 
-      raise ArgumentError, "Don't use `aria-label` on `#{tag}` elements. See https://www.tpgi.com/short-note-on-aria-label-aria-labelledby-and-aria-describedby/" if should_raise_error?
-
-      arguments.except!(:"aria-label")
-      arguments[:aria] = arguments[:aria].except!(:label) if arguments[:aria]
+      raise ArgumentError, "Don't use `aria-label` on `#{tag}` elements. See https://www.tpgi.com/short-note-on-aria-label-aria-labelledby-and-aria-describedby/" if should_raise_aria_error?
     end
 
     def deny_tag_argument(**arguments)
@@ -114,5 +115,9 @@ module Primer
     def should_raise_error?
       raise_on_invalid_options? && !ENV["PRIMER_WARNINGS_DISABLED"]
     end
+
+    def should_raise_aria_error?
+      raise_on_invalid_aria? && !ENV["PRIMER_WARNINGS_DISABLED"]
+    end
   end
 end

data/app/components/primer/octicon_component.rb

@@ -65,8 +65,10 @@ module Primer
         # Filter out classify options to prevent them from becoming invalid html attributes.
         # Note height and width are both classify options and valid html attributes.
         octicon_options = {
-          height: SIZE_MAPPINGS[fetch_or_fallback(SIZE_OPTIONS, size, SIZE_DEFAULT)]
-        }.merge(@system_arguments.slice(:height, :width))
+          height: @system_arguments[:height] || SIZE_MAPPINGS[fetch_or_fallback(SIZE_OPTIONS, size, SIZE_DEFAULT)],
+          width: @system_arguments[:width]
+        }
+        octicon_options.compact!
 
         @icon = Octicons::Octicon.new(icon_key, octicon_options)
         Primer::Octicon::Cache.set(cache_key, @icon)

data/app/lib/primer/octicon/cache.rb

@@ -9,9 +9,10 @@ module Primer
       PRELOADED_ICONS = [:alert, :check, :"chevron-down", :paste, :clock, :"dot-fill", :info, :"kebab-horizontal", :link, :lock, :mail, :pencil, :plus, :question, :repo, :search, :"shield-lock", :star, :trash, :x].freeze
 
       class << self
-        def get_key(**kwargs)
-          correct_key_args?(**kwargs)
-          kwargs.hash
+        def get_key(symbol:, size:, width: nil, height: nil)
+          attrs = { symbol: symbol, size: size, width: width, height: height }
+          attrs.compact!
+          attrs.hash
         end
 
         def read(key)
@@ -37,13 +38,6 @@ module Primer
         def preload!
           PRELOADED_ICONS.each { |icon| Primer::OcticonComponent.new(icon: icon) }
         end
-
-        private
-
-        def correct_key_args?(symbol:, size:, width: nil, height: nil)
-          # This method does nothing but will raise an ArgumentError if the
-          # wrong args are passed.
-        end
       end
     end
   end

data/lib/primer/classify/utilities.yml

@@ -1578,6 +1578,12 @@
   - border-x
   true:
   - border
+  0:
+  - border-0
+  false:
+  - border-0
+  :dashed:
+  - border-dashed
 :border_top:
   0:
   - border-top-0
@@ -1602,32 +1608,84 @@
 :justify_content:
   :flex_start:
   - flex-justify-start
+  - flex-sm-justify-start
+  - flex-md-justify-start
+  - flex-lg-justify-start
+  - flex-xl-justify-start
   :flex_end:
   - flex-justify-end
+  - flex-sm-justify-end
+  - flex-md-justify-end
+  - flex-lg-justify-end
+  - flex-xl-justify-end
   :center:
   - flex-justify-center
+  - flex-sm-justify-center
+  - flex-md-justify-center
+  - flex-lg-justify-center
+  - flex-xl-justify-center
   :space_between:
   - flex-justify-between
+  - flex-sm-justify-between
+  - flex-md-justify-between
+  - flex-lg-justify-between
+  - flex-xl-justify-between
   :space_around:
   - flex-justify-around
+  - flex-sm-justify-around
+  - flex-md-justify-around
+  - flex-lg-justify-around
+  - flex-xl-justify-around
 :align_items:
   :flex_start:
   - flex-items-start
+  - flex-sm-items-start
+  - flex-md-items-start
+  - flex-lg-items-start
+  - flex-xl-items-start
   :flex_end:
   - flex-items-end
+  - flex-sm-items-end
+  - flex-md-items-end
+  - flex-lg-items-end
+  - flex-xl-items-end
   :center:
   - flex-items-center
+  - flex-sm-items-center
+  - flex-md-items-center
+  - flex-lg-items-center
+  - flex-xl-items-center
   :baseline:
   - flex-items-baseline
+  - flex-sm-items-baseline
+  - flex-md-items-baseline
+  - flex-lg-items-baseline
+  - flex-xl-items-baseline
   :stretch:
   - flex-items-stretch
+  - flex-sm-items-stretch
+  - flex-md-items-stretch
+  - flex-lg-items-stretch
+  - flex-xl-items-stretch
 :flex_wrap:
   :wrap:
   - flex-wrap
+  - flex-sm-wrap
+  - flex-md-wrap
+  - flex-lg-wrap
+  - flex-xl-wrap
   :nowrap:
   - flex-nowrap
+  - flex-sm-nowrap
+  - flex-md-nowrap
+  - flex-lg-nowrap
+  - flex-xl-nowrap
   :reverse:
   - flex-wrap-reverse
+  - flex-sm-wrap-reverse
+  - flex-md-wrap-reverse
+  - flex-lg-wrap-reverse
+  - flex-xl-wrap-reverse
 :direction:
   :column:
   - flex-column
@@ -1656,24 +1714,64 @@
 :flex:
   1:
   - flex-1
+  - flex-sm-1
+  - flex-md-1
+  - flex-lg-1
+  - flex-xl-1
   :auto:
   - flex-auto
+  - flex-sm-auto
+  - flex-md-auto
+  - flex-lg-auto
+  - flex-xl-auto
 :align_self:
   :auto:
   - flex-self-auto
+  - flex-sm-self-auto
+  - flex-md-self-auto
+  - flex-lg-self-auto
+  - flex-xl-self-auto
   :start:
   - flex-self-start
+  - flex-sm-self-start
+  - flex-md-self-start
+  - flex-lg-self-start
+  - flex-xl-self-start
   :end:
   - flex-self-end
+  - flex-sm-self-end
+  - flex-md-self-end
+  - flex-lg-self-end
+  - flex-xl-self-end
   :center:
   - flex-self-center
+  - flex-sm-self-center
+  - flex-md-self-center
+  - flex-lg-self-center
+  - flex-xl-self-center
   :baseline:
   - flex-self-baseline
+  - flex-sm-self-baseline
+  - flex-md-self-baseline
+  - flex-lg-self-baseline
+  - flex-xl-self-baseline
   :stretch:
   - flex-self-stretch
+  - flex-sm-self-stretch
+  - flex-md-self-stretch
+  - flex-lg-self-stretch
+  - flex-xl-self-stretch
 :flex_grow:
   0:
   - flex-grow-0
+  - flex-sm-grow-0
+  - flex-md-grow-0
+  - flex-lg-grow-0
+  - flex-xl-grow-0
 :flex_shrink:
   0:
   - flex-shrink-0
+  - flex-sm-shrink-0
+  - flex-md-shrink-0
+  - flex-lg-shrink-0
+  - flex-xl-shrink-0

data/lib/primer/classify.rb

@@ -42,7 +42,7 @@ module Primer
       # extract_css_attrs(classes: "d-flex", mt: 4, py: 2) => { classes: "d-flex mt-4 py-2", style: nil }
       # extract_css_attrs(classes: "d-flex", style: "float: left", mt: 4, py: 2) => { classes: "d-flex mt-4 py-2", style: "float: left" }
       #
-      def call(**args)
+      def call(args = {})
         style = nil
         classes = [].tap do |result|
           args.each do |key, val|

data/lib/primer/view_components/engine.rb

@@ -18,6 +18,7 @@ module Primer
       config.primer_view_components.raise_on_invalid_options = false
       config.primer_view_components.silence_deprecations = false
       config.primer_view_components.validate_class_names = !Rails.env.production?
+      config.primer_view_components.raise_on_invalid_aria = false
 
       initializer "primer_view_components.assets" do |app|
         app.config.assets.precompile += %w[primer_view_components] if app.config.respond_to?(:assets)

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 63
+      PATCH = 64
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/tasks/custom_utilities.yml

@@ -99,6 +99,12 @@
   - border-x
   true:
   - border
+  0:
+  - border-0
+  false:
+  - border-0
+  :dashed:
+  - border-dashed
 :border_top:
   0:
   - border-top-0
@@ -123,32 +129,84 @@
 :justify_content:
   :flex_start:
   - flex-justify-start
+  - flex-sm-justify-start
+  - flex-md-justify-start
+  - flex-lg-justify-start
+  - flex-xl-justify-start
   :flex_end:
   - flex-justify-end
+  - flex-sm-justify-end
+  - flex-md-justify-end
+  - flex-lg-justify-end
+  - flex-xl-justify-end
   :center:
   - flex-justify-center
+  - flex-sm-justify-center
+  - flex-md-justify-center
+  - flex-lg-justify-center
+  - flex-xl-justify-center
   :space_between:
   - flex-justify-between
+  - flex-sm-justify-between
+  - flex-md-justify-between
+  - flex-lg-justify-between
+  - flex-xl-justify-between
   :space_around:
   - flex-justify-around
+  - flex-sm-justify-around
+  - flex-md-justify-around
+  - flex-lg-justify-around
+  - flex-xl-justify-around
 :align_items:
   :flex_start:
   - flex-items-start
+  - flex-sm-items-start
+  - flex-md-items-start
+  - flex-lg-items-start
+  - flex-xl-items-start
   :flex_end:
   - flex-items-end
+  - flex-sm-items-end
+  - flex-md-items-end
+  - flex-lg-items-end
+  - flex-xl-items-end
   :center:
   - flex-items-center
+  - flex-sm-items-center
+  - flex-md-items-center
+  - flex-lg-items-center
+  - flex-xl-items-center
   :baseline:
   - flex-items-baseline
+  - flex-sm-items-baseline
+  - flex-md-items-baseline
+  - flex-lg-items-baseline
+  - flex-xl-items-baseline
   :stretch:
   - flex-items-stretch
+  - flex-sm-items-stretch
+  - flex-md-items-stretch
+  - flex-lg-items-stretch
+  - flex-xl-items-stretch
 :flex_wrap:
   :wrap:
   - flex-wrap
+  - flex-sm-wrap
+  - flex-md-wrap
+  - flex-lg-wrap
+  - flex-xl-wrap
   :nowrap:
   - flex-nowrap
+  - flex-sm-nowrap
+  - flex-md-nowrap
+  - flex-lg-nowrap
+  - flex-xl-nowrap
   :reverse:
   - flex-wrap-reverse
+  - flex-sm-wrap-reverse
+  - flex-md-wrap-reverse
+  - flex-lg-wrap-reverse
+  - flex-xl-wrap-reverse
 :direction:
   :column:
   - flex-column
@@ -177,24 +235,64 @@
 :flex:
   1:
   - flex-1
+  - flex-sm-1
+  - flex-md-1
+  - flex-lg-1
+  - flex-xl-1
   :auto:
   - flex-auto
+  - flex-sm-auto
+  - flex-md-auto
+  - flex-lg-auto
+  - flex-xl-auto
 :align_self:
   :auto:
   - flex-self-auto
+  - flex-sm-self-auto
+  - flex-md-self-auto
+  - flex-lg-self-auto
+  - flex-xl-self-auto
   :start:
   - flex-self-start
+  - flex-sm-self-start
+  - flex-md-self-start
+  - flex-lg-self-start
+  - flex-xl-self-start
   :end:
   - flex-self-end
+  - flex-sm-self-end
+  - flex-md-self-end
+  - flex-lg-self-end
+  - flex-xl-self-end
   :center:
   - flex-self-center
+  - flex-sm-self-center
+  - flex-md-self-center
+  - flex-lg-self-center
+  - flex-xl-self-center
   :baseline:
   - flex-self-baseline
+  - flex-sm-self-baseline
+  - flex-md-self-baseline
+  - flex-lg-self-baseline
+  - flex-xl-self-baseline
   :stretch:
   - flex-self-stretch
+  - flex-sm-self-stretch
+  - flex-md-self-stretch
+  - flex-lg-self-stretch
+  - flex-xl-self-stretch
 :flex_grow:
   0:
   - flex-grow-0
+  - flex-sm-grow-0
+  - flex-md-grow-0
+  - flex-lg-grow-0
+  - flex-xl-grow-0
 :flex_shrink:
   0:
   - flex-shrink-0
+  - flex-sm-shrink-0
+  - flex-md-shrink-0
+  - flex-lg-shrink-0
+  - flex-xl-shrink-0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.63
+  version: 0.0.64
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-03 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview