primer_view_components 0.0.61 → 0.0.62

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61a72c86047d4820bb909bb7aba73505a1401868e362831ce3cfcd44f6c65da2
-  data.tar.gz: cedb04ce42976410ad380e5d39e448fc2078f07fb3d26b3d2ce4e7d79141f6ea
+  metadata.gz: adce588d18cdf5a429f1cfbf22474252e3bfb96e929c7a991590069b38d7a8c6
+  data.tar.gz: d7c0ada1fa78d39d82b7beb6ef90b1900b923a4fcc0a401f5dc14a0f7e8d157e
 SHA512:
-  metadata.gz: 714f04473ef45b3a80c4fcad50dbcd575a981c93b990f770844e903d561dc016cc88a94b09567deaa9954680add33581bc002c6f80b3a3590d2e64faf9397c63
-  data.tar.gz: 8d982a43c2fd2a0d5fe32287c129c8d4559ae2441e3124f9f50857ccbf25e2a4a3b63426e6f5a1c24572d6d8804b90849a3e600e3680de3efdbc59c92de0293e
+  metadata.gz: 1d7a91266039e243395f6a630a1fa7838e1ca8cc6a038e66f22ad286e2b80e7c937408ce6f2f71bd3c2474680818d2a6fd0017a1ccc390432a83a331564309c8
+  data.tar.gz: 4f9d8101365c03c8fe01cd9b18da13ea6d602e93469511dd3d8b0792861f8d9f34a78b4a6137e6d80ebfa67c0387e46dd3fd391c6547cf232accc24536310b21

data/CHANGELOG.md

@@ -30,6 +30,48 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 ## main
 
+## 0.0.62
+
+### New
+
+* Add linter for tracking deprecated `LayoutComponent` callsites
+
+    *Josh Klina*
+
+### Updates
+
+* Update `Button` to add `8px` spacing between icon, text and counter.
+
+    *Manuel Puyol*
+
+* Update `BlankslateApiMigration` linter to support interpolations.
+
+    *Manuel Puyol*
+
+* Change spacing in `Blankslate`:
+  * Between `description` and `primary_action` to `32px`.
+  * Between `primary_action` and `secondary_action` to `16px`.
+
+    *Manuel Puyol*
+
+* Improve performance of `Classify#call`.
+
+    *Cameron Dutro*
+
+### Breaking Changes
+
+* Add a warning to users if they try to use `tag:` parameters on a component where the tag is fixed
+
+    *Owen Niblock*
+
+* Updating to @primer/css@19.0.0 and @primer/primitives@7.1.0. Which removes support for deprecated system color arguments
+
+    *Jon Rohan*
+
+* Prevent `aria-label` to be used with `:div, :span, :p` tags without an explicit `role`.
+
+    *Manuel Puyol*
+
 ## 0.0.61
 
 ### New
@@ -48,7 +90,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 ### Updates
 
-* Bump Storybook version to include Skip to Content links for keyboard auditors
+* Bump Storybook version to include Skip to Content links for keyboard auditors.
 
     *Katie Foster @inkblotty*
 
@@ -68,7 +110,7 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 ### Bug Fixes
 
-* Fix issue where tags were not self-closing when they are void elements
+* Fix issue where tags were not self-closing when they are void elements.
 
     *Owen Niblock*
 

data/app/components/primer/alpha/border_box/header.rb

@@ -3,8 +3,7 @@
 module Primer
   module Alpha
     module BorderBox
-      # BorderBox::Header: used inside the BorderBoxComponent to render its header slot
-      # Optional title slot
+      # `BorderBox::Header` is used inside `BorderBox` to render its header slot.
       #
       # @accessibility When using `header.title`, set `tag` to one of `h1`, `h2`, `h3`, etc. based on what is appropriate for the page context. <%= link_to_heading_practices %>
       class Header < Primer::Component

data/app/components/primer/alpha/button_marketing.rb

@@ -7,9 +7,9 @@ module Primer
       DEFAULT_SCHEME = :default
       SCHEME_MAPPINGS = {
         DEFAULT_SCHEME => "",
-        :primary => "btn-primary-mktg",
-        :outline => "btn-outline-mktg",
-        :transparent => "btn-transparent"
+        :primary => "btn-signup-mktg",
+        :outline => "btn-muted-mktg",
+        :transparent => "btn-subtle-mktg"
       }.freeze
       SCHEME_OPTIONS = SCHEME_MAPPINGS.keys
 
@@ -30,7 +30,7 @@ module Primer
       #   <%= render(Primer::Alpha::ButtonMarketing.new(mr: 2)) { "Default" } %>
       #   <%= render(Primer::Alpha::ButtonMarketing.new(scheme: :primary, mr: 2)) { "Primary" } %>
       #   <%= render(Primer::Alpha::ButtonMarketing.new(scheme: :outline)) { "Outline" } %>
-      #   <div class="color-bg-canvas-inverse">
+      #   <div class="color-bg-emphasis">
       #     <%= render(Primer::Alpha::ButtonMarketing.new(scheme: :transparent)) { "Transparent" } %>
       #   </div>
       #

data/app/components/primer/alpha/tab_nav.rb

@@ -101,7 +101,7 @@ module Primer
       #   <% end %>
       #
       # @example Customizing the body
-      #   <%= render(Primer::Alpha::TabNav.new(label: "Default", body_arguments: { classes: "custom-class", border: true, border_color: :info })) do |c| %>
+      #   <%= render(Primer::Alpha::TabNav.new(label: "Default", body_arguments: { classes: "custom-class", border: true, border_color: :accent_emphasis })) do |c| %>
       #     <% c.tab(selected: true, href: "#") { "Tab 1" }%>
       #     <% c.tab(href: "#") { "Tab 2" } %>
       #     <% c.tab(href: "#") { "Tab 3" } %>

data/app/components/primer/alpha/tab_panels.rb

@@ -66,11 +66,11 @@ module Primer
         @align = EXTRA_ALIGN_DEFAULT
         @wrapper_arguments = wrapper_arguments
 
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = :div
         @system_arguments[:classes] = tab_nav_classes(@system_arguments[:classes])
 
-        @body_arguments = body_arguments
+        @body_arguments = deny_tag_argument(**body_arguments)
         @body_arguments[:tag] = :ul
         @body_arguments[:classes] = tab_nav_body_classes(@body_arguments[:classes])
 

data/app/components/primer/alpha/underline_nav.rb

@@ -5,6 +5,7 @@ module Primer
     # Use `UnderlineNav` to style navigation links with a minimal
     # underlined selected state, typically placed at the top
     # of the page.
+    #
     # For panel navigation, use <%= link_to_component(Primer::Alpha::UnderlinePanels) %> instead.
     #
     # @accessibility
@@ -102,7 +103,7 @@ module Primer
       #   <% end %>
       #
       # @example Customizing the body
-      #   <%= render(Primer::Alpha::UnderlineNav.new(label: "Default", body_arguments: { classes: "custom-class", border: true, border_color: :info })) do |c| %>
+      #   <%= render(Primer::Alpha::UnderlineNav.new(label: "Default", body_arguments: { classes: "custom-class", border: true, border_color: :accent_emphasis })) do |c| %>
       #     <% c.tab(selected: true, href: "#") { "Tab 1" }%>
       #     <% c.tab(href: "#") { "Tab 2" } %>
       #     <% c.tab(href: "#") { "Tab 3" } %>

data/app/components/primer/alpha/underline_panels.rb

@@ -64,11 +64,11 @@ module Primer
         @align = fetch_or_fallback(ALIGN_OPTIONS, align, ALIGN_DEFAULT)
         @wrapper_arguments = wrapper_arguments
 
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = :div
         @system_arguments[:classes] = underline_nav_classes(@system_arguments[:classes], @align)
 
-        @body_arguments = body_arguments
+        @body_arguments = deny_tag_argument(**body_arguments)
         @body_arguments[:tag] = :ul
         @body_arguments[:classes] = underline_nav_body_classes(@body_arguments[:classes])
 

data/app/components/primer/base_component.rb

@@ -72,14 +72,14 @@ module Primer
     #
     # | Name | Type | Description |
     # | :- | :- | :- |
-    # | `align_items` | Symbol | <%= one_of(Primer::Classify::Flex::ALIGN_ITEMS_VALUES) %> |
-    # | `align_self` | Symbol | <%= one_of(Primer::Classify::Flex::ALIGN_SELF_VALUES) %> |
-    # | `direction` | Symbol | <%= one_of(Primer::Classify::Flex::DIRECTION_VALUES) %> |
-    # | `flex` | Integer, Symbol | <%= one_of(Primer::Classify::Flex::FLEX_VALUES) %> |
+    # | `align_items` | Symbol | <%= one_of(Primer::Classify::FLEX_ALIGN_ITEMS_VALUES) %> |
+    # | `align_self` | Symbol | <%= one_of(Primer::Classify::FLEX_ALIGN_SELF_VALUES) %> |
+    # | `direction` | Symbol | <%= one_of(Primer::Classify::FLEX_DIRECTION_VALUES) %> |
+    # | `flex` | Integer, Symbol | <%= one_of(Primer::Classify::FLEX_VALUES) %> |
     # | `flex_grow` | Integer | To enable, set to `0`. |
     # | `flex_shrink` | Integer | To enable, set to `0`. |
-    # | `flex_wrap` | Symbol | <%= one_of(Primer::Classify::Flex::WRAP_MAPPINGS.keys) %> |
-    # | `justify_content` | Symbol | <%= one_of(Primer::Classify::Flex::JUSTIFY_CONTENT_VALUES) %> |
+    # | `flex_wrap` | Symbol | <%= one_of(Primer::Classify::FLEX_WRAP_MAPPINGS.keys) %> |
+    # | `justify_content` | Symbol | <%= one_of(Primer::Classify::FLEX_JUSTIFY_CONTENT_VALUES) %> |
     #
     # ## Grid
     #
@@ -151,42 +151,14 @@ module Primer
     # | test_selector | String | Adds `data-test-selector='given value'` in non-Production environments for testing purposes. |
     def initialize(tag:, classes: nil, **system_arguments)
       @tag = tag
-      @system_arguments = system_arguments
 
-      raise ArgumentError, "`class` is an invalid argument. Use `classes` instead." if system_arguments.key?(:class) && !Rails.env.production?
-
-      if (denylist = system_arguments[:system_arguments_denylist])
-        if raise_on_invalid_options? && !ENV["PRIMER_WARNINGS_DISABLED"]
-          # Convert denylist from:
-          # { [:p, :pt] => "message" } to:
-          # { p: "message", pt: "message" }
-          unpacked_denylist =
-            denylist.each_with_object({}) do |(keys, value), memo|
-              keys.each { |key| memo[key] = value }
-            end
-
-          violations = unpacked_denylist.keys & @system_arguments.keys
-
-          if violations.any?
-            message = "Found #{violations.count} #{'violation'.pluralize(violations)}:"
-            violations.each do |violation|
-              message += "\n The #{violation} system argument is not allowed here. #{unpacked_denylist[violation]}"
-            end
-
-            raise(ArgumentError, message)
-          end
-        end
-
-        # Remove :system_arguments_denylist key and any denied keys from system arguments
-        @system_arguments.except!(:system_arguments_denylist)
-        @system_arguments.except!(*denylist.keys.flatten)
-      end
+      @system_arguments = validate_arguments(tag: tag, **system_arguments)
 
       @result = Primer::Classify.call(**@system_arguments.merge(classes: classes))
 
       @system_arguments[:"data-view-component"] = true
       # Filter out Primer keys so they don't get assigned as HTML attributes
-      @content_tag_args = add_test_selector(@system_arguments).except(*Primer::Classify::VALID_KEYS)
+      @content_tag_args = add_test_selector(@system_arguments).except(*Primer::Classify::Utilities::UTILITIES.keys)
     end
 
     def call

data/app/components/primer/beta/auto_complete/item.rb

@@ -20,7 +20,7 @@ module Primer
         # @param disabled [Boolean] Whether the item is disabled.
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
         def initialize(value:, selected: false, disabled: false, **system_arguments)
-          @system_arguments = system_arguments
+          @system_arguments = deny_tag_argument(**system_arguments)
           @system_arguments[:tag] = :li
           @system_arguments[:role] = :option
           @system_arguments[:"data-autocomplete-value"] = value

data/app/components/primer/beta/auto_complete.rb

@@ -19,6 +19,7 @@ module Primer
       #
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :label, lambda { |**system_arguments|
+        deny_tag_argument(**system_arguments)
         system_arguments[:for] = @input_id
         system_arguments[:tag] = :label
         Primer::BaseComponent.new(**system_arguments)
@@ -47,6 +48,7 @@ module Primer
       #
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :results, lambda { |**system_arguments|
+        deny_tag_argument(**system_arguments)
         system_arguments[:tag] = :ul
         system_arguments[:id] = @list_id
         system_arguments[:classes] = class_names(
@@ -110,7 +112,7 @@ module Primer
 
         system_arguments.delete(:"aria-label") && system_arguments[:aria]&.delete(:label)
 
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = "auto-complete"
         @system_arguments[:src] = src
         @system_arguments[:for] = list_id
@@ -133,7 +135,7 @@ module Primer
         # @param type [Symbol] <%= one_of(Primer::Beta::AutoComplete::Input::TYPE_OPTIONS) %>
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
         def initialize(type: DEFAULT_TYPE, **system_arguments)
-          @system_arguments = system_arguments
+          @system_arguments = deny_tag_argument(**system_arguments)
           @system_arguments[:tag] = :input
 
           @aria_label = system_arguments[:"aria-label"]

data/app/components/primer/beta/avatar.rb

@@ -53,7 +53,7 @@ module Primer
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(src:, alt:, size: DEFAULT_SIZE, shape: DEFAULT_SHAPE, href: nil, **system_arguments)
         @href = href
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = :img
         @system_arguments[:src] = src
         @system_arguments[:alt] = alt

data/app/components/primer/beta/blankslate.html.erb

@@ -7,9 +7,9 @@
 
     <%= primary_action %>
     <% if secondary_action.present? %>
-      <p>
+      <div class="mt-3">
         <%= secondary_action %>
-      </p>
+      </div>
     <% end %>
   <% end %>
 <% end %>

data/app/components/primer/beta/blankslate.rb

@@ -50,6 +50,7 @@ module Primer
       # @param tag [String]  <%= one_of(Primer::HeadingComponent::TAG_OPTIONS) %>
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :heading, lambda { |tag:, **system_arguments|
+        deny_tag_argument(**system_arguments)
         system_arguments[:tag] = tag
         system_arguments[:mb] = 1
         system_arguments[:classes] = class_names("h2", system_arguments[:classes])
@@ -64,7 +65,8 @@ module Primer
       #
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :description, lambda { |**system_arguments|
-        system_arguments[:tag] = :p
+        deny_tag_argument(**system_arguments)
+        system_arguments[:tag] = :div
 
         Primer::BaseComponent.new(**system_arguments)
       }
@@ -77,9 +79,10 @@ module Primer
       # @param href [String] URL to be used for the primary action.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :primary_action, lambda { |href:, **system_arguments|
+        deny_tag_argument(**system_arguments)
         system_arguments[:tag] = :a
         system_arguments[:href] = href
-        system_arguments[:my] = 3
+        system_arguments[:mt] = 5
         system_arguments[:variant] = :medium
         system_arguments[:scheme] ||= :primary
 
@@ -211,7 +214,7 @@ module Primer
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(narrow: false, spacious: false, border: false, **system_arguments)
         @border = border
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = :div
         @system_arguments[:classes] = class_names(
           @system_arguments[:classes],

data/app/components/primer/beta/breadcrumbs.rb

@@ -40,7 +40,7 @@ module Primer
       #
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(**system_arguments)
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = :nav
         @system_arguments[:aria] = ARIA_LABEL
         @system_arguments[:system_arguments_denylist] = ARGS_DENYLIST
@@ -57,7 +57,7 @@ module Primer
 
         def initialize(href:, **system_arguments)
           @href = href
-          @system_arguments = system_arguments
+          @system_arguments = deny_tag_argument(**system_arguments)
           @selected = false
 
           @system_arguments[:tag] = :li

data/app/components/primer/beta/text.rb

@@ -10,7 +10,7 @@ module Primer
 
       # @example Default
       #   <%= render(Primer::Beta::Text.new(tag: :p, font_weight: :bold)) { "Bold Text" } %>
-      #   <%= render(Primer::Beta::Text.new(tag: :p, color: :text_danger)) { "Danger Text" } %>
+      #   <%= render(Primer::Beta::Text.new(tag: :p, color: :danger)) { "Danger Text" } %>
       #
       # @param tag [Symbol]
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>

data/app/components/primer/border_box_component.rb

@@ -127,7 +127,7 @@ module Primer
     # @param padding [Symbol] <%= one_of(Primer::BorderBoxComponent::PADDING_MAPPINGS.keys) %>
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(padding: DEFAULT_PADDING, **system_arguments)
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @system_arguments[:tag] = :div
       @system_arguments[:classes] = class_names(
         "Box",

data/app/components/primer/box_component.rb

@@ -9,11 +9,12 @@ module Primer
     #   <%= render(Primer::BoxComponent.new) { "Your content here" } %>
     #
     # @example Color and padding
-    #   <%= render(Primer::BoxComponent.new(bg: :tertiary, p: 3)) { "Hello world" } %>
+    #   <%= render(Primer::BoxComponent.new(bg: :subtle, p: 3)) { "Hello world" } %>
     #
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(**system_arguments)
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
+
       @system_arguments[:tag] = :div
     end
 

data/app/components/primer/button_component.html.erb

@@ -1,9 +1,3 @@
-<%= render Primer::BaseButton.new(**@system_arguments) do %>
-  <%= icon %>
-  <%= content %>
-  <%= counter %>
-
-  <% if @caret %>
-    <%= primer_octicon("triangle-down") %>
-  <% end %>
-<% end %>
+<%= render Primer::BaseButton.new(**@system_arguments) do -%>
+  <%= icon %><%= trimmed_content %><%= counter %><%= primer_octicon("triangle-down", mr: -1) if @caret %>
+<% end -%>

data/app/components/primer/button_component.rb

@@ -28,12 +28,20 @@ module Primer
     # Icon to be rendered in the button.
     #
     # @param system_arguments [Hash] Same arguments as <%= link_to_component(Primer::OcticonComponent) %>.
-    renders_one :icon, Primer::OcticonComponent
+    renders_one :icon, lambda { |**system_arguments|
+      system_arguments[:mr] = 2
+
+      Primer::OcticonComponent.new(**system_arguments)
+    }
 
     # Counter to be rendered in the button.
     #
     # @param system_arguments [Hash] Same arguments as <%= link_to_component(Primer::CounterComponent) %>.
-    renders_one :counter, Primer::CounterComponent
+    renders_one :counter, lambda { |**system_arguments|
+      system_arguments[:ml] = 2
+
+      Primer::CounterComponent.new(**system_arguments)
+    }
 
     # @example Schemes
     #   <%= render(Primer::ButtonComponent.new) { "Default" } %>
@@ -111,5 +119,16 @@ module Primer
     def link?
       @scheme == LINK_SCHEME
     end
+
+    def trimmed_content
+      return if content.blank?
+
+      trimmed_content = content.strip
+
+      return trimmed_content unless content.html_safe?
+
+      # strip unsets `html_safe`, so we have to set it back again to guarantee that HTML blocks won't break
+      trimmed_content.html_safe # rubocop:disable Rails/OutputSafety
+    end
   end
 end

data/app/components/primer/button_group.rb

@@ -45,7 +45,7 @@ module Primer
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(variant: Primer::ButtonComponent::DEFAULT_VARIANT, **system_arguments)
       @variant = variant
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @system_arguments[:tag] = :div
 
       @system_arguments[:classes] = class_names(

data/app/components/primer/clipboard_copy.rb

@@ -25,7 +25,7 @@ module Primer
     # @param for [String] Element id from where to get the copied value.
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(value: nil, **system_arguments)
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @value = value
 
       validate!

data/app/components/primer/close_button.rb

@@ -19,7 +19,7 @@ module Primer
     # @param type [Symbol] <%= one_of(Primer::CloseButton::TYPE_OPTIONS) %>
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(type: DEFAULT_TYPE, **system_arguments)
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @system_arguments[:tag] = :button
       @system_arguments[:block] = false
       @system_arguments[:type] = fetch_or_fallback(TYPE_OPTIONS, type, DEFAULT_TYPE)

data/app/components/primer/component.rb

@@ -14,6 +14,8 @@ module Primer
     include Status::Dsl
     include Audited::Dsl
 
+    INVALID_ARIA_LABEL_TAGS = [:div, :span, :p].freeze
+
     private
 
     def raise_on_invalid_options?
@@ -42,5 +44,74 @@ module Primer
     def silence_deprecations?
       Rails.application.config.primer_view_components.silence_deprecations
     end
+
+    def check_denylist(denylist = [], **arguments)
+      if should_raise_error?
+
+        # Convert denylist from:
+        # { [:p, :pt] => "message" } to:
+        # { p: "message", pt: "message" }
+        unpacked_denylist =
+          denylist.each_with_object({}) do |(keys, value), memo|
+            keys.each { |key| memo[key] = value }
+          end
+
+        violations = unpacked_denylist.keys & arguments.keys
+
+        if violations.any?
+          message = "Found #{violations.count} #{'violation'.pluralize(violations)}:"
+          violations.each do |violation|
+            message += "\n The #{violation} argument is not allowed here. #{unpacked_denylist[violation]}"
+          end
+
+          raise(ArgumentError, message)
+        end
+      end
+
+      arguments
+    end
+
+    def validate_arguments(tag:, denylist_name: :system_arguments_denylist, **arguments)
+      deny_single_argument(:class, "Use `classes` instead.", **arguments)
+
+      if (denylist = arguments[denylist_name])
+        check_denylist(denylist, **arguments)
+
+        # Remove :system_arguments_denylist key and any denied keys from system arguments
+        arguments.except!(denylist_name)
+        arguments.except!(*denylist.keys.flatten)
+      end
+
+      deny_aria_label(tag: tag, arguments: arguments)
+
+      arguments
+    end
+
+    def deny_single_argument(key, help_text, **arguments)
+      raise ArgumentError, "`#{key}` is an invalid argument. #{help_text}" \
+        if should_raise_error? && arguments.key?(key)
+
+      arguments.except!(key)
+    end
+
+    def deny_aria_label(tag:, arguments:)
+      return arguments.except!(:skip_aria_label_check) if arguments[:skip_aria_label_check]
+      return if arguments[:role]
+      return unless aria(:label, arguments)
+      return unless INVALID_ARIA_LABEL_TAGS.include?(tag)
+
+      raise ArgumentError, "Don't use `aria-label` on `#{tag}` elements. See https://www.tpgi.com/short-note-on-aria-label-aria-labelledby-and-aria-describedby/" if should_raise_error?
+
+      arguments.except!(:"aria-label")
+      arguments[:aria] = arguments[:aria].except!(:label) if arguments[:aria]
+    end
+
+    def deny_tag_argument(**arguments)
+      deny_single_argument(:tag, "This component has a fixed tag.", **arguments)
+    end
+
+    def should_raise_error?
+      raise_on_invalid_options? && !ENV["PRIMER_WARNINGS_DISABLED"]
+    end
   end
 end

data/app/components/primer/counter_component.rb

@@ -51,7 +51,7 @@ module Primer
       @hide_if_zero = hide_if_zero
       @text = text
       @round = round
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
 
       @has_limit = !@limit.nil?
       @system_arguments[:title] = title

data/app/components/primer/details_component.rb

@@ -52,7 +52,7 @@ module Primer
     # @param reset [Boolean] Defatuls to false. If set to true, it will remove the default caret and remove style from the summary element
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     def initialize(overlay: NO_OVERLAY, reset: false, **system_arguments)
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @system_arguments[:tag] = :details
       @system_arguments[:classes] = class_names(
         system_arguments[:classes],

data/app/components/primer/dropdown/menu.rb

@@ -33,7 +33,7 @@ module Primer
         @direction = direction
         @as = fetch_or_fallback(AS_OPTIONS, as, AS_DEFAULT)
 
-        @system_arguments = system_arguments
+        @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = "details-menu"
         @system_arguments[:role] = "menu"
 

data/app/components/primer/dropdown.html.erb

@@ -1,7 +1,6 @@
 <%= render(Primer::DetailsComponent.new(**@system_arguments)) do |c| %>
   <% c.summary(**@button_arguments) do %>
     <%= button %>
-    <% if @with_caret %><div class="dropdown-caret"></div><% end %>
   <% end %>
 
   <% c.body do %>

data/app/components/primer/dropdown.rb

@@ -9,6 +9,7 @@ module Primer
     renders_one :button, lambda { |**system_arguments, &block|
       @button_arguments = system_arguments
       @button_arguments[:button] = true
+      @button_arguments[:caret] = @with_caret
 
       view_context.capture { block&.call }
     }

data/app/components/primer/dropdown_menu_component.rb

@@ -42,7 +42,7 @@ module Primer
     def initialize(direction: DIRECTION_DEFAULT, scheme: SCHEME_DEFAULT, header: nil, **system_arguments)
       @header = header
       @direction = direction
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
 
       @system_arguments[:tag] = "details-menu"
       @system_arguments[:role] = "menu"

data/app/components/primer/flash_component.rb

@@ -9,6 +9,7 @@ module Primer
     #
     # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
     renders_one :action, lambda { |**system_arguments|
+      deny_tag_argument(**system_arguments)
       system_arguments[:tag] = :div
       system_arguments[:classes] = class_names(system_arguments[:classes], "flash-action")
 
@@ -54,7 +55,7 @@ module Primer
     def initialize(full: false, spacious: false, dismissible: false, icon: nil, scheme: DEFAULT_SCHEME, **system_arguments)
       @icon = icon
       @dismissible = dismissible
-      @system_arguments = system_arguments
+      @system_arguments = deny_tag_argument(**system_arguments)
       @system_arguments[:tag] = :div
       @system_arguments[:classes] = class_names(
         @system_arguments[:classes],