primer_view_components 0.0.55 → 0.0.56

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24d9b6954280f4366b91f69fe7d29af41b8ce480b015a6d2f281c9e6c3bd4637
-  data.tar.gz: cae48c352697db57fd18b2712850cdc5a47da809449dcbd1f32398a777135cda
+  metadata.gz: 1263f18dfe58150640310bfea1bd27f14e3854656f77606ed824fb4cc068b47e
+  data.tar.gz: 6dc1be9c61762bc31d0274b9402853d53c9a8e75438ffb3361179f0104c1896c
 SHA512:
-  metadata.gz: e334ce2c9e71f8b54f0a22d094a333ce1df7216a601885732c2a1f669e03d67f4b0e2d9799c39600edc33e9ef972949a02de1a8adc4081c702b14d4bfe6bacbc
-  data.tar.gz: 4640a31794a5e6df77bcf1a707758bb970d80a33afbcd42a812efd3ce3c9f032b7789de55f3ab0d74d7d8657c1d06f3965f926437cf609455f3db4b2c4a2bc6f
+  metadata.gz: da4c5a2f914f1b08177830023af568d4cc9970bf8047c95fa39ce13d3ea46b6a30687ae6df89a9fefbfb65b5e9f52f37ace2801370f9582513c43b0e5e26ccfb
+  data.tar.gz: 66e9eb50c0f9a91aecd6804d7b44aa5d6644f094edbf6011e60361a54d9de1c51dcb0ec157c162458139ca69d2cb7a469c8978b53b63d5f2aa06f59b79ebdc1f

data/CHANGELOG.md

@@ -30,6 +30,36 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
 ## main
 
+## 0.0.56
+
+### Updates
+
+* `Octicon` linter will autocorrect colors.
+
+    *Manuel Puyol*
+
+* `Button` linter will autocorrect when button uses `href`, `name`, `value` or `tabindex`.
+
+    *Manuel Puyol*
+
+* `Flash` linter won't autocorrect flashes with ERB in their content.
+
+    *Manuel Puyol*
+
+* Eager load components.
+
+    *Cameron Dutro*
+
+### Misc
+
+* Refactor some of the rubocop valid_node? logic into BaseCop class.
+
+    *Jon Rohan*
+
+* Fix validation checker to use Utilities for color-* classes.
+
+    *Jon Rohan*
+
 ## 0.0.55
 
 ### Breaking changes
@@ -59,10 +89,6 @@ The category for changes related to documentation, testing and tooling. Also, fo
 
     *Kate Higa*
 
-* Refactor some of the rubocop valid_node? logic into BaseCop class.
-
-    *Jon Rohan*
-
 ## 0.0.54
 
 ### Breaking changes

data/lib/primer/classify/utilities.rb

@@ -115,7 +115,11 @@ module Primer
         end
 
         def classes_to_args(classes)
-          classes_to_hash(classes).map do |key, value|
+          hash_to_args(classes_to_hash(classes))
+        end
+
+        def hash_to_args(hash)
+          hash.map do |key, value|
             val = case value
                   when Symbol
                     ":#{value}"

data/lib/primer/classify/validation.rb

@@ -6,7 +6,7 @@ module Primer
   class Classify
     # :nodoc:
     class Validation
-      INVALID_CLASS_NAME_PREFIXES = /bg-|color-|text-|box-shadow-|text-|box_shadow-/.freeze
+      INVALID_CLASS_NAME_PREFIXES = /bg-|color-bg-|text-|box-shadow-|box_shadow-/.freeze
 
       class << self
         def invalid?(class_name)

data/lib/primer/view_components/engine.rb

@@ -7,7 +7,7 @@ module Primer
     # :nodoc:
     class Engine < ::Rails::Engine
       isolate_namespace Primer::ViewComponents
-      config.autoload_once_paths = %W[
+      config.eager_load_paths = %W[
         #{root}/app/components
         #{root}/app/lib
       ]

data/lib/primer/view_components/linters/argument_mappers/button.rb

@@ -23,12 +23,13 @@ module ERBLint
           component: "Primer::BaseButton",
           constant: "TYPE_OPTIONS"
         ).freeze
+
         DEFAULT_TAG = Primer::ViewComponents::Constants.get(
           component: "Primer::BaseButton",
           constant: "DEFAULT_TAG"
         ).freeze
 
-        ATTRIBUTES = %w[disabled type].freeze
+        ATTRIBUTES = %w[disabled type href name value tabindex].freeze
 
         def attribute_to_args(attribute)
           attr_name = attribute.name
@@ -43,6 +44,8 @@ module ERBLint
             raise ConversionError, "Button component does not support type \"#{attribute.value}\"" unless TYPE_OPTIONS.include?(attribute.value)
 
             { type: ":#{attribute.value}" }
+          else
+            { attr_name.to_sym => erb_helper.convert(attribute) }
           end
         end
 

data/lib/primer/view_components/linters/flash_component_migration_counter.rb

@@ -22,6 +22,11 @@ module ERBLint
         # Hash children indicates that there are tags in the content.
         return nil if tag_tree[:children].first.is_a?(Hash)
 
+        content = tag_tree[:children].first
+
+        # Don't accept content with ERB blocks
+        return nil if content.type != :text || content.children&.any? { |n| n.try(:type) == :erb }
+
         ARGUMENT_MAPPER.new(tag).to_s
       rescue ArgumentMappers::ConversionError
         nil

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 55
+      PATCH = 56
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/cop/primer/primer_octicon.rb

@@ -128,12 +128,29 @@ module RuboCop
           string_args = string_args_to_string(node)
 
           args = "#{args}, #{size_attributes_to_string(size_attributes)}" if size_args.present?
-          args = "#{args}, #{::Primer::Classify::Utilities.classes_to_args(classes)}" if classes.present?
+          args = "#{args}, #{utilities_args(classes)}" if classes.present?
           args = "#{args}, #{string_args}" if string_args.present?
 
           args
         end
 
+        def utilities_args(classes)
+          args = ::Primer::Classify::Utilities.classes_to_hash(classes)
+
+          color = case args[:color]
+                  when :text_white
+                    :text_white
+                  when :text_link
+                    :icon_info
+                  else
+                    args[:color].to_s.gsub("text_", "icon_").to_sym
+                  end
+
+          args[:color] = color
+
+          ::Primer::Classify::Utilities.hash_to_args(args)
+        end
+
         def size_attributes_to_string(size_attributes)
           # No arguments if they map to the default size
           return if size_attributes.blank? || size_attributes.values.all?(&:blank?)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.55
+  version: 0.0.56
 platform: ruby
 authors:
 - GitHub Open Source
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-09 00:00:00.000000000 Z
+date: 2021-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -366,7 +366,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.25
-description: 
+description:
 email:
 - opensource+primer_view_components@github.com
 executables: []
@@ -387,8 +387,6 @@ files:
 - app/components/primer/alpha/underline_nav.rb
 - app/components/primer/alpha/underline_panels.html.erb
 - app/components/primer/alpha/underline_panels.rb
-- app/components/primer/auto_complete/auto_complete.d.ts
-- app/components/primer/auto_complete/auto_complete.js
 - app/components/primer/base_button.rb
 - app/components/primer/base_component.rb
 - app/components/primer/beta/auto_complete.rb
@@ -557,7 +555,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -572,8 +570,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: ViewComponents for the Primer Design System
 test_files: []

data/app/components/primer/auto_complete/auto_complete.d.ts

@@ -1 +0,0 @@
-import '@github/auto-complete-element';

data/app/components/primer/auto_complete/auto_complete.js

@@ -1 +0,0 @@
-import '@github/auto-complete-element';