primer_view_components 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: adc437081b46691abf1c8946de200196e1ceb5b535aa47e7925c03495ae73f3d
-  data.tar.gz: fbbeda9a022db4a9799daf8c0b509481f0ef57c122ac50c51c487a50445a9d65
+  metadata.gz: be0c09210143e8465e55e213978714a4b27a19d2ddb690e3dfc378e4e3123e3b
+  data.tar.gz: '0862e8437eff534e74fc1275f99c53f0445285de2cd409cd9ea4f20e54349ec0'
 SHA512:
-  metadata.gz: 648cb2d8145c520fdf7f3da6af9b4047954343d7311caa7b5579adab5dc67b9ca697815e0f0b9c0f9f8d702edd82f9948fbf14ae3ee9397175aa0f3a8d12ec0e
-  data.tar.gz: 90e55106cc699d69f4473cb2844687b4b77597b85c5038be41acf3f56575f0c7e8dbce27ec7fe407b80b91ee12345bc272d2442b84af8ebf837be4451f0983b8
+  metadata.gz: 2b0511a3995c27d1d0b7bb8979c53a1b72e6ae1ea73bff636278ccb590a386d96e46393d871e3993c613604c6e10dbc386cc1a1de6f6ebeebccbf3f973965326
+  data.tar.gz: 20ba7273f5b2d655c5ebb6c283ea2d36e34e2417fd51f6bd4698dc7187985baa1944b4f548a3756622f7c697742f3388bec5dd3f3d00d1e7a12936e011dea440

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # main
 
+# 0.0.4
+
+* Added support for mx: and my: :auto.
+
+    *Christian Giordano*
+
+* Added support for custom layout sizes.
+
+    *Manuel Puyol*
 # 0.0.3
 
 * Add support for responsive `float` style argument.

data/app/components/primer/layout_component.html.erb

@@ -1,16 +1,16 @@
 <%= render(Primer::FlexComponent.new(**@kwargs)) do %>
   <% if @side == :left %>
-    <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, 3] : 3), mb: (@responsive ? [4, nil, 0] : nil)) do %>
+    <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, @sidebar_col] : @sidebar_col), mb: (@responsive ? [4, nil, 0] : nil)) do %>
       <%= sidebar %>
     <% end %>
   <% end %>
 
-  <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, 9] : 9), mb: (@responsive ? [4, nil, 0] : nil)) do %>
+  <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, @main_col] : @main_col), mb: (@responsive ? [4, nil, 0] : nil)) do %>
     <%= main %>
   <% end %>
 
   <% if @side == :right %>
-    <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, 3] : 3)) do %>
+    <%= render Primer::BaseComponent.new(tag: :div, classes: "flex-shrink-0", col: (@responsive ? [12, nil, @sidebar_col] : @sidebar_col)) do %>
       <%= sidebar %>
     <% end %>
   <% end %>

data/app/components/primer/layout_component.rb

@@ -5,17 +5,24 @@ module Primer
     with_content_areas :main, :sidebar
 
     DEFAULT_SIDE = :right
-    ALLOWED_SIDES = [DEFAULT_SIDE, :left]
+    ALLOWED_SIDES = [DEFAULT_SIDE, :left].freeze
 
-    def initialize(responsive: false, side: DEFAULT_SIDE, **kwargs)
+    MAX_COL = 12
+    DEFAULT_SIDEBAR_COL = 3
+    ALLOWED_SIDEBAR_COLS = (1..(MAX_COL - 1)).to_a.freeze
+
+    def initialize(responsive: false, side: DEFAULT_SIDE, sidebar_col: DEFAULT_SIDEBAR_COL, **kwargs)
       @kwargs = kwargs
-      @side = fetch_or_fallback(ALLOWED_SIDES, side, DEFAULT_SIDE)
+      @side = fetch_or_fallback(ALLOWED_SIDES, side.to_sym, DEFAULT_SIDE)
       @responsive = responsive
       @kwargs[:classes] = class_names(
         "gutter-condensed gutter-lg",
         @kwargs[:classes]
       )
       @kwargs[:direction] = responsive ? [:column, nil, :row] : nil
+
+      @sidebar_col = fetch_or_fallback(ALLOWED_SIDEBAR_COLS, sidebar_col, DEFAULT_SIDEBAR_COL)
+      @main_col = MAX_COL - @sidebar_col
     end
   end
 end

data/lib/primer/classify.rb

@@ -161,9 +161,9 @@ module Primer
 
             if SPACING_KEYS.include?(key)
               if MARGIN_DIRECTION_KEYS.include?(key)
-                raise ArgumentError, "value must be between -6 and 6" if (val < -6 || val > 6)
-              else
-                raise ArgumentError, "value must be between 0 and 6" if (val < 0 || val > 6)
+                raise ArgumentError, "value of #{key} must be between -6 and 6" if (val < -6 || val > 6)
+              elsif !((key == :mx || key == :my) && val == :auto)
+                raise ArgumentError, "value of #{key} must be between 0 and 6" if (val < 0 || val > 6)
               end
             end
 

data/lib/primer/fetch_or_fallback_helper.rb

@@ -23,7 +23,7 @@ module Primer
       if allowed_values.include?(given_value)
         given_value
       else
-        if fallback_raises && ENV["RAILS_ENV"] != "production"
+        if fallback_raises && ENV["RAILS_ENV"] != "production" && ENV["STORYBOOK"] != "true"
           raise InvalidValueError, <<~MSG
             fetch_or_fallback was called with an invalid value.
 

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 3
+      PATCH = 4
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-13 00:00:00.000000000 Z
+date: 2020-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails