preval 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a68492a84d002ce1287b7494fdeb2f7da2c1bf40f9001830c189b012679fff82
-  data.tar.gz: ee652180924518b7c95ecc4dd3d1453ad05bc72b87f550c8921b765fc1b17418
+  metadata.gz: 38f2a5ee7be77fb0aac3f27ff453882026d53c50dfa3358dbcdf5f2a022486e2
+  data.tar.gz: 4dc976e6da2f87d5b18cd588d1c11e86e0a3aa08a4adca073629144984d5de40
 SHA512:
-  metadata.gz: 79755ecb9e6b832a030d31052ffac72eccf86620562b7e82ec1b0f16a0dd5a9009e89c4c219ebad42a03984e144fbce042bd603b269b6970cdaf847e5c2969f4
-  data.tar.gz: 974140ac97093237681db2d8369a9ef295001bc6135dd6802ab55f35888627dbd571c4935a2d8091d6d2a6db17136eb9b3e5e55c1ac379c5388ceffc7c0d9ac7
+  metadata.gz: d0387f1656097fe72b7eef9a83b98bf5c8cd38b65225c5931dc7d179416630577a7e3248fa57e4f4453cecca91fcd864c48e7e181aa74178cacf3fce4cdfe692
+  data.tar.gz: 9d623940a4710c8e83c1f9ac5eccc797280d99db3d4ace3750d01577965198302df92f80f7336525583d9b3b55a4ba3e68201b6d8d6e2343cbf7929d5f4ab1b0

data/.rubocop.yml

@@ -0,0 +1,30 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  TargetRubyVersion: 2.6
+  Exclude:
+  - lib/preval/format.rb
+
+Layout/CommentIndentation:
+  Enabled: false
+
+Lint/InheritException:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false

data/.travis.yml

@@ -2,3 +2,6 @@ language: ruby
 cache: bundler
 rvm: 2.6.0
 before_install: gem install bundler -v 2.0.0
+script:
+- bundle exec rake
+- bundle exec rubocop

data/CHANGELOG.md

@@ -6,23 +6,37 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+## [0.5.0] - 2019-06-13
+
+### Added
+
+- Replace `.sort.first` with `.min`.
+- Replace `.sort.last` with `.max`.
+
 ## [0.4.1] - 2019-04-20
+
 ### Changed
+
 - Support `attr_writer` transformations even if there is a void statement at the beginning of the method.
 
 ## [0.4.0] - 2019-04-19
+
 ### Added
+
 - Replace `def foo=(value); @foo = value; end` with `attr_writer :foo`
 - Replace `while false ... end` loops with nothing
 - Replace `until false ... end` loops with `loop do ... end` loops
 - Replace `until true ... end` loops with nothing
 
 ### Changed
+
 - Extracted out the `Preval::Visitors::AttrAccessor` visitor.
 - Renamed the `Preval::Visitors::Micro` visitor to `Preval::Visitors::Fasterer`.
 
 ## [0.3.0] - 2019-04-19
+
 ### Added
+
 - Fold constant for exponentiation if exponent is 0 and value is an integer.
 - Replace `.reverse.each` usage with `.reverse_each`.
 - Replace `foo ... in` loops with `.each do` loops.
@@ -33,14 +47,19 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 - Replace `def foo=(value); @foo = value; end` with `attr_writer :foo`.
 
 ## [0.2.0] - 2019-04-18
+
 ### Added
+
 - Hook into the `bootsnap` gem if it's loaded.
 
 ## [0.1.0] - 2019-03-08
+
 ### Added
+
 - Initial release. 🎉
 
-[Unreleased]: https://github.com/kddeisz/preval/compare/v0.4.1...HEAD
+[unreleased]: https://github.com/kddeisz/preval/compare/v0.5.0...HEAD
+[0.5.0]: https://github.com/kddeisz/preval/compare/v0.4.1...v0.5.0
 [0.4.1]: https://github.com/kddeisz/preval/compare/v0.4.0...v0.4.1
 [0.4.0]: https://github.com/kddeisz/preval/compare/v0.3.0...v0.4.0
 [0.3.0]: https://github.com/kddeisz/preval/compare/v0.2.0...v0.3.0

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,76 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and expression,
+level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+- Using welcoming and inclusive language
+- Being respectful of differing viewpoints and experiences
+- Gracefully accepting constructive criticism
+- Focusing on what is best for the community
+- Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+- The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+- Trolling, insulting/derogatory comments, and personal or political attacks
+- Public or private harassment
+- Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+- Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at kevin.deisz@gmail.com. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see
+https://www.contributor-covenant.org/faq

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Gemfile.lock

@@ -1,26 +1,41 @@
 PATH
   remote: .
   specs:
-    preval (0.4.1)
+    preval (0.5.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    bootsnap (1.4.3)
+    ast (2.4.0)
+    bootsnap (1.4.4)
       msgpack (~> 1.0)
+    jaro_winkler (1.5.2)
     minitest (5.11.3)
     msgpack (1.2.10)
     mustermann (1.0.3)
+    parallel (1.17.0)
+    parser (2.6.3.0)
+      ast (~> 2.4.0)
     rack (2.0.6)
     rack-protection (2.0.5)
       rack
+    rainbow (3.0.0)
     rake (12.3.2)
+    rubocop (0.71.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
     sinatra (2.0.5)
       mustermann (~> 1.0)
       rack (~> 2.0)
       rack-protection (= 2.0.5)
       tilt (~> 2.0)
     tilt (2.0.9)
+    unicode-display_width (1.6.0)
 
 PLATFORMS
   ruby
@@ -31,6 +46,7 @@ DEPENDENCIES
   minitest (~> 5.11)
   preval!
   rake (~> 12.3)
+  rubocop (~> 0.71)
   sinatra
 
 BUNDLED WITH

data/README.md

@@ -1,5 +1,7 @@
 # Preval
 
+[![Build Status](https://travis-ci.com/kddeisz/preval.svg?branch=master)](https://travis-ci.com/kddeisz/preval)
+
 `preval` is a gem that hooks into the Ruby compilation process and runs optimizations before it gets loaded by the virtual machine.
 
 Certain optimizations that are common in compilers are not immediately possible with Ruby on account of Ruby's flexibility. For example, most compilers will run through a process called [constant folding](https://en.wikipedia.org/wiki/Constant_folding) to eliminate the need to perform extraneous operations at runtime (e.g., `5 + 2` in the source can be replaced with `7`). However, because Ruby allows you to override the `Integer#+` method, it's possible that `5 + 2` would not evaluate to `7`. `preval` assumes that most developers will not override the `Integer#+` method, and performs optimizations under that assumption.
@@ -26,27 +28,60 @@ Or install it yourself as:
 
 If you're using the `bootsnap` gem, `preval` will automatically hook into its compilation step. Otherwise, you'll need to manually call `Preval.process(source)` with your own iseq loader (you can check out [yomikomu](https://github.com/ko1/yomikomu) for an example).
 
-Each optimization is generally named for the function it performs, and can be enabled through the `enable!` method on the visitor class. If you do not explicitly call `enable!` on any optimizations, nothing will change with your source.
-
-* `Preval::Visitors::Arithmetic` replaces:
-  * constant expressions with their evaluation (e.g., `5 + 2` becomes `7`)
-  * arithmetic identities with their evaluation (e.g., `a * 1` becomes `a`)
-* `Preval::Visitors::AttrAccessor` replaces:
-  * `def foo; @foo; end` with `attr_reader :foo`
-  * `def foo=(value); @foo = value; end` with `attr_writer :foo`
-* `Preval::Visitors::Fasterer` replaces:
-  * `.gsub('...', '...')` with `.tr('...', '...')` if the arguments are strings and are both of length 1
-  * `.map { ... }.flatten(1)` with `.flat_map { ... }`
-  * `.reverse.each` with `.reverse_each` 
-  * `.shuffle.first` with `.sample`
-* `Preval::Visitors::Loops` replaces:
-  * `for ... in ... end` loops with `... each do ... end` loops
-  * `while true ... end` loops with `loop do ... end` loops
-  * `while false ... end` loops with nothing
-  * `until false ... end` loops with `loop do ... end` loops
-  * `until true ... end` loops with nothing
-
-You can also call `Preval.enable_all!` which will enable every built-in visitor. Be especially careful when doing this.
+Each optimization is generally named for the function it performs, and can be enabled through the `enable!` method on the visitor class. If you do not explicitly call `enable!` on any optimizations, nothing will change with your source. You can also call `Preval.enable_all!` which will enable every built-in visitor. Be especially careful when doing this.
+
+### `Preval::Visitors::Arithmetic`
+
+Replaces:
+
+- constant expressions with their evaluation (e.g., `5 + 2` becomes `7`)
+- arithmetic identities with their evaluation (e.g., `a * 1` becomes `a`)
+
+Unsafe if:
+
+- you overload any of the `Integer` operator methods
+
+### `Preval::Visitors::AttrAccessor`
+
+Replaces:
+
+- `def foo; @foo; end` with `attr_reader :foo`
+- `def foo=(value); @foo = value; end` with `attr_writer :foo`
+
+Unsafe if:
+
+- you overload the `attr_reader` method
+- you overload the `attr_writer` method
+- you have custom complex `method_added` logic
+
+### `Preval::Visitors::Fasterer`
+
+Replaces:
+
+- `.gsub('...', '...')` with `.tr('...', '...')` if the arguments are strings and are both of length 1
+- `.map { ... }.flatten(1)` with `.flat_map { ... }`
+- `.reverse.each` with `.reverse_each`
+- `.shuffle.first` with `.sample`
+- `.sort.first` with `.min`
+- `.sort.last` with `.max`
+
+Unsafe if:
+
+- any of the effected methods are overwritten or custom (`gsub` and `tr` for the first one, `map`, `flatten`, and `flat_map` for the second, etc.)
+
+### `Preval::Visitors::Loops`
+
+Replaces:
+
+- `for ... in ... end` loops with `... each do ... end` loops
+- `while true ... end` loops with `loop do ... end` loops
+- `while false ... end` loops with nothing
+- `until false ... end` loops with `loop do ... end` loops
+- `until true ... end` loops with nothing
+
+Unsafe if:
+
+- the object over which you're iterating with a `for` loop has a custom `each` method that doesn't do what you'd expect it to do
 
 ## Development
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'preval'

data/bin/parse

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'ripper'
 

data/bin/print

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'preval'

data/docs/index.html

@@ -42,28 +42,104 @@ textarea, code {
       <code></code>
     </main>
     <script>
-const textarea = document.querySelector("textarea");
-const code = document.querySelector("code");
+(() => {
+  const textarea = document.querySelector("textarea");
+  const code = document.querySelector("code");
 
-const fetchCode = () => {
-  var xhr = new XMLHttpRequest();
-  xhr.open("POST", "/", true);
+  const fetchCode = () => {
+    var xhr = new XMLHttpRequest();
+    xhr.open("POST", "/", true);
 
-  xhr.onreadystatechange = () => {
-    if (xhr.readyState === XMLHttpRequest.DONE) {
-      code.innerText = xhr.status === 200 ? xhr.responseText : "";
+    xhr.onreadystatechange = () => {
+      if (xhr.readyState === XMLHttpRequest.DONE) {
+        code.innerText = xhr.status === 200 ? xhr.responseText : "";
+      }
+    };
+
+    xhr.send(textarea.value);
+  };
+
+  let timeout = 0;
+
+  textarea.addEventListener("input", () => {
+    clearTimeout(timeout);
+    timeout = setTimeout(fetchCode, 300);
+  });
+
+  const handleTab = event => {
+    event.preventDefault();
+
+    const { selectionStart, selectionEnd, value } = textarea;
+
+    const preSpace = value.substring(0, selectionStart);
+    const postSpace = value.substring(selectionEnd);
+
+    textarea.value = `${preSpace}  ${postSpace}`;
+    textarea.selectionStart = textarea.selectionEnd = selectionStart + 2;
+  };
+
+  const indentLine = line => `  ${line}`;
+  const dedentLine = line => {
+    if (line.startsWith("  ")) {
+      return line.slice(2);
+    }
+    if (line.startsWith(" ")) {
+      return line.slice(1);
     }
+    return line;
   };
 
-  xhr.send(textarea.value);
-};
+  const handleDent = event => {
+    event.preventDefault();
 
-let timeout = 0;
+    const { selectionStart, selectionEnd, value } = textarea;
+    const lines = value.split("\n");
 
-textarea.addEventListener("input", () => {
-  clearTimeout(timeout);
-  timeout = setTimeout(fetchCode, 300);
-});
+    let currentStart = selectionStart;
+    let currentEnd = selectionEnd;
+    let startLine = null;
+    let endLine = null;
+
+    for (let lineIdx = 0; lineIdx < lines.length; lineIdx += 1) {
+      currentStart -= (lines[lineIdx].length + 1);
+      if (startLine === null && currentStart < 0) {
+        startLine = lineIdx;
+      }
+
+      currentEnd -= (lines[lineIdx].length + 1);
+      if (endLine === null && currentEnd < 0) {
+        endLine = lineIdx;
+      }
+
+      if (currentStart < 0 && currentEnd < 0) {
+        break;
+      }
+    }
+
+    const nextLines = (
+      lines.slice(0, startLine)
+        .concat(lines.slice(startLine, endLine + 1).map(
+          event.key === "]" ? indentLine : dedentLine
+        ))
+        .concat(lines.slice(endLine + 1))
+    );
+
+    textarea.value = nextLines.join("\n");
+
+    const buffer = nextLines.slice(0, startLine + 1).join("\n").length;
+    textarea.selectionStart = textarea.selectionEnd = (
+      buffer + currentStart + 1
+    );
+  };
+
+  textarea.addEventListener("keydown", event => {
+    if (event.key === "Tab") {
+      handleTab(event);
+    } else if (["[", "]"].includes(event.key) && event.metaKey) {
+      handleDent(event);
+    }
+  });
+})();
     </script>
   </body>
 </html>

data/docs/server.rb

@@ -14,4 +14,6 @@ post '/' do
   Preval.process(request.body.read || '').tap do |response|
     halt 422 unless response
   end
+rescue NoMethodError
+  halt 422
 end

data/lib/preval.rb

@@ -3,7 +3,7 @@
 require 'ripper'
 
 module Preval
-  SyntaxError = Class.new(SyntaxError)
+  SyntaxError = Class.new(::SyntaxError)
 
   class << self
     attr_reader :visitors

data/lib/preval/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Preval
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/lib/preval/visitors/attr_accessor.rb

@@ -6,15 +6,15 @@ module Preval
       def on_def(node)
         # auto create attr_readers
         if node.type_match?(:@ident, :params, :bodystmt) &&
-             # def foo; @foo; end
+           # def foo; @foo; end
            node[1].body.none? &&
-             # there are no params to this method
+           # there are no params to this method
            node[2, 0].type_match?(:stmts_new, :var_ref) &&
-             # there is only one statement in the body and its a var reference
+           # there is only one statement in the body and its a var reference
            node[2, 0, 1, 0].is?(:@ivar) &&
-             # the var reference is referencing an instance variable
+           # the var reference is referencing an instance variable
            node[0].body == node[2, 0, 1, 0].body[1..-1]
-             # the name of the variable matches the name of the method
+           # the name of the variable matches the name of the method
 
           ast = Parser.parse("attr_reader :#{node[0].body}")
           node.update(:stmts_add, ast.body[0].body)
@@ -22,28 +22,28 @@ module Preval
 
         # auto create attr_writers
         if node.type_match?(:@ident, :paren, :bodystmt) &&
-             # def foo=(value); @foo = value; end
+           # def foo=(value); @foo = value; end
            node[0].body.end_with?('=') &&
-             # this is a setter method
+           # this is a setter method
            node[1, 0, 0].length == 1 &&
-             # there is exactly one required param
+           # there is exactly one required param
            node[1, 0].body[1..-1].none? &&
-             # there are no other params
+           # there are no other params
            (
              node[2, 0].type_match?(:stmts_new, :assign) || (
                node[2, 0, 0].type_match?(:stmts_new, :void_stmt) &&
                node[2, 0].type_match?(:stmts_add, :assign)
              )
            ) &&
-             # there is only one statement in the body and it's an assignment
+           # there is only one statement in the body and it's an assignment
            node[2, 0, 1].type_match?(:var_field, :var_ref) &&
-             # assigning a variable
+           # assigning a variable
            node[2, 0, 1, 0, 0].is?(:@ivar) &&
-             # assigning to an instance variable
+           # assigning to an instance variable
            node[0].body[0..-2] == node[2, 0, 1, 0, 0].body[1..-1] &&
-             # variable name matches the method name
+           # variable name matches the method name
            node[1, 0, 0][0].body == node[2, 0, 1, 1, 0].body
-             # assignment variable matches the argument name
+           # assignment variable matches the argument name
 
           ast = Parser.parse("attr_writer :#{node[0].body[0..-2]}")
           node.update(:stmts_add, ast.body[0].body)

data/lib/preval/visitors/fasterer.rb

@@ -9,16 +9,24 @@ module Preval
 
         # replace `.reverse.each` with `.reverse_each`
         # replace `.shuffle.first` with `.sample`
+        # replace `.sort.first` with `min`
+        # replace `.sort.last` with `max`
         if node.type_match?(:call, :@period, :@ident) &&
-             # foo.each
+           # foo.each
            left.type_match?(%i[array vcall], :@period, :@ident)
-             # foo.reverse
+           # foo.reverse
 
           callleft, callperiod, callright = left.body
 
           if callright.body == 'reverse' && right.body == 'each'
             callright.update(:@ident, 'reverse_each')
             node.update(:call, [callleft, callperiod, callright])
+          elsif callright.body == 'sort' && right.body == 'first'
+            callright.update(:@ident, 'min')
+            node.update(:call, [callleft, callperiod, callright])
+          elsif callright.body == 'sort' && right.body == 'last'
+            callright.update(:@ident, 'max')
+            node.update(:call, [callleft, callperiod, callright])
           elsif callright.body == 'shuffle' && right.body == 'first'
             callright.update(:@ident, 'sample')
             node.update(:call, [callleft, callperiod, callright])
@@ -29,20 +37,20 @@ module Preval
       def on_method_add_arg(node)
         # replace `.gsub('...', '...')` with `.tr('...', '...')`
         if node.type_match?(:call, :arg_paren) &&
-             # foo.gsub()
+           # foo.gsub()
            node[0].type_match?(:vcall, :@period, :@ident) &&
-             # foo.gsub
+           # foo.gsub
            node[0, 2].body == 'gsub'
-             # the method being called is gsub
+           # the method being called is gsub
 
           left = node[1, 0, 0, 0, 1]
           right = node[1, 0, 0, 1]
 
           if left.is?(:string_literal) &&
              right.is?(:string_literal) &&
-             [left, right].all? do |node|
-               node[0, 1].is?(:@tstring_content) &&
-               node[0, 1].body.length == 1
+             [left, right].all? do |string|
+               string[0, 1].is?(:@tstring_content) &&
+               string[0, 1].body.length == 1
              end
 
             node[0, 2].update(:@ident, 'tr')
@@ -50,22 +58,22 @@ module Preval
         end
 
         # replace `.map { ... }.flatten(1)` with `.flat_map { ... }`
-        if node.type_match?(:call, :arg_paren) && 
-             # foo.flatten()
+        if node.type_match?(:call, :arg_paren) &&
+           # foo.flatten()
            node[0].type_match?(:method_add_block, :@period, :@ident) &&
-             # foo.map {}
+           # foo.map {}
            node[0, 0, 0].type_match?(%i[array vcall], :@period, :@ident) &&
-             # foo.flatten
+           # foo.flatten
            node[0, 0, 0, 2].body == 'map' &&
-             # the inner call is a call to map
+           # the inner call is a call to map
            node[0, 2].body == 'flatten' &&
-             # the outer call is a call to flatten
+           # the outer call is a call to flatten
            node[1].is?(:arg_paren) &&
-             # flatten has a param
+           # flatten has a param
            node[1, 0, 0].type_match?(:args_new, :@int) &&
-             # there is only one argument to flatten and it is an integer
+           # there is only one argument to flatten and it is an integer
            node[1, 0, 0, 1].body == '1'
-             # the value of the argument to flatten is 1
+           # the value of the argument to flatten is 1
 
           node[0, 0, 0, 2].update(:@ident, 'flat_map')
           node.update(:method_add_block, node[0, 0].body)

data/lib/preval/visitors/loops.rb

@@ -16,11 +16,11 @@ module Preval
       def on_while(node)
         # auto replace `while true` with `loop do`
         if node[0].is?(:var_ref) &&
-             # the predicate to the while is a variable reference
+           # the predicate to the while is a variable reference
            node[0, 0].is?(:@kw) &&
-             # the variable reference is a keyword
+           # the variable reference is a keyword
            node[0, 0].body == 'true'
-             # the keyword is "true"
+           # the keyword is "true"
 
           ast = Parser.parse(<<~CODE)
             loop do
@@ -33,11 +33,11 @@ module Preval
 
         # ignore `while false`
         if node[0].is?(:var_ref) &&
-             # the predicate to the while is a variable reference
+           # the predicate to the while is a variable reference
            node[0, 0].is?(:@kw) &&
-             # the variable reference is a keyword
+           # the variable reference is a keyword
            node[0, 0].body == 'false'
-             # the kwyword is "false"
+           # the kwyword is "false"
 
           node.update(:void_stmt, [])
         end
@@ -46,11 +46,11 @@ module Preval
       def on_until(node)
         # auto replace `until false` with `loop do`
         if node[0].is?(:var_ref) &&
-             # the predicate to the while is a variable reference
+           # the predicate to the while is a variable reference
            node[0, 0].is?(:@kw) &&
-             # the variable reference is a keyword
+           # the variable reference is a keyword
            node[0, 0].body == 'false'
-             # the keyword is "false"
+           # the keyword is "false"
 
           ast = Parser.parse(<<~CODE)
             loop do
@@ -63,11 +63,11 @@ module Preval
 
         # ignore `until true`
         if node[0].is?(:var_ref) &&
-             # the predicate to the until is a variable reference
+           # the predicate to the until is a variable reference
            node[0, 0].is?(:@kw) &&
-             # the variable reference is a keyword
+           # the variable reference is a keyword
            node[0, 0].body == 'true'
-             # the kwyword is "true"
+           # the kwyword is "true"
 
           node.update(:void_stmt, [])
         end

data/preval.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'preval/version'
@@ -12,14 +14,19 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/kddeisz/preval'
   spec.license       = 'MIT'
 
-  spec.files         = Dir.chdir(__dir__) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
+  spec.files         =
+    Dir.chdir(__dir__) do
+      `git ls-files -z`.split("\x0").reject do |f|
+        f.match(%r{^(test|spec|features)/})
+      end
+    end
+
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'minitest', '~> 5.11'
+  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'rubocop', '~> 0.71'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: preval
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Kevin Deisz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-20 00:00:00.000000000 Z
+date: 2019-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -39,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '12.3'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '0.71'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '0.71'
 description: 
 email:
 - kevin.deisz@gmail.com
@@ -60,8 +74,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
 - LICENSE