RubyGems - pretty_face - Versions diffs - 0.1 → 0.2 - Mend

pretty_face 0.1 → 0.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (33) hide show

data/.gitignore +2 -0
data/.travis.yml +2 -0
data/ChangeLog +7 -0
data/README.md +8 -2
data/Rakefile +1 -0
data/autotrader.png +0 -0
data/cucumber.yml +1 -1
data/features/feature_pages.feature +94 -0
data/features/pretty_face_report.feature +38 -32
data/features/support/hooks.rb +5 -0
data/fixtures/advanced.feature +43 -0
data/fixtures/background.feature +10 -0
data/fixtures/basic.feature +3 -0
data/fixtures/failing_background.feature +7 -0
data/fixtures/more/more.feature +8 -0
data/fixtures/step_definitions/advanced_steps.rb +24 -2
data/fixtures/step_definitions/basic_steps.rb +6 -0
data/lib/pretty_face/formatter/html.rb +123 -38
data/lib/pretty_face/formatter/report.rb +145 -14
data/lib/pretty_face/formatter/view_helper.rb +10 -9
data/lib/pretty_face/templates/_step.erb +41 -0
data/lib/pretty_face/templates/failed.png +0 -0
data/lib/pretty_face/templates/feature.erb +147 -0
data/lib/pretty_face/templates/main.erb +71 -130
data/lib/pretty_face/templates/passed.png +0 -0
data/lib/pretty_face/templates/pending.png +0 -0
data/lib/pretty_face/templates/skipped.png +0 -0
data/lib/pretty_face/templates/style.css +149 -0
data/lib/pretty_face/templates/undefined.png +0 -0
data/lib/pretty_face/version.rb +1 -1
data/pretty_face.gemspec +3 -1
data/spec/lib/html_formatter_spec.rb +45 -16
metadata +35 -4

data/.gitignore CHANGED Viewed

@@ -6,3 +6,5 @@ pkg/*
 *.swp
 fixture.html
 images
+results
+tmp

data/.travis.yml CHANGED Viewed

@@ -1,3 +1,5 @@
+before_install: mkdir results
 language: ruby
 rvm:
   - 1.9.3

data/ChangeLog CHANGED Viewed

@@ -1,2 +1,9 @@
+=== Release 0.2
+* Creating a page for each feature file
+* Displaying Background
+* Displaying Errors on feature pages
+* Displaying multi-line steps
+* Displaying embedded images
 === Release 0.1 / 2012-11-17
 Initial release with single page basic report

data/README.md CHANGED Viewed

@@ -1,6 +1,12 @@
 # pretty_face
-HTML report for cucumber and rspec.  You can customzie the report by editing an erb file.
+HTML report for cucumber and rspec.  You can customize the report by editing an erb file.
+The current release is very basic but you can expect a lot more over the next month or so.  If you wish to use this formatter you can simply add the following to your command-line or cucumber.yml profile:
+    --format PrettyFace::Formatter::Html --out index.html
 ## Known Issues
@@ -18,4 +24,4 @@ See [http://github.com/cheezy/pretty_face/issues](http://github.com/cheezy/prett
 ## Copyright
-Copyright (c) 2012 Jeffrey S. Morgan. See LICENSE for details.
+Copyright (c) 2012-2013 Jeffrey S. Morgan. See LICENSE for details.

data/Rakefile CHANGED Viewed

@@ -6,6 +6,7 @@ require 'rspec/core/rake_task'
 Cucumber::Rake::Task.new(:features, "Run all features") do |t|
   t.profile = 'default'
 end
 RSpec::Core::RakeTask.new(:spec) do |spec|
   spec.ruby_opts = "-I lib:spec"
   spec.pattern = 'spec/**/*_spec.rb'

data/autotrader.png ADDED Viewed

Binary file

data/cucumber.yml CHANGED Viewed

@@ -1,3 +1,3 @@
 default: --color --no-source --format pretty
-fixture: --color --no-source --require fixtures/step_definitions --format PrettyFace::Formatter::Html --out fixture.html
+fixture: --color --no-source --require fixtures/step_definitions --format PrettyFace::Formatter::Html --out results/fixture.html
 focus: --color --no-source --format pretty --tags @focus

data/features/feature_pages.feature ADDED Viewed

@@ -0,0 +1,94 @@
+Feature: pages that show details for features
+  Background:
+    When I run `cucumber fixtures --profile fixture`
+  Scenario: Generate the pages
+    Then the following files should exist:
+    | results/basic.html    |
+    | results/advanced.html |
+  Scenario: Generating the basic html page from the erb
+    Then the file "results/basic.html" should contain "DOCTYPE html PUBLIC"
+    And the file "results/basic.html" should contain "<html xmlns='http://www.w3.org/1999/xhtml'>"
+    And the file "results/basic.html" should contain "<head>"
+    And the file "results/basic.html" should contain "<body"
+    And the file "results/basic.html" should contain "<title>Feature Results</title>"
+  Scenario: Including an image / logo
+    Then the file "results/basic.html" should contain "<img src="
+    And the file "results/basic.html" should contain "images/face.jpg"
+  Scenario: It should show start time and duration in the header
+    Then the file "results/basic.html" should contain "Feature started:"
+    And the file "results/basic.html" should contain "Duration:"
+  Scenario: Generating some basic stats from the erb
+    Then the file "results/basic.html" should contain "<th>Executed<"
+    And the file "results/basic.html" should contain "<th>Average<br/>Duration"
+    And the file "results/basic.html" should contain "Scenarios"
+    And the file "results/basic.html" should contain "Steps"
+  Scenario: It should capture scenario and step statuses
+    Then the file "results/basic.html" should contain "Passed"
+    And the file "results/basic.html" should contain "Failed"
+    And the file "results/basic.html" should contain "Pending"
+    And the file "results/basic.html" should contain "Undefined"
+    And the file "results/basic.html" should contain "Skipped"
+  Scenario: It should display scenario names
+    Then the file "results/basic.html" should contain "A passing scenario"
+    And the file "results/advanced.html" should contain "A scenario outline"
+    And the file "results/background.html" should contain "Another passing scenario"
+  Scenario: It should display scenario steps
+    Then the file "results/basic.html" should contain "it should say hello"
+    And the file "results/background.html" should contain "it should say hello"
+    And the file "results/advanced.html" should contain "I am using a scenario outline"
+  Scenario: It should display the step and data for scenario outline steps
+  I use &#x27;aaa&#x27;\
+    Then the file "results/advanced.html" should contain "I use &#x27;aaa&#x27;"
+    And the file "results/advanced.html" should contain "I use &#x27;bbb&#x27;"
+  Scenario: It should display descriptions for features
+    Then the file "results/basic.html" should contain "As a stakeholder"
+    Then the file "results/basic.html" should contain "I want to see some details about this feature"
+    Then the file "results/basic.html" should contain "So that I have some idea why this test matters"
+  Scenario: It should display a nested table
+    Then the file "results/advanced.html" should contain "<th>key1</th>"
+    And the file "results/advanced.html" should contain "<th>key2</th>"
+    And the file "results/advanced.html" should contain "<th>key3</th>"
+    And the file "results/advanced.html" should contain "<td>value1</td>"
+    And the file "results/advanced.html" should contain "<td>value2</td>"
+    And the file "results/advanced.html" should contain "<td>value3</td>"
+  Scenario: It should display the multi-line argument
+    Then the file "results/advanced.html" should contain "Hello with"
+    And the file "results/advanced.html" should contain "more than one"
+    And the file "results/advanced.html" should contain "line in a string"
+  Scenario: It should display errors for features
+    Then the file "results/basic.html" should contain "RSpec::Expectations::ExpectationNotMetError"
+    Then the file "results/advanced.html" should contain "RSpec::Expectations::ExpectationNotMetError"
+    Then the file "results/failing_background.html" should contain "RSpec::Expectations::ExpectationNotMetError"
+  Scenario: Embedding an image into the page
+    Then the file "results/basic.html" should contain "<img id='img_0' style='display: none' src='images/autotrader.png'/>"
+    And the file "results/basic.html" should contain "<a href='' onclick="
+    And the file "results/basic.html" should contain "img=document.getElementById('img_0'); img.style.display = (img.style.display == 'none' ? 'block' : 'none');return false"
+    And the file "results/basic.html" should contain ">AutoTrader</a>"
+  Scenario: Displaying a background
+    Then the file "results/background.html" should contain "Background: A scenario can have a background"
+    And the file "results/background.html" should contain "When  Cucumber puts"
+  Scenario: Feature pages should have a link back to the report summary
+    Then the file "results/advanced.html" should contain "<a href="
+  Scenario: Should create directories when directories exist in features directory
+    Then the following files should exist:
+    | results/more/more.html |

data/features/pretty_face_report.feature CHANGED Viewed

@@ -5,59 +5,65 @@ Feature: pretty face report
   Scenario: Cucumber crefates an html report
     Then the following files should exist:
-    | fixture.html |
+    | results/fixture.html |
   Scenario: Generating the basic html page from the erb
-    Then the file "fixture.html" should contain "DOCTYPE html PUBLIC"
-    And the file "fixture.html" should contain "<html xmlns='http://www.w3.org/1999/xhtml'>"
-    And the file "fixture.html" should contain "<head>"
-    And the file "fixture.html" should contain "<body"
-    And the file "fixture.html" should contain "<title>Test Results</title>"
+    Then the file "results/fixture.html" should contain "DOCTYPE html PUBLIC"
+    And the file "results/fixture.html" should contain "<html xmlns='http://www.w3.org/1999/xhtml'>"
+    And the file "results/fixture.html" should contain "<head>"
+    And the file "results/fixture.html" should contain "<body"
+    And the file "results/fixture.html" should contain "<title>Test Results</title>"
   Scenario: Generating some basic stats from the erb
-    Then the file "fixture.html" should contain "<th>Executed<"
-    And the file "fixture.html" should contain "<th>Average<br/>Duration"
-    And the file "fixture.html" should contain "Scenarios"
-    And the file "fixture.html" should contain "Steps"
+    Then the file "results/fixture.html" should contain "<th>Executed<"
+    And the file "results/fixture.html" should contain "<th>Average<br/>Duration"
+    And the file "results/fixture.html" should contain "Scenarios"
+    And the file "results/fixture.html" should contain "Steps"
   Scenario: Including the styles for the main page
-    Then the file "fixture.html" should contain "<style type='text/css'>"
-    And the file "fixture.html" should contain "</style>"
+    Then the file "results/fixture.html" should contain "<link href='stylesheets/style.css' type='text/css' rel='stylesheet' />"
+    And the file "results/fixture.html" should not contain "</style>"
   Scenario: Including an image / logo
-    Then the file "fixture.html" should contain "<img src="
-    And the file "fixture.html" should contain "images/face.jpg"
+    Then the file "results/fixture.html" should contain "<img src="
+    And the file "results/fixture.html" should contain "images/face.jpg"
+  Scenario: It should copy the style sheet to the stylesheets directory
+    Then the following files should exist:
+      | results/stylesheets/style.css |
   Scenario: It should copy the logo image to the images directory
     Then the following files should exist:
-    | images/face.jpg |
+    | results/images/face.jpg |
   Scenario: It should show start time and duration in the header
-    Then the file "fixture.html" should contain "Tests started:"
-    And the file "fixture.html" should contain "Duration:"
+    Then the file "results/fixture.html" should contain "Tests started:"
+    And the file "results/fixture.html" should contain "Duration:"
   Scenario: It should capture scenario and step statuses
-    Then the file "fixture.html" should contain "Passed"
-    And the file "fixture.html" should contain "Failed"
-    And the file "fixture.html" should contain "Pending"
-    And the file "fixture.html" should contain "Undefined"
-    And the file "fixture.html" should contain "Skipped"
+    Then the file "results/fixture.html" should contain "Passed"
+    And the file "results/fixture.html" should contain "Failed"
+    And the file "results/fixture.html" should contain "Pending"
+    And the file "results/fixture.html" should contain "Undefined"
+    And the file "results/fixture.html" should contain "Skipped"
   Scenario: It should display all of the tests with failures
-    Then the file "fixture.html" should contain "Tests With Failures:"
+    Then the file "results/fixture.html" should contain "Tests With Failures:"
   Scenario: It should display a list of all features / scenarios
-    Then the file "fixture.html" should contain "Scenario Overview:"
+    Then the file "results/fixture.html" should contain "Feature Overview:"
   Scenario: It should display useful information about each scenario
-    Then the file "fixture.html" should contain "Result"
-    And the file "fixture.html" should contain "Name"
-    And the file "fixture.html" should contain "# Steps"
-    And the file "fixture.html" should contain "Duration"
+    Then the file "results/fixture.html" should contain "Feature"
+    And the file "results/fixture.html" should contain "File"
+    And the file "results/fixture.html" should contain "Passed"
+    And the file "results/fixture.html" should contain "Failed"
+    And the file "results/fixture.html" should contain "Pending"
+    And the file "results/fixture.html" should contain "Undefined"
+    And the file "results/fixture.html" should contain "Skipped"
   Scenario: It should display the data from scenario outlines
-    Then the file "fixture.html" should contain "| aaa | bbb |"
-    And the file "fixture.html" should contain "| ccc | ddd |"
+    Then the file "results/fixture.html" should contain "| aaa | bbb |"
+    And the file "results/fixture.html" should contain "| ccc | ddd |"
-  Scenario: It should display the scenario name for scenario outlines
-    Then the file "fixture.html" should contain "A scenario outline"

data/features/support/hooks.rb CHANGED Viewed

@@ -1,5 +1,10 @@
 require 'fileutils'
+Before do
+  @aruba_timeout_seconds = 60
+  FileUtils.mkdir('results') unless File.exists? 'results'
+end
 After do
   file = File.join(File.dirname(__FILE__), '..', '..', 'fixture.html')
  # FileUtils.rm file

data/fixtures/advanced.feature CHANGED Viewed

@@ -11,4 +11,47 @@ Feature: Advanced scenarios
   | aaa   | bbb    |
   | ccc   | ddd    |
   | eee   | fff    |
+  Scenario: Nested table in a step
+    When I have a nested table step like this:
+    | key1   | key2   | key3   |
+    | value1 | value2 | value3 |
+    Then the table should be displayed in the results
+  Scenario: A scenario with muti-line arguments
+    When Cucumber puts
+      """
+      Hello with
+      more than one
+      line in a string
+      """
+    Then it should say
+      """
+      Hello with
+      more than one
+      line in a string
+      """
+  Scenario Outline:  Fails during examples
+    Given I am using a scenario outline
+    When I fail with <first>
+    Then I use <second>
+    Then the examples should not work
+  Examples:
+  | first | second |
+  | aaa   | bbb    |
+  | ccc   | ddd    |
+  | eee   | fff    |
+  Scenario Outline:  Fails before examples
+    Given the first step fails
+    When I use <first>
+    And I use <second>
+    Then the examples should not work
+  Examples:
+  | first | second |
+  | aaa   | bbb    |
+  | ccc   | ddd    |
+  | eee   | fff    |

data/fixtures/background.feature ADDED Viewed

@@ -0,0 +1,10 @@
+Feature: Background for scenarios
+  Background: A scenario can have a background
+    When Cucumber puts "hello" in a background
+  Scenario: A passing scenario
+    Then it should say hello
+  Scenario: Another passing scenario
+    Then it should say hello

data/fixtures/basic.feature CHANGED Viewed

@@ -1,4 +1,7 @@
 Feature: Basic scenarios
+  As a stakeholder
+  I want to see some details about this feature
+  So that I have some idea why this test matters
   Scenario: A passing scenario
     When Cucumber puts "hello"

data/fixtures/failing_background.feature ADDED Viewed

@@ -0,0 +1,7 @@
+Feature: Failing Background for scenarios
+  Background: A scenario can have a failing background
+    Given the first step fails
+  Scenario: A scenario with failing background
+    Then the second step should not execute

data/fixtures/more/more.feature ADDED Viewed

@@ -0,0 +1,8 @@
+Feature: More scenarios
+  As a stakeholder
+  I want to see some details about this feature
+  So that I have some idea why this test matters
+  Scenario: A passing scenario with more
+    When Cucumber puts "hello"
+    Then it should say hello

data/fixtures/step_definitions/advanced_steps.rb CHANGED Viewed

@@ -1,12 +1,34 @@
 Given /^I am using a scenario outline$/ do
 end
 When /^I use (.*?)$/ do |value|
 end
-Then /^the examples should work$/ do
+When /^I fail with (.*?)$/ do |value|
+  true.should == false
+end
+Then /^the examples should(?: not)? work$/ do
+  sleep 1
+end
+When /^I have a nested table step like this:$/ do |table|
 end
+Then /^the table should be displayed in the results$/ do
+end
+When /^Cucumber puts$/ do |some_string|
+  puts some_string
+  @last_string = some_string
+  sleep 1
+end
+Then /^it should say$/ do |some_string|
+  @last_string.should == some_string
+end

data/fixtures/step_definitions/basic_steps.rb CHANGED Viewed

@@ -1,5 +1,11 @@
 When /^Cucumber puts "(.*?)"$/ do |some_string|
   puts some_string
+  embed('autotrader.png', 'image/png', 'AutoTrader')
+  sleep 1
+end
+When /^Cucumber puts "(.*?)" in a background$/ do |some_string|
+  puts some_string
 end
 Then /^it should say hello$/ do

data/lib/pretty_face/formatter/html.rb CHANGED Viewed

@@ -1,4 +1,4 @@
-require 'erb'
+require 'action_view'
 require 'fileutils'
 require 'cucumber/formatter/io'
 require 'cucumber/formatter/duration'
@@ -16,31 +16,61 @@ module PrettyFace
       include Cucumber::Formatter::Duration
       include ViewHelper
+      attr_reader :report
       def initialize(step_mother, path_or_io, options)
         @path = path_or_io
         @io = ensure_io(path_or_io, 'html')
+        @path_to_erb = File.join(File.dirname(__FILE__), '..', 'templates')
         @step_mother = step_mother
         @options = options
         @report = Report.new
-        @step_times = []
-        @scenario_times = []
-        @outline_steps = []
+        @img_id = 0
+      end
+      def embed(src, mime_type, label)
+        case(mime_type)
+        when /^image\/(png|gif|jpg|jpeg)/
+          embed_image(src, label)
+        end
+      end
+      def embed_image(src, label)
+        @report.current_scenario.image = src.split('/').last
+        @report.current_scenario.image_label = label
+        @report.current_scenario.image_id = "img_#{@img_id}"
+        @img_id += 1
+        FileUtils.cp src, "#{File.dirname(@path)}/images"
       end
       def before_features(features)
+        make_output_directories
         @tests_started = Time.now
       end
+      def features_summary_file
+        parts = @io.path.split('/')
+        parts[parts.length - 1]
+      end
       def before_feature(feature)
-        @report.add_feature ReportFeature.new(feature)
+        @report.add_feature ReportFeature.new(feature, features_summary_file)
       end
       def after_feature(feature)
-        @report.current_feature.title = feature.title
+        @report.current_feature.close(feature)
+      end
+      def before_background(background)
+        @report.begin_background
+      end
+      def after_background(background)
+        @report.end_background
+        @report.current_feature.background << ReportStep.new(background)
       end
       def before_feature_element(feature_element)
-        @scenario_timer = Time.now
         unless scenario_outline? feature_element
           @report.add_scenario  ReportScenario.new(feature_element)
         end
@@ -52,12 +82,16 @@ module PrettyFace
         end
       end
-      def after_outline_table(outline_table)
-        process_scenario_outline(outline_table)
+      def before_table_row(example_row)
+        @report.add_scenario ReportScenario.new(example_row) unless info_row?(example_row)
       end
       def after_table_row(example_row)
-        @scenario_times.push Time.now - @scenario_timer
+        unless info_row?(example_row)
+          @report.current_scenario.populate(example_row)
+          build_scenario_outline_steps(example_row)
+        end
+        populate_cells(example_row) if example_row.instance_of? Cucumber::Ast::Table::Cells
       end
       def before_step(step)
@@ -65,7 +99,11 @@ module PrettyFace
       end
       def after_step(step)
-        process_step(step)
+        step = process_step(step) unless step_belongs_to_outline? step
+        if @cells
+          step.table = @cells
+          @cells = nil
+        end
       end
       def after_features(features)
@@ -73,6 +111,7 @@ module PrettyFace
         @duration = format_duration(Time.now - @tests_started)
         generate_report
         copy_images_directory
+        copy_stylesheets_directory
       end
       def features
@@ -82,58 +121,104 @@ module PrettyFace
       private
       def generate_report
-        filename = File.join(File.dirname(__FILE__), '..', 'templates', 'main.erb')
-        text = File.new(filename).read
-        @io.puts ERB.new(text, nil, "%").result(binding)
+        renderer = ActionView::Base.new(@path_to_erb)
+        filename = File.join(@path_to_erb, 'main')
+        @io.puts renderer.render(:file => filename, :locals => {:report => self})
+        features.each do |feature|
+          write_feature_file(feature)
+        end
       end
-      def copy_images_directory
-        path = "#{File.dirname(@path)}/images"
+      def write_feature_file(feature)
+        renderer = ActionView::Base.new(@path_to_erb)
+        filename = File.join(@path_to_erb, 'feature')
+        output_file = "#{File.dirname(@path)}/#{feature.file}"
+        to_cut = output_file.split('/').last
+        directory = output_file.sub("/#{to_cut}", '')
+        FileUtils.mkdir directory unless File.directory? directory
+        file = File.new(output_file, Cucumber.file_mode('w'))
+        file.puts renderer.render(:file => filename, :locals => {:feature => feature})
+        file.flush
+        file.close
+      end
+      def make_output_directories
+        make_directory 'images'
+        make_directory 'stylesheets'
+      end
+      def make_directory(dir)
+        path = "#{File.dirname(@path)}/#{dir}"
         FileUtils.mkdir path unless File.directory? path
-        %w(face failed passed pending undefined skipped).each do |file|
-          FileUtils.cp File.join(File.dirname(__FILE__), '..', 'templates', "#{file}.jpg"), path
+      end
+      def copy_directory(dir, file_names, file_extension)
+        path = "#{File.dirname(@path)}/#{dir}"
+        file_names.each do |file|
+          FileUtils.cp File.join(File.dirname(__FILE__), '..', 'templates', "#{file}.#{file_extension}"), path
         end
       end
-      def process_scenario(scenario)
-        @scenario_times.push Time.now - @scenario_timer
-        @report.current_scenario.populate(scenario)
+      def copy_images_directory
+        copy_directory 'images', ['face'], 'jpg'
+        copy_directory 'images', %w(failed passed pending undefined skipped), "png"
       end
-      def process_example_row(example_row)
-        @report.add_scenario build_scenario_outline_with example_row
+      def copy_stylesheets_directory
+        copy_directory 'stylesheets', ['style'], 'css'
       end
-      def process_scenario_outline(scenario_outline)
-        scenario_outline.example_rows.each do |example_row|
-          process_example_row(example_row)
-        end
-        @outline_steps = []
+      def process_scenario(scenario)
+        @report.current_scenario.populate(scenario)
       end
-      def process_step(step)
-        @step_times.push Time.now - @step_timer
-        if step_belongs_to_outline? step
-          @outline_steps << ReportStep.new(step)
+      def process_step(step, status=nil)
+        duration =  Time.now - @step_timer
+        report_step = ReportStep.new(step)
+        report_step.duration = duration
+        report_step.status = status unless status.nil?
+        if step.background?
+          @report.current_feature.background << report_step if @report.processing_background_steps?
         else
-          @report.add_step ReportStep.new(step)
+          @report.add_step report_step
         end
+        report_step
       end
       def scenario_outline?(feature_element)
         feature_element.is_a? Cucumber::Ast::ScenarioOutline
       end
+      def info_row?(example_row)
+        return example_row.scenario_outline.nil? if example_row.respond_to? :scenario_outline
+        return true if example_row.instance_of? Cucumber::Ast::Table::Cells
+        false
+      end
       def step_belongs_to_outline?(step)
         scenario = step.instance_variable_get "@feature_element"
         not scenario.nil?
       end
-      def build_scenario_outline_with(example_row)
-        scenario = ReportScenario.new(example_row)
-        scenario.steps = @outline_steps
-        scenario.populate example_row
-        scenario
+      def build_scenario_outline_steps(example_row)
+        si = example_row.instance_variable_get :@step_invocations
+        si.each do |row|
+          process_step(row, row.status)
+        end
+      end
+      def step_error(exception, step)
+        return nil if exception.nil?
+        exception.backtrace[-1] =~ /^#{step.file_colon_line}/ ? exception : nil
+      end
+      def populate_cells(example_row)
+        @cells ||= []
+        values = []
+        example_row.to_a.each do |cell|
+          values << cell.value
+        end
+        @cells << values
       end
     end
   end