presenter_rails 2.0.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ad881d965883dd21b21b96fca07691befd7aaa50
-  data.tar.gz: bbd8f56f09035195e9b469733f98188b281e8c37
+SHA256:
+  metadata.gz: a355a092de54795f9dfe502bb5b0f261232d0596b1062063377e223282e77ac3
+  data.tar.gz: 167f0bdfc3541a90df1a481ed39c0d40c6259472f1b397acf90e7c6c1c99be3d
 SHA512:
-  metadata.gz: d0540e2d1c5e94a3aacb7ca87db48ec09f67c8c06bca8685e3f6bb501c49aec9e7c08b4599fa1a8882fe2c97f27b598f05a90ab25b29e4f46430c89c28d4a853
-  data.tar.gz: cb5fd596bc8178cc99362e555d0c3039b3448786279a702791d332fbf43be36f6517b4bcf1b5a7d3c6fa5b6719073904961b08ebbb60432de43286ce483df6fb
+  metadata.gz: 860615c6538cffd6b4b1cbdf1f30cb3834a65e4b9d0058b46b267d720f81b9143d8610013fbb2a72f6778e5b8a529b6659f34a55fad4a5fea3a427314c4f7cdb
+  data.tar.gz: 66fb24a6bad6b1cfd78226fd5dd3c3fba992322b1e32a227be33c88b97c8fbff91edf08674b25e6c7ad6f514415f5e7d6cf979c3e0ba55775de4296599929d3e

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+## PresenterRails 3.0.0 (2021-02-24) ##
+
+*   Remove `ruby_version` restriction from gemspec to allow usage in Ruby 3.0.
+*   Remove additional Controller module.
+
+## PresenterRails 2.0.0 (2017-04-01) ##
+
+*   Now every call to `present` must pass a block, and defines a single method.
+*   PresenterRails is auto-included in mailers as well.
+*   Presenter methods are no longer assignable since the need does not come up in practice (`pakiderm` used to provide the feature).
+*   Dropped `pakiderm` as a dependency since memoization is now simpler.

data/README.md

@@ -1,4 +1,4 @@
-Presenter [![Gem Version](https://badge.fury.io/rb/presenter_rails.svg)](http://badge.fury.io/rb/presenter_rails) [![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/ElMassimo/presenter_rails/blob/master/LICENSE.txt)
+Presenter [![Gem Version](https://badge.fury.io/rb/presenter_rails.svg)](https://rubygems.org/gems/presenter_rails) [![Build Status](https://github.com/ElMassimo/presenter_rails/workflows/build/badge.svg)](https://github.com/ElMassimo/presenter_rails/actions) [![Test Coverage](https://codeclimate.com/github/ElMassimo/presenter_rails/badges/coverage.svg)](https://codeclimate.com/github/ElMassimo/presenter_rails) [![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/ElMassimo/presenter_rails/blob/master/LICENSE.txt)
 =====================
 
 Presenter helps you expose view models to your views in a convenient way, while
@@ -32,7 +32,9 @@ The method is also available in the controller, with a `_presenter` suffix:
  # app/controllers/people_controller.rb
  class PeopleController < ApplicationController
 
-    ...
+    present(:person) {
+      PersonDecorator.decorate(person)
+    }
 
     def update
       person.update(attrs)
@@ -47,7 +49,7 @@ The method is also available in the controller, with a `_presenter` suffix:
 ## Background
 Presenter attempts to simplify the exposure of variables to the views. It doesn't really care
 about what you are exposing, although it's specially useful to implement [two-step views](http://martinfowler.com/eaaCatalog/twoStepView.html) while using
-[draper](https://github.com/drapergem/draper) in combination with [resourcerer](https://github.com/ElMassimo/resourcerer).
+[view models](https://github.com/drapergem/draper) in combination with [resourcerer](https://github.com/ElMassimo/resourcerer).
 
 ### How it works
 
@@ -59,36 +61,8 @@ After that, it creates a helper method for your views, which calls the `"#{name}
 Each presenter method is memoized, so the method is called only once and your views get the same instance every time. The block is evaluated only if the method is called.
 
 #### Corolary
-Since the helper methods defined are only available for the view, you can define methods with the same name in your controller :smiley:.
-
-License
---------
-
-    Copyright (c) 2014 Máximo Mussini
-
-    MIT License
-
-    Permission is hereby granted, free of charge, to any person obtaining
-    a copy of this software and associated documentation files (the
-    "Software"), to deal in the Software without restriction, including
-    without limitation the rights to use, copy, modify, merge, publish,
-    distribute, sublicense, and/or sell copies of the Software, and to
-    permit persons to whom the Software is furnished to do so, subject to
-    the following conditions:
-
-    The above copyright notice and this permission notice shall be
-    included in all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-    EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-    MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-    NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-    LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-    OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-    WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
+Since the helper methods defined are only available for the view, you can define methods with the same name in your controller :smiley:
 
 Credits
 --------
-Presenter was crafted to use in combination with [resourcerer](https://github.com/ElMassimo/resourcerer) and
-[draper](https://github.com/drapergem/draper).
+Presenter was crafted to use in combination with [resourcerer](https://github.com/ElMassimo/resourcerer).

data/lib/presenter_rails.rb

@@ -2,7 +2,29 @@ require "presenter_rails/version"
 require "active_support/all"
 
 module PresenterRails
-  autoload :Controller, "presenter_rails/controller"
+  # Public: Defines a method and makes it available to the view context
+  # under the specified name as a memoized variable.
+  #
+  # name  - The name of the method as called from the view context.
+  # block - Executed once if (and only if) the method is called.
+  #
+  # Returns nothing.
+  def present(name, &block)
+    presenter_method = PresenterRails.method_name_for(name)
+    ivar = PresenterRails.ivar_for(name)
+
+    private define_method(presenter_method) {
+      if instance_variable_defined?(ivar)
+        instance_variable_get(ivar)
+      else
+        instance_variable_set(ivar, instance_exec(&block))
+      end
+    }
+
+    helper Module.new {
+      define_method(name) { controller.send(presenter_method) }
+    }
+  end
 
   # Internal: Name of the presenter method as defined in the controller.
   def self.method_name_for(name)
@@ -15,10 +37,10 @@ module PresenterRails
   end
 
   ActiveSupport.on_load :action_controller do
-    extend Controller
+    extend PresenterRails
   end
 
   ActiveSupport.on_load :action_mailer do
-    extend Controller
+    extend PresenterRails
   end
 end

data/lib/presenter_rails/version.rb

@@ -1,3 +1,3 @@
 module PresenterRails
-  VERSION = "2.0.0"
+  VERSION = "3.0.0"
 end

data/spec/presenter_rails/controller_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 require "rspec/rails"
 
-RSpec.describe PresenterRails::Controller do
+RSpec.describe PresenterRails do
   class Thing; end
   class DifferentThing; end
 
@@ -14,7 +14,7 @@ RSpec.describe PresenterRails::Controller do
   end
 
   class BaseController
-    extend PresenterRails::Controller
+    extend PresenterRails
 
     def self.helper(helper_module)
       @helper_modules ||= []

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+require "simplecov"
+SimpleCov.start { add_filter '/spec/' }
+
 require "presenter_rails"
 require "rspec/given"
-require "pry-byebug"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: presenter_rails
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Máximo Mussini
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-04-02 00:00:00.000000000 Z
+date: 2021-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -25,33 +25,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: actionmailer
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.18'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.18'
+- !ruby/object:Gem::Dependency
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rspec-given
   requirement: !ruby/object:Gem::Requirement
@@ -89,9 +103,9 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
+- CHANGELOG.md
 - README.md
 - lib/presenter_rails.rb
-- lib/presenter_rails/controller.rb
 - lib/presenter_rails/version.rb
 - spec/features/birds_controller_spec.rb
 - spec/features/birds_mailer_spec.rb
@@ -102,13 +116,13 @@ homepage: https://github.com/ElMassimo/presenter_rails
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -117,11 +131,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
-summary: ViewModels had a baby with helper_method
+summary: Expose your view models without using instance variables.
 test_files:
 - spec/features/birds_controller_spec.rb
 - spec/features/birds_mailer_spec.rb

data/lib/presenter_rails/controller.rb

@@ -1,26 +0,0 @@
-module PresenterRails
-  module Controller
-    # Public: Defines a method and makes it available to the view context
-    # under the specified name as a memoized variable.
-    #
-    # name  - The name of the method as called from the view context.
-    # block - Executed once if (and only if) the method is called.
-    #
-    # Returns nothing.
-    def present(name, &block)
-      presenter_method = PresenterRails.method_name_for(name)
-      ivar = PresenterRails.ivar_for(name)
-
-      private define_method(presenter_method) {
-        unless instance_variable_defined?(ivar)
-          instance_variable_set(ivar, instance_exec(&block))
-        end
-        instance_variable_get(ivar)
-      }
-
-      helper Module.new {
-        define_method(name) { controller.send(presenter_method) }
-      }
-    end
-  end
-end