predicates 0.1.1 → 0.1.2

data/README.md

@@ -32,7 +32,7 @@ Include Predicates in your class or model and define the predicate by supplying
     user.confirmed = 1
     user.confirmed? #=> true
 
-Predicates will define the attribute for you using `attr_accessor` if the attribute you supplied has not been defined yet.
+Predicates will also create an attribute writer for you using `attr_writer` if the attribute you supplied has not been predefined.
 
     class User
       extend Predicates

data/lib/predicates/version.rb

@@ -1,3 +1,3 @@
 module Predicates
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/predicates.rb

@@ -3,8 +3,8 @@ require "predicates/version"
 module Predicates
   class NameError < Exception; end
 
-  # Defines a predicate (truth accessor) for a given attribute. If the attribute has not been defined yet,
-  # the attribute will be created along with the predicate via +attr_accessor+.
+  # Defines a predicate (truth accessor) for a given attribute. If the attribute has not been predefined,
+  # an attribute writer will be created along with the predicate.
   #
   # == Class Example
   #
@@ -42,10 +42,10 @@ module Predicates
       raise NameError
     end
 
-    attr_accessor attribute unless method_defined? attribute
+    attr_writer attribute unless method_defined? attribute
 
     define_method method do
-      !!send(attribute)
+      !!eval("@#{attribute}")
     end
   end
 end

data/test/predicates_test.rb

@@ -21,7 +21,7 @@ class PredicatesTest < MiniTest::Unit::TestCase
     end
   end
 
-  def test_define_a_predicate_with_an_existing_attribute_accessor
+  def test_define_a_predicate_with_a_predefined_attribute_accessor
     klass = Class.new WithPredicates do
       attr_accessor :attribute
       predicate :attribute?
@@ -41,7 +41,7 @@ class PredicatesTest < MiniTest::Unit::TestCase
     refute object.attribute?
   end
 
-  def test_define_a_predicate_with_an_existing_attribute_reader
+  def test_define_a_predicate_with_only_a_predefined_attribute_reader
     klass = Class.new WithPredicates do
       attr_reader :attribute
       predicate :attribute?
@@ -59,20 +59,45 @@ class PredicatesTest < MiniTest::Unit::TestCase
     assert object.attribute?
   end
 
-  def test_define_a_predicate_with_an_existing_attribute_method
+  def test_define_a_predicate_with_only_a_predefined_attribute_writer
     klass = Class.new WithPredicates do
-      def attribute
-        1
-      end
+      attr_writer :attribute
+      predicate :attribute?
+    end
+
+    object = klass.new
+
+    assert object.respond_to?(:attribute?)
+    refute object.respond_to?(:attribute)
+
+    object.attribute = 1
+    assert object.attribute?
+
+    object.attribute = true
+    assert object.attribute?
 
+    object.attribute = nil
+    refute object.attribute?
+  end
+
+  def test_define_a_predicate_with_no_predefined_attribute_accessor
+    klass = Class.new WithPredicates do
       predicate :attribute?
     end
 
     object = klass.new
 
     assert object.respond_to?(:attribute?)
-    refute object.respond_to?(:attribute=)
+    assert object.respond_to?(:attribute=)
+    refute object.respond_to?(:attribute)
 
+    object.attribute = 1
     assert object.attribute?
+
+    object.attribute = true
+    assert object.attribute?
+
+    object.attribute = nil
+    refute object.attribute?
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: predicates
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors: