preadly-bulbasaur 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 975df2c7ace7a0947cd98b55bfcf896a970e5660
-  data.tar.gz: 5a5b086ba797209a5493d4d1db2026631f2091a2
+  metadata.gz: 31c936bb121a4f61275241d5c059222c02f3e7b6
+  data.tar.gz: eeeb22a1d7d7177372fe8e40d7f2ad58feab00d3
 SHA512:
-  metadata.gz: a62e0c0d111f954d147003c25d37ede0ee09c1717ac3a15f8194d07d847e2cedf474667b03bf9c2a84f52a93d53920f6d5162c44b399ebbc9551b4db88bf65c9
-  data.tar.gz: fc8dd0769358ef5e52da253d0a412065667920a401c78a07eb52b8f14bb5368542db7098874987386b9ddd9952df0847d2c6c6acd43ef4a21765e596b75ec3f2
+  metadata.gz: f83867d13892773d3e73758b99f3d1c2289f41ad8a7fdfc073d902b4f21f83612b71cb320da2eac96937fbf733af3a7e520b0134e3a2c98657ad1501f776c241
+  data.tar.gz: 813a56226a7f1ae0db8fd34d3fdafd8666a0aec5c6abea393ec7f73afdbab54805c2b353aeaa010899ba02f4fe7d905ae76e63a22f2ddc2c800575c2aabcdb0d

data/lib/bulbasaur/utils/normalize_image_sources.rb

@@ -28,13 +28,17 @@ module Bulbasaur
 
     def adjust(element, attr)
       element.set_attribute 'src', lazy_load_url(element, element.xpath(attr).text)
-      element.xpath(attr).remove
+      remove_target_attrs_from element
     end
 
     def lazy_load_url(element, text)
       text_match = text.match(DOMAIN_REGEX).to_s
       element_match = element.css('@src').text.match(DOMAIN_REGEX).to_s
-      (text_match == element_match) ? text : "#{element_match}/#{text}"
+      element_match.empty? || text_match == element_match ? text : "#{element_match}/#{text}"
+    end
+
+    def remove_target_attrs_from(element)
+      @target_attrs.each { |attr| element.xpath("@#{attr}").remove }
     end
   end
 end

data/lib/bulbasaur/version.rb

@@ -3,7 +3,7 @@ module Bulbasaur
   module Version
     MAJOR = 0
     MINOR = 8
-    PATCH = 0
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
   

data/spec/bulbasaur/utils/normalize_image_sources_spec.rb

@@ -14,7 +14,10 @@ RSpec.describe Bulbasaur::NormalizeImageSources do
         <img src="http://somewhere.to/get/another-pixel.gif" data-image="http://somewhere.to/get/the-other-real-image.jpg">
         <img src="http://somewhere.to/get/a-third-pixel.gif" data-src="get/the-third-real-image.jpg">
         <img src="otherplace.to/load/a-fourth-pixel.gif" lazy-data="otherplace.to/load/the-fourth-real-image.jpg">
-        )
+        <img src="https://place.where/an-image/is/without-extension/" data-src="https://place.where/an-image/is/without-extension/">
+        <img src="https://place.where/an-image/has-two/lazy-params/" data-src="https://place.where/an-image/has-two/lazy-params/" data-image="https://place.where/an-image/has-two/lazy-params/">
+        <img lazy-data="https://place.where/an-image/has/no-src-tag.jpg">
+      )
     end
     
     context "When there are no target attributes" do
@@ -40,7 +43,10 @@ RSpec.describe Bulbasaur::NormalizeImageSources do
           <img src="http://somewhere.to/get/the-other-real-image.jpg">
           <img src="http://somewhere.to/get/a-third-pixel.gif" data-src="get/the-third-real-image.jpg">
           <img src="otherplace.to/load/a-fourth-pixel.gif" lazy-data="otherplace.to/load/the-fourth-real-image.jpg">
-          )
+          <img src="https://place.where/an-image/is/without-extension/" data-src="https://place.where/an-image/is/without-extension/">
+          <img src="https://place.where/an-image/has-two/lazy-params/" data-src="https://place.where/an-image/has-two/lazy-params/">
+          <img lazy-data="https://place.where/an-image/has/no-src-tag.jpg">
+        )
       end
 
       it "Returns the HTML code with the specified image tags adjusted" do
@@ -60,6 +66,9 @@ RSpec.describe Bulbasaur::NormalizeImageSources do
           <img src="http://somewhere.to/get/the-other-real-image.jpg">
           <img src="http://somewhere.to/get/the-third-real-image.jpg">
           <img src="otherplace.to/load/the-fourth-real-image.jpg">
+          <img src="https://place.where/an-image/is/without-extension/">
+          <img src="https://place.where/an-image/has-two/lazy-params/">
+          <img src="https://place.where/an-image/has/no-src-tag.jpg">
         )
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: preadly-bulbasaur
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Magno Costa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-21 00:00:00.000000000 Z
+date: 2015-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler