pre-commit 0.37.0 → 0.38.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 042b09e17f23f621e1faa6ea9932694fa6263e0a
-  data.tar.gz: 16934f896ce3e9e328bd883eae9408d396102be7
+SHA256:
+  metadata.gz: 96c57d45df82f130c47a784c55ee806ff6172aa2eac959d38798973f2e902b5e
+  data.tar.gz: b97b72e32177c6ae7d49487e16400e4a6f5c4c05311ec3c61adbaf819e082f76
 SHA512:
-  metadata.gz: b5802aa631fc983865d924f5b20e42a8431a0d685b414924315a61e698aa397ee858d7c581550d58a2efcc16b16675c09cad35c813a90e19d49d5f3a9dd9f26a
-  data.tar.gz: 7306cab5fd90c76570e10e80f4906fb02b207df6e6d09296be5a4b372cee7962409bbbc900b7de981e8159c459abca53bfd0e1eff2a1ece9e60a05bb77e9c79b
+  metadata.gz: 2eb7d67a62bdae21d161bd4d25dbe6222386d9dd688c701846ef0d1aa27c59d8b852d01c0c88d769f7261b98712d3234934549e28f5bee3a3d16ba0a1edf71ef
+  data.tar.gz: da0828e32f361b021278ba1d576a04405346eebd08dccb8527a03b2965ca8ceb71d56c241a4e3da77989391f878ecaf7878d1f3a75b8403c42501827ec962844

data/lib/plugins/pre_commit/checks/ci.rb

@@ -2,20 +2,25 @@ require 'pre-commit/checks/plugin'
 
 module PreCommit
   module Checks
+    ##
+    # The CI check will run `rake pre_commmit:ci` before the commit and check
+    # its exit code. If the task runs successfully, the commit will proceed.
+    # If it fails, the commit will be aborted.
+    #
     class Ci < Plugin
       CI_TASK_NAME = 'pre_commit:ci'
 
+      def self.description
+        "Runs 'rake #{CI_TASK_NAME} --silent'"
+      end
+
       def call(_)
-        return if system("rake #{Ci::CI_TASK_NAME} --silent")
+        return if system("rake", CI_TASK_NAME, "--silent")
+
         PreCommit::ErrorList.new(
           "your test suite has failed, for the full output run `#{CI_TASK_NAME}`"
         )
       end
-
-      def self.description
-        "Runs 'rake #{CI_TASK_NAME} --silent'"
-      end
-
     end
   end
 end

data/lib/plugins/pre_commit/checks/yaml.rb

@@ -1,9 +1,19 @@
+# frozen-string-literal: true
+
 require 'yaml'
 require 'pre-commit/checks/plugin'
 
 module PreCommit
   module Checks
+    ##
+    # The Yaml check will read and parse YAML files to ensure they have valid
+    # syntax.
+    #
     class Yaml < Plugin
+      def self.description
+        'Runs yaml to detect errors.'
+      end
+
       def call(staged_files)
         staged_files = staged_files.grep(/\.(yml|yaml)$/)
         return if staged_files.empty?
@@ -13,6 +23,8 @@ module PreCommit
         errors.join("\n") + "\n" unless errors.empty?
       end
 
+      private
+
       def load_file(file)
         if YAML.respond_to?(:safe_load)
           safe_load_file(file)
@@ -39,10 +51,6 @@ module PreCommit
       rescue ArgumentError
         $stdout.puts "Warning: Skipping '#{file}' because it contains serialized ruby objects."
       end
-
-      def self.description
-        'Runs yaml to detect errors.'
-      end
     end
   end
 end

data/lib/pre-commit.rb

@@ -1,5 +1,8 @@
 require 'pre-commit/runner'
 
+##
+# The pre-commit gem.
+#
 module PreCommit
 
   # Can not delete this method with out a deprecation strategy.

data/lib/pre-commit/checks/grep.rb

@@ -1,3 +1,5 @@
+require 'open3'
+
 require 'pre-commit/checks/shell'
 require 'pre-commit/error_list'
 require 'pre-commit/line'
@@ -91,7 +93,11 @@ module PreCommit
       end
 
       def detect_grep_version
-        `grep --version | head -n 1 | sed -e 's/^[^0-9.]*\([0-9.]*\)$/\1/'`
+        first_line = Open3.popen2('grep', '--version') do |_, stdout, _|
+          stdout.readline
+        end
+
+        first_line.sub(/^[^0-9.]*\([0-9.]*\)$/, '\1')
       end
 
       def extra_execute(files)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.37.0
+  version: 0.38.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-15 00:00:00.000000000 Z
+date: 2018-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pluginator
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.25'
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.25'
+        version: '0.49'
 description: A git pre-commit hook written in ruby with a few more tricks up its sleeve
 email: dontneedmoreemail@example.com
 executables:
@@ -198,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 3
 summary: A slightly better git pre-commit hook