pre-commit 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56459f95e495f7c552ffae3ce9a01df82fae3610
-  data.tar.gz: 7e7ecd073b7c05d92ade69067c3e90a9f5594b47
+  metadata.gz: b7ea99f3d301a99ec233fe182ef6c28e38584ca4
+  data.tar.gz: b3bacc10c1f8c848a52491ec0f7d4816804cf1b7
 SHA512:
-  metadata.gz: 549a9b3f4a4d44d4c938048a2b9360c968c7867a636649d56d231be51c045548599fd570795c4f5170983767bd07a4908111425072ed341c6868320c5e679373
-  data.tar.gz: 91162e4a907af1b2b2a8d9786faf0e6092dfaa2a0bedcc533cffa2ff3ef6f69339e2beee64bdd28b7b87fe3f6f8a9fe32df498d71c8b86af14cf1c287bf46473
+  metadata.gz: 4ca0eaaf5dc427420f1ced3a4c765034b182443f6ec941aef2b82e0fd550dde887f753ab2f71206adb504c239023610e17ac0fa4067c6ea1bc35c3ae4ff68e40
+  data.tar.gz: f0a2a71ef8721284d77ccf35be3c7a8221f284397ad516e3dc384aa8861aba216793b1fca4c469c4b9ddfd39ebd755bf530551c5048f4cc1cfefa620ea059bd1

data/lib/plugins/pre_commit/checks/rubocop.rb

@@ -5,6 +5,12 @@ module PreCommit
   module Checks
     class Rubocop < Plugin
 
+      WHITELIST = [
+        ".gemspec", ".jbuilder", ".opal", ".podspec", ".rake", ".rb",
+        "Berksfile", "Capfile", "Cheffile", "Gemfile", "Guardfile", "Podfile",
+        "Rakefile", "Thorfile", "Vagabondfile", "Vagrantfile"
+      ]
+
       def self.aliases
         [ :rubocop_all, :rubocop_new ]
       end
@@ -18,24 +24,7 @@ module PreCommit
       rescue LoadError => e
         $stderr.puts "Could not find rubocop: #{e}"
       else
-        allowed_files_regex = /\.gemspec\Z|
-                               \.podspec\Z|
-                               \.jbuilder\Z|
-                               \.rake\Z|
-                               \.opal\Z|
-                               \.rb\Z|
-                               Gemfile\Z|
-                               Rakefile\Z|
-                               Capfile\Z|
-                               Guardfile\Z|
-                               Podfile\Z|
-                               Thorfile\Z|
-                               Vagrantfile\Z|
-                               Berksfile\Z|
-                               Cheffile\Z|
-                               Vagabondfile\Z
-                              /x
-        staged_files = staged_files.grep(allowed_files_regex)
+        staged_files = filter_staged_files(staged_files)
         return if staged_files.empty?
 
         args = config_file_flag + user_supplied_flags + ["--force-exclusion"] + staged_files
@@ -44,6 +33,11 @@ module PreCommit
         captured unless success
       end
 
+      def filter_staged_files(staged_files)
+        expression = Regexp.new(WHITELIST.map { |i| i + "\\Z" }.join("|"))
+        staged_files.grep(expression)
+      end
+
       def capture
         $stdout, stdout = StringIO.new, $stdout
         $stderr, stderr = StringIO.new, $stderr

data/lib/plugins/pre_commit/checks/whitespace.rb

@@ -23,6 +23,8 @@ module PreCommit
       end
 
       def call(staged_files)
+        return if staged_files.empty?
+
         errors = `git diff-index --check --cached HEAD -- #{files_string(staged_files)} 2>&1`
         return if $?.success?
 

data/templates/hooks/automatic

@@ -9,6 +9,11 @@
 #     pre-commit install --manual
 #
 
+# This is a work-around to get GitHub for Mac to be able to run `node` commands
+# https://stackoverflow.com/questions/12881975/git-pre-commit-hook-failing-in-github-for-mac-works-on-command-line
+PATH=$PATH:/usr/local/bin:/usr/local/sbin
+
+
 cmd=`git config pre-commit.ruby 2>/dev/null`
 if   test -n "${cmd}"
 then true

data/templates/hooks/default

@@ -9,6 +9,11 @@
 #     pre-commit install --manual
 #
 
+# This is a work-around to get GitHub for Mac to be able to run `node` commands
+# https://stackoverflow.com/questions/12881975/git-pre-commit-hook-failing-in-github-for-mac-works-on-command-line
+PATH=$PATH:/usr/local/bin:/usr/local/sbin
+
+
 cmd=`git config pre-commit.ruby 2>/dev/null`
 if   test -n "${cmd}"
 then true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-01 00:00:00.000000000 Z
+date: 2015-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pluginator
@@ -201,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 3
 summary: A slightly better git pre-commit hook