pre-commit 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b3925dbdc545f62cd3ac2f1ecc78e95f79ba2be
-  data.tar.gz: 3fb7a0973a89765ac6ddd1898c8a2d379759ad6b
+  metadata.gz: 0db8f765f2e06da8499568ce2e7c3bd3904a167d
+  data.tar.gz: b597ec14fa63e579dd63caf6edffac6937110ba5
 SHA512:
-  metadata.gz: 052c70e54f7833c4adb7094cdfd73ea90664046f8af25d9a8c2cb50a933de025bad522a7872c23e08639ba485f5a43d36ec037117d3d6297a2f422daa13938e6
-  data.tar.gz: e6d37cbb422edd64b9714947904452963e9e1272dccbb2a98886646e8b75e2a6846ba67fcac40aa20e1a95025242d8565289b2b6be250a5f2053d941052cc2ed
+  metadata.gz: ade68622b31830c6a7a5cb2cb03f211fff4065682b280ba58e2a9d308ca6ec9db11cf2544e5d861f966cbaff831dc0d34f9a546788d15a3734608e8485d00663
+  data.tar.gz: 1c92273dd73c2ce6da7224eacf7b3021f98604c59549231b5cab0ec6dead89d6071c5e5259a71b4db66c54c86baefb8d613262fa32ac0a713335bd5a3517dab7

data/README.md

@@ -43,6 +43,9 @@ These are the available checks:
 * before_all (Check your RSpec tests for the use of `before(:all)`)
 * coffeelint (Check your coffeescript files using the [coffeelint gem.](https://github.com/clutchski/coffeelint))
 * go (Runs go fmt on a go source file and fail if formatting is incorrect, then runs go build and fails if can't compile)
+* scss_lint (Check your SCSS files using the [scss-lint gem](https://github.com/causes/scss-lint))
+* yaml (Check that your YAML is parsable)
+* json (Checks if JSON is parsable)
 
 ## Default checks
 
@@ -61,7 +64,7 @@ To disable, simply leave one off the list
 ### CLI configuration
 
 ```ssh
-pre-commit <enable|disbale> <git|yaml> <checks|warnings> check1 [check2...]
+pre-commit <enable|disable> <git|yaml> <checks|warnings> check1 [check2...]
 ```
 
 The `git` provider can be used for local machine configuration, the `yaml` can be used for shared
@@ -69,7 +72,7 @@ project configuration.
 
 Example move `jshint` from `checks` to `warnings` in `yaml` provider and save configuration to git:
 ```bash
-pre-commit disbale yaml checks   jshint
+pre-commit disable yaml checks   jshint
 pre-commit enable  yaml warnings jshint
 git add config/pre-commit.yml
 git commit -m "pre-commit: move jshint from checks to warnings"

data/lib/plugins/pre_commit/checks/coffeelint.rb

@@ -1,9 +1,8 @@
-require 'open3'
-require 'pre-commit/checks/plugin'
+require 'pre-commit/checks/shell'
 
 module PreCommit
   module Checks
-    class Coffeelint < Plugin
+    class Coffeelint < Shell
 
       def call(staged_files)
         staged_files = staged_files.grep(/\.coffee$/)
@@ -11,8 +10,7 @@ module PreCommit
 
         args = (config_file_flag + staged_files).join(' ')
 
-        stdout, stderr, result = Open3.capture3("coffeelint #{args}")
-        stdout + stderr unless result.success?
+        execute("coffeelint #{args}")
       end
 
       def config_file_flag

data/lib/plugins/pre_commit/checks/console_log.rb

@@ -5,7 +5,7 @@ module PreCommit
     class ConsoleLog < Grep
 
       def files_filter(staged_files)
-        staged_files.grep(/\.js$/)
+        staged_files.grep(/\.(js|coffee)$/)
       end
 
       def extra_grep

data/lib/plugins/pre_commit/checks/json.rb

@@ -0,0 +1,28 @@
+require 'json'
+require 'pre-commit/checks/plugin'
+
+module PreCommit
+  module Checks
+    class Json < Plugin
+      def call(staged_files)
+        staged_files = staged_files.grep(/\.json$/)
+        return if staged_files.empty?
+
+        errors = staged_files.map {|file| load_file(file)}.compact
+
+        errors.join("\n") + "\n" unless errors.empty?
+      end
+
+      def load_file(file)
+        File.open(file) {|io| JSON.load(io)}
+        nil
+      rescue JSON::ParserError => e
+        "#{e.message} parsing #{file}"
+      end
+
+      def self.description
+        'Runs json to detect errors.'
+      end
+    end
+  end
+end

data/lib/plugins/pre_commit/checks/scss_lint.rb

@@ -0,0 +1,30 @@
+require 'pre-commit/checks/shell'
+
+module PreCommit
+  module Checks
+    class ScssLint < Shell
+
+      def call(staged_files)
+        staged_files = staged_files.grep(/\.scss$/)
+        return if staged_files.empty?
+
+        args = (config_file_flag + staged_files).join(' ')
+
+        execute("scss-lint #{args}")
+      end
+
+      def config_file_flag
+        config_file ? ['-c', config_file] : []
+      end
+
+      def alternate_config_file
+        '.scss-lint.yml'
+      end
+
+      def self.description
+        "Runs scss lint to detect errors"
+      end
+
+    end
+  end
+end

data/lib/plugins/pre_commit/checks/yaml.rb

@@ -0,0 +1,48 @@
+require 'yaml'
+require 'pre-commit/checks/plugin'
+
+module PreCommit
+  module Checks
+    class Yaml < Plugin
+      def call(staged_files)
+        staged_files = staged_files.grep(/\.(yml|yaml)$/)
+        return if staged_files.empty?
+
+        errors = staged_files.map {|file| load_file(file)}.compact
+
+        errors.join("\n") + "\n" unless errors.empty?
+      end
+
+      def load_file(file)
+        if YAML.respond_to?(:safe_load)
+          safe_load_file(file)
+        else
+          normal_load_file(file)
+        end
+
+      rescue Psych::SyntaxError => e
+        e.message
+      end
+
+      def safe_load_file(file)
+        YAML.safe_load(File.read(file), [], [], true, file)
+
+        nil
+      rescue Psych::DisallowedClass
+        $stdout.puts "Warning: Skipping '#{file}' because it contains serialized ruby objects."
+      end
+
+      def normal_load_file(file)
+        YAML.load_file(file)
+
+        nil
+      rescue ArgumentError
+        $stdout.puts "Warning: Skipping '#{file}' because it contains serialized ruby objects."
+      end
+
+      def self.description
+        'Runs yaml to detect errors.'
+      end
+    end
+  end
+end

data/lib/pre-commit/checks/shell.rb

@@ -0,0 +1,16 @@
+require 'pre-commit/checks/plugin'
+require 'open3'
+
+module PreCommit
+  module Checks
+    class Shell < Plugin
+
+    private
+
+      def execute(command)
+        _, stdout, stderr, process = Open3.popen3(command)
+        stdout.read + stderr.read unless process.value.success?
+      end
+    end
+  end
+end

data/lib/pre-commit/cli.rb

@@ -27,7 +27,7 @@ module PreCommit
       warn "Usage: pre-commit install"
       warn "Usage: pre-commit list"
       warn "Usage: pre-commit plugins"
-      warn "Usage: pre-commit <enable|disbale> <git|yaml> <checks|warnings> check1 [check2...]"
+      warn "Usage: pre-commit <enable|disable> <git|yaml> <checks|warnings> check1 [check2...]"
       args.empty? # return status, it's ok if user requested help
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-11 00:00:00.000000000 Z
+date: 2014-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pluginator
@@ -116,6 +116,7 @@ files:
 - lib/plugins/pre_commit/checks/go.rb
 - lib/plugins/pre_commit/checks/jshint.rb
 - lib/plugins/pre_commit/checks/jslint.rb
+- lib/plugins/pre_commit/checks/json.rb
 - lib/plugins/pre_commit/checks/local.rb
 - lib/plugins/pre_commit/checks/merge_conflict.rb
 - lib/plugins/pre_commit/checks/migration.rb
@@ -127,8 +128,10 @@ files:
 - lib/plugins/pre_commit/checks/rubocop.rb
 - lib/plugins/pre_commit/checks/ruby.rb
 - lib/plugins/pre_commit/checks/ruby_symbol_hashrockets.rb
+- lib/plugins/pre_commit/checks/scss_lint.rb
 - lib/plugins/pre_commit/checks/tabs.rb
 - lib/plugins/pre_commit/checks/whitespace.rb
+- lib/plugins/pre_commit/checks/yaml.rb
 - lib/plugins/pre_commit/configuration/providers/default.rb
 - lib/plugins/pre_commit/configuration/providers/env.rb
 - lib/plugins/pre_commit/configuration/providers/git.rb
@@ -139,6 +142,7 @@ files:
 - lib/pre-commit/checks/js.rb
 - lib/pre-commit/checks/plugin/config_file.rb
 - lib/pre-commit/checks/plugin.rb
+- lib/pre-commit/checks/shell.rb
 - lib/pre-commit/checks.rb
 - lib/pre-commit/cli.rb
 - lib/pre-commit/configuration/providers.rb