pre-commit 0.1.9 → 0.1.10

data/README.md

@@ -39,4 +39,4 @@ To enable `white_space`, `console_log` and `debugger` checks:
 
 Note: If no checks are configured, a default set of checks is run:
 
-    white_space, console_log, debugger, tabs, jshint
+    white_space, console_log, debugger, tabs, jshint, migrations

data/lib/pre-commit/checks/migration_check.rb

@@ -0,0 +1,55 @@
+class PreCommit
+  class MigrationCheck
+
+    attr_accessor :error_message
+
+    def call
+      staged_files = load_staged_files
+      run(staged_files)
+
+      if !passed? && error_message
+        $stderr.puts "pre-commit: #{error_message}"
+      end
+
+      passed?
+    end
+
+    def run(staged_files)
+      migration_present = migration_file_present?(staged_files)
+      schema_change = schema_file_present?(staged_files)
+
+      if migration_present && !schema_change
+        @error_message = "It looks like you're adding a migration, but did not update the schema file"
+        @passed = false
+      elsif schema_change && !migration_present
+        @error_message = "You're trying to change the schema without adding a migraiton file"
+        @passed = false
+      else
+        @passed = true
+      end
+    end
+
+    def migration_file_present?(staged_files)
+      staged_files.any? { |file| file =~ /db\/migrate\/.*\.rb/ }
+    end
+
+    def schema_file_present?(staged_files)
+      staged_files.any? do |file|
+        basename = File.basename(file)
+
+        [/schema\.rb/i, /structure.*\.sql/].any? do |regex|
+          basename =~ regex
+        end
+      end
+    end
+
+    def passed?
+      @passed
+    end
+
+    def load_staged_files
+      Utils.staged_files('.').split(" ")
+    end
+
+  end
+end

data/lib/pre-commit/checks.rb

@@ -6,6 +6,7 @@ require 'pre-commit/checks/console_log'
 require 'pre-commit/checks/debugger_check'
 require 'pre-commit/checks/jslint_check'
 require 'pre-commit/checks/jshint_check'
+require 'pre-commit/checks/migration_check'
 
 class PreCommit
 
@@ -64,7 +65,8 @@ class PreCommit
     :debugger             => DebuggerCheck,
     :tabs                 => Tabs,
     :closure_syntax_check => ClosureSyntaxCheck,
-    :merge_conflict       => MergeConflict
+    :merge_conflict       => MergeConflict,
+    :migrations           => MigrationCheck.new
   }
 
   # Can not delete this method with out a deprecation strategy.
@@ -82,7 +84,7 @@ class PreCommit
     checks_to_run = `git config pre-commit.checks`.chomp.split(/,\s*/).map(&:to_sym)
 
     if checks_to_run.empty?
-      Checks.values_at(:white_space, :console_log, :debugger, :tabs, :jshint)
+      Checks.values_at(:white_space, :console_log, :debugger, :tabs, :jshint, :migrations)
     else
       Checks.values_at(*checks_to_run)
     end.compact

metadata

@@ -2,7 +2,7 @@
 name: pre-commit
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors: 
 - Shajith Chacko, Josh Lubaway
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-21 00:00:00 -07:00
+date: 2011-05-05 00:00:00 -07:00
 default_executable: pre-commit
 dependencies: []
 
@@ -29,6 +29,7 @@ files:
 - lib/pre-commit/checks/jshint_check.rb
 - lib/pre-commit/checks/jslint_check.rb
 - lib/pre-commit/checks/merge_conflict.rb
+- lib/pre-commit/checks/migration_check.rb
 - lib/pre-commit/checks/tabs.rb
 - lib/pre-commit/checks.rb
 - lib/pre-commit/runner.rb