praxis 2.0.pre.15 → 2.0.pre.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9391f2cd6fb2c5a605a4b4c9f492371ef1d7f01849e94a9d17fdc51b95c211a9
-  data.tar.gz: 70c9f00cd12c7b3e99cebd10f86a98ac913433b8b96a41b658893b63ddc4b31b
+  metadata.gz: 2fe1ba3515514e34ad80775b6b68b4fe046fd1806c40d2345c4fa945d34ed92a
+  data.tar.gz: 11934130d0c527d1bc52020f393f2a5167ba3f88c876e81deaf7eaa05c518eff
 SHA512:
-  metadata.gz: edfc42021b347aea6bd7b84853ebd901f55e4963612da2a6870e00b956b3352e51efd8cd3c360123625af48f89553bff6fa0ad7766e076bc164ba8ccf770ba7b
-  data.tar.gz: da2df887a849f03be390f7218f931807670a58addc8eb3d101b293e0827a522680ca1824f47bafcff2c3f26bfb45bd13e8ad0c6f02577edad12c5c8cfca60904
+  metadata.gz: a32c98bd77159e59c5192390c2eb683b62930cb3f4b30cbe680b63db5b0c076199b0fb63e5a0a55abb772a92cadef19a8f05d7cedf7eb8218f585ce8b7a01acf
+  data.tar.gz: 2a086210825ac166730d63b9ea7e5baa2420cdeb1772e434028b95de356ce69778d983fededb1125825f5b036bc0a0c13fc9b61536d77a31cc63cd87f6a48c02

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## next
 
+## 2.0.pre.16
+
+* Updated `Resource.property` signature to only accept known named arguments (`dependencies` and `though` at this time) to spare anyone else from going insane wondering why their `depednencies` aren't working.
+* Fixed issue with Filtering Params, that occurred with using the ! or !! operators on String-typed fields.
+
 ## 2.0.pre.14
 
 * More encoding/decoding robustness for filters. 

data/lib/praxis/extensions/attribute_filtering/filtering_params.rb

@@ -222,8 +222,7 @@ module Praxis
             value_type = attr_filters[:value_type]
             next unless value_type == Attributor::String
 
-            value = item[:value]
-            unless value.empty?
+            if item[:value].presence
               fuzzy_match = attr_filters[:fuzzy_match]
               if item[:fuzzy] && !item[:fuzzy].empty? && !fuzzy_match
                 errors << "Fuzzy matching for #{attr_name} is not allowed (yet '*' was found in the value)"

data/lib/praxis/mapper/resource.rb

@@ -46,8 +46,8 @@ module Praxis::Mapper
       end
     end
 
-    def self.property(name, **options)
-      self.properties[name] = options
+    def self.property(name, dependencies: nil, through: nil)
+      self.properties[name] = {dependencies: dependencies, through: through}
     end
 
     def self._finalize!

data/lib/praxis/version.rb

@@ -1,3 +1,3 @@
 module Praxis
-  VERSION = '2.0.pre.15'
+  VERSION = '2.0.pre.16'
 end

data/spec/praxis/extensions/attribute_filtering/filtering_params_spec.rb

@@ -161,9 +161,9 @@ describe Praxis::Extensions::AttributeFiltering::FilteringParams do
       # construct it propertly by applying the block. Seems easier than creating the type alone, and 
       # then manually apply the block
       Attributor::Attribute.new(described_class.for(Post)) do
-        filter 'id', using: ['=', '!=']
+        filter 'id', using: ['=', '!=', '!']
         filter 'title', using: ['=', '!='], fuzzy: true
-        filter 'content', using: ['=', '!=']
+        filter 'content', using: ['=', '!=', '!']
       end.type
     end
     let(:loaded_params) { filtering_params_type.load(filters_string) }
@@ -194,6 +194,21 @@ describe Praxis::Extensions::AttributeFiltering::FilteringParams do
         end
       end
     end
+
+    context 'non-valued operators' do
+      context 'for string typed fields' do
+        let(:filters_string) { 'content!'}
+        it 'validates properly' do
+          expect(subject).to be_empty
+        end
+      end
+      context 'for non-string typed fields' do
+        let(:filters_string) { 'id!'}
+        it 'validates properly' do
+          expect(subject).to be_empty
+        end
+      end
+    end
     context 'fuzzy matches' do
       context 'when allowed' do
         context 'given a fuzzy string' do

data/spec/praxis/mapper/resource_spec.rb

@@ -14,15 +14,15 @@ describe Praxis::Mapper::Resource do
       subject(:properties) { resource.properties }
 
       it 'includes directly-set properties' do
-        expect(properties[:other_resource]).to eq(dependencies: [:other_model])
+        expect(properties[:other_resource]).to eq(dependencies: [:other_model], through: nil)
       end
 
       it 'inherits from a superclass' do
-        expect(properties[:href]).to eq(dependencies: [:id])
+        expect(properties[:href]).to eq(dependencies: [:id], through: nil)
       end
 
       it 'properly overrides a property from the parent' do
-        expect(properties[:name]).to eq(dependencies: [:simple_name])
+        expect(properties[:name]).to eq(dependencies: [:simple_name], through: nil)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: praxis
 version: !ruby/object:Gem::Version
-  version: 2.0.pre.15
+  version: 2.0.pre.16
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-28 00:00:00.000000000 Z
+date: 2021-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack