prawn-svg 0.34.2 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f405c26de28dcc55e41e63ee5a6f8d433ab7dc4e9900bc3012e869689516698
-  data.tar.gz: f6cfebbb831bbfd6a66608202285acd66a295de102ebd94a2a6be8e73454bec4
+  metadata.gz: 0567f606c8d50a83ca8521e9af1a39cda59c570086d624eb08f415e13e2e0623
+  data.tar.gz: 37e4d144020f202b293fb7106c7e9bcbe47b47bf3dd85ee6f811c757b89e1dc9
 SHA512:
-  metadata.gz: e9092e304d63b84b8947e585448b627be95fcfbaad38b02e386bb9ed0b585871990a3ab1bc87a0480949141010aea67cb60c5c1ddc1be19b674056f8b7adceab
-  data.tar.gz: 4dd717b2d65681f792951ef98a93df4dd1dd7a8f2f4f9caaa13ef7fce9a3428e8f2041e71537244167be257351f1a5720069e5b88c173145fc8f51ae31d1453f
+  metadata.gz: 89263ec912e718bb6405d0b4fd6b963665c1165bcedd8ec62226f7cfc4f8a80e9be771ceb55cfec45a65320e718724763f82dce20c274a6258da78f23394d91b
+  data.tar.gz: b87dfa3862f6679c530e2dfce0fcf9ef7a1e942cc2dff68f54bc6c053dd1b66915d2cae096a5d82e9905f35d3348a4e3a64bf02c0bb8491ef17826c890465e15

data/.github/workflows/lint.yml

@@ -0,0 +1,19 @@
+name: RuboCop
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.3
+          bundler-cache: true
+
+      - name: Run RuboCop
+        run: bundle exec rubocop --parallel

data/.github/workflows/test.yml

@@ -1,35 +1,22 @@
 name: test
 on: [push, pull_request]
 jobs:
-  rake_new:
+  test:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.6, 2.7, '3.0', 3.1, 3.2, 3.3]
+        ruby: [2.7, '3.0', 3.1, 3.2, 3.3]
     steps:
-    - uses: actions/checkout@v4
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        bundler-cache: true
-        ruby-version: ${{ matrix.ruby }}
-    - name: Run tests
-      run:  bundle exec rake
-      env:
-        RUBYOPT: "--enable-frozen-string-literal"
-  rake_old:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [2.5]
-    steps:
-    - uses: actions/checkout@v4
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        bundler-cache: true
-        ruby-version: ${{ matrix.ruby }}
-    - name: Run tests
-      run:  bundle exec rake
+      - uses: actions/checkout@v4
+      - name: Remove Gemfile.lock
+        run: rm -f Gemfile.lock
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: ${{ matrix.ruby }}
+      - name: Run tests
+        run: bundle exec rake
+        env:
+          RUBYOPT: "--enable-frozen-string-literal"

data/.gitignore

@@ -1,7 +1,6 @@
 .DS_Store
 spec/sample_output/*.pdf
 prawn-svg-*.gem
-Gemfile.lock
 .rvmrc
 .*.swp
 .ruby-version

data/.rubocop.yml

@@ -0,0 +1,86 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: enable
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+
+Layout/FirstArgumentIndentation:
+  EnforcedStyle: consistent
+
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation
+
+Lint/SuppressedException:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false
+
+Naming/MethodParameterName:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Naming/VariableNumber:
+  Enabled: false
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - spec/**/*.rb
+
+Style/GlobalVars:
+  Exclude:
+    - spec/**/*.rb
+
+Style/MultilineBlockChain:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,51 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2024-06-16 03:19:10 UTC using RuboCop version 1.62.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 13
+Lint/NonLocalExitFromIterator:
+  Exclude:
+    - 'lib/prawn/svg/css/selector_parser.rb'
+    - 'lib/prawn/svg/ttf.rb'
+
+# Offense count: 1
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/prawn/svg/calculators/document_sizing.rb'
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+  Exclude:
+    - 'lib/prawn-svg.rb'
+
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/prawn/svg/css/selector_parser.rb'
+    - 'lib/prawn/svg/elements/base.rb'
+    - 'lib/prawn/svg/elements/gradient.rb'
+    - 'lib/prawn/svg/elements/root.rb'
+    - 'lib/prawn/svg/elements/text_component.rb'
+    - 'lib/prawn/svg/elements/use.rb'
+    - 'lib/prawn/svg/loaders/file.rb'
+
+# Offense count: 28
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 180

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
 
 # Declare your gem's dependencies in prawn-svg.gemspec.
 # Bundler will treat runtime dependencies like base dependencies, and
@@ -10,5 +10,6 @@ gemspec
 # Git. Remember to move these dependencies to your gemspec before releasing
 # your gem to rubygems.org.
 
-# To use debugger
-# gem 'ruby-debug19', :require => 'ruby-debug'
+gem 'rake', '~> 13.0'
+gem 'rspec', '~> 3.0'
+gem 'rubocop', '~> 1.64'

data/Gemfile.lock

@@ -0,0 +1,81 @@
+PATH
+  remote: .
+  specs:
+    prawn-svg (0.34.2)
+      css_parser (~> 1.6)
+      matrix (~> 0.4.2)
+      prawn (>= 0.11.1, < 3)
+      rexml (~> 3.2)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    addressable (2.8.6)
+      public_suffix (>= 2.0.2, < 6.0)
+    ast (2.4.2)
+    bigdecimal (3.1.8)
+    css_parser (1.17.1)
+      addressable
+    diff-lcs (1.5.1)
+    json (2.7.2)
+    language_server-protocol (3.17.0.3)
+    matrix (0.4.2)
+    parallel (1.25.1)
+    parser (3.3.3.0)
+      ast (~> 2.4.1)
+      racc
+    pdf-core (0.10.0)
+    prawn (2.5.0)
+      matrix (~> 0.4)
+      pdf-core (~> 0.10.0)
+      ttfunk (~> 1.8)
+    public_suffix (5.1.0)
+    racc (1.8.0)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    regexp_parser (2.9.2)
+    rexml (3.3.0)
+      strscan
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.64.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
+    ruby-progressbar (1.13.0)
+    strscan (3.1.0)
+    ttfunk (1.8.0)
+      bigdecimal (~> 3.1)
+    unicode-display_width (2.5.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  prawn-svg!
+  rake (~> 13.0)
+  rspec (~> 3.0)
+  rubocop (~> 1.64)
+
+BUNDLED WITH
+   2.5.1

data/README.md

@@ -10,7 +10,7 @@ This will take an SVG document as input and render it into your PDF.  Find out m
   http://github.com/prawnpdf/prawn
 
 prawn-svg is compatible with all versions of Prawn from 0.11.1 onwards, including the 1.x and 2.x series.
-The minimum Ruby version required is 2.5.0.
+The minimum Ruby version required is 2.7.
 
 ## Using prawn-svg
 

data/Rakefile

@@ -23,4 +23,4 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |spec|
 end
 
-task :default => :spec
+task default: :spec

data/lib/prawn/svg/attributes/clip_path.rb

@@ -1,16 +1,16 @@
 module Prawn::SVG::Attributes::ClipPath
   def parse_clip_path_attribute_and_call
-    return unless clip_path = properties.clip_path
+    return unless (clip_path = properties.clip_path)
     return if clip_path == 'none'
 
     clip_path_element = extract_element_from_url_id_reference(clip_path, 'clipPath')
 
     if clip_path_element.nil?
-      document.warnings << "Could not resolve clip-path URI to a clipPath element"
+      document.warnings << 'Could not resolve clip-path URI to a clipPath element'
     else
       add_call_and_enter 'save_graphics_state'
       add_calls_from_element clip_path_element
-      add_call "clip"
+      add_call 'clip'
     end
   end
 end

data/lib/prawn/svg/attributes/opacity.rb

@@ -1,9 +1,9 @@
 module Prawn::SVG::Attributes::Opacity
   def parse_opacity_attributes_and_call
     # We can't do nested opacities quite like the SVG requires, but this is close enough.
-    opacity = clamp(properties.opacity.to_f, 0, 1) if properties.opacity
-    fill_opacity = clamp(properties.fill_opacity.to_f, 0, 1) if properties.fill_opacity
-    stroke_opacity = clamp(properties.stroke_opacity.to_f, 0, 1) if properties.stroke_opacity
+    opacity = properties.opacity.to_f.clamp(0, 1) if properties.opacity
+    fill_opacity = properties.fill_opacity.to_f.clamp(0, 1) if properties.fill_opacity
+    stroke_opacity = properties.stroke_opacity.to_f.clamp(0, 1) if properties.stroke_opacity
 
     if opacity || fill_opacity || stroke_opacity
       state.fill_opacity *= [opacity || 1, fill_opacity || 1].min

data/lib/prawn/svg/attributes/stroke.rb

@@ -1,9 +1,9 @@
 module Prawn::SVG::Attributes::Stroke
-  CAP_STYLE_TRANSLATIONS = {"butt" => :butt, "round" => :round, "square" => :projecting_square}
-  JOIN_STYLE_TRANSLATIONS = {"miter" => :miter, "round" => :round, "bevel" => :bevel}
+  CAP_STYLE_TRANSLATIONS = { 'butt' => :butt, 'round' => :round, 'square' => :projecting_square }.freeze
+  JOIN_STYLE_TRANSLATIONS = { 'miter' => :miter, 'round' => :round, 'bevel' => :bevel }.freeze
 
   def parse_stroke_attributes_and_call
-    if width_string = properties.stroke_width
+    if (width_string = properties.stroke_width)
       width = pixels(width_string)
       state.stroke_width = width
       add_call('line_width', width)
@@ -12,12 +12,12 @@ module Prawn::SVG::Attributes::Stroke
     if (linecap = properties.stroke_linecap) && linecap != 'inherit'
       add_call('cap_style', CAP_STYLE_TRANSLATIONS.fetch(linecap, :butt))
     end
-    
+
     if (linejoin = properties.stroke_linejoin) && linejoin != 'inherit'
       add_call('join_style', JOIN_STYLE_TRANSLATIONS.fetch(linejoin, :miter))
     end
 
-    if dasharray = properties.stroke_dasharray
+    if (dasharray = properties.stroke_dasharray)
       case dasharray
       when 'inherit'
         # don't do anything
@@ -25,13 +25,13 @@ module Prawn::SVG::Attributes::Stroke
         add_call('undash')
       else
         array = dasharray.split(Prawn::SVG::Elements::COMMA_WSP_REGEXP)
-        array *= 2 if array.length % 2 == 1
-        number_array = array.map {|value| pixels(value)}
+        array *= 2 if array.length.odd?
+        number_array = array.map { |value| pixels(value) }
 
-        if number_array.any? {|number| number < 0}
+        if number_array.any?(&:negative?)
           @document.warnings << "stroke-dasharray cannot have negative numbers; treating as 'none'"
           add_call('undash')
-        elsif number_array.inject(0) {|a, b| a + b} == 0
+        elsif number_array.inject(0) { |a, b| a + b }.zero?
           add_call('undash')
         else
           add_call('dash', number_array)

data/lib/prawn/svg/attributes/transform.rb

@@ -1,8 +1,8 @@
 module Prawn::SVG::Attributes::Transform
   def parse_transform_attribute_and_call
-    return unless transform = attributes['transform']
+    return unless (transform = attributes['transform'])
 
     matrix = parse_transform_attribute(transform)
-    add_call_and_enter "transformation_matrix", *matrix unless matrix == [1, 0, 0, 1, 0, 0]
+    add_call_and_enter 'transformation_matrix', *matrix unless matrix == [1, 0, 0, 1, 0, 0]
   end
 end

data/lib/prawn/svg/attributes.rb

@@ -1,6 +1,6 @@
 module Prawn::SVG::Attributes
 end
 
-%w(transform opacity clip_path stroke space).each do |name|
+%w[transform opacity clip_path stroke space].each do |name|
   require "prawn/svg/attributes/#{name}"
 end

data/lib/prawn/svg/calculators/arc_to_bezier_curve.rb

@@ -7,15 +7,15 @@ module Prawn::SVG::Calculators
     def calculate_bezier_curve_points_for_arc(cx, cy, a, b, lambda_1, lambda_2, theta)
       e = lambda do |eta|
         [
-          cx + a * Math.cos(theta) * Math.cos(eta) - b * Math.sin(theta) * Math.sin(eta),
-          cy + a * Math.sin(theta) * Math.cos(eta) + b * Math.cos(theta) * Math.sin(eta)
+          cx + (a * Math.cos(theta) * Math.cos(eta)) - (b * Math.sin(theta) * Math.sin(eta)),
+          cy + (a * Math.sin(theta) * Math.cos(eta)) + (b * Math.cos(theta) * Math.sin(eta))
         ]
       end
 
       ep = lambda do |eta|
         [
-          -a * Math.cos(theta) * Math.sin(eta) - b * Math.sin(theta) * Math.cos(eta),
-          -a * Math.sin(theta) * Math.sin(eta) + b * Math.cos(theta) * Math.cos(eta)
+          (-a * Math.cos(theta) * Math.sin(eta)) - (b * Math.sin(theta) * Math.cos(eta)),
+          (-a * Math.sin(theta) * Math.sin(eta)) + (b * Math.cos(theta) * Math.cos(eta))
         ]
       end
 
@@ -28,28 +28,30 @@ module Prawn::SVG::Calculators
           # puts "error = #{calculate_curve_approximation_error(a, b, eta1, eta1 + d_eta)}"
           break
         end
+
         iterations *= 2
         d_lambda = (lambda_2 - lambda_1) / iterations
       end
 
       (0...iterations).collect do |iteration|
-        eta_a, eta_b = calculate_eta_from_lambda(a, b, lambda_1+iteration*d_lambda, lambda_1+(iteration+1)*d_lambda)
+        eta_a, eta_b = calculate_eta_from_lambda(a, b, lambda_1 + (iteration * d_lambda),
+          lambda_1 + ((iteration + 1) * d_lambda))
         d_eta = eta_b - eta_a
 
-        alpha = Math.sin(d_eta) * ((Math.sqrt(4 + 3 * Math.tan(d_eta / 2) ** 2) - 1) / 3)
+        alpha = Math.sin(d_eta) * ((Math.sqrt(4 + (3 * (Math.tan(d_eta / 2)**2))) - 1) / 3)
 
         x1, y1 = e[eta_a]
         x2, y2 = e[eta_b]
 
         ep_eta1_x, ep_eta1_y = ep[eta_a]
-        q1_x = x1 + alpha * ep_eta1_x
-        q1_y = y1 + alpha * ep_eta1_y
+        q1_x = x1 + (alpha * ep_eta1_x)
+        q1_y = y1 + (alpha * ep_eta1_y)
 
         ep_eta2_x, ep_eta2_y = ep[eta_b]
-        q2_x = x2 - alpha * ep_eta2_x
-        q2_y = y2 - alpha * ep_eta2_y
+        q2_x = x2 - (alpha * ep_eta2_x)
+        q2_y = y2 - (alpha * ep_eta2_y)
 
-        {:p2 => [x2, y2], :q1 => [q1_x, q1_y], :q2 => [q2_x, q2_y]}
+        { p2: [x2, y2], q1: [q1_x, q1_y], q2: [q2_x, q2_y] }
       end
     end
 
@@ -68,7 +70,7 @@ module Prawn::SVG::Calculators
         [-0.0695069, -0.0437594, 0.0120636, 0.0163087],
         [-0.0328856, -0.00926032, -0.00173573, 0.00527385]
       ]
-    ]
+    ].freeze
 
     ERROR_COEFFICIENTS_B = [
       [
@@ -83,7 +85,7 @@ module Prawn::SVG::Calculators
         [0.0156192, -0.017535, 0.00326508, -0.228157],
         [-0.0236752, 0.0405821, -0.0173086, 0.176187]
       ]
-    ]
+    ].freeze
 
     def calculate_curve_approximation_error(a, b, eta1, eta2)
       b_over_a = b / a
@@ -92,11 +94,11 @@ module Prawn::SVG::Calculators
       c = lambda do |i|
         (0..3).inject(0) do |accumulator, j|
           coef = coefficents[i][j]
-          accumulator + ((coef[0] * b_over_a**2 + coef[1] * b_over_a + coef[2]) / (b_over_a * coef[3])) * Math.cos(j * (eta1 + eta2))
+          accumulator + ((((coef[0] * (b_over_a**2)) + (coef[1] * b_over_a) + coef[2]) / (b_over_a * coef[3])) * Math.cos(j * (eta1 + eta2)))
         end
       end
 
-      ((0.001 * b_over_a**2 + 4.98 * b_over_a + 0.207) / (b_over_a * 0.0067)) * a * Math.exp(c[0] + c[1] * (eta2 - eta1))
+      (((0.001 * (b_over_a**2)) + (4.98 * b_over_a) + 0.207) / (b_over_a * 0.0067)) * a * Math.exp(c[0] + (c[1] * (eta2 - eta1)))
     end
 
     def calculate_eta_from_lambda(a, b, lambda_1, lambda_2)

data/lib/prawn/svg/calculators/aspect_ratio.rb

@@ -4,10 +4,10 @@ module Prawn::SVG::Calculators
     attr_reader :width, :height, :x, :y
 
     def initialize(value, container_dimensions, object_dimensions)
-      values = (value || "xMidYMid meet").split(' ')
+      values = (value || 'xMidYMid meet').split
       @x = @y = 0
 
-      if values.first == "defer"
+      if values.first == 'defer'
         @defer = true
         values.shift
       end
@@ -20,35 +20,37 @@ module Prawn::SVG::Calculators
       container_ratio = w_container / h_container.to_f
       object_ratio    = w_object / h_object.to_f
 
-      if @align == "none"
+      if @align == 'none'
         @width, @height = container_dimensions
       else
-        matches = @align.to_s.strip.match(/\Ax(Min|Mid|Max)Y(Min|Mid|Max)\z/i) || [nil, "Mid", "Mid"]
+        matches = @align.to_s.strip.match(/\Ax(Min|Mid|Max)Y(Min|Mid|Max)\z/i) || [nil, 'Mid', 'Mid']
 
         if (container_ratio > object_ratio) == slice?
-          @width, @height = [w_container, w_container / object_ratio]
+          @width = w_container
+          @height = w_container / object_ratio
           @y = case matches[2].downcase
-               when "min" then 0
-               when "mid" then (h_container - w_container/object_ratio)/2
-               when "max" then h_container - w_container/object_ratio
+               when 'min' then 0
+               when 'mid' then (h_container - (w_container / object_ratio)) / 2
+               when 'max' then h_container - (w_container / object_ratio)
                end
         else
-          @width, @height = [h_container * object_ratio, h_container]
+          @width = h_container * object_ratio
+          @height = h_container
           @x = case matches[1].downcase
-               when "min" then 0
-               when "mid" then (w_container - h_container*object_ratio)/2
-               when "max" then w_container - h_container*object_ratio
+               when 'min' then 0
+               when 'mid' then (w_container - (h_container * object_ratio)) / 2
+               when 'max' then w_container - (h_container * object_ratio)
                end
         end
       end
     end
 
     def slice?
-      @meet_or_slice == "slice"
+      @meet_or_slice == 'slice'
     end
 
     def meet?
-      @meet_or_slice != "slice"
+      @meet_or_slice != 'slice'
     end
 
     def inspect

data/lib/prawn/svg/calculators/document_sizing.rb

@@ -1,6 +1,6 @@
 module Prawn::SVG::Calculators
   class DocumentSizing
-    DEFAULT_ASPECT_RATIO = "xMidYMid meet"
+    DEFAULT_ASPECT_RATIO = 'xMidYMid meet'.freeze
 
     attr_writer :document_width, :document_height
     attr_writer :view_box, :preserve_aspect_ratio
@@ -33,21 +33,20 @@ module Prawn::SVG::Calculators
 
       if @view_box
         values = @view_box.strip.split(Prawn::SVG::Elements::COMMA_WSP_REGEXP)
-        @x_offset, @y_offset, @viewport_width, @viewport_height = values.map {|value| value.to_f}
+        @x_offset, @y_offset, @viewport_width, @viewport_height = values.map(&:to_f)
 
-        if @viewport_width > 0 && @viewport_height > 0
+        if @viewport_width.positive? && @viewport_height.positive?
           # If neither the width nor height was specified, use the entire width and the viewbox ratio
           # to determine the height.
-          if @output_width.nil? && @output_height.nil?
-            @output_width = container_width
-          end
+          @output_width = container_width if @output_width.nil? && @output_height.nil?
 
           # If one of the output dimensions is missing, calculate it from the other one
           # using the ratio of the viewport width to height.
           @output_width ||= @output_height * @viewport_width / @viewport_height
           @output_height ||= @output_width * @viewport_height / @viewport_width
 
-          aspect = AspectRatio.new(@preserve_aspect_ratio, [@output_width, @output_height], [@viewport_width, @viewport_height])
+          aspect = AspectRatio.new(@preserve_aspect_ratio, [@output_width, @output_height],
+            [@viewport_width, @viewport_height])
           @x_scale = aspect.width / @viewport_width
           @y_scale = aspect.height / @viewport_height
           @x_offset -= aspect.x / @x_scale
@@ -64,7 +63,7 @@ module Prawn::SVG::Calculators
       return if invalid?
 
       # SVG 1.1 section 7.10
-      @viewport_diagonal = Math.sqrt(@viewport_width**2 + @viewport_height**2) / Math.sqrt(2)
+      @viewport_diagonal = Math.sqrt((@viewport_width**2) + (@viewport_height**2)) / Math.sqrt(2)
 
       if @requested_width
         scale = @requested_width / @output_width
@@ -94,11 +93,11 @@ module Prawn::SVG::Calculators
     end
 
     def requested_width=(value)
-      @requested_width = (value.to_f if value)
+      @requested_width = value&.to_f
     end
 
     def requested_height=(value)
-      @requested_height = (value.to_f if value)
+      @requested_height = value&.to_f
     end
   end
 end